Re: Review Board 1.6 RC1 released

2011-07-06 Thread N.S.S.R.Murthy
Hi Christian,

We are waiting for 1.6 stable release. We have upgraded to 1.6RC1 and
there are no plans to roll back as the 1.6 is the one that has all the
features we want.
Can you please tell us a tentative date of release?

Regards,
Murthy.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board 1.6 RC1 released

2011-07-06 Thread Christian Hammond
The goal is to release in July, or early August. There's a couple bugs that
still need to be worked out, and then documentation fixes.

I'll soon be releasing RC2. Unless there are any large bugs we notice after
releasing RC2, the only differences between RC2 and the final release will
be the version number and the addition of some new documentation.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Wed, Jul 6, 2011 at 10:29 PM, N.S.S.R.Murthy murthyn...@gmail.comwrote:

 Hi Christian,

 We are waiting for 1.6 stable release. We have upgraded to 1.6RC1 and
 there are no plans to roll back as the 1.6 is the one that has all the
 features we want.
 Can you please tell us a tentative date of release?

 Regards,
 Murthy.

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-27 Thread N.S.S.R.Murthy
 Would you mind filing a bug so we can better track it?

Hi Christian,

I have filed the bug here: 
http://groups.google.com/group/reviewboard-issues/t/758157f3b10ad4a1

Regards,
Murthy.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board 1.6 RC1 released

2011-06-27 Thread Christian Hammond
Hi,

Thanks for bringing that again to my attention.

Yeah, I think we can get this in. I'll run some tests on it and then push
it.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 27, 2011 at 12:34 AM, Clemens Ballarin balla...@aicas.comwrote:

 Hi Christian,

 I wonder whether my patch

  Fix display of revision if there is a parent diff.
  
 http://reviews.reviewboard.**org/r/2094/http://reviews.reviewboard.org/r/2094/

 will make it into Release 1.6.  My understanding was that it will.  Are you
 still planning to incorporate it?

 Clemens



 On 23 Jun 2011, at 10:48, Christian Hammond wrote:

  Hi everyone,

 We released Review Board 1.6 RC1 tonight, which has several new features,
 fixes, and performance enhancements. We're very close to a final release, so
 let us know if you hit any problems.

 For more information on the release, see http://www.reviewboard.org/**
 news/2011/06/23/review-board-**16-rc1-released/http://www.reviewboard.org/news/2011/06/23/review-board-16-rc1-released/

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to reviewboard+unsubscribe@**
 googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en


 --
 Dr. Clemens Ballarin -- Senior Software Engineer

 aicas GmbH  *  Haid-und-Neu-Straße 18  *  D-76131 Karlsruhe  *  Germany
 http://www.aicas.com  *  phone +49 721 663 968-35  *  fax -99

 USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
 Geschäftsführer: Dr. James J. Hunt


 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to reviewboard+unsubscribe@**
 googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=en http://groups.google.com/group/reviewboard?hl=en


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-27 Thread Christian Hammond
Also, it would really help if you could make some unit tests for this? Make
sure the diff revision is what we expect in diffs and parent diffs.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Mon, Jun 27, 2011 at 12:59 AM, Christian Hammond chip...@chipx86.comwrote:

 Hi,

 Thanks for bringing that again to my attention.

 Yeah, I think we can get this in. I'll run some tests on it and then push
 it.


 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com


 On Mon, Jun 27, 2011 at 12:34 AM, Clemens Ballarin balla...@aicas.comwrote:

 Hi Christian,

 I wonder whether my patch

  Fix display of revision if there is a parent diff.
  
 http://reviews.reviewboard.**org/r/2094/http://reviews.reviewboard.org/r/2094/

 will make it into Release 1.6.  My understanding was that it will.  Are
 you still planning to incorporate it?

 Clemens



 On 23 Jun 2011, at 10:48, Christian Hammond wrote:

  Hi everyone,

 We released Review Board 1.6 RC1 tonight, which has several new features,
 fixes, and performance enhancements. We're very close to a final release, so
 let us know if you hit any problems.

 For more information on the release, see http://www.reviewboard.org/**
 news/2011/06/23/review-board-**16-rc1-released/http://www.reviewboard.org/news/2011/06/23/review-board-16-rc1-released/

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board - http://www.reviewboard.org
 VMware, Inc. - http://www.vmware.com

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/http://www.reviewboard.org/donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to reviewboard+unsubscribe@**
 googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en


 --
 Dr. Clemens Ballarin -- Senior Software Engineer

 aicas GmbH  *  Haid-und-Neu-Straße 18  *  D-76131 Karlsruhe  *  Germany
 http://www.aicas.com  *  phone +49 721 663 968-35  *  fax -99

 USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
 Geschäftsführer: Dr. James J. Hunt


 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/**donate/ http://www.reviewboard.org/donate/
 Happy user? Let us know at 
 http://www.reviewboard.org/**users/http://www.reviewboard.org/users/
 -~--~~~~--**~~--~--~---
 To unsubscribe from this group, send email to reviewboard+unsubscribe@**
 googlegroups.com reviewboard%2bunsubscr...@googlegroups.com
 For more options, visit this group at http://groups.google.com/**
 group/reviewboard?hl=enhttp://groups.google.com/group/reviewboard?hl=en




-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-24 Thread Christian Hammond
On Thu, Jun 23, 2011 at 10:55 PM, N.S.S.R.Murthy murthyn...@gmail.comwrote:

 Thank you Christian for quick reply. Please see my answers below.

  I don't see any screenshot attached, but did you create the repository in
  the administration UI? If we don't show it, then we generally couldn't
 load
  a valid repository.
 Yes, a valid SVN repository was created and used on 1.5.5 version.
 But I revisited it's configuration based on your suggestion above.
 When I tied to save the configuration, facing the error Unable to
 create directory /var/www/reviews.amer.actel.com/data/.subversion,
 which is needed for the Subversion configuration. Create this
 directory and set the web server's user as the the owner.


Okay, then it should be just a matter of adding that and setting the
permissions. I think I'm going to do some better checks for that after a
server upgrade so you don't end up hitting it without realizing.




  Did you run 'rb-site upgrade' and restart your web server?
 I am just site admin. Our server admin surely ran the 'rb-site
 upgrade'. I will ask our server admin whether he restarted the server.
 Below are steps followed to upgrade.
 1. Backed up MySQL with mysqldump
 2. Backed up /var, /opt/memcache and /etc using tar.
 3. root@wolf.62 easy_install -f
 http://downloads.reviewboard.org/releases/ReviewBoard/1.6/
 -U 
 http://downloads.reviewboard.org/releases/ReviewBoard/1.6/%0A-UReviewBoard
 4. root@wolf.64 rb-site upgrade /var/www/reviews.amer.actel.com
 5. root@wolf.65 service httpd restart
 6. root@wolf.70 service memcached stop
 7. root@wolf.71 service memcached start

  Can you look at the web server log files and reviewboard log files (you
 may
  have to enable logging in Admin  - Settings - Logging) and see what
 errors
  show up?
 It seems a logs directory needs to be created for this. I will get it
 done and update you back.

  I don't understand what you mean here. What are you clicking? How are you
  generating the diff being posted to Review Board? How did you put
 anything
  up if #1 above wasn't working?
 The web UI is actually creating a review request with graphics only
 option. Then it is allowing to add file of any type. We can open these
 added files by clicking the link provided in the review request. But
 we cannot comment on this.
 May be this will be fixed if we add a valid repository.


Ahh, I misunderstood what you were saying. Okay, I will take a look at that
and get a fix in for 1.6.

Would you mind filing a bug so we can better track it?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-24 Thread Christian Hammond
On Thu, Jun 23, 2011 at 11:13 PM, Christian Hammond chip...@chipx86.comwrote:

   I don't understand what you mean here. What are you clicking? How are
 you
  generating the diff being posted to Review Board? How did you put
 anything
  up if #1 above wasn't working?
 The web UI is actually creating a review request with graphics only
 option. Then it is allowing to add file of any type. We can open these
 added files by clicking the link provided in the review request. But
 we cannot comment on this.
 May be this will be fixed if we add a valid repository.


 Ahh, I misunderstood what you were saying. Okay, I will take a look at that
 and get a fix in for 1.6.

 Would you mind filing a bug so we can better track it?


Nevermind, we have a fix upstream.

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-23 Thread Robert Munteanu
Hi,

I see that http://code.google.com/p/reviewboard/issues/detail?id=2009 still 
happens. Just mentioned it in case it slipped under your radar and is an 
easy fix.

Thanks,

Robert

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-23 Thread Christian Hammond
We'll get it in for 1.6. We're focusing on the last remaining bug fixes now.
We just wanted to make sure the new stuff is out so it can be played with in
the wild.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com


On Thu, Jun 23, 2011 at 2:15 PM, Robert Munteanu
robert.munte...@gmail.comwrote:

 Hi,

 I see that http://code.google.com/p/reviewboard/issues/detail?id=2009still 
 happens. Just mentioned it in case it slipped under your radar and is
 an easy fix.

 Thanks,

 Robert

 --
 Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
 Happy user? Let us know at http://www.reviewboard.org/users/
 -~--~~~~--~~--~--~---
 To unsubscribe from this group, send email to
 reviewboard+unsubscr...@googlegroups.com
 For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-23 Thread N.S.S.R.Murthy
On Jun 24, 3:32 am, Christian Hammond chip...@chipx86.com wrote:
 We'll get it in for 1.6. We're focusing on the last remaining bug fixes now.
 We just wanted to make sure the new stuff is out so it can be played with in
 the wild.

 Christian

 --
 Christian Hammond - chip...@chipx86.com
 Review Board -http://www.reviewboard.org
 VMware, Inc. -http://www.vmware.com

 On Thu, Jun 23, 2011 at 2:15 PM, Robert Munteanu
 robert.munte...@gmail.comwrote:







  Hi,

  I see 
  thathttp://code.google.com/p/reviewboard/issues/detail?id=2009stillhappens. 
  Just mentioned it in case it slipped under your radar and is
  an easy fix.

  Thanks,

  Robert

  --
  Want to help the Review Board project? Donate today at
 http://www.reviewboard.org/donate/
  Happy user? Let us know athttp://www.reviewboard.org/users/
  -~--~~~~--~~--~--~---
  To unsubscribe from this group, send email to
  reviewboard+unsubscr...@googlegroups.com
  For more options, visit this group at
 http://groups.google.com/group/reviewboard?hl=en

We have tried 1.6 RC1 today. Below is list of problems faced:

1. The SVN repository configured is not showing up while creating a
new review. Below is the screenshot of options for new review:
2. Review requests created on version 1.5.5. are visible in dashboard-
All My Requests. But when opened getting the error: Something broke!
(Error 500) It appears something broke when you tried to go to here.
This is either a bug in Review Board or a server configuration error.
Please report this to your administrator.
3. It is allowing to add any files to review. I have tried to add a
brand new C file commited to SVN, which do not have diffs. But there
is no provision to comment on these files. When clicked on the link to
this files, it is showing the plain text.

I am not sure if any of above are installation/admin problems. Please
help.

Regards,
Murthy.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en


Re: Review Board 1.6 RC1 released

2011-06-23 Thread Christian Hammond
Hi,

On Thu, Jun 23, 2011 at 10:25 PM, N.S.S.R.Murthy murthyn...@gmail.comwrote:

 We have tried 1.6 RC1 today. Below is list of problems faced:

 1. The SVN repository configured is not showing up while creating a
 new review. Below is the screenshot of options for new review:


I don't see any screenshot attached, but did you create the repository in
the administration UI? If we don't show it, then we generally couldn't load
a valid repository.


 2. Review requests created on version 1.5.5. are visible in dashboard-
 All My Requests. But when opened getting the error: Something broke!
 (Error 500) It appears something broke when you tried to go to here.
 This is either a bug in Review Board or a server configuration error.
 Please report this to your administrator.


Did you run 'rb-site upgrade' and restart your web server?

Can you look at the web server log files and reviewboard log files (you may
have to enable logging in Admin  - Settings - Logging) and see what errors
show up?



 3. It is allowing to add any files to review. I have tried to add a
 brand new C file commited to SVN, which do not have diffs. But there
 is no provision to comment on these files. When clicked on the link to
 this files, it is showing the plain text.


I don't understand what you mean here. What are you clicking? How are you
generating the diff being posted to Review Board? How did you put anything
up if #1 above wasn't working?

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Review Board 1.6 RC1 released

2011-06-23 Thread N.S.S.R.Murthy
Thank you Christian for quick reply. Please see my answers below.

 I don't see any screenshot attached, but did you create the repository in
 the administration UI? If we don't show it, then we generally couldn't load
 a valid repository.
Yes, a valid SVN repository was created and used on 1.5.5 version.
But I revisited it's configuration based on your suggestion above.
When I tied to save the configuration, facing the error Unable to
create directory /var/www/reviews.amer.actel.com/data/.subversion,
which is needed for the Subversion configuration. Create this
directory and set the web server's user as the the owner.

 Did you run 'rb-site upgrade' and restart your web server?
I am just site admin. Our server admin surely ran the 'rb-site
upgrade'. I will ask our server admin whether he restarted the server.
Below are steps followed to upgrade.
1. Backed up MySQL with mysqldump
2. Backed up /var, /opt/memcache and /etc using tar.
3. root@wolf.62 easy_install -f 
http://downloads.reviewboard.org/releases/ReviewBoard/1.6/
-U ReviewBoard
4. root@wolf.64 rb-site upgrade /var/www/reviews.amer.actel.com
5. root@wolf.65 service httpd restart
6. root@wolf.70 service memcached stop
7. root@wolf.71 service memcached start

 Can you look at the web server log files and reviewboard log files (you may
 have to enable logging in Admin  - Settings - Logging) and see what errors
 show up?
It seems a logs directory needs to be created for this. I will get it
done and update you back.

 I don't understand what you mean here. What are you clicking? How are you
 generating the diff being posted to Review Board? How did you put anything
 up if #1 above wasn't working?
The web UI is actually creating a review request with graphics only
option. Then it is allowing to add file of any type. We can open these
added files by clicking the link provided in the review request. But
we cannot comment on this.
May be this will be fixed if we add a valid repository.

Regards,
Murthy.

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en