Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-13 Thread Richard Parks
Hi Griffin, That's an interesting way to work on a branch and then merge to trunk (but don't commit) then post a pre-commit review. I'll try it out here, thanks for the idea! We've found another way around the original problem here too: the root cause of the problem is an rbt diff can't fully

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-12 Thread Griffin Myers
Hi Richard, One thing I totally forgot about with my prior suggestion was the relatively new exclude (-X/--exclude) functionality in rbt diff and post. This might be a cleaner way to commit from root while weeding out the unwanted files. I work under the same methodology where we have

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-09 Thread Richard Parks
Hi Griffin, Yes that got around it for me, particularly the not generically point to the root of the repo. thank you very much for your help. In between there was another issue where it explicitly failed on a single file which it again complained about, but this was an empty file (i.e. size

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-08 Thread Richard Parks
Thank you very much Griffin, I've pulled in your modified process.py and my diff works fine now. Thanks for taking the time to reproduce my issue and fixing it so fast! -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-08 Thread Richard Parks
Oh, so my diff works but a post still fails! rbt post --debug 12192 12218 RBTools 0.7.2 Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel )] Running on Windows-7-6.1.7601-SP1 Home = C:\Users\myuser\AppData\Roaming Current directory =

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-08 Thread Richard Parks
Oh, so my diff works but a post still fails! rbt post --debug 12192 12218 RBTools 0.7.2 Python 2.7.6 (default, Nov 10 2013, 19:24:18) [MSC v.1500 32 bit (Intel )] Running on Windows-7-6.1.7601-SP1 Home = C:\Users\myuser\AppData\Roaming Current directory =

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-08 Thread Griffin Myers
Hi Richard, Your initial issue was a legitimate bug. I think this is something separate, but still likely due to moved/deleted files. I don't do very many post-commit reviews, but coincidentally I needed to do one today and I think I ran into the latest issue you are seeing. I fought with

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-07 Thread Griffin Myers
I've posted a patch for review at https://reviews.reviewboard.org/r/7183/ which should resolve this issue. On Tuesday, April 7, 2015 at 2:18:43 PM UTC-4, Richard Parks wrote: Hi, I've used RBTools for several reviews with no problems but I've now encountered a problem with a svn repository

Re: rbt diff object of type 'NoneType' has no len(). RBTools 0.7.2 with svn

2015-04-07 Thread Barret Rennie
Hey all, Griffin’s patch has landed on the release-0.7.x and master branches as commit 3afaf5dbf66c57e837a6521bb83ea712682817c5. This patch will be included in the next minor RBTools release (RBTools 0.7.3). Regards, Barret Rennie -- Supercharge your Review Board with Power Pack: