Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review161356 --- Ship it! Ship It! - Sebastian Toader On Jan. 11, 2017, 11:03

Re: Review Request 55423: AMBARI-19459 Optimizing services startup time when ranger admin is down

2017-01-11 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55423/#review161355 --- Ship it! Ship It! - Gautam Borad On Jan. 11, 2017, 1:41 p.m.

Review Request 55444: AMBARI-19478: Need to handle unsupported configurations gracefully in workflow actions.

2017-01-11 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55444/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-11 Thread Mugdha Varadkar
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > > > > > Do all of these properties have

Re: Review Request 55371: AMBARI-19436: Need ability to upload a file in HDFS browser.

2017-01-11 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55371/#review161351 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 10, 2017, 12:10

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55382/#review161350 --- Ship it! Ship It! - Mugdha Varadkar On Jan. 10, 2017, 3:54 p

Re: Review Request 55174: AMBARI-19360 : Ranger policies not syncing for storm, kafka and knox

2017-01-11 Thread Vishal Suvagia
> On Jan. 11, 2017, 4:42 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json, > > line 337 > > > > > > What about HDF since it doesnt have HDFS? Not suppor

Re: Review Request 55373: AMBARI-19438 Add enable delta sync property for Ranger

2017-01-11 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55373/ --- (Updated Jan. 12, 2017, 5:39 a.m.) Review request for Ambari, Gautam Borad, Jai

Re: Review Request 55433: Add Downgrade request validation to avoid accidental double-upgrades

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55433/ --- (Updated Jan. 11, 2017, 10:27 p.m.) Review request for Ambari, Nate Cole, Rober

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-11 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/ --- (Updated Jan. 12, 2017, 12:33 a.m.) Review request for Ambari, Di Li, Jaimin Je

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Sumit Mohanty
> On Jan. 11, 2017, 9:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 37 > > > > > > We need to be able to tolerate

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review161333 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 11, 2017, 10

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Alejandro Fernandez
> On Jan. 11, 2017, 9:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 37 > > > > > > We need to be able to tolerate

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55382/#review161327 --- Ship it! Ship It! - Sumit Mohanty On Jan. 10, 2017, 3:54 p.m

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Sumit Mohanty
> On Jan. 11, 2017, 9:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 37 > > > > > > We need to be able to tolerate

Re: Review Request 55433: Add Downgrade request validation to avoid accidental double-upgrades

2017-01-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55433/#review161325 --- Ship it! Ship It! - Robert Levas On Jan. 11, 2017, 4:28 p.m.

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/ --- (Updated Jan. 11, 2017, 11:03 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 55399: Changing Capacity-scheduler configs while llap is enabled should warn the user if llap is affected

2017-01-11 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55399/#review161304 --- Ship it! Ship It! - Jaimin Jetly On Jan. 11, 2017, 12:34 a.m

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Madhan Neethiraj
> On Jan. 11, 2017, 9:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 37 > > > > > > We need to be able to tolerate

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review161301 --- Fix it, then Ship it! ambari-common/src/main/python/resource_m

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Attila Doroszlai
> On Jan. 11, 2017, 10:32 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > line 112 > > > > > > I prefer to move imports like this to the top of

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review161299 --- Fix it, then Ship it! ambari-common/src/main/python/resource_m

Review Request 55433: Add Downgrade request validation to avoid accidental double-upgrades

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55433/ --- Review request for Ambari, Nate Cole, Robert Levas, and Robert Nettleton. Bugs:

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55382/#review161297 --- ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Sumit Mohanty
> On Jan. 11, 2017, 12:13 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 37 > > > > > > Why is this iterating over eve

Re: Review Request 55382: AMBARI-19386 : ATLAS service check should run against metadata server host.

2017-01-11 Thread Sumit Mohanty
> On Jan. 11, 2017, 12:13 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/service_check.py, > > line 37 > > > > > > Why is this iterating over eve

Re: Review Request 55432: AMBARI-19471: Ambari-server: In HIVE and OOZIE configurations, annotate PASSWORD properties that need to be stored in a JCEKS provider

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55432/#review161294 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 11, 2017, 8:

Review Request 55432: AMBARI-19471: Ambari-server: In HIVE and OOZIE configurations, annotate PASSWORD properties that need to be stored in a JCEKS provider

2017-01-11 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55432/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-19471 https://iss

Re: Review Request 53213: Exporting blueprint from kerberos enabled cluster, exports hardcoded values cluster name and realm in principal_name property

2017-01-11 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53213/#review161291 --- Ship it! Ship It! - Jaimin Jetly On Nov. 9, 2016, 12:11 a.m.

Re: Review Request 55429: Logsearch should run zk/solr operations internally (instead of in ambari-agent code)

2017-01-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/#review161288 --- Fix it, then Ship it! Patch looks fine to me, other than the mi

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55007/#review161287 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54970/#review161286 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 24, 2016, 7:

Re: Review Request 55009: HDFS Service check fails if previous active NN is down

2017-01-11 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55009/#review161285 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 10, 2017, 2:

Re: Review Request 55373: AMBARI-19438 Add enable delta sync property for Ranger

2017-01-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55373/#review161284 --- Ship it! Ship It! - Jayush Luniya On Jan. 10, 2017, 8:15 a.m

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-11 Thread Jayush Luniya
> On Jan. 9, 2017, 7:24 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/ranger-kafka-audit.xml, > > line 26 > > > > > > Do all of these properties have

Re: Review Request 55402: Minor: Ownership is changed before the creation of directory

2017-01-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55402/#review161282 --- Ship it! Ship It! - Jayush Luniya On Jan. 11, 2017, 4:25 a.m

Re: Review Request 55129: [AMBARI-19337] Ambari has some spelling mistakes in YARN proxyuser properties in many places.

2017-01-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55129/#review161280 --- Ping. What's the status of this review? - Nate Cole On Jan. 3,

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55391/#review161276 --- Ship it! Ship It! - Sid Wagle On Jan. 10, 2017, 9:24 p.m., J

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Jonathan Hurley
> On Jan. 11, 2017, 12:18 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java, > > lines 119-124 > > > > > > Sigh :) Can we make jira to move RCO to someth

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
> On Jan. 11, 2017, 4:28 p.m., Attila Doroszlai wrote: > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java, > > line 113 > > > > > > Somehow this comment doesn't seem

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 11, 2017, 5:27 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 55427: Sqlline-thin is unable to connect to phoenix

2017-01-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55427/#review161273 --- Fix it, then Ship it! ambari-server/src/main/resources/stacks/

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55391/#review161272 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 55396: Host version incorrectly reported as OUT_OF_SYNC

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/#review161271 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 55396: Host version incorrectly reported as OUT_OF_SYNC

2017-01-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/ --- (Updated Jan. 11, 2017, 12:04 p.m.) Review request for Ambari, Dmitro Lisnichen

Re: Review Request 55174: AMBARI-19360 : Ranger policies not syncing for storm, kafka and knox

2017-01-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55174/#review161262 --- ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stac

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55007/#review161259 --- Ship it! Ship It! - Oliver Szabo On Dec. 23, 2016, 5:23 a.m.

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161258 --- ambari-server/src/test/java/org/apache/ambari/server/controller/i

Re: Review Request 55396: Host version incorrectly reported as OUT_OF_SYNC

2017-01-11 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/ --- (Updated Jan. 11, 2017, 11:20 a.m.) Review request for Ambari, Dmitro Lisnichen

Re: Review Request 55429: Logsearch should run zk/solr operations internally (instead of in ambari-agent code)

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/ --- (Updated Jan. 11, 2017, 4:16 p.m.) Review request for Ambari, Miklos Gergely an

Re: Review Request 55430: Log Search: Calendar widget for setting the time range is confusing

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55430/#review161256 --- Ship it! Ship It! - Oliver Szabo On Jan. 11, 2017, 4:01 p.m.

Re: Review Request 55430: Log Search: Calendar widget for setting the time range is confusing

2017-01-11 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55430/#review161254 --- Ship it! Ship It! - Robert Nettleton On Jan. 11, 2017, 4:01

Review Request 55430: Log Search: Calendar widget for setting the time range is confusing

2017-01-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55430/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-1946

Review Request 55429: Logsearch should run zk/solr operations internally (instead of in ambari-agent code)

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs: AMBARI-19

Re: Review Request 55425: Setup the correct authentication and authorization between Hive/Hcatalog and ZooKeeper

2017-01-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55425/#review161246 --- Ship it! Ship It! - Sebastian Toader On Jan. 11, 2017, 3:24

Re: Review Request 55428: Custom jdk built for PPC architecture - making it easier for PPC users to pick the right JDK.

2017-01-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55428/#review161247 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 11, 2017,

Re: Review Request 55428: Custom jdk built for PPC architecture - making it easier for PPC users to pick the right JDK.

2017-01-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55428/ --- (Updated Jan. 11, 2017, 3:13 p.m.) Review request for Ambari and Vitalyi Brodet

Re: Review Request 55427: Sqlline-thin is unable to connect to phoenix

2017-01-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55427/#review161248 --- Ship it! Ship It! - Robert Levas On Jan. 11, 2017, 10:07 a.m

Review Request 55428: Custom jdk built for PPC architecture - making it easier for PPC users to pick the right JDK.

2017-01-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55428/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-19467 https:

Review Request 55427: Sqlline-thin is unable to connect to phoenix

2017-01-11 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55427/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert Levas

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Robert Levas
> On Jan. 11, 2017, 9:41 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java, > > line 405 > > > > > > This isn't a deep copy of the map. Will that be an

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Jonathan Hurley
> On Jan. 11, 2017, 9:41 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java, > > line 405 > > > > > > This isn't a deep copy of the map. Will that be an

Re: Review Request 55391: Role Command Order For HOU Is Different For Some Components

2017-01-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55391/#review161121 --- Fix it, then Ship it! Ship It! ambari-server/src/main/java/or

Re: Review Request 55425: Setup the correct authentication and authorization between Hive/Hcatalog and ZooKeeper

2017-01-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55425/#review161243 --- Ship it! Ship It! - Robert Levas On Jan. 11, 2017, 9:24 a.m.

Re: Review Request 55396: Host version incorrectly reported as OUT_OF_SYNC

2017-01-11 Thread Nate Cole
> On Jan. 10, 2017, 8:18 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java, > > lines 142-144 > > > > > > Is it possible

Re: Review Request 55425: Setup the correct authentication and authorization between Hive/Hcatalog and ZooKeeper

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55425/#review161242 --- Ship it! Ship It! - Laszlo Puskas On Jan. 11, 2017, 2:24 p.m

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Robert Levas
> On Jan. 11, 2017, 8:48 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpgradeUserKerberosDescriptor.java, > > lines 246-248 > > > > > > I'm worried abou

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161238 --- Fix it, then Ship it! Ship It! ambari-server/src/main/java/or

Review Request 55425: Setup the correct authentication and authorization between Hive/Hcatalog and ZooKeeper

2017-01-11 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55425/ --- Review request for Ambari, Laszlo Puskas, Oliver Szabo, Robert Levas, and Sebast

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2017-01-11 Thread Jonathan Hurley
> On Jan. 10, 2017, 4:42 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, > > line 168 > > > > > > Does thie curl command work when Kerberos /

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161236 --- Ship it! Ship It! - Laszlo Puskas On Jan. 9, 2017, 3:07 p.m.

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2017-01-11 Thread Tim Thorpe
> On Jan. 10, 2017, 9:42 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, > > line 168 > > > > > > Does thie curl command work when Kerberos /

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
> On Jan. 11, 2017, 12:13 p.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 5529 > > > > > > The factory could be injected;

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2017-01-11 Thread Jonathan Hurley
> On Jan. 10, 2017, 4:42 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, > > line 168 > > > > > > Does thie curl command work when Kerberos /

Re: Review Request 55426: JS error when user click Alert Link in the popup on the service summary page

2017-01-11 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55426/#review161233 --- Ship it! Ship It! - Andrii Tkach On Jan. 11, 2017, 1:52 p.m.

Review Request 55426: JS error when user click Alert Link in the popup on the service summary page

2017-01-11 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55426/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19465 https://issu

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2017-01-11 Thread Tim Thorpe
> On Jan. 10, 2017, 9:42 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py, > > line 168 > > > > > > Does thie curl command work when Kerberos /

Re: Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/#review161230 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 11, 2017, 12:28

Re: Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/#review161228 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Review Request 55423: AMBARI-19459 Optimizing services startup time when ranger admin is down

2017-01-11 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55423/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Vishal Suvagia, an

Re: Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/#review161227 --- Ship it! Ship It! - Gaurav Nagar On Jan. 11, 2017, 12:28 p.m

Review Request 55424: Stack Downgrading Potentially Corrupts Kerberos Descriptor

2017-01-11 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55424/ --- Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Robert Levas.

Re: Review Request 55396: Host version incorrectly reported as OUT_OF_SYNC

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/#review161225 --- Ship it! Assuming that there's no concurrency issue - I'll mark

Re: Review Request 55414: AMBARI-19458. Compile error in RoleGraphTest

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55414/#review161224 --- Ship it! Ship It! - Oliver Szabo On Jan. 11, 2017, 12:58 p.m

Re: Review Request 55414: AMBARI-19458. Compile error in RoleGraphTest

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55414/#review161223 --- Whoops! Thanks for fixing this! - Jonathan Hurley On Jan. 11, 2

Re: Review Request 55414: AMBARI-19458. Compile error in RoleGraphTest

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55414/#review161222 --- Ship it! Ship It! - Oliver Szabo On Jan. 11, 2017, 12:58 p.m

Re: Review Request 55414: AMBARI-19458. Compile error in RoleGraphTest

2017-01-11 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55414/#review161221 --- Ship it! Ship It! - Jonathan Hurley On Jan. 11, 2017, 7:58 a

Re: Review Request 55422: Oozie Restart is not prompted on changing core-site.xml

2017-01-11 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55422/#review161220 --- Ship it! Ship It! - Myroslav Papirkovskyy On Січ. 11, 2017,

Review Request 55422: Oozie Restart is not prompted on changing core-site.xml

2017-01-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55422/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-19463 https:

Re: Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/#review161219 --- Ship it! Ship It! - belliraj hb On Jan. 11, 2017, 12:28 p.m.

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

2017-01-11 Thread Masahiro Tanaka
> On Jan. 11, 2017, 3:37 a.m., Alejandro Fernandez wrote: > > ambari-agent/src/main/python/ambari_agent/Facter.py, line 400 > > > > > > Add documentation to these 2 functions Thanks you for reviewing my patch! You m

Re: Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/ --- (Updated Jan. 11, 2017, 12:28 p.m.) Review request for Ambari, DIPAYAN BHOWMICK

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161216 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Review Request 55418: AMBARI-19454. Label changes and missing fields for action nodes

2017-01-11 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55418/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 55417: Log Search: default search ranges don't look right

2017-01-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55417/ --- (Updated Jan. 11, 2017, 11:17 a.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 55417: Bug DBBUG-70501 Log Search: default search ranges don't look right

2017-01-11 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55417/#review161211 --- Ship it! Ship It! - Oliver Szabo On Jan. 11, 2017, 11:12 a.m

Review Request 55417: Bug DBBUG-70501 Log Search: default search ranges don't look right

2017-01-11 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55417/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: AMBARI-1946

Review Request 55415: Screen stuck when no suitable OS is detected

2017-01-11 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55415/ --- Review request for Ambari and Denys Buzhor. Bugs: AMBARI-19460 https://issu

Re: Review Request 55415: Screen stuck when no suitable OS is detected

2017-01-11 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55415/#review161210 --- Ship it! Ship It! - Denys Buzhor On Jan. 11, 2017, 11:07 a.m

Re: Review Request 55396: Host version incorrectly reported as OUT_OF_SYNC

2017-01-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/#review161208 --- Ship it! Ship It! - Dmitro Lisnichenko On Jan. 11, 2017, 1:5

  1   2   >