Re: Review Request 50594: Fix Spark hdp.version issues in upgrading and fresh install

2016-08-01 Thread Jayush Luniya
i-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java <https://reviews.apache.org/r/50594/#comment210435> Same as above - Jayush Luniya On Aug. 1, 2016, 1:22 a.m., Saisai Shao wrote: > > --- &g

Re: Review Request 50656: Improvements/fixes for AMBARI_INFRA initial service definition

2016-08-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50656/#review144371 --- Ship it! Ship It! - Jayush Luniya On Aug. 1, 2016, 12:22

Re: Review Request 50512: Spark and Spark2 should use different keytab files to avoid ACL issues

2016-07-27 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50512/#review143765 --- Ship it! Ship It! - Jayush Luniya On July 27, 2016, 5:10

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-27 Thread Jayush Luniya
view143535 --- On July 27, 2016, 9:06 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-27 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50445/#review143746 --- Ship it! Ship It! - Jayush Luniya On July 27, 2016, 9:06

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-27 Thread Jayush Luniya
/package/scripts/params.py (line 325) <https://reviews.apache.org/r/50445/#comment209675> Merge the 2 if-blocks - Jayush Luniya On July 27, 2016, 9:06 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically g

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-26 Thread Jayush Luniya
/stack_advisor.py (line 1686) <https://reviews.apache.org/r/50445/#comment209538> We should be consistent in naming conventions for variable names. - Jayush Luniya On July 26, 2016, 2:49 p.m., Mugdha Varadkar

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-26 Thread Jayush Luniya
/kerberos.json (line 189) <https://reviews.apache.org/r/50445/#comment209537> How did this typo not cause problems in the past? - Jayush Luniya On July 26, 2016, 2:49 p.m., Mugdha Varadkar wrote: > > --- > This is a

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-26 Thread Jayush Luniya
ot be Kerberized if Kerberos is enabled for the cluster? > > > > It seems like this is redundant info and possible problematic if a user > > changes the value via Ranger's service config page or the REST API. > > Jayush Luniya wrote: > Agree

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-26 Thread Jayush Luniya
scenario? - Jayush Luniya On July 26, 2016, 2:49 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 50445: AMBARI-17902 Config changes to support external solr and internal solr for Ranger

2016-07-26 Thread Jayush Luniya
-- > > (Updated July 26, 2016, 2:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Robert Levas, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bug

Re: Review Request 50394: Ranger Atlas plugin status needs to be shown in Ranger summary tab

2016-07-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50394/#review143394 --- Ship it! Ship It! - Jayush Luniya On July 25, 2016, 5:03

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jayush Luniya
he way to Finalize step and kick DOWNGRADE will old alerts be restored? - Jayush Luniya On July 21, 2016, 12:36 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jayush Luniya
> On July 21, 2016, 3:30 p.m., Jonathan Hurley wrote: > > It would have been nice to break this type of server action out into > > something more generic for alert updates. That way, future changes like > > this won't need to worry about broadcasting events. However, it's not > > necessary

Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/#review143111 --- Ship it! Ship It! - Jayush Luniya On July 21, 2016, 10:19

Re: Review Request 50300: AMBARI-17828 : Nimbus, Storm UI server stopped after disabling ranger plugins

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50300/#review143109 --- Ship it! Ship It! - Jayush Luniya On July 21, 2016, 4:14

Re: Review Request 50294: AMBARI-17833 EU fails during restart of Ranger Admin at setup_ranger_audit_solr

2016-07-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50294/#review143101 --- Ship it! Ship It! - Jayush Luniya On July 21, 2016, 2:15

Re: Review Request 50234: Kerberos Client fails to install

2016-07-20 Thread Jayush Luniya
> On July 20, 2016, 3:49 p.m., Jayush Luniya wrote: > > Ship It! @Rob, whats the Apache JIRA for this? Can you update the review with the Apache JIRA? - Jayush --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 50237: AMBARI-17810 - Extensions directory shouldn't be packaged in ambari-server RPM

2016-07-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50237/#review142951 --- Ship it! Ship It! - Jayush Luniya On July 20, 2016, 3:21

Re: Review Request 50234: Kerberos Client fails to install

2016-07-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50234/#review142950 --- Ship it! Ship It! - Jayush Luniya On July 20, 2016, 2:09

Re: Review Request 50196: Ranger Admin Fails To Stop Or Start During Downgrade From HDP 2.5 to HDP 2.4

2016-07-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50196/#review142824 --- Ship it! Ship It! - Jayush Luniya On July 19, 2016, 6:36

Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

2016-07-19 Thread Jayush Luniya
> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50087/ > ----------- > > (Updated July 18, 2016, 8:51 p.m.) > > > Review request for Ambari, Alexander Denissov, Jayush Luniya,

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49987/#review142413 --- Ship it! Ship It! - Jayush Luniya On July 14, 2016, 2:23

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-07-15 Thread Jayush Luniya
> On June 17, 2016, 3:04 p.m., Jayush Luniya wrote: > > @Saisai > > Looks like you need to rebase again > > $ git apply ~/Downloads/AMBARI-16864-v1.patch > > /Users/jluniya/Downloads/AMBARI-16864-v1.patch:1100: trailing whitespace. > > "spark-javaop

Re: Review Request 48999: Fix Spark2 history server quick link still point to spark1 url

2016-07-15 Thread Jayush Luniya
> On June 21, 2016, 3:22 a.m., Jayush Luniya wrote: > > Ship It! Saisai, Can you close this review? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48999/#rev

Re: Review Request 50030: AMBARI-17688 Ranger stack changes in Ambari to support secure Solr

2016-07-15 Thread Jayush Luniya
> On July 15, 2016, 5:25 p.m., Jayush Luniya wrote: > > Ship It! Committed patch. Please close review. - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50030/#rev

Re: Review Request 50030: AMBARI-17688 Ranger stack changes in Ambari to support secure Solr

2016-07-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50030/#review142401 --- Ship it! Ship It! - Jayush Luniya On July 15, 2016, 8:43

Re: Review Request 49987: AMBARI-17687 [RU/Downgrade] ranger service goes down in between of RU downgrade

2016-07-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49987/#review142266 --- Can we add any unit tests to cover these cases? - Jayush Luniya

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-13 Thread Jayush Luniya
> On July 13, 2016, 12:30 a.m., Jonathan Hurley wrote: > > I'm going to +1 this, but I'd still like to know how other commiters feel > > about making the socket commands paramters vs actual parts of the source > > element. Parameters make more sense for script alerts than port alerts in my

Re: Review Request 48972: AMBARI-17253 Ambari Alert causes too many wanings in ZooKeeper logs.

2016-07-13 Thread Jayush Luniya
> On July 11, 2016, 9:51 p.m., Masahiro Tanaka wrote: > > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0? > > Jonathan Hurley wrote: > That depends; there's no Fix Version on this Jira, so I don't know if > it's only going into trunk or if it's going to into

Re: Review Request 49831: AMBARI-17562 - Adding single stack, extension and service should be removed from management pack support

2016-07-11 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49831/#review141725 --- Ship it! Ship It! - Jayush Luniya On July 8, 2016, 9:13 p.m

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions

2016-07-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49328/#review141290 --- Ship it! Ship It! - Jayush Luniya On July 8, 2016, 2:43 p.m

Re: Review Request 49449: AMBARI-17415 Ambari configuration for ranger-tagsync needs to support property for atlas keystore filename

2016-07-07 Thread Jayush Luniya
> On July 7, 2016, 7:32 a.m., Jayush Luniya wrote: > > Ship It! Committed - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49449/#rev

Re: Review Request 49449: AMBARI-17415 Ambari configuration for ranger-tagsync needs to support property for atlas keystore filename

2016-07-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49449/#review141140 --- Ship it! Ship It! - Jayush Luniya On July 1, 2016, 5:56 a.m

Re: Review Request 49295: remove spark.driver.extraJavaOptions and spark.yarn.am.extraJavaOptions property in HDP2.5 definition

2016-07-05 Thread Jayush Luniya
/configuration/spark-defaults.xml (line 1) <https://reviews.apache.org/r/49295/#comment206177> The self detection mechanism for hdp.version was added in HDP-2.3.4. So shouldnt be remove these properties from HDP-2.4 onwards instead of HDP-2.5 onwards? - Jayush Luniya On June 29, 2016

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack

2016-07-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49429/#review140825 --- Ship it! Ship It! - Jayush Luniya On June 30, 2016, 11:48

Re: Review Request 49328: AMBARI-17465 - Management packs should be able to install extensions

2016-07-05 Thread Jayush Luniya
/serverConfiguration.py (line 187) <https://reviews.apache.org/r/49328/#comment206160> Aldo add property to ambari.properties - Jayush Luniya On June 30, 2016, 5:16 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e

Re: Review Request 49429: Logsearch shows all the services not only those which are available in the stack

2016-06-30 Thread Jayush Luniya
could have service_name : "ACCUMULO" so that the list of templates can be filtered based on service_names in the stack definition. Long term we should definitely push this down to the service-level. We wont be able to support logsearch for custom services. - Jayush Luniya On June 30, 2

Re: Review Request 49134: Add llap-*log4j config dependency for hive server interactive component

2016-06-23 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49134/#review139323 --- Ship it! Ship It! - Jayush Luniya On June 23, 2016, 6:18

Re: Review Request 48970: Follow up NiFi log changes in the LogFeeder config

2016-06-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48970/#review138863 --- Ship it! Ship It! - Jayush Luniya On June 20, 2016, 11:19

Re: Review Request 47656: AMBARI-12885 - Dynamic stack extensions - install and upgrade support for custom services

2016-06-21 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47656/#review138862 --- Ship it! Ship It! - Jayush Luniya On June 20, 2016, 4:18

Re: Review Request 48999: Fix Spark2 history server quick link still point to spark1 url

2016-06-20 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48999/#review138755 --- Ship it! Ship It! - Jayush Luniya On June 21, 2016, 3:14

Re: Review Request 48734: App timeline Server start fails on enabling HA because namenode is in safemode

2016-06-17 Thread Jayush Luniya
tps://reviews.apache.org/r/48734/#comment203429> Not sure if stopping namenodes is the right way to go about with this. - Jayush Luniya On June 15, 2016, 4:41 p.m., Victor Galgo wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 17, 2016, 2:57 p.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > Update patch in CR with > https://issues.apache.org/jira/secure/attachment/12811383/AMBARI-16920-7.patch Also close CR

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-17 Thread Jayush Luniya
> On June 15, 2016, 4:57 p.m., Jayush Luniya wrote: > > Ship It! @Jeff can you close this CR as the patch is committed? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-17 Thread Jayush Luniya
trailing whitespace. "hooks_folder": "HDP/2.0.6/hooks", error: patch failed: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py:58 error: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_servi

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 17, 2016, 2:57 p.m., Jayush Luniya wrote: > > Ship It! Update patch in CR with https://issues.apache.org/jira/secure/attachment/12811383/AMBARI-16920-7.patch - Jayush --- This is an automatically generated e-mail.

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47941/#review138226 --- Ship it! Ship It! - Jayush Luniya On June 16, 2016, 11:06

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 16, 2016, 6:15 p.m., Jayush Luniya wrote: > > This is causing unit test failures. Please take a look. > > > > --- > > Failed tests: > > FAIL: test_hook_default_conf_select > > (

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-17 Thread Jayush Luniya
> On June 16, 2016, 6:15 p.m., Jayush Luniya wrote: > > This is causing unit test failures. Please take a look. > > > > --- > > Failed tests: > > FAIL: test_hook_default_conf_select > > (

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-17 Thread Jayush Luniya
> On June 2, 2016, 5:01 p.m., Jayush Luniya wrote: > > Ship It! @Jeff can you close this CR? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#rev

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-16 Thread Jayush Luniya
- [INFO] Total time: 1:15.808s [INFO] Finished at: Thu Jun 16 09:56:48 PDT 2016 [INFO] Final Memory: 60M/837M [INFO]

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jayush Luniya
. There are conflicts. Will commit once I have the latest patch. - Jayush Luniya On June 13, 2016, 10:45 a.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47941: [AMBARI-16920] Follow up issue for Spark2 stack definition

2016-06-15 Thread Jayush Luniya
> On June 2, 2016, 4:42 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py, > > line 1 > > <https://reviews.apache.org/r/47941/diff/1/?file=1396057#file1396057line1> > > > > Pleas

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-15 Thread Jayush Luniya
> On June 15, 2016, 5:51 p.m., Jayush Luniya wrote: > > Ship It! For 2.4 and trunk, we should not have any hdp-select and hdp hardcodings. Everything should be stack config driven. - Jayush --- This is an automatically ge

Re: Review Request 48308: [AMBARI-17078] Make Spark2-ThriftServer and Livy Server as optional by default

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48308/#review137771 --- Ship it! Ship It! - Jayush Luniya On June 14, 2016, 4:10

Re: Review Request 48335: Zeppelin service: Update default zeppelin_pid_dir to /var/run/zeppelin

2016-06-15 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48335/#review137770 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 11:45

Re: Review Request 48636: Zeppelin Views are not working with Custom and Remote cluster view configuration

2016-06-15 Thread Jayush Luniya
) <https://reviews.apache.org/r/48636/#comment202960> fake? - Jayush Luniya On June 13, 2016, 1:22 p.m., Renjith Kamath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-06-15 Thread Jayush Luniya
> On June 1, 2016, 8:55 p.m., Jayush Luniya wrote: > > Ship It! Lav, can you close the review if the patch is already committed? - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apa

Re: Review Request 48651: Add unit tests for Spark2 service definition

2016-06-15 Thread Jayush Luniya
ing whitespace. "hooks_folder": "HDP/2.0.6/hooks", error: patch failed: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py:156 error: ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py: patch does

Re: Review Request 48659: Fix Spark2 thriftserver Ambari definition bug

2016-06-15 Thread Jayush Luniya
> On June 15, 2016, 4:40 p.m., Jayush Luniya wrote: > > Ship It! Committed patch. Please close CR - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48659/#rev

Re: Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

2016-06-15 Thread Jayush Luniya
> On June 10, 2016, 9:35 p.m., Jayush Luniya wrote: > > Ship It! > > Masahiro Tanaka wrote: > Thank you! Could you commit this ? Committed, thanks for your contribution. Can you close the

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Jayush Luniya
16, 4:09 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16916 > https://issues.apache.org/jira/browse/AMBARI-16916 > > > Repository: ambari > > > Description > --- > >

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136845 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 4:09 p.m

Re: Review Request 48332: Log search capability for Nifi

2016-06-07 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48332/#review136499 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 10:05

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Jayush Luniya
> On June 3, 2016, 5:16 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/configuration/livy-conf.xml, > > line 32 > > <https://reviews.apache.org/r/48212/diff/1-2/?file=1405757#file1405757line32> > > > &g

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-06 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48212/#review136366 --- Ship it! Ship It! - Jayush Luniya On June 3, 2016, 4:55 p.m

Re: Review Request 48212: Fix files mentioned by ServicePropertiesTest on latest commits

2016-06-03 Thread Jayush Luniya
de add="false" v/s on-ambari-upgrade add="true") Can you provide examples? I am not clear on why on-ambari-upgrade delete="true" and on-stack-upgrade delete="false"? I will look at your original patch to get some context and then review la

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jayush Luniya
tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48157/#review135933 ------- On June 2, 2016, 6:15 p.m., Jayush Luniya wrote: > > --- > This is an au

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jayush Luniya
y: 38M/1011M [INFO] ---- Thanks, Jayush Luniya

Re: Review Request 47579: Spark2 service definition for Ambari

2016-06-02 Thread Jayush Luniya
-mail. To reply, visit: > https://reviews.apache.org/r/47579/ > --- > > (Updated May 23, 2016, 2:55 a.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-16753 > http

Re: Review Request 47885: AMBARI-16894: Default Ranger repos for some services are not getting created

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47885/#review135972 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:30 a.m

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
> On June 2, 2016, 4:52 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json, > > line 1 > > <https://reviews.apache.org/r/46727/diff/18/?file=1404615#file1404615line1> > > > > Patch does not

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review135966 --- Ship it! Ship It! - Jayush Luniya On June 2, 2016, 10:27

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
/kerberos.json (line 1) <https://reviews.apache.org/r/46727/#comment200974> Patch does not apply. I dont see a kerberos.json file in HDP-2.5 ls ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK metainfo.xml - Jayush Luniya On June 2, 2016, 10:27 a.m., Jeff

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-02 Thread Jayush Luniya
g/r/47941/#comment200972> Use explicit imports - Jayush Luniya On May 27, 2016, 3:33 a.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47653/#review135952 --- Ship it! Ship It! - Jayush Luniya On May 20, 2016, 6:14 p.m

Re: Review Request 47941: [AMBARI-16920] Spark2 thrift server can not started due to miss of spark-thrift-fairscheduler.xml

2016-06-02 Thread Jayush Luniya
e path defined in one place - Jayush Luniya On May 27, 2016, 3:33 a.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-06-02 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47923/#review135942 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 11:04

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-06-02 Thread Jayush Luniya
change in a new CR request. I will verify it and commit this delta patch instead of reverting the old patch. - Jayush Luniya On June 1, 2016, 11:06 p.m., Jeff Zhang wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-02 Thread Jayush Luniya
Memory: 38M/1011M [INFO] ---- Thanks, Jayush Luniya

Re: Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-01 Thread Jayush Luniya
y: 38M/1011M [INFO] ---- Thanks, Jayush Luniya

Review Request 48157: AMBARI-16994: Ambari Server Upgrade should always update stack_features and stack_tools config properties

2016-06-01 Thread Jayush Luniya
/test_ru_set_all.py 9a4dd31 ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 7fbda2d ambari-server/src/test/python/stacks/utils/RMFTestCase.py 74454e5 Diff: https://reviews.apache.org/r/48157/diff/ Testing --- Thanks, Jayush Luniya

Re: Review Request 47858: Cache service advisors when stack advisor is loaded

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47858/#review135854 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 7:11 p.m

Re: Review Request 48143: Missing import check_process_status for YARN nodemanager service

2016-06-01 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48143/#review135851 --- Ship it! Ship It! - Jayush Luniya On June 1, 2016, 6:26 p.m

Re: Review Request 47963: clean up import * for YARN service

2016-06-01 Thread Jayush Luniya
/package/scripts/nodemanager.py (line 90) <https://reviews.apache.org/r/47963/#comment200862> @Juanjo, it looks like check_process_status is not imported for YARN nodemanager and will cause problems. Can you submit an addendum patch with this change? - Jayush Luniya On May 27, 2016

Re: Review Request 47964: clean up import * for ZOOKEEPER service

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47964/#review135757 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:36 p.m

Re: Review Request 47963: clean up import * for YARN service

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47963/#review135756 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:33 p.m

Re: Review Request 47962: clean up import * for STORM, TEZ and ZEPPELIN services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47962/#review135755 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 4:28 p.m

Re: Review Request 47923: clean up import * for SPARK service scripts in common-services

2016-05-31 Thread Jayush Luniya
- > > (Updated May 26, 2016, 11:04 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16797 > https://issues.apache.org/jira/browse/AMBARI-16797 > > > Repository: ambari > > > Description

Re: Review Request 47934: clean up import * for SLIDER service scripts in common-services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47934/#review135752 --- Ship it! Ship It! - Jayush Luniya On May 27, 2016, 12:20

Re: Review Request 47653: clean up import * for OOZIE service scripts in common-services

2016-05-31 Thread Jayush Luniya
conflicts? - Jayush Luniya On May 20, 2016, 6:14 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47922: clean up import * for KNOX service scripts in common-services

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47922/#review135749 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 10:59

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-31 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46727/#review135657 --- Ship it! Ship It! - Jayush Luniya On May 31, 2016, 12:53

Re: Review Request 46727: [AMBARI-15612] Add Livy to HDP 2.5 as slave component of Spark

2016-05-31 Thread Jayush Luniya
> On May 18, 2016, 11:53 p.m., Jayush Luniya wrote: > > @Jeff > > Can you verify that blueprint deployment of the cluster without Livy Server > > works? > > > > Guide on Blueprints > > https://cwiki.apache.org/confluence/display/AMBARI/Blueprints >

Re: Review Request 47579: Spark2 service definition for Ambari

2016-05-26 Thread Jayush Luniya
> > (Updated May 23, 2016, 2:55 a.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-16753 > https://issues.apache.org/jira/browse/AMBARI-16753 > > > Repository: ambari

Re: Review Request 47722: AMBARI-16813 Ranger Usersync config to support Group Based Search for LDAP Sync Source

2016-05-26 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47722/#review134934 --- Ship it! Ship It! - Jayush Luniya On May 25, 2016, 10:38

Re: Review Request 47830: AMBARI-16874 Add capability to derive required core-site.xml properties in case if not already available

2016-05-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47830/#review134932 --- Ship it! Ship It! - Jayush Luniya On May 26, 2016, 5:29 a.m

Re: Review Request 47845: "Zeppelin service check" was scheduled before "Zeppelin Notebook Start"

2016-05-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47845/#review134907 --- Ship it! Ship It! - Jayush Luniya On May 25, 2016, 7:13 p.m

Re: Review Request 47774: AMBARI-16843. Auto logout zeppelin server in case of session inactivity.

2016-05-25 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47774/#review134905 --- Ship it! Ship It! - Jayush Luniya On May 24, 2016, 1:27 p.m

<    1   2   3   4   5   >