ed any hashCode()/equals() overrides here now that we're using them
in a Set?
- Nate Cole
On May 15, 2017, 1:35 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59133/#review174786
---
Please close this review if it has been pushed.
- Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59192/#review174718
---
Ship it!
Ship It!
- Nate Cole
On May 11, 2017, 2:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59180/#review174659
---
Ship it!
Ship It!
- Nate Cole
On May 11, 2017, 11:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59176/#review174644
---
Ship it!
Ship It!
- Nate Cole
On May 11, 2017, 9:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174544
---
Ship it!
Ship It!
- Nate Cole
On May 10, 2017, 10:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58929/#review174466
---
What is the state of this review?
- Nate Cole
On May 3, 2017
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59112/#review174464
---
Ship it!
Ship It!
- Nate Cole
On May 9, 2017, 5:07 p.m
host_version1 -> repo1 'INSTALLED'
host_version1 -> repo2 'CURRENT'
- Nate Cole
On May 8, 2017, 2:50 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
gt;
> > Should this instead be across host versions for the repo now?
I was hoping the cascade on entities would solve this problem, but I see the
point. Will update.
- Nate
---
This is an automatically generated e-mail. To re
/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59022/#review174072
---
Ship it!
Ship It!
- Nate Cole
On May 5, 2017, 1:55 p.m
/ambari/server/state/RepositoryVersionState.java
Lines 106 (patched)
<https://reviews.apache.org/r/59022/#comment247126>
Maybe make this a float to make rearranging them less cumbersome.
- Nate Cole
On May 5, 2017, 10:33 a.m., Jonathan Hurley
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58969/#review173817
---
Ship it!
Ship It!
- Nate Cole
On May 3, 2017, 2 p.m
/TestInstallPackages.py
5206ea351c
Diff: https://reviews.apache.org/r/58970/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
ted e-mail. To reply, visit:
> https://reviews.apache.org/r/58489/
> ---
>
> (Updated April 19, 2017, 3:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush
> Luniya, Nate Cole, and Sumit Mohanty.
>
> On May 2, 2017, 3:58 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 296 (patched)
> > <https://reviews.apache.org/r/58929/diff/1/?file=1705974#file1705974line300>
> >
> > Oracle 12 allows more than
Lines 299 (patched)
<https://reviews.apache.org/r/58929/#comment246635>
try_count ?
- Nate Cole
On May 2, 2017, 3:09 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
c/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 296 (patched)
<https://reviews.apache.org/r/58929/#comment246634>
Oracle 12 allows more than 30 characters for db objects; this name may be
pushing it :)
- Nate Cole
On May 2, 2017, 3:09 p.m., Robert
.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
Lines 102-103 (patched)
<https://reviews.apache.org/r/58857/#comment246412>
Should this be done in the constructor that takes the UpgradeEntity?
- Nate Cole
On April 28, 2
at: 2017-04-27T14:27:30-04:00
[INFO] Final Memory: 57M/635M
[INFO]
Thanks,
Nate Cole
case I took did what the majority of the file was formatted.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58801/#review173236
-------
-2/
Testing
---
Manual for both centos6 and ubuntu14. Automated pending.
Thanks,
Nate Cole
77-79 (patched)
<https://reviews.apache.org/r/58802/#comment246272>
we usually use some type of SMALLINT for booleans instead of VARCHAR(1)'s
See host_role_command.is_background
- Nate Cole
On April 27, 2017, 12:16 p.m., Dmitro Lisni
/stacks/2.0.6/configs/repository_file.json
PRE-CREATION
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
082d2001cf
Diff: https://reviews.apache.org/r/58801/diff/1/
Testing
---
Manual for both centos6 and ubuntu14. Automated pending.
Thanks,
Nate
<https://reviews.apache.org/r/58723/#comment246123>
nit: formatting
ambari-server/src/main/java/org/apache/ambari/server/alerts/ComponentVersionAlertRunnable.java
Lines 153 (patched)
<https://reviews.apache.org/r/58723/#comment246124>
nit: formatting
- Nate Cole
On April 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/#review172970
---
Ship it!
Ship It!
- Nate Cole
On April 25, 2017, 12:37 p.m
for Hive LLAP so
the dependency must still be there.
- Nate Cole
On April 10, 2017, 9:05 p.m., zhangxiaolu zhangxiaolu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
]
Thanks,
Nate Cole
/actionmanager/TestActionManager.java
e12461ddb3
Diff: https://reviews.apache.org/r/58675/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58674/#review172821
---
Ship it!
Ship It!
- Nate Cole
On April 24, 2017, 1:13 p.m
ari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
7f0c81821d
ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml
727987067b
Diff: https://reviews.apache.org/r/58629/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58577/#review172655
---
Ship it!
Ship It!
- Nate Cole
On April 21, 2017, 4:18 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58569/#review172498
---
Ship it!
Ship It!
- Nate Cole
On April 20, 2017, 8:59 a.m
>
> (Updated April 17, 2017, 8:31 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush
> Luniya, Nate Cole, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20775
> https://issues.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58483/#review172191
---
Ship it!
Ship It!
- Nate Cole
On April 17, 2017, 5:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58426/#review172080
---
Ship it!
Ship It!
- Nate Cole
On April 13, 2017, 1:14 p.m
bit misleading about whether we have
implemented it or not. The NN case is simple because we know where the holdup
is. For other daemons we can just let the server manage the timeout when
@retry isn't used.
- Nate
-------
This i
g/r/58277/#comment244750>
%s format is deprecated. Use {0} notation.
- Nate Cole
On April 12, 2017, 2:15 a.m., Madhuvanthi Radhakrishnan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58363/#review171731
---
Ship it!
Ship It!
- Nate Cole
On April 11, 2017, 8:55 p.m
>
> (Updated April 11, 2017, 12:52 p.m.)
>
>
> Review request for Ambari, Nate Cole and Robert Levas.
>
>
> Bugs: AMBARI-20714
> https://issues.apache.org/jira/browse/AMBARI-20714
>
>
> Repository: ambari
>
>
> Descripti
: 47M/216M
[INFO]
--
Total run:1192
Total errors:0
Total failures:0
OK
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58218/#review171165
---
Ship it!
Ship It!
- Nate Cole
On April 5, 2017, 4:40 p.m
-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
Lines 129-131 (original), 129-131 (patched)
<https://reviews.apache.org/r/58198/#comment244017>
There should be a test to cover this case.
- Nate Cole
On April 5, 2017, 1:52 a.m., zhangxiaolu zhangxiaolu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58208/#review171128
---
Ship it!
Ship It!
- Nate Cole
On April 5, 2017, 8:27 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58148/#review170911
---
Ship it!
Ship It!
- Nate Cole
On April 3, 2017, 11:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58153/#review170909
---
Ship it!
Ship It!
- Nate Cole
On April 3, 2017, 1:42 p.m
] Finished at: Thu Mar 30 18:52:54 EDT 2017
[INFO] Final Memory: 31M/301M
[INFO]
Thanks,
Nate Cole
-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixCapacitySchedulerOrderingPolicyTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/58046/diff/1/
Testing
---
pending
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58022/#review170386
---
Ship it!
Ship It!
- Nate Cole
On March 29, 2017, 7:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57981/#review170273
---
Ship it!
Ship It!
- Nate Cole
On March 27, 2017, 10:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57917/#review170224
---
Ship it!
Ship It!
- Nate Cole
On March 27, 2017, 4:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57969/#review170225
---
Ship it!
Ship It!
- Nate Cole
On March 27, 2017, 4:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57909/#review170117
---
Ship it!
Ship It!
- Nate Cole
On March 24, 2017, 8:05 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57918/#review170116
---
Ship it!
Ship It!
- Nate Cole
On March 24, 2017, 4:48 p.m
> On March 15, 2017, 11:20 a.m., Nate Cole wrote:
> > It looks like this was pushed to trunk - can it be closed?
>
> Nate Cole wrote:
> Ping, can this be closed?
Ping
- Nate
---
This is an automatically generate
rg/apache/ambari/server/state/UpgradeHelperTest.java
Lines 41 (patched)
<https://reviews.apache.org/r/57792/#comment242571>
should be org.junit.Assert
- Nate Cole
On March 22, 2017, 9:22 p.m., Ale
src/main/resources/upgrade-pack.xsd
Lines 187 (patched)
<https://reviews.apache.org/r/57792/#comment242236>
The code is one task per ExecuteStage, it's not a list. And it shouldn't
be! There is more thought that has to be made before we make ExecuteStage
support more than one task.
-
> On March 15, 2017, 11:20 a.m., Nate Cole wrote:
> > It looks like this was pushed to trunk - can it be closed?
Ping, can this be closed?
- Nate
---
This is an automatically generated e-mail. To reply, vis
ed)
<https://reviews.apache.org/r/57582/#comment241484>
Why do these classes need to be in a different package?
This is an odd package name, should just be
"org.apache.ambari.server.api.services.group"
I don't think I've ever seen a camel-case package name.
> On March 15, 2017, 11:23 a.m., Nate Cole wrote:
> > LGTM, make sure you get a UI person to take a look.
>
> wang jianfei wrote:
> OK, thanks very much! By the way, can you recommend some UI persons for
> me?
Poss
> On March 15, 2017, 11:24 a.m., Nate Cole wrote:
> > LGTM, make sure a UI person reviews.
>
> zhangxiaolu zhangxiaolu wrote:
> Yes, of course.Could you provide some UI person for me? I'm not sure who
> are experts.I just know you and yusaku.Thanks a lot.
?
- Nate Cole
On Feb. 6, 2017, 6:09 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53686/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57583/#review169016
---
Ship it!
LGTM, make sure a UI person reviews.
- Nate Cole
.
- Nate Cole
On March 14, 2017, 4:01 a.m., wang jianfei wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/HDP/2.5/upgrades/upgrade-2.6.xml
Lines 219-222 (original), 219-222 (patched)
<https://reviews.apache.org/r/57604/#comment241345>
I thought the class was in 2.5 such that this wouldn't be the same issue.
Did your tests show otherwise?
- Nate Cole
On March 14, 2017, 1:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57265/#review168819
---
Ship it!
Ship It!
- Nate Cole
On March 13, 2017, 1:59 a.m
quot;
This is taken direct from the UI person that approved this message.
- Nate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57255/#review167736
---
/java/org/apache/ambari/server/checks/AutoStartDisabledCheckTest.java
c1e2ce7
Diff: https://reviews.apache.org/r/57255/diff/1/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57215/#review167677
---
Ship it!
Ship It!
- Nate Cole
On March 1, 2017, 3:51 p.m
tate/stack/upgrade/StageWrapperBuilderTest.java
b9e27be
Diff: https://reviews.apache.org/r/57000/diff/
Testing (updated)
---
Manual. Automated:
Results :
Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56994/#review166580
---
Ship it!
Ship It!
- Nate Cole
On Feb. 23, 2017, 3:04 p.m
rTest.java
b9e27be
Diff: https://reviews.apache.org/r/57000/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
: 57M/584M
[INFO]
Thanks,
Nate Cole
/cluster/ClusterImpl.java
db4aa21
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java
6cdfbad
Diff: https://reviews.apache.org/r/56793/diff/
Testing
---
Manual. Automated pending.
Thanks,
Nate Cole
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56787/#review165958
---
Ship it!
Ship It!
- Nate Cole
On Feb. 17, 2017, 10:44 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56766/#review165940
---
Ship it!
Ship It!
- Nate Cole
On Feb. 17, 2017, 8:09 a.m
values are 'minimal'
or 'full'."
- Nate Cole
On Feb. 14, 2017, 3:07 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53686/#review165540
---
Ship it!
Ship It!
- Nate Cole
On Feb. 6, 2017, 6:09 p.m
37371>
Any specific reason for a new Exception class? There's remarkable changed
that isn't covered by a "regular" AmbariException.
- Nate Cole
On Feb. 14, 2017, 10:27 a.m., Balázs Bence Sári wrote:
>
> ---
> This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56599/#review165335
---
Ship it!
Ship It!
- Nate Cole
On Feb. 13, 2017, 8:48 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56552/#review165321
---
Ship it!
Ship It!
- Nate Cole
On Feb. 10, 2017, 12:41 p.m
247)
<https://reviews.apache.org/r/56540/#comment236935>
+1 for Jonathan's comments. String comparison is evil.
- Nate Cole
On Feb. 10, 2017, 7:21 a.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically genera
59/
> ---
>
> (Updated Feb. 8, 2017, 9:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro
> Grinenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-19768
> https://i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56331/#review164511
---
Ship it!
Ship It!
- Nate Cole
On Feb. 7, 2017, 4:59 a.m
/AmbariCustomCommandExecutionHelper.java
(lines 1151 - 1154)
<https://reviews.apache.org/r/55989/#comment235713>
I know this has been submitted, but how exactly is this change affecting
performance. I'm betting 0%.
- Nate Cole
On Jan. 31, 2017, 7:45 a.m., Vitalyi Brodetskyi
s marked
@Transactional already, this method may not need those annotations.
@Jonathan for input if it's required for both methods.
- Nate Cole
On Jan. 18, 2017, 5:33 p.m., Jaimin Jetly wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56059/#review164021
---
Ship it!
Ship It!
- Nate Cole
On Feb. 2, 2017, 11:16 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164018
---
Ship it!
Ship It!
- Nate Cole
On Feb. 2, 2017, 3:01 p.m
ps://reviews.apache.org/r/56141/#review163850
---
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail.
uot;AUTO_INSTALL_START", "AUTO_START", "FULL"]
> > I think we may also check for other options as well.
>
> Jonathan Hurley wrote:
> Are the other options valid / used? Why are they not enums - does that
> mean that people can somehow define their ow
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/56141/#review163841
---
On Jan. 31, 2017, 9:32 p.m., Nate Cole wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
)
<https://reviews.apache.org/r/56059/#comment235364>
Is it possible that these paths are different between redhat6 and redhat7
(or any of their flavors?)
- Nate Cole
On Feb. 1, 2017, 2:13 p.m., Dmitro Lisnichenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56166/#review163884
---
Ship it!
Ship It!
- Nate Cole
On Feb. 1, 2017, 8:29 a.m
--
On Feb. 1, 2017, 2:13 p.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56059/
> ---
>
> (Updated Feb. 1, 2017, 2:13 p.m.)
>
>
> Review request for Ambari
]
[INFO] Total time: 40:57.215s
[INFO] Finished at: Tue Jan 31 18:24:43 EST 2017
[INFO] Final Memory: 45M/694M
[INFO]
Thanks,
Nate Cole
> On Jan. 29, 2017, 5:09 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/ambari_commons/shell.py, lines 141-142
> > <https://reviews.apache.org/r/56059/diff/1/?file=1618458#file1618458line141>
> >
> > Seems awfully specific. Would be more flexible
exible if we could pass in the
kill delay as an argument whose default is 5 (the graceful_kill_delay).
- Nate Cole
On Jan. 29, 2017, 7:27 a.m., Dmitro Lisnichenko wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55789/#review163139
---
Ship it!
Ship It!
- Nate Cole
On Jan. 25, 2017, 1:25 p.m
this change.
- Nate Cole
On Jan. 23, 2017, 12:34 p.m., Amruta Borkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
301 - 400 of 891 matches
Mail list logo
