---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64276/#review192700
---
Ship it!
Ship It!
- Yusaku Sako
On Dec. 2, 2017, 8:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/#review192606
---
Ship it!
Ship It!
- Yusaku Sako
On Dec. 1, 2017, 11:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64227/#review192382
---
Ship it!
Ship It!
- Yusaku Sako
On Nov. 30, 2017, 10:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64185/#review192197
---
Ship it!
Ship It!
- Yusaku Sako
On Nov. 29, 2017, 11:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62235/#review185220
---
Ship it!
Ship It!
- Yusaku Sako
On Sept. 12, 2017, 4:38 p.m
e. So essentially, yarn is being run with "yarn
--ignore-engines".
Also, --pure-lockfile argument is missing in this particular pom.xml.
- Yusaku Sako
On May 4, 2017, 6:36 a.m., venkat sairam wrote:
>
> ---
>
ot; builds Ambari Web successfully.
Ran ambari-web unit tests:
30380 passing (19s)
157 pending
Thanks,
Yusaku Sako
/
Testing
---
Tested locally to make sure that "mvn package" builds Ambari Web successfully.
Ran ambari-web unit tests:
30380 passing (19s)
157 pending
Thanks,
Yusaku Sako
ambari-web unit tests:
30380 passing (19s)
157 pending
Thanks,
Yusaku Sako
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57895/#review169935
---
Ship it!
Ship It!
- Yusaku Sako
On March 23, 2017, 10:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57625/#review169216
---
Ship it!
Ship It!
- Yusaku Sako
On March 16, 2017, 2:14 p.m
the quotes add much value /
clarity / readability.
2. Can we change the prompt a little bit, like this: "Fix permissions for XXX
to YYY (recommended) [y/n] (y)?"
- Yusaku Sako
On March 14, 2017, 10:35 p.m., Vitalyi Brodet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57577/#review168850
---
Ship it!
Ship It!
- Yusaku Sako
On March 14, 2017, 12:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57567/#review168832
---
Ship it!
Ship It!
- Yusaku Sako
On March 13, 2017, 8:40 p.m
: https://reviews.apache.org/r/57493/diff/1/
Testing
---
Tested manually with a reverse proxy with subpath configured per
http://docs.grafana.org/installation/behind_proxy/.
There are currently no unit tests covering the data source, so no tests are
included.
Thanks,
Yusaku Sako
://reviews.apache.org/r/57493/diff/1/
Testing
---
Tested manually with a reverse proxy with subpath configured per
http://docs.grafana.org/installation/behind_proxy/.
There are currently no unit tests covering the data source, so no tests are
included.
Thanks,
Yusaku Sako
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57201/#review168325
---
Ship it!
Ship It!
- Yusaku Sako
On March 1, 2017, 7:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57051/#review166767
---
Ship it!
Ship It!
- Yusaku Sako
On Feb. 24, 2017, 10:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56508/#review165037
---
Ship it!
Ship It!
- Yusaku Sako
On Feb. 9, 2017, 9:33 p.m
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing
> > this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log
> issues against the
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing
> > this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log
> issues against the
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing
> > this out.
>
> Yusaku Sako wrote:
> Willy, this is outside the scope of this patch, but where can I log
> issues against the
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote:
> > Thanks for this contribution and creating this ReviewBoard. I am testing
> > this out.
Willy, this is outside the scope of this patch, but where can I log issues
against the Solr mpack? I got an error regarding not being ab
testing this
out.
- Yusaku Sako
On Feb. 9, 2017, 6:38 p.m., Willy Solaligue wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56266/#review164185
---
Ship it!
Ship It!
- Yusaku Sako
On Feb. 3, 2017, 3:44 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56196/#review164005
---
Ship it!
Ship It!
- Yusaku Sako
On Feb. 1, 2017, 11:56 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56097/#review163685
---
Ship it!
Ship It!
- Yusaku Sako
On Jan. 30, 2017, 9:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55957/#review163062
---
Ship it!
Ship It!
- Yusaku Sako
On Jan. 25, 2017, 9:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55369/#review162562
---
Ship it!
Ship It!
- Yusaku Sako
On Jan. 16, 2017, 3:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55528/#review161633
---
Ship it!
Ship It!
- Yusaku Sako
On Jan. 14, 2017, 1:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55232/#review160775
---
Ship it!
Ship It!
- Yusaku Sako
On Jan. 5, 2017, 11:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55245/#review160663
---
Ship it!
Ship It!
- Yusaku Sako
On Jan. 6, 2017, 1:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54887/#review160234
---
Ship it!
Ship It!
- Yusaku Sako
On Dec. 20, 2016, 11:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54644/#review158885
---
Ship it!
Ship It!
- Yusaku Sako
On Dec. 12, 2016, 6:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54326/#review157846
---
Ship it!
Ship It!
- Yusaku Sako
On Dec. 2, 2016, 10:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53922/#review156508
---
Ship it!
Ship It!
- Yusaku Sako
On Nov. 19, 2016, 3:10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52850/#review154963
---
Ship it!
Ship It!
- Yusaku Sako
On Nov. 4, 2016, 1:45 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53091/#review153571
---
Ship it!
Ship It!
- Yusaku Sako
On Oct. 21, 2016, 3:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52971/#review153015
---
Ship it!
Ship It!
- Yusaku Sako
On Oct. 18, 2016, 1:39 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52904/#review152769
---
Ship it!
Ship It!
- Yusaku Sako
On Oct. 15, 2016, 12:58 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152522
---
Ship it!
Ship It!
- Yusaku Sako
On Oct. 13, 2016, 1:48 p.m
, non-vendor style.
Can we move the Roboto font files back to vendor, though?
LICENSE.txt (line 348)
<https://reviews.apache.org/r/52747/#comment221387>
This should not have been reverted.
- Yusaku Sako
On Oct. 12, 2016, 7:05 p.m., Aleksandr Kovalenko
> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote:
> > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js,
> > line 44
> > <https://reviews.apache.org/r/52747/diff/1/?file=1530666#file1530666line44>
> >
> > glyphicon is dup
g/r/52747/#comment221035>
Need to fix this typo
ambari-web/vendor/theme/bootstrap-ambari.min.css (line 1)
<https://reviews.apache.org/r/52747/#comment221051>
Can we put this in a non-vendor directory, unminified with an appropriate
license header?
- Yusaku Sako
On Oct.
tail?
Also, did you explicitly build all the contrib/views modules with the change?
- Yusaku Sako
On Oct. 3, 2016, 10:46 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51859/#review148778
---
Ship it!
Ship It!
- Yusaku Sako
On Sept. 13, 2016, 8:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51280/#review146348
---
Ship it!
Ship It!
- Yusaku Sako
On Aug. 22, 2016, 5:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51165/#review145952
---
Ship it!
Ship It!
- Yusaku Sako
On Aug. 17, 2016, 1:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49727/#review141110
---
Ship it!
Ship It!
- Yusaku Sako
On July 6, 2016, 9:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48293/#review136378
---
Ship it!
Ship It!
- Yusaku Sako
On June 6, 2016, 9:24 p.m
org/r/48212/#comment201053)
- Yusaku Sako
On June 6, 2016, 9:24 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48241/#review136139
---
Ship it!
Ship It!
- Yusaku Sako
On June 3, 2016, 11:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48106/#review135737
---
Ship it!
Ship It!
- Yusaku Sako
On June 1, 2016, 12:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47920/#review135117
---
Ship it!
Ship It!
- Yusaku Sako
On May 26, 2016, 10:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46543/#review129975
---
Ship it!
Ship It!
- Yusaku Sako
On April 21, 2016, 10:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46352/#review129449
---
Ship it!
Ship It!
- Yusaku Sako
On April 18, 2016, 11:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46054/#review128293
---
Ship it!
Ship It!
- Yusaku Sako
On April 11, 2016, 10:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45903/#review127709
---
Ship it!
Ship It!
- Yusaku Sako
On April 8, 2016, 12:36 a.m
/controllers/stackVersions/StackVersionsEditCtrl.js
(line 138)
<https://reviews.apache.org/r/45903/#comment191096>
Should this be negated?
- Yusaku Sako
On April 8, 2016, 12:19 a.m., Zhe (Joe) Wang wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45841/#review127506
---
Ship it!
Ship It!
- Yusaku Sako
On April 6, 2016, 11:25 p.m
. The user
would need to see what went wrong.
Also, can we get into partial failure scenarios?
- Yusaku Sako
On March 23, 2016, 8:58 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45069/#review124354
---
Ship it!
Ship It!
- Yusaku Sako
On March 19, 2016, 1:43 a.m
62 matches
Mail list logo