Re: Review Request 64276: hive2 queries fails after adding any service to the cluster

2017-12-04 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64276/#review192700 --- Ship it! Ship It! - Yusaku Sako On Dec. 2, 2017, 8:19 p.m

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-12-01 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63847/#review192606 --- Ship it! Ship It! - Yusaku Sako On Dec. 1, 2017, 11:16 p.m

Re: Review Request 64227: AMBARI-22570. Repository Fields missing when register version is clicked

2017-11-30 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64227/#review192382 --- Ship it! Ship It! - Yusaku Sako On Nov. 30, 2017, 10:15 p.m

Re: Review Request 64185: UI should pass repo_name for repository validation

2017-11-29 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64185/#review192197 --- Ship it! Ship It! - Yusaku Sako On Nov. 29, 2017, 11:40 p.m

Re: Review Request 62235: Some clients are being additionally installed via Add service wizard

2017-09-12 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62235/#review185220 --- Ship it! Ship It! - Yusaku Sako On Sept. 12, 2017, 4:38 p.m

Re: Review Request 58984: Ambari Views are failing to compile in 2.4.3

2017-05-04 Thread Yusaku Sako
e. So essentially, yarn is being run with "yarn --ignore-engines". Also, --pure-lockfile argument is missing in this particular pom.xml. - Yusaku Sako On May 4, 2017, 6:36 a.m., venkat sairam wrote: > > --- >

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Yusaku Sako
ot; builds Ambari Web successfully. Ran ambari-web unit tests: 30380 passing (19s) 157 pending Thanks, Yusaku Sako

Re: Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Yusaku Sako
/ Testing --- Tested locally to make sure that "mvn package" builds Ambari Web successfully. Ran ambari-web unit tests: 30380 passing (19s) 157 pending Thanks, Yusaku Sako

Review Request 58596: AMBARI-20813. Convert ambari-web build process to use yarn package manager to fix dependencies and to make the process faster

2017-04-20 Thread Yusaku Sako
ambari-web unit tests: 30380 passing (19s) 157 pending Thanks, Yusaku Sako

Re: Review Request 57895: upgrade frontend-maven-plugin to latest >= 1.3 to make use of ignore proxy feature

2017-03-23 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57895/#review169935 --- Ship it! Ship It! - Yusaku Sako On March 23, 2017, 10:13

Re: Review Request 57625: Minor refactoring and clean up in ambari-server

2017-03-16 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57625/#review169216 --- Ship it! Ship It! - Yusaku Sako On March 16, 2017, 2:14 p.m

Re: Review Request 57625: Minor refactoring and clean up in ambari-server

2017-03-15 Thread Yusaku Sako
the quotes add much value / clarity / readability. 2. Can we change the prompt a little bit, like this: "Fix permissions for XXX to YYY (recommended) [y/n] (y)?" - Yusaku Sako On March 14, 2017, 10:35 p.m., Vitalyi Brodet

Re: Review Request 57577: ambari-web shows redundant configuration for "Number of nodes used by Hive's LLAP"

2017-03-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57577/#review168850 --- Ship it! Ship It! - Yusaku Sako On March 14, 2017, 12:28

Re: Review Request 57567: Hive Server interactive not removed from Hive summary page after HSI is disabled

2017-03-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57567/#review168832 --- Ship it! Ship It! - Yusaku Sako On March 13, 2017, 8:40 p.m

Re: Review Request 57493: Ambari Metrics Grafana Datasource plugin does not work when configured with a reverse proxy with subpath

2017-03-09 Thread Yusaku Sako
: https://reviews.apache.org/r/57493/diff/1/ Testing --- Tested manually with a reverse proxy with subpath configured per http://docs.grafana.org/installation/behind_proxy/. There are currently no unit tests covering the data source, so no tests are included. Thanks, Yusaku Sako

Review Request 57493: Ambari Metrics Grafana Datasource plugin does not work when configured with a reverse proxy with subpath

2017-03-09 Thread Yusaku Sako
://reviews.apache.org/r/57493/diff/1/ Testing --- Tested manually with a reverse proxy with subpath configured per http://docs.grafana.org/installation/behind_proxy/. There are currently no unit tests covering the data source, so no tests are included. Thanks, Yusaku Sako

Re: Review Request 57201: Service Alert Popup - Unexpected User Experience

2017-03-08 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57201/#review168325 --- Ship it! Ship It! - Yusaku Sako On March 1, 2017, 7:16 p.m

Re: Review Request 57051: Move spinner for Next and Back button in Kerberos Wizard

2017-02-24 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57051/#review166767 --- Ship it! Ship It! - Yusaku Sako On Feb. 24, 2017, 10:27 p.m

Re: Review Request 56508: Solr grafana dashboards - trunk

2017-02-09 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56508/#review165037 --- Ship it! Ship It! - Yusaku Sako On Feb. 9, 2017, 9:33 p.m

Re: Review Request 56508: Solr grafana dashboards - trunk

2017-02-09 Thread Yusaku Sako
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote: > > Thanks for this contribution and creating this ReviewBoard. I am testing > > this out. > > Yusaku Sako wrote: > Willy, this is outside the scope of this patch, but where can I log > issues against the

Re: Review Request 56508: Solr grafana dashboards - trunk

2017-02-09 Thread Yusaku Sako
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote: > > Thanks for this contribution and creating this ReviewBoard. I am testing > > this out. > > Yusaku Sako wrote: > Willy, this is outside the scope of this patch, but where can I log > issues against the

Re: Review Request 56508: Solr grafana dashboards - trunk

2017-02-09 Thread Yusaku Sako
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote: > > Thanks for this contribution and creating this ReviewBoard. I am testing > > this out. > > Yusaku Sako wrote: > Willy, this is outside the scope of this patch, but where can I log > issues against the

Re: Review Request 56508: Solr grafana dashboards - trunk

2017-02-09 Thread Yusaku Sako
> On Feb. 9, 2017, 6:39 p.m., Yusaku Sako wrote: > > Thanks for this contribution and creating this ReviewBoard. I am testing > > this out. Willy, this is outside the scope of this patch, but where can I log issues against the Solr mpack? I got an error regarding not being ab

Re: Review Request 56508: Solr grafana dashboards - trunk

2017-02-09 Thread Yusaku Sako
testing this out. - Yusaku Sako On Feb. 9, 2017, 6:38 p.m., Willy Solaligue wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56266: The user must be clearly communicated about YARN pre-emption requirements when Hive LLAP is enabled

2017-02-03 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56266/#review164185 --- Ship it! Ship It! - Yusaku Sako On Feb. 3, 2017, 3:44 a.m

Re: Review Request 56196: UI changes to resolve discrepancies between what the stack vs Ambari reports as "live" for NodeManagers

2017-02-02 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56196/#review164005 --- Ship it! Ship It! - Yusaku Sako On Feb. 1, 2017, 11:56 p.m

Re: Review Request 56097: Need to have a flag from UI to show/hide ranger plugin configs

2017-01-31 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56097/#review163685 --- Ship it! Ship It! - Yusaku Sako On Jan. 30, 2017, 9:30 p.m

Re: Review Request 55957: HDFS TopN Operations by User graph showing wrong data in grafana

2017-01-25 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55957/#review163062 --- Ship it! Ship It! - Yusaku Sako On Jan. 25, 2017, 9:24 p.m

Re: Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

2017-01-21 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55369/#review162562 --- Ship it! Ship It! - Yusaku Sako On Jan. 16, 2017, 3:34 a.m

Re: Review Request 55528: Re-order rows in HDFS-TopN Grafana Dashboard

2017-01-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55528/#review161633 --- Ship it! Ship It! - Yusaku Sako On Jan. 14, 2017, 1:11 a.m

Re: Review Request 55232: Grafana datasource changes to accommodate new visualizations for TopN

2017-01-06 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55232/#review160775 --- Ship it! Ship It! - Yusaku Sako On Jan. 5, 2017, 11:44 p.m

Re: Review Request 55245: ambari-web action to download all client configs of a service

2017-01-05 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55245/#review160663 --- Ship it! Ship It! - Yusaku Sako On Jan. 6, 2017, 1:21 a.m

Re: Review Request 54887: Incorrect Method types displayed in the description of created Alert notification

2016-12-28 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54887/#review160234 --- Ship it! Ship It! - Yusaku Sako On Dec. 20, 2016, 11:24 a.m

Re: Review Request 54644: Ambari-web unit tests cannot be run in Mac OS Sierra

2016-12-12 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54644/#review158885 --- Ship it! Ship It! - Yusaku Sako On Dec. 12, 2016, 6:59 a.m

Re: Review Request 54326: Remove 'llap_queue_capacity' references from UI code.

2016-12-02 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54326/#review157846 --- Ship it! Ship It! - Yusaku Sako On Dec. 2, 2016, 10:33 p.m

Re: Review Request 53922: AMBARI-18942 - Auto-start services: Avoid full page reload after "Save" / "Discard"

2016-11-21 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53922/#review156508 --- Ship it! Ship It! - Yusaku Sako On Nov. 19, 2016, 3:10 a.m

Re: Review Request 52850: Icons don't display in Windows 10 Microsoft Edge or Internet Explorer 11

2016-11-04 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52850/#review154963 --- Ship it! Ship It! - Yusaku Sako On Nov. 4, 2016, 1:45 a.m

Re: Review Request 53091: Adding custom property to hive-site adds it to other 'Custom' panels on hive

2016-10-21 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53091/#review153571 --- Ship it! Ship It! - Yusaku Sako On Oct. 21, 2016, 3:58 p.m

Re: Review Request 52971: Service Summary screen does not show hostname in tooltip pop-up for all services

2016-10-17 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52971/#review153015 --- Ship it! Ship It! - Yusaku Sako On Oct. 18, 2016, 1:39 a.m

Re: Review Request 52904: Hive Settings Page: Mouse-over on "HiveServer2 Interactive host" label repeats same message twice

2016-10-14 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52904/#review152769 --- Ship it! Ship It! - Yusaku Sako On Oct. 15, 2016, 12:58 a.m

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52747/#review152522 --- Ship it! Ship It! - Yusaku Sako On Oct. 13, 2016, 1:48 p.m

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako
, non-vendor style. Can we move the Roboto font files back to vendor, though? LICENSE.txt (line 348) <https://reviews.apache.org/r/52747/#comment221387> This should not have been reverted. - Yusaku Sako On Oct. 12, 2016, 7:05 p.m., Aleksandr Kovalenko

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako
> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote: > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js, > > line 44 > > <https://reviews.apache.org/r/52747/diff/1/?file=1530666#file1530666line44> > > > > glyphicon is dup

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-11 Thread Yusaku Sako
g/r/52747/#comment221035> Need to fix this typo ambari-web/vendor/theme/bootstrap-ambari.min.css (line 1) <https://reviews.apache.org/r/52747/#comment221051> Can we put this in a non-vendor directory, unminified with an appropriate license header? - Yusaku Sako On Oct.

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

2016-10-03 Thread Yusaku Sako
tail? Also, did you explicitly build all the contrib/views modules with the change? - Yusaku Sako On Oct. 3, 2016, 10:46 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 51859: Enable Kerberos Wizard: Metrics collector fails to start on a cluster with Ranger installed

2016-09-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51859/#review148778 --- Ship it! Ship It! - Yusaku Sako On Sept. 13, 2016, 8:40 p.m

Re: Review Request 51280: Ambari logo (and other images) missing in Chrome when SSL is enabled.

2016-08-22 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51280/#review146348 --- Ship it! Ship It! - Yusaku Sako On Aug. 22, 2016, 5:52 a.m

Re: Review Request 51165: HSI is not started even when "Enable Interactive Query" is set to Yes on installer wizard

2016-08-16 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51165/#review145952 --- Ship it! Ship It! - Yusaku Sako On Aug. 17, 2016, 1:19 a.m

Re: Review Request 49727: AMBARI-17598 Permission mismatch b/w 'Cluster user' and 'read only user' from older ambari

2016-07-06 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49727/#review141110 --- Ship it! Ship It! - Yusaku Sako On July 6, 2016, 9:27 p.m

Re: Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

2016-06-06 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48293/#review136378 --- Ship it! Ship It! - Yusaku Sako On June 6, 2016, 9:24 p.m

Re: Review Request 48293: Make QuickLink to HS2 UI work when HTTPS is enabled

2016-06-06 Thread Yusaku Sako
org/r/48212/#comment201053) - Yusaku Sako On June 6, 2016, 9:24 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &

Re: Review Request 48241: Enable kerberos wizard UI showing incorrect total of required fields

2016-06-03 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48241/#review136139 --- Ship it! Ship It! - Yusaku Sako On June 3, 2016, 11:43 p.m

Re: Review Request 48106: HS2 Interactive not shown on summary page after enabling HS Interactive (Blueprint deployment)

2016-05-31 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48106/#review135737 --- Ship it! Ship It! - Yusaku Sako On June 1, 2016, 12:59 a.m

Re: Review Request 47920: Enable HS2 Interactive > Select Hosts does not have Cancel and close

2016-05-26 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47920/#review135117 --- Ship it! Ship It! - Yusaku Sako On May 26, 2016, 10:36 p.m

Re: Review Request 46543: After HSI is enabled in install wizard the validation call does not send HSI in the component list of the host_group resulting in validation errors

2016-04-21 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46543/#review129975 --- Ship it! Ship It! - Yusaku Sako On April 21, 2016, 10:39

Re: Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

2016-04-18 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46352/#review129449 --- Ship it! Ship It! - Yusaku Sako On April 18, 2016, 11:48

Re: Review Request 46054: Enable Hive Interactive is turned ON by default

2016-04-11 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46054/#review128293 --- Ship it! Ship It! - Yusaku Sako On April 11, 2016, 10:11

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45903/#review127709 --- Ship it! Ship It! - Yusaku Sako On April 8, 2016, 12:36 a.m

Re: Review Request 45903: AMBARI-15775 Integrate Red Hat Satellite option in Ambari Admin

2016-04-07 Thread Yusaku Sako
/controllers/stackVersions/StackVersionsEditCtrl.js (line 138) <https://reviews.apache.org/r/45903/#comment191096> Should this be negated? - Yusaku Sako On April 8, 2016, 12:19 a.m., Zhe (Joe) Wang wrote: > > --- > This is a

Re: Review Request 45841: Restart LLAP action should be shown only when Hive Interactive Server is present in the cluster

2016-04-06 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45841/#review127506 --- Ship it! Ship It! - Yusaku Sako On April 6, 2016, 11:25 p.m

Re: Review Request 45247: YARN Queue should be refreshed when enabling/disabling Interactive Query

2016-03-23 Thread Yusaku Sako
. The user would need to see what went wrong. Also, can we get into partial failure scenarios? - Yusaku Sako On March 23, 2016, 8:58 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 45069: HiveServerInteractive. Remove Password requirement from hive-interactive-site.xml.

2016-03-18 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45069/#review124354 --- Ship it! Ship It! - Yusaku Sako On March 19, 2016, 1:43 a.m