Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/#review129369
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py (line 67)


It should not take long enough for upgrade to execute that will allow 
remote debugging, don't you want a configurable supend action so JVM will pause 
sufficiently ?


- Sid Wagle


On April 18, 2016, 5:14 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46137/
> ---
> 
> (Updated April 18, 2016, 5:14 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-15814
> https://issues.apache.org/jira/browse/AMBARI-15814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15814: Enable debugging of ambari-server upgrade command
> 
> ** Issue **:
> Right now **ambari-server upgrade** cannot be debugged remotely. To enable 
> remote debugging, handle the -g/--debug flag the same way **ambari-server 
> start -g** works.
> 
> ** Fix **:
> Create a debug command line for JVM to execute, the same way as ambari-server 
> start -g works.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 
> 
> Diff: https://reviews.apache.org/r/46137/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.946s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.036s]
> [INFO] Ambari Web  SUCCESS [39.154s]
> [INFO] Ambari Views .. SUCCESS [1.073s]
> [INFO] Ambari Admin View . SUCCESS [8.779s]
> [INFO] ambari-metrics  SUCCESS [0.356s]
> [INFO] Ambari Metrics Common . SUCCESS [0.467s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.190s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.633s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.645s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.640s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.663s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.831s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.896s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.645s]
> [INFO] Ambari Server . SUCCESS [2:49.890s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.347s]
> [INFO] Ambari Agent .. SUCCESS [24.663s]
> [INFO] Ambari Client . SUCCESS [0.045s]
> [INFO] Ambari Python Client .. SUCCESS [0.983s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.203s]
> [INFO] Ambari Shell .. SUCCESS [0.041s]
> [INFO] Ambari Python Shell ... SUCCESS [0.720s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.966s]
> [INFO] ambari-logsearch .. SUCCESS [0.288s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [8.111s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.025s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.216s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.089s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:07.410s
> [INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016
> [INFO] Final Memory: 281M/1155M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 260 tests in 6.521s
> 
> OK
> --
> Total run:963
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.557s
> [INFO] 

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

> On April 18, 2016, 5:33 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py,
> >  line 137
> > 
> >
> > Add null checks and check reponse validity of  json_response before 
> > checking json_reponse['app']['state']
> 
> Masahiro Tanaka wrote:
> Thank you for review !
> I have a question, what do you mean `response validity of json_response` ?

I meant check that the json_response has ['app'] node and further has ['state'] 
node. 

Example:

json_response = { 'app' : { } }
json_response['app']['state']
Traceback (most recent call last):
  File "", line 1, in 
KeyError: 'state'


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129295
---


On April 17, 2016, 4:56 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 17, 2016, 4:56 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45713/#review129356
---


Ship it!




Ship It!

- Srimanth Gunturi


On April 11, 2016, 5:36 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45713/
> ---
> 
> (Updated April 11, 2016, 5:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-15700
> https://issues.apache.org/jira/browse/AMBARI-15700
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15700: Stack advisor - Component layout recommendation needs support 
> for avoiding hosts in maintenance mode
> 
> ** Issue **
> Stack advisor script should ignore hosts in maintenance mode when 
> recommending or validating component layout
> 
> ** Fix **
> Modified the stack advisor scripts to handle the case when one or more hosts 
> are in maintenance state while recommending or validating component layout
> Added two test cases to validate the recommendation when one or more hosts 
> are in maintenance state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 53591cdcaed05713013be1ba7295b1c2b3ed64af 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483d3e1f08afe495fb30b6341f6f825f145d 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
> b99c484b3e65de0c9186727064fc67a4bb1d8315 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 
> 636de01ad6fc72d9dc397b754aa5e190d4d9c5ff 
>   ambari-server/src/test/python/TestStackAdvisor.py 
> 149ae1dc7ea2e596680321dd70030dcfe060f6cf 
> 
> Diff: https://reviews.apache.org/r/45713/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [8.744s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.041s]
> [INFO] Ambari Web  SUCCESS [25.392s]
> [INFO] Ambari Views .. SUCCESS [1.375s]
> [INFO] Ambari Admin View . SUCCESS [11.669s]
> [INFO] ambari-metrics  SUCCESS [0.375s]
> [INFO] Ambari Metrics Common . SUCCESS [0.524s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.450s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.662s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.685s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.209s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.115s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.137s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.980s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.948s]
> [INFO] Ambari Server . SUCCESS [2:56.964s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.720s]
> [INFO] Ambari Agent .. SUCCESS [24.955s]
> [INFO] Ambari Client . SUCCESS [0.045s]
> [INFO] Ambari Python Client .. SUCCESS [0.838s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.152s]
> [INFO] Ambari Shell .. SUCCESS [0.054s]
> [INFO] Ambari Python Shell ... SUCCESS [0.719s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.118s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 5:54.648s
> [INFO] Finished at: Thu Apr 07 16:59:26 PDT 2016
> [INFO] Final Memory: 261M/1301M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 253 tests in 6.689s
> 
> OK
> --
> Total run:944
> Total errors:0
> Total failures:0
> OK
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total 

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/#review129378
---


Ship it!




- Alejandro Fernandez


On April 18, 2016, 5:39 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46137/
> ---
> 
> (Updated April 18, 2016, 5:39 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-15814
> https://issues.apache.org/jira/browse/AMBARI-15814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15814: Enable debugging of ambari-server upgrade command
> 
> ** Issue **:
> Right now **ambari-server upgrade** cannot be debugged remotely. To enable 
> remote debugging, handle the -g/--debug flag the same way **ambari-server 
> start -g** works.
> 
> ** Fix **:
> Create a debug command line for JVM to execute, the same way as ambari-server 
> start -g works.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 
> 
> Diff: https://reviews.apache.org/r/46137/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.946s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.036s]
> [INFO] Ambari Web  SUCCESS [39.154s]
> [INFO] Ambari Views .. SUCCESS [1.073s]
> [INFO] Ambari Admin View . SUCCESS [8.779s]
> [INFO] ambari-metrics  SUCCESS [0.356s]
> [INFO] Ambari Metrics Common . SUCCESS [0.467s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.190s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.633s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.645s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.640s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.663s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.831s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.896s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.645s]
> [INFO] Ambari Server . SUCCESS [2:49.890s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.347s]
> [INFO] Ambari Agent .. SUCCESS [24.663s]
> [INFO] Ambari Client . SUCCESS [0.045s]
> [INFO] Ambari Python Client .. SUCCESS [0.983s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.203s]
> [INFO] Ambari Shell .. SUCCESS [0.041s]
> [INFO] Ambari Python Shell ... SUCCESS [0.720s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.966s]
> [INFO] ambari-logsearch .. SUCCESS [0.288s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [8.111s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.025s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.216s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.089s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:07.410s
> [INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016
> [INFO] Final Memory: 281M/1155M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 260 tests in 6.521s
> 
> OK
> --
> Total run:963
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.557s
> [INFO] Finished at: Mon Apr 18 10:03:46 PDT 2016
> [INFO] Final Memory: 56M/1024M
> [INFO] 
> 
> 
> 
> ** 3. Manual testing **
> 
> Ran *ambari-server upgrade -g* and verified that intelliJ debugger could be 
> 

Re: Review Request 46310: Use exclude list in order to merge hive-interactve-site from hive-site. Both will show common props in their config bag.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46310/#review129383
---


Ship it!




Ship It!

- Swapan Shridhar


On April 18, 2016, 2:11 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46310/
> ---
> 
> (Updated April 18, 2016, 2:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-15937
> https://issues.apache.org/jira/browse/AMBARI-15937
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Along with the changes, there are some clean-up and addition of basic unit 
> tests. Some more comments in the diff.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7d913e5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9d05d37 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  03fd40c 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46310/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests manually, and tested by applying patch.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46338/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-15949
https://issues.apache.org/jira/browse/AMBARI-15949


Repository: ambari


Description
---

Change the way the hyperlink to an external alert detail URL is shown.


Diffs
-

  ambari-web/app/messages.js 8d73bb3 
  ambari-web/app/templates/main/alerts/configs.hbs 4259be8 
  ambari-web/app/templates/main/alerts/definition_details.hbs 15cf168 

Diff: https://reviews.apache.org/r/46338/diff/


Testing
---

Local ambari-web test passed.
25681 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 46332: Upgrade Checks Fail After New Host Is Added To Cluster

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46332/#review129361
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
 (line 766)


Would also accept Collections.singleton(), but thank you!


- Nate Cole


On April 18, 2016, 10:13 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46332/
> ---
> 
> (Updated April 18, 2016, 10:13 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-15942
> https://issues.apache.org/jira/browse/AMBARI-15942
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by newly added hosts not having an ID and an internal map not being 
> updated correctly.
> 
> - Deploy 2.4.0.0 cluster with Ambari 222 (secure, non-HA cluster)
> - Add a new host to the cluster. The newly added host has following 
> components: DataNode, SmartSense HST Agent, Kerberos Client, Metrics Monitor
> - Register 2.4.2.0-221 version and install the bits
> - Start EU  or RU
> 
> ```
> 18 Apr 2016 05:21:37,172 ERROR [qtp-ambari-client-613] CheckHelper:120 - 
> Check SERVICES_UP failed
> org.apache.ambari.server.HostNotFoundException: Host not found, hostname=Host 
> Id = 51
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.getHostById(ClustersImpl.java:404)
>   at 
> org.apache.ambari.server.checks.ServicesUpCheck.isConsideredDown(ServicesUpCheck.java:208)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> 59dcaf8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  dcbf5a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 186590e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  b563268 
> 
> Diff: https://reviews.apache.org/r/46332/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/
---

(Updated April 18, 2016, 10:39 a.m.)


Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and Sid 
Wagle.


Changes
---

Use suspend start option (-y or --suspend-start) if specified for debugging.


Bugs: AMBARI-15814
https://issues.apache.org/jira/browse/AMBARI-15814


Repository: ambari


Description
---

AMBARI-15814: Enable debugging of ambari-server upgrade command

** Issue **:
Right now **ambari-server upgrade** cannot be debugged remotely. To enable 
remote debugging, handle the -g/--debug flag the same way **ambari-server start 
-g** works.

** Fix **:
Create a debug command line for JVM to execute, the same way as ambari-server 
start -g works.


Diffs (updated)
-

  ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 

Diff: https://reviews.apache.org/r/46137/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.946s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Web  SUCCESS [39.154s]
[INFO] Ambari Views .. SUCCESS [1.073s]
[INFO] Ambari Admin View . SUCCESS [8.779s]
[INFO] ambari-metrics  SUCCESS [0.356s]
[INFO] Ambari Metrics Common . SUCCESS [0.467s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.190s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.633s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.645s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.640s]
[INFO] Ambari Metrics Collector .. SUCCESS [6.663s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.831s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.896s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:18.645s]
[INFO] Ambari Server . SUCCESS [2:49.890s]
[INFO] Ambari Functional Tests ... SUCCESS [2.347s]
[INFO] Ambari Agent .. SUCCESS [24.663s]
[INFO] Ambari Client . SUCCESS [0.045s]
[INFO] Ambari Python Client .. SUCCESS [0.983s]
[INFO] Ambari Groovy Client .. SUCCESS [2.203s]
[INFO] Ambari Shell .. SUCCESS [0.041s]
[INFO] Ambari Python Shell ... SUCCESS [0.720s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.966s]
[INFO] ambari-logsearch .. SUCCESS [0.288s]
[INFO] Ambari Logsearch Portal ... SUCCESS [8.111s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.025s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.216s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.089s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:07.410s
[INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016
[INFO] Final Memory: 281M/1155M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 260 tests in 6.521s

OK
--
Total run:963
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 52.557s
[INFO] Finished at: Mon Apr 18 10:03:46 PDT 2016
[INFO] Final Memory: 56M/1024M
[INFO] 


** 3. Manual testing **

Ran *ambari-server upgrade -g* and verified that intelliJ debugger could be 
attached to the remote process.


Thanks,

Nahappan Somasundaram

Re: Review Request 46337: Upgrading Ambari should delete any pyc files

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46337/#review129379
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 18, 2016, 5:35 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46337/
> ---
> 
> (Updated April 18, 2016, 5:35 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15947
> https://issues.apache.org/jira/browse/AMBARI-15947
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A python file owned by ambari agent had a swp file open during the ambari 
> agent upgrade. For that reason, the pyc file never got recreated, which led 
> to seeing the bug again for that Jira even though the source code was correct.
> 
> Upgrading ambari agent or server should always delete any pyc files in
> /var/lib/ambari-agent
> /var/lib/ambari-server
> /usr/lib/python2.6/site-packages/ambari-agent
> /usr/lib/python2.6/site-packages/ambari-server
> /usr/lib/python2.6/site-packages/ambari-commons
> /usr/lib/python2.7/site-packages/ambari-agent
> /usr/lib/python2.7/site-packages/ambari-server
> /usr/lib/python2.7/site-packages/ambari-commons
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/install-helper.sh 2495080 
>   ambari-server/conf/unix/install-helper.sh 25a10d6 
> 
> Diff: https://reviews.apache.org/r/46337/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
---

(Updated April 18, 2016, 4:47 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

- rewrite solr client to java (from groovy)
- added ZkClient (for future usage)
- bosco's issues still in progress


Bugs: AMBARI-15865
https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
---

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to 
access zookeeper/solr and create their own collections in logsearch solr. (e.g. 
for ATLAS or RANGER)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
---

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in 
org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo

Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/
---

Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and Sid 
Wagle.


Bugs: AMBARI-15814
https://issues.apache.org/jira/browse/AMBARI-15814


Repository: ambari


Description
---

AMBARI-15814: Enable debugging of ambari-server upgrade command

** Issue **:
Right now **ambari-server upgrade** cannot be debugged remotely. To enable 
remote debugging, handle the -g/--debug flag the same way **ambari-server start 
-g** works.

** Fix **:
Create a debug command line for JVM to execute, the same way as ambari-server 
start -g works.


Diffs
-

  ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 

Diff: https://reviews.apache.org/r/46137/diff/


Testing
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [7.946s]
[INFO] Apache Ambari Project POM . SUCCESS [0.036s]
[INFO] Ambari Web  SUCCESS [39.154s]
[INFO] Ambari Views .. SUCCESS [1.073s]
[INFO] Ambari Admin View . SUCCESS [8.779s]
[INFO] ambari-metrics  SUCCESS [0.356s]
[INFO] Ambari Metrics Common . SUCCESS [0.467s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.190s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.633s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.645s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [1.640s]
[INFO] Ambari Metrics Collector .. SUCCESS [6.663s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.831s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.896s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:18.645s]
[INFO] Ambari Server . SUCCESS [2:49.890s]
[INFO] Ambari Functional Tests ... SUCCESS [2.347s]
[INFO] Ambari Agent .. SUCCESS [24.663s]
[INFO] Ambari Client . SUCCESS [0.045s]
[INFO] Ambari Python Client .. SUCCESS [0.983s]
[INFO] Ambari Groovy Client .. SUCCESS [2.203s]
[INFO] Ambari Shell .. SUCCESS [0.041s]
[INFO] Ambari Python Shell ... SUCCESS [0.720s]
[INFO] Ambari Groovy Shell ... SUCCESS [0.966s]
[INFO] ambari-logsearch .. SUCCESS [0.288s]
[INFO] Ambari Logsearch Portal ... SUCCESS [8.111s]
[INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.025s]
[INFO] Ambari Logsearch Appender . SUCCESS [0.216s]
[INFO] Ambari Logsearch Assembly . SUCCESS [0.089s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 6:07.410s
[INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016
[INFO] Final Memory: 281M/1155M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 260 tests in 6.521s

OK
--
Total run:963
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 52.557s
[INFO] Finished at: Mon Apr 18 10:03:46 PDT 2016
[INFO] Final Memory: 56M/1024M
[INFO] 


** 3. Manual testing **

Ran *ambari-server upgrade -g* and verified that intelliJ debugger could be 
attached to the remote process.


Thanks,

Nahappan Somasundaram

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/#review129370
---




ambari-server/src/main/python/ambari_server/serverUpgrade.py (line 67)


Maybe suspend for 10 secs only if debug mode is on AND it's a schema 
upgrade.


- Alejandro Fernandez


On April 18, 2016, 5:14 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46137/
> ---
> 
> (Updated April 18, 2016, 5:14 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-15814
> https://issues.apache.org/jira/browse/AMBARI-15814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15814: Enable debugging of ambari-server upgrade command
> 
> ** Issue **:
> Right now **ambari-server upgrade** cannot be debugged remotely. To enable 
> remote debugging, handle the -g/--debug flag the same way **ambari-server 
> start -g** works.
> 
> ** Fix **:
> Create a debug command line for JVM to execute, the same way as ambari-server 
> start -g works.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 
> 
> Diff: https://reviews.apache.org/r/46137/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.946s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.036s]
> [INFO] Ambari Web  SUCCESS [39.154s]
> [INFO] Ambari Views .. SUCCESS [1.073s]
> [INFO] Ambari Admin View . SUCCESS [8.779s]
> [INFO] ambari-metrics  SUCCESS [0.356s]
> [INFO] Ambari Metrics Common . SUCCESS [0.467s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.190s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.633s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.645s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.640s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.663s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.831s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.896s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.645s]
> [INFO] Ambari Server . SUCCESS [2:49.890s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.347s]
> [INFO] Ambari Agent .. SUCCESS [24.663s]
> [INFO] Ambari Client . SUCCESS [0.045s]
> [INFO] Ambari Python Client .. SUCCESS [0.983s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.203s]
> [INFO] Ambari Shell .. SUCCESS [0.041s]
> [INFO] Ambari Python Shell ... SUCCESS [0.720s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.966s]
> [INFO] ambari-logsearch .. SUCCESS [0.288s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [8.111s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.025s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.216s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.089s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:07.410s
> [INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016
> [INFO] Final Memory: 281M/1155M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 260 tests in 6.521s
> 
> OK
> --
> Total run:963
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.557s
> [INFO] Finished at: Mon Apr 18 10:03:46 PDT 2016
> [INFO] Final Memory: 56M/1024M
> 

Review Request 46337: Upgrading Ambari should delete any pyc files

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46337/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15947
https://issues.apache.org/jira/browse/AMBARI-15947


Repository: ambari


Description
---

A python file owned by ambari agent had a swp file open during the ambari agent 
upgrade. For that reason, the pyc file never got recreated, which led to seeing 
the bug again for that Jira even though the source code was correct.

Upgrading ambari agent or server should always delete any pyc files in
/var/lib/ambari-agent
/var/lib/ambari-server
/usr/lib/python2.6/site-packages/ambari-agent
/usr/lib/python2.6/site-packages/ambari-server
/usr/lib/python2.6/site-packages/ambari-commons
/usr/lib/python2.7/site-packages/ambari-agent
/usr/lib/python2.7/site-packages/ambari-server
/usr/lib/python2.7/site-packages/ambari-commons


Diffs
-

  ambari-agent/conf/unix/install-helper.sh 2495080 
  ambari-server/conf/unix/install-helper.sh 25a10d6 

Diff: https://reviews.apache.org/r/46337/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 46137: AMBARI-15814: Enable debugging of ambari-server upgrade command

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46137/#review129382
---


Ship it!




Ship It!

- Sid Wagle


On April 18, 2016, 5:39 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46137/
> ---
> 
> (Updated April 18, 2016, 5:39 p.m.)
> 
> 
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Sumit Mohanty, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-15814
> https://issues.apache.org/jira/browse/AMBARI-15814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15814: Enable debugging of ambari-server upgrade command
> 
> ** Issue **:
> Right now **ambari-server upgrade** cannot be debugged remotely. To enable 
> remote debugging, handle the -g/--debug flag the same way **ambari-server 
> start -g** works.
> 
> ** Fix **:
> Create a debug command line for JVM to execute, the same way as ambari-server 
> start -g works.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/serverUpgrade.py 72c4185 
> 
> Diff: https://reviews.apache.org/r/46137/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [7.946s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.036s]
> [INFO] Ambari Web  SUCCESS [39.154s]
> [INFO] Ambari Views .. SUCCESS [1.073s]
> [INFO] Ambari Admin View . SUCCESS [8.779s]
> [INFO] ambari-metrics  SUCCESS [0.356s]
> [INFO] Ambari Metrics Common . SUCCESS [0.467s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.190s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.633s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.645s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.640s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.663s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.831s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.896s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.645s]
> [INFO] Ambari Server . SUCCESS [2:49.890s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.347s]
> [INFO] Ambari Agent .. SUCCESS [24.663s]
> [INFO] Ambari Client . SUCCESS [0.045s]
> [INFO] Ambari Python Client .. SUCCESS [0.983s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.203s]
> [INFO] Ambari Shell .. SUCCESS [0.041s]
> [INFO] Ambari Python Shell ... SUCCESS [0.720s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.966s]
> [INFO] ambari-logsearch .. SUCCESS [0.288s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [8.111s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [3.025s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.216s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.089s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 6:07.410s
> [INFO] Finished at: Mon Apr 18 10:12:38 PDT 2016
> [INFO] Final Memory: 281M/1155M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 260 tests in 6.521s
> 
> OK
> --
> Total run:963
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.557s
> [INFO] Finished at: Mon Apr 18 10:03:46 PDT 2016
> [INFO] Final Memory: 56M/1024M
> [INFO] 
> 
> 
> 
> ** 3. Manual testing **
> 
> Ran *ambari-server upgrade -g* and verified that intelliJ debugger could be 
> 

Re: Review Request 46338: AMBARI-15949 Tweaks to Alerts hyperlink display

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46338/#review129406
---


Ship it!




Ship It!

- Richard Zang


On April 18, 2016, 6:12 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46338/
> ---
> 
> (Updated April 18, 2016, 6:12 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-15949
> https://issues.apache.org/jira/browse/AMBARI-15949
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change the way the hyperlink to an external alert detail URL is shown.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/messages.js 8d73bb3 
>   ambari-web/app/templates/main/alerts/configs.hbs 4259be8 
>   ambari-web/app/templates/main/alerts/definition_details.hbs 15cf168 
> 
> Diff: https://reviews.apache.org/r/46338/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 25681 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 46345: HDFS /etc/hadoop/conf Points To Wrong Location After Adding Host

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46345/#review129421
---




ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 (lines 485 - 490)


Part of the problem; the component being installed is conf-select'd which 
creates the initial symlink of:

```
/etc/hadoop/conf -> /etc/hadoop/conf.backup
```

We need to ensure that even if we're skipping links that the links are to 
the correct places



ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 (lines 550 - 554)


At this point we're committed to creating a link so we need to make sure 
that whatever might be there is removed first (whether that's a link or 
directory)


- Jonathan Hurley


On April 18, 2016, 4:13 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46345/
> ---
> 
> (Updated April 18, 2016, 4:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-15950
> https://issues.apache.org/jira/browse/AMBARI-15950
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install cluster on HDP 2.3
> - Add a host with DataNode after cluster has been installed
> 
> For hosts part of the cluster creation:
> {code}
> [root@os-r6-orydgs-upg-sanity-211-5 /]# ls -la /etc/hadoop/
> total 24
> drwxr-xr-x.   4 root root  4096 Apr 18 04:49 .
> drwxr-xr-x. 114 root root 12288 Apr 18 10:53 ..
> drwxr-xr-x.   3 root root  4096 Apr 18 04:49 2.3.4.0-3485
> lrwxrwxrwx.   1 root root35 Apr 18 04:49 conf -> 
> /usr/hdp/current/hadoop-client/conf
> drwxr-xr-x.   2 root root  4096 Apr 18 04:49 conf.install
> {code}
> 
> For hosts was added after cluster creation:
> {code}
> [root@os-r6-orydgs-upg-sanity-211-2 ~]# ls -la /etc/hadoop
> total 16
> drwxr-xr-x.  4 root root 4096 Apr 18 09:34 .
> drwxr-xr-x. 80 root root 4096 Apr 18 09:35 ..
> drwxr-xr-x.  3 root root 4096 Apr 18 09:34 2.3.4.0-3485
> lrwxrwxrwx.  1 root root   23 Apr 18 09:34 conf -> /etc/hadoop/conf.backup
> drwxr-xr-x.  2 root root 4096 Apr 18 10:36 conf.backup
> {code}
> 
> This causes the {{/etc//conf}} folder to point indefinitely to the 
> {{/etc//conf.backup}}.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  7ce4a6f 
> 
> Diff: https://reviews.apache.org/r/46345/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46263: AMBARI-15906 Make Ranger TagSync to be installed as a slave and optional

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46263/#review129410
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 15, 2016, 6:51 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46263/
> ---
> 
> (Updated April 15, 2016, 6:51 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan 
> Hurley, Jayush Luniya, Mahadev Konar, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15906
> https://issues.apache.org/jira/browse/AMBARI-15906
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to support blueprints to setup cluster without TagSync, make stack 
> level changes to allow Ranger TagSync to be installed as a optional slave 
> component.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  4466671 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-tagsync-site.xml
>  cfcab3b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/metainfo.xml 
> 9f96308 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 7407da3 
> 
> Diff: https://reviews.apache.org/r/46263/diff/
> 
> 
> Testing
> ---
> 
> Tested on Centos 6 with and without RANGER_TAGSYNC.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 46272: AMBARI-15914 Ranger stack changes to remove audit to db config params

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46272/#review129411
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 15, 2016, 2:45 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46272/
> ---
> 
> (Updated April 15, 2016, 2:45 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan 
> Hurley, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15914
> https://issues.apache.org/jira/browse/AMBARI-15914
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In order to remove feature of Audit to DB in Ranger, need to remove Audit to 
> DB related configs from Ambari stacks.
> For fresh installs, audit to db configs should not be shown.
> 
> Upgrade scenario will be handle in AMBARI-15916.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  86dbc48 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  7201c36 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
>  c66a0e9 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  6949ced 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  03fd40c 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1.2.2/package/scripts/params.py
>  8d483dc 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
>  5c65a1e 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  c0ab3e8 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  fc722da 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
>  101ca46 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  5c37e4b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  03b7e01 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/configuration/ranger-hbase-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/ranger-hdfs-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/ranger-hive-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KAFKA/configuration/ranger-kafka-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/KNOX/configuration/ranger-knox-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-admin-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/ranger-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/ranger-kms-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/STORM/configuration/ranger-storm-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/ranger-yarn-audit.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46272/diff/
> 
> 
> Testing
> ---
> 
> Tested installation of Ranger on centos6 and checked audit to db properties 
> are not getting reflected under Ranger Configs and components supporting 
> Ranger plugin.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45713/
---

(Updated April 18, 2016, 11:48 a.m.)


Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, and 
Sid Wagle.


Changes
---

Updated results of unit tests.


Bugs: AMBARI-15700
https://issues.apache.org/jira/browse/AMBARI-15700


Repository: ambari


Description
---

AMBARI-15700: Stack advisor - Component layout recommendation needs support for 
avoiding hosts in maintenance mode

** Issue **
Stack advisor script should ignore hosts in maintenance mode when recommending 
or validating component layout

** Fix **
Modified the stack advisor scripts to handle the case when one or more hosts 
are in maintenance state while recommending or validating component layout
Added two test cases to validate the recommendation when one or more hosts are 
in maintenance state.


Diffs
-

  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
53591cdcaed05713013be1ba7295b1c2b3ed64af 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
0130483d3e1f08afe495fb30b6341f6f825f145d 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
b99c484b3e65de0c9186727064fc67a4bb1d8315 
  ambari-server/src/main/resources/stacks/stack_advisor.py 
636de01ad6fc72d9dc397b754aa5e190d4d9c5ff 
  ambari-server/src/test/python/TestStackAdvisor.py 
149ae1dc7ea2e596680321dd70030dcfe060f6cf 

Diff: https://reviews.apache.org/r/45713/diff/


Testing (updated)
---

** 1. mvn clean install **

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [8.744s]
[INFO] Apache Ambari Project POM . SUCCESS [0.041s]
[INFO] Ambari Web  SUCCESS [25.392s]
[INFO] Ambari Views .. SUCCESS [1.375s]
[INFO] Ambari Admin View . SUCCESS [11.669s]
[INFO] ambari-metrics  SUCCESS [0.375s]
[INFO] Ambari Metrics Common . SUCCESS [0.524s]
[INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.450s]
[INFO] Ambari Metrics Flume Sink . SUCCESS [0.662s]
[INFO] Ambari Metrics Kafka Sink . SUCCESS [0.685s]
[INFO] Ambari Metrics Storm Sink . SUCCESS [2.209s]
[INFO] Ambari Metrics Collector .. SUCCESS [7.115s]
[INFO] Ambari Metrics Monitor  SUCCESS [2.137s]
[INFO] Ambari Metrics Grafana  SUCCESS [0.980s]
[INFO] Ambari Metrics Assembly ... SUCCESS [1:18.948s]
[INFO] Ambari Server . SUCCESS [2:56.964s]
[INFO] Ambari Functional Tests ... SUCCESS [2.720s]
[INFO] Ambari Agent .. SUCCESS [24.955s]
[INFO] Ambari Client . SUCCESS [0.045s]
[INFO] Ambari Python Client .. SUCCESS [0.838s]
[INFO] Ambari Groovy Client .. SUCCESS [2.152s]
[INFO] Ambari Shell .. SUCCESS [0.054s]
[INFO] Ambari Python Shell ... SUCCESS [0.719s]
[INFO] Ambari Groovy Shell ... SUCCESS [1.118s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5:54.648s
[INFO] Finished at: Thu Apr 07 16:59:26 PDT 2016
[INFO] Final Memory: 261M/1301M
[INFO] 

** 2. mvn test -DskipSurefireTests **

--
Ran 253 tests in 6.689s

OK
--
Total run:944
Total errors:0
Total failures:0
OK

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 54.377s
[INFO] Finished at: Thu Apr 07 16:50:46 PDT 2016
[INFO] Final Memory: 56M/1003M
[INFO] 

** 3. mvn test -DskipPythonTests **

All tests passed.

** 4. Manual tests **

Deployed a cluster with 3 VMs and modified stack_advisor.py scripts on the host 
running ambari-server.

** Regression testing **
Tested the current behavior - all hosts are active.

** Hosts in maintenance mode **
Put 1 host in maintenance mode and verified that the 

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46294/#review129409
---


Ship it!




Ship It!

- bhuvnesh chaudhary


On April 16, 2016, 12:56 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46294/
> ---
> 
> (Updated April 16, 2016, 12:56 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15926
> https://issues.apache.org/jira/browse/AMBARI-15926
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activating standby could start a master with an old port, and the following 
> operations in the Activate Standby wizard could be mislead. 
> The fix is to stop the newly become master so that the wizard will only have 
> to deal with the current value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  e2114d8 
> 
> Diff: https://reviews.apache.org/r/46294/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed.
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46294/#review129408
---


Ship it!




Ship It!

- Matt


On April 15, 2016, 5:56 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46294/
> ---
> 
> (Updated April 15, 2016, 5:56 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15926
> https://issues.apache.org/jira/browse/AMBARI-15926
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activating standby could start a master with an old port, and the following 
> operations in the Activate Standby wizard could be mislead. 
> The fix is to stop the newly become master so that the wizard will only have 
> to deal with the current value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  e2114d8 
> 
> Diff: https://reviews.apache.org/r/46294/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed.
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Review Request 46345: HDFS /etc/hadoop/conf Points To Wrong Location After Adding Host

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46345/
---

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-15950
https://issues.apache.org/jira/browse/AMBARI-15950


Repository: ambari


Description
---

STR:

- Install cluster on HDP 2.3
- Add a host with DataNode after cluster has been installed

For hosts part of the cluster creation:
{code}
[root@os-r6-orydgs-upg-sanity-211-5 /]# ls -la /etc/hadoop/
total 24
drwxr-xr-x.   4 root root  4096 Apr 18 04:49 .
drwxr-xr-x. 114 root root 12288 Apr 18 10:53 ..
drwxr-xr-x.   3 root root  4096 Apr 18 04:49 2.3.4.0-3485
lrwxrwxrwx.   1 root root35 Apr 18 04:49 conf -> 
/usr/hdp/current/hadoop-client/conf
drwxr-xr-x.   2 root root  4096 Apr 18 04:49 conf.install
{code}

For hosts was added after cluster creation:
{code}
[root@os-r6-orydgs-upg-sanity-211-2 ~]# ls -la /etc/hadoop
total 16
drwxr-xr-x.  4 root root 4096 Apr 18 09:34 .
drwxr-xr-x. 80 root root 4096 Apr 18 09:35 ..
drwxr-xr-x.  3 root root 4096 Apr 18 09:34 2.3.4.0-3485
lrwxrwxrwx.  1 root root   23 Apr 18 09:34 conf -> /etc/hadoop/conf.backup
drwxr-xr-x.  2 root root 4096 Apr 18 10:36 conf.backup
{code}

This causes the {{/etc//conf}} folder to point indefinitely to the 
{{/etc//conf.backup}}.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 7ce4a6f 

Diff: https://reviews.apache.org/r/46345/diff/


Testing
---

mvn clean test


Thanks,

Jonathan Hurley

Re: Review Request 46310: Use exclude list in order to merge hive-interactve-site from hive-site. Both will show common props in their config bag.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46310/#review129405
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 (line 85)


I'm actually going to change this since we need to populate 2 dirs, hive 
conf and the conf.server subdir.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 497)


Ideally, we should be using
/etc/tez_hive2/$version/0
or
/usr/hdp/current//conf

to avoid any confusion of symlinks.


- Alejandro Fernandez


On April 18, 2016, 2:11 a.m., Sumit Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46310/
> ---
> 
> (Updated April 18, 2016, 2:11 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-15937
> https://issues.apache.org/jira/browse/AMBARI-15937
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Along with the changes, there are some clean-up and addition of basic unit 
> tests. Some more comments in the diff.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  7d913e5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9d05d37 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  03fd40c 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/hsi_default.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46310/diff/
> 
> 
> Testing
> ---
> 
> Ran unit tests manually, and tested by applying patch.
> 
> 
> Thanks,
> 
> Sumit Mohanty
> 
>

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review129420
---




ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 (line 103)


I just added a return value here if the code executed successfully, the 
real assert here is the verify, that checks how many times the "request" 
called. altough the test method name is not right, that is the 
CollectionDoesNotExist case not the CollectionExists


- Oliver Szabo


On April 18, 2016, 4:47 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> ---
> 
> (Updated April 18, 2016, 4:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
> Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
> https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to 
> access zookeeper/solr and create their own collections in logsearch solr. 
> (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
>  PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - 
> in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129418
---




ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 (line 280)


switch(String) may not be compatible with Java 7. Can we change to "if"?



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 (line 118)


Can we use specific static imports?



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 (line 57)


This config needs to go into the stack 
(ambari/ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml)
 for UI to pick it up. 

It should also go into the Upgrade path so that this config gets added to 
the service on Upgrade. Perhaps, we can use another JIRA to track that.


- Aravindan Vijayan


On April 18, 2016, 7:04 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 7:04 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Aravindan Vijayan]

> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java,
> >  line 57
> > 
> >
> > This config needs to go into the stack 
> > (ambari/ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml)
> >  for UI to pick it up. 
> > 
> > It should also go into the Upgrade path so that this config gets added 
> > to the service on Upgrade. Perhaps, we can use another JIRA to track that.

This issue is valid only if we need to control the TTL value of the container 
metrics table through Ambari.


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129418
---


On April 18, 2016, 7:04 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 7:04 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Jian He]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/
---

(Updated April 18, 2016, 10:20 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Repository: ambari


Description
---

BUG-55643 Add container metrics in AMS


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 28d3b9c 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 db8791f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 ab11333 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 e434d33 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 c0093a0 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
 2f08f3f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 0efa68f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
 d2526a0 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 f61d619 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
 61d6e71 

Diff: https://reviews.apache.org/r/46342/diff/


Testing
---

Did end-to-end testing on cluster, NM can publish the container metrics, and 
AMS will store that in phoenix


File Attachments (updated)


patch v2 - address comments
  
https://reviews.apache.org/media/uploaded/files/2016/04/18/aa152e6c-df4c-44cf-a28f-5caedf0d58cf__BUG-55643.2.patch


Thanks,

Jian He

Re: Review Request 46345: HDFS /etc/hadoop/conf Points To Wrong Location After Adding Host

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46345/#review129440
---


Ship it!




Ship It!

- Jayush Luniya


On April 18, 2016, 8:13 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46345/
> ---
> 
> (Updated April 18, 2016, 8:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-15950
> https://issues.apache.org/jira/browse/AMBARI-15950
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> - Install cluster on HDP 2.3
> - Add a host with DataNode after cluster has been installed
> 
> For hosts part of the cluster creation:
> {code}
> [root@os-r6-orydgs-upg-sanity-211-5 /]# ls -la /etc/hadoop/
> total 24
> drwxr-xr-x.   4 root root  4096 Apr 18 04:49 .
> drwxr-xr-x. 114 root root 12288 Apr 18 10:53 ..
> drwxr-xr-x.   3 root root  4096 Apr 18 04:49 2.3.4.0-3485
> lrwxrwxrwx.   1 root root35 Apr 18 04:49 conf -> 
> /usr/hdp/current/hadoop-client/conf
> drwxr-xr-x.   2 root root  4096 Apr 18 04:49 conf.install
> {code}
> 
> For hosts was added after cluster creation:
> {code}
> [root@os-r6-orydgs-upg-sanity-211-2 ~]# ls -la /etc/hadoop
> total 16
> drwxr-xr-x.  4 root root 4096 Apr 18 09:34 .
> drwxr-xr-x. 80 root root 4096 Apr 18 09:35 ..
> drwxr-xr-x.  3 root root 4096 Apr 18 09:34 2.3.4.0-3485
> lrwxrwxrwx.  1 root root   23 Apr 18 09:34 conf -> /etc/hadoop/conf.backup
> drwxr-xr-x.  2 root root 4096 Apr 18 10:36 conf.backup
> {code}
> 
> This causes the {{/etc//conf}} folder to point indefinitely to the 
> {{/etc//conf.backup}}.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
>  7ce4a6f 
> 
> Diff: https://reviews.apache.org/r/46345/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Jian He]

> On April 18, 2016, 8:19 p.m., Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java,
> >  line 280
> > 
> >
> > switch(String) may not be compatible with Java 7. Can we change to "if"?

https://docs.oracle.com/javase/8/docs/technotes/guides/language/strings-switch.html
  here it says it's ok to use switch in jdk 7


- Jian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129418
---


On April 18, 2016, 10:20 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 10:20 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> File Attachments
> 
> 
> patch v2 - address comments
>   
> https://reviews.apache.org/media/uploaded/files/2016/04/18/aa152e6c-df4c-44cf-a28f-5caedf0d58cf__BUG-55643.2.patch
> 
> 
> Thanks,
> 
> Jian He
> 
>

Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/
---

Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.


Bugs: AMBARI-15955
https://issues.apache.org/jira/browse/AMBARI-15955


Repository: ambari


Description
---

Hive Server Interactive should also create a conf.server folder (similar to 
Hive Server Batch), in order to distinguish the configs used by the server and 
client.

Further, when it starts the LLAP App on slider, it can specify which folder to 
unpack it it,
E.g., 
```
/usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
-slider-am-container-mb {size} --loglevel INFO --output {directory}
```


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 a2ee491 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 9cfd41f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
 8adff0a 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 9d011a0 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 33e8e47 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 92e67c7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 1205202 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 feca9f1 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ac4f6fc 

Diff: https://reviews.apache.org/r/46351/diff/


Testing
---

Verified on live cluster by installing Hive Server Interactive with LLAP, and 
then restarting HSI and LLAP.

Python unit tests passed.
--
Total run:966
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46355/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, and 
Sumit Mohanty.


Bugs: AMBARI-15953
https://issues.apache.org/jira/browse/AMBARI-15953


Repository: ambari


Description
---

The 'NameNode Last Checkpoint' alert description says "This service-level alert 
will trigger if the last time that the NameNode performed a checkpoint was too 
long ago. It will also trigger if the number of uncommitted transactions is 
beyond a certain threshold."

But the default alert definition seems to miss the threshold parameters for 
alerting the number of uncommitted transactions.


Diffs
-

  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
fc3e21f 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py
 71e34e6 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_checkpoint_time.py 
PRE-CREATION 

Diff: https://reviews.apache.org/r/46355/diff/


Testing
---

--
Ran 246 tests in 6.541s

OK
--
Total run:928
Total errors:0
Total failures:0
OK


Thanks,

Sid Wagle

Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46358/
---

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-15959
https://issues.apache.org/jira/browse/AMBARI-15959


Repository: ambari


Description
---

Incorporate 'llap status check' to be used for (1). Before Hive Server 
Interactive start, and (2). status call.

- Currently, code calls are commented as "hive --service llapstatus --name 
llap0" command is always showing app status as LAUNCHING. Following up with 
HIVE team.
- Further, changed hive.llap.daemon.service.hosts value to @llap0.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 9d011a0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 0b3de15 
  ambari-server/src/test/python/stacks/2.5/HIVE/appComplete.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/invalidApp.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown.json 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/running.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/starting.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ac4f6fc 

Diff: https://reviews.apache.org/r/46358/diff/


Testing
---

- UT added for this functionality tested.


Thanks,

Swapan Shridhar

Re: Review Request 46358: Incorporate 'llap status check' to be used for (1). Before Hive Server Interactive start, and (2). status call.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46358/
---

(Updated April 19, 2016, 1:42 a.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Uncommeted the code for calling "check_llap_app_status".
Updated UT.


Bugs: AMBARI-15959
https://issues.apache.org/jira/browse/AMBARI-15959


Repository: ambari


Description
---

Incorporate 'llap status check' to be used for (1). Before Hive Server 
Interactive start, and (2). status call.

- Currently, code calls are commented as "hive --service llapstatus --name 
llap0" command is always showing app status as LAUNCHING. Following up with 
HIVE team.
- Further, changed hive.llap.daemon.service.hosts value to @llap0.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 9d011a0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 0b3de15 
  ambari-server/src/test/python/stacks/2.5/HIVE/appComplete.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/invalidApp.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/oneContainerDown.json 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/running.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/starting.json PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py ac4f6fc 

Diff: https://reviews.apache.org/r/46358/diff/


Testing
---

- UT added for this functionality tested.


Thanks,

Swapan Shridhar

Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/#review129469
---


Ship it!




Ship It!

- Lav Jain


On April 19, 2016, 1:20 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46359/
> ---
> 
> (Updated April 19, 2016, 1:20 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-15960
> https://issues.apache.org/jira/browse/AMBARI-15960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error log from running the wizard:
> 
> 
> stderr: 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 98, in 
> HawqMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 219, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 69, in immediate_stop_hawq_service
> common.stop_component(hawq_constants.CLUSTER, hawq_constants.IMMEDIATE)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py",
>  line 309, in stop_component
> port_property_name = 
> hawq_constants.COMPONENT_ATTRIBUTES_MAP[component_name]['port_property']
> KeyError: 'cluster'
>  stdout:
> None
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  4ce0c94 
> 
> Diff: https://reviews.apache.org/r/46359/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Unit Tests passed.
> 
> 
> Thanks,
> 
> Matt
> 
>

Review Request 46359: HAWQ Immediate Stop cluster fails with key error

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/
---

Review request for Ambari.


Bugs: AMBARI-15960
https://issues.apache.org/jira/browse/AMBARI-15960


Repository: ambari


Description
---

Error log from running the wizard:


stderr: 
Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
 line 98, in 
HawqMaster().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 219, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
 line 69, in immediate_stop_hawq_service
common.stop_component(hawq_constants.CLUSTER, hawq_constants.IMMEDIATE)
  File 
"/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py",
 line 309, in stop_component
port_property_name = 
hawq_constants.COMPONENT_ATTRIBUTES_MAP[component_name]['port_property']
KeyError: 'cluster'
 stdout:
None


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
 4ce0c94 

Diff: https://reviews.apache.org/r/46359/diff/


Testing
---

Manually Tested. Unit Tests passed.


Thanks,

Matt

Review Request 46360: Atlas Integration :Use stack advisor to suggest correct integration related configs

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46360/
---

Review request for Ambari, John Speidel and Robert Levas.


Bugs: AMBARI-15939
https://issues.apache.org/jira/browse/AMBARI-15939


Repository: ambari


Description
---

Use the stack advisor to suggest the correct configs for the Atlas integrations 
if the Atlas service is installed.  

See AMBARI-14920.

Also, minor refactoring to move integration specific work into separate scripts.


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 46457ad 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 84d8b57 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/configuration/sqoop-site.xml
 dd299fe 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 7db974f 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/setup_atlas_sqoop.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
 1276a54 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/configuration/storm-site.xml
 cf702c0 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py
 101ca46 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/setup_atlas_storm.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py
 74050d8 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/FALCON/configuration/falcon-startup.properties.xml
 5d4fa1e 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
66076f2 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 6c9fd46 

Diff: https://reviews.apache.org/r/46360/diff/


Testing
---

Added unit tests for new stack advisor methods.

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 46342: AMBARI-15952 Add container metrics in AMS

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129462
---



Thank you for the patch Jian. You can go ahead and close the review.

- Aravindan Vijayan


On April 18, 2016, 11:24 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15952
> https://issues.apache.org/jira/browse/AMBARI-15952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/#review129465
---


Fix it, then Ship it!




Fix it and Ship It.


ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 


White spaces



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 (line 97)


White spaces


- Swapan Shridhar


On April 18, 2016, 11:24 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46351/
> ---
> 
> (Updated April 18, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15955
> https://issues.apache.org/jira/browse/AMBARI-15955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive should also create a conf.server folder (similar to 
> Hive Server Batch), in order to distinguish the configs used by the server 
> and client.
> 
> Further, when it starts the LLAP App on slider, it can specify which folder 
> to unpack it it,
> E.g., 
> ```
> /usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> -slider-am-container-mb {size} --loglevel INFO --output {directory}
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2ee491 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9cfd41f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  33e8e47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  92e67c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1205202 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  feca9f1 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
> 
> Diff: https://reviews.apache.org/r/46351/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster by installing Hive Server Interactive with LLAP, and 
> then restarting HSI and LLAP.
> 
> Python unit tests passed.
> --
> Total run:966
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

[Balázs Bence Sári]

> On April 15, 2016, 1:52 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184
> > 
> >
> > Let's be consistent.  Either:
> > pk_sc_desired_state
> > fk_scds_...
> > unq_scdesired...
> > 
> > or
> > PK_sc_desired
> > FK_scds...
> > UNQ_scdesired...
> > 
> > I seem recall issues of case between the sql files and UpgradeCatalog* 
> > classes.  Jonathan?
> 
> Jonathan Hurley wrote:
> I'm all for consistency. You're right that we used to have problems with 
> the case of the contraints. For PK's, we added some utility methods which 
> don't require us to know the name anymore:
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java#L569-L581
> 
> We could do something similar for FKs as well.
> 
> Balázs Bence Sári wrote:
> I've got a couple of questions:
> - The method in DBAccessor only works with 3 databases. Can we rely on 
> that?
> - I just learned that the name of the constraints are important during 
> upgrade. So I guess I'd need to revert any constraint renamings I've done and 
> only name constraints that had been unnamed so far. (pls. confirm)
> - Existing constraints are mostly in PK_the_rest_is_lowecase format, but 
> some are in all lowercase format (also unique is sometimes noted as UQ and 
> sometimes UNQ). I always used the PK/FK/UQ_the_rest_is_lowercase format 
> because that seemed to be the most frequent. Are you ok to follow that 
> convenions? (Also, what should happen with existing all-lowercase 
> constraints? Would renaming them break upgrade scripts?)
> 
> Nate Cole wrote:
> I don't mind the PK/FK/UNQ_lower_name syntax myself, it's easy to 
> visually see "type" from "name" if you will.  These scripts are create-only, 
> so changing them shouldn't break existing deployments.  The concern is if 
> you've added new constraints, then yes, those need to be reflected in 
> UpgradeCatalog, but otherwise it seems safe.

I haven't introduced any new constraints, only renamed existing ones.
I am still a bit worried about renaming existing constraints (even naming 
unnamed ones). While these scripts are create only, there will still be 
inconsistency between fresh 2.4 installs and old installs upgraded to 2.4. It 
won't be an issue right away, but it can become one when we will upgrade to the 
next version after 2.4, unless we are 100% sure that after 2.4 upgrade catalogs 
will never drop any constraint by name (e.g. by using Jonathan's new API 
extended to all kinds of constraints).


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46269/#review129114
---


On April 15, 2016, 1:41 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46269/
> ---
> 
> (Updated April 15, 2016, 1:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Robie, Nate Cole, and Nahappan 
> Somasundaram.
> 
> 
> Bugs: AMBARI-15915
> https://issues.apache.org/jira/browse/AMBARI-15915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Inlined alter table statements (except one to overcome a circular FK 
> dependency)
> 2. Reorganized create table statemens to avoid forward references
> 3. Named all unnamed constraints, shortened names to fit Oracle's 30 
> character limit
> 4. Unified constraint names across database flavors
> 5. Wrote a JUnit test that checks DDL's for consistency (all constraints are 
> named, the same tables and constraints are defined for all database flavors)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f90ac96 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2b214c4 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql fc93372 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 870a8e8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 71d4813 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6e600c7 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql a3ea10d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTestUtils.java 
> PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46269/diff/
> 
> 
> Testing
> ---
> 
> 1. Run all java unit tests in ambari-server. All passed, except 
> ViewDirectoryWatcherTest.testDirectoryExtractionOnFileAdd(). Failure occured 
> to a hardcoded 

Review Request 46317: Basic authentication for Logsearch service

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46317/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-15884
https://issues.apache.org/jira/browse/AMBARI-15884


Repository: ambari


Description
---

Basic authentication fog logsearch:
Admin user generated from a json file, the password is encoded after the 
logsearch service starts


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 8352d7c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 9289ceb 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/user_pass.json.j2
 PRE-CREATION 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 46517f0 
  ambari-server/src/test/python/stacks/2.4/configs/default.json e03d25f 

Diff: https://reviews.apache.org/r/46317/diff/


Testing
---

Total run:963
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/
---

Review request for Ambari, John Speidel and Sumit Mohanty.


Bugs: AMBARI-15791
https://issues.apache.org/jira/browse/AMBARI-15791


Repository: ambari


Description
---

Blueprint config processing engine should automatically populate 
dfs.internal.nameservices when it is deploying HA clusters. The work-around 
till then is to explicitly add the property when submitting the blueprint.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 1433a1b 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 4f2f02d 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 834953b 

Diff: https://reviews.apache.org/r/46327/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 46317: Basic authentication for Logsearch service

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46317/#review129324
---


Ship it!




Ship It!

- Robert Nettleton


On April 18, 2016, 10:17 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46317/
> ---
> 
> (Updated April 18, 2016, 10:17 a.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15884
> https://issues.apache.org/jira/browse/AMBARI-15884
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Basic authentication fog logsearch:
> Admin user generated from a json file, the password is encoded after the 
> logsearch service starts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-admin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  8352d7c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  9289ceb 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/user_pass.json.j2
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 
> 46517f0 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json e03d25f 
> 
> Diff: https://reviews.apache.org/r/46317/diff/
> 
> 
> Testing
> ---
> 
> Total run:963
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129331
---



Could we get some more background context as to why this change is necessary?  
I've checked the associated Apache JIRA, and there isn't much information there.

In particular, can the submitter please explain why this internal property 
needs to be added, especially considering that the HDFS documentation seems to 
indicate that the public and internal forms of this property should generally 
have the same value? 

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 (line 858)


Why is this internal property being checked here?  

The update change above seems to indicate that these properties should 
always be set to the same values.  If that is the case, then why is this method 
being modified?



ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 (line 193)


+1 on Sumit's comment.  This change does not appear necessary.



ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 (line 4900)


I'm not certain that the tests using the public property should be 
modified.  I'd recommend adding new unit tests to verify that the internal 
property being added here is handled properly.


- Robert Nettleton


On April 18, 2016, 1:07 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated April 18, 2016, 1:07 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  4f2f02d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45924/#review129326
---



Generally for trunk we don't separate tests into different jira.  Any 
particular reason for that?  For feature branches it's ok because those don't 
go through automated testing.

- Nate Cole


On April 18, 2016, 12:22 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45924/
> ---
> 
> (Updated April 18, 2016, 12:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15681
> https://issues.apache.org/jira/browse/AMBARI-15681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement**
> 
> Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot 
> be updated from Ambari. This forces the users to directly edit the 
> configuration file.
> 
> **Proposed Solution**
> Exposing log4j configurations for individual compomnents to Ambari as a 
> properties file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  86dbc48 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  7201c36 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  c0ab3e8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9544ee8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  03b7e01 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45924/diff/
> 
> 
> Testing
> ---
> 
> Verifed Ranger Admin and usersync log files being created based on configs 
> given in log4j.properties block from Ambari UI.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129329
---


Ship it!




Ship It!

- Sumit Mohanty


On April 18, 2016, 1:07 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated April 18, 2016, 1:07 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  4f2f02d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129328
---




ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
 (line 193)


This change should not be needed. Existence of dfs.nameservices should be 
enough.


- Sumit Mohanty


On April 18, 2016, 1:07 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated April 18, 2016, 1:07 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
>  4f2f02d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Dmytro Sen]

> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote:
> > Could we get some more background context as to why this change is 
> > necessary?  I've checked the associated Apache JIRA, and there isn't much 
> > information there.
> > 
> > In particular, can the submitter please explain why this internal property 
> > needs to be added, especially considering that the HDFS documentation seems 
> > to indicate that the public and internal forms of this property should 
> > generally have the same value? 
> > 
> > Thanks.

HDFS-6376 allows distcp to copy data between HA clusters. Users can use a new 
configuration property "dfs.internal.nameservices" to explicitly specify the 
name services belonging to the local cluster, while continue using the 
configuration property "dfs.nameservices" to specify all the name services in 
the local and remote clusters.

All ambari users have single namesevice value in "dfs.nameservices" on existing 
clusters, that's the name service belonging to the local cluster. After upgrade 
to 2.4.0 or restoring ambari cluster from a blueprint created from any older 
version, we add "dfs.internal.nameservices" pointing to the local cluster and 
allow user to add to "dfs.nameservices" any external name services.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129331
---


On Апрель 18, 2016, 1:39 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated Апрель 18, 2016, 1:39 п.п.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Dmytro Sen]

> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java,
> >  line 858
> > 
> >
> > Why is this internal property being checked here?  
> > 
> > The update change above seems to indicate that these properties should 
> > always be set to the same values.  If that is the case, then why is this 
> > method being modified?

We only add "dfs.internal.nameservices" if it's not specified in user's 
blueprint and always rely on "dfs.internal.nameservices" instead of 
"dfs.nameservices". "dfs.nameservices" might contain external name services, 
not managed by Ambari
if (clusterTopology.isNameNodeHAEnabled()) {

  // add "dfs.internal.nameservices" if it's not specified
  Map hdfsSiteConfig = 
clusterConfig.getFullProperties().get("hdfs-site");
  String nameservices = hdfsSiteConfig.get("dfs.nameservices");
  String int_nameservices = hdfsSiteConfig.get("dfs.internal.nameservices");
  if(int_nameservices == null && nameservices != null) {
clusterConfig.setProperty("hdfs-site", "dfs.internal.nameservices", 
nameservices);
  }


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129331
---


On Апрель 18, 2016, 1:39 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated Апрель 18, 2016, 1:39 п.п.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Dmytro Sen]

> On Апрель 18, 2016, 1:39 п.п., Robert Nettleton wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java,
> >  line 4900
> > 
> >
> > I'm not certain that the tests using the public property should be 
> > modified.  I'd recommend adding new unit tests to verify that the internal 
> > property being added here is handled properly.

We rely on "dfs.internal.nameservices" in 2.4.0, "dfs.nameservices" might 
contain name services, not managed by Ambari.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129331
---


On Апрель 18, 2016, 1:39 п.п., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated Апрель 18, 2016, 1:39 п.п.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Review Request 46334: DB version checker failure: Command line switch --skip-database-validation is broken

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46334/
---

Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Bugs: AMBARI-15944
https://issues.apache.org/jira/browse/AMBARI-15944


Repository: ambari


Description
---

we should not skip DB version check. So please exclude it from 
--skip-database-validation in run() and fix the error message which instructs 
the user to use --skip-database-validation.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 0e45f79 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java
 3a3ef9a 

Diff: https://reviews.apache.org/r/46334/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 46294: HAWQ activate standby wizard fails after port number change but before restart.

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46294/#review129412
---


Ship it!




Ship It!

- Alexander Denissov


On April 16, 2016, 12:56 a.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46294/
> ---
> 
> (Updated April 16, 2016, 12:56 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-15926
> https://issues.apache.org/jira/browse/AMBARI-15926
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Activating standby could start a master with an old port, and the following 
> operations in the Activate Standby wizard could be mislead. 
> The fix is to stop the newly become master so that the wizard will only have 
> to deal with the current value.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  e2114d8 
> 
> Diff: https://reviews.apache.org/r/46294/diff/
> 
> 
> Testing
> ---
> 
> Unit test passed.
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Don Bosco Durai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review129415
---




ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 (line 49)


might be good to put the path at the end, e.g. 
host1:port,host2:port,host3:port,.../ambari_solr



ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 (line 95)


short form for retryOption and intervalOption seems to be the same



ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
 (line 52)


Show we move the sleep in the else condition?



ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 (line 103)


Not sure why we are testing result with "collection1".


- Don Bosco Durai


On April 18, 2016, 4:47 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> ---
> 
> (Updated April 18, 2016, 4:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
> Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
> https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to 
> access zookeeper/solr and create their own collections in logsearch solr. 
> (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh 
> PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
>  PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> ---
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - 
> in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129425
---




ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 (line 354)


This Exception is dangerous to be thrown from the Sink is not handled by 
the caller. We should be logging the exceotion and moving on.


- Sid Wagle


On April 18, 2016, 7:04 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 7:04 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Review Request 46363: Kerberos wizard stuck trying to schedule service check operation

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46363/
---

Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, Sumit 
Mohanty, Srimanth Gunturi, and Sid Wagle.


Bugs: AMBARI-15961
https://issues.apache.org/jira/browse/AMBARI-15961


Repository: ambari


Description
---

Attached jstack after firing up the curl call.

```
curl -u admin:admin -H "X-Requested-By:ambari" -i -X POST 
-d'{"RequestInfo":{"context":"Kerberos Service 
Check","command":"KERBEROS_SERVICE_CHECK","operation_level":{"level":"CLUSTER","cluster_name":"c1"}},"Requests/resource_filters":[{"service_name":"KERBEROS"}]}'
 http://104.196.89.51:8080/api/v1/clusters/c1/requests
```

Behavior:
- Call timedout on the UI and wizard cannot proceed further.
- Exception in the server log after long wait:
```
12 Apr 2016 23:01:45,231  INFO [qtp-ambari-client-818] 
AmbariManagementControllerImpl:3376 - Received action execution request, 
clusterName=c1, request=isCommand :true, action :null, command 
:KERBEROS_SERVICE_CHECK, inputs :{}, resourceFilters: 
[RequestResourceFilter{serviceName='KERBEROS', componentName='null', 
hostNames=[]}], exclusive: false, clusterName :c1
12 Apr 2016 23:01:45,409  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: HIVE
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: AMBARI_METRICS
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: HDFS
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: MAPREDUCE2
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: OOZIE
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: TEZ
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: HBASE
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: ZOOKEEPER
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: KERBEROS
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: YARN
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: PIG
12 Apr 2016 23:03:49,984  WARN [qtp-ambari-client-818] 
MITKerberosOperationHandler:434 - Failed to execute kadmin:
Command: /usr/bin/kadmin -s perf-b-3.c.pramod-thangali.internal -p 
admin -w  -r EXAMPLE.COM -q "get_principal admin"
ExitCode: 1
STDOUT: Authenticating as principal admin with password.

STDERR: kadmin: Client not found in Kerberos database while 
initializing kadmin interface
```


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 737b0aa 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
 a1e1544 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 55e046e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
 93daae8 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosMissingAdminCredentialsException.java
 ddb2769 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
 e3d31de 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosPrincipalAlreadyExistsException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosPrincipalDoesNotExistException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
 90858fb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
 34de6a8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 eefaf04 

Diff: https://reviews.apache.org/r/46363/diff/


Testing
---

Manually tested in large cluster against MIT KDC and small cluster against 
Active Directory

# 

Review Request 46353: AMBARI-15957: Ambari functional tests: Support auto start for service components

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46353/
---

Review request for Ambari, Ajit Kumar, Sumit Mohanty, and Sid Wagle.


Repository: ambari


Description
---

AMBARI-15957: Ambari functional tests: Support auto start for service components

** Issue **
Add *recovery_enabled* parameter to SetServiceComponentStateWebRequest


Diffs
-

  
ambari-funtest/src/test/java/org/apache/ambari/funtest/server/api/servicecomponent/SetServiceComponentStateWebRequest.java
 f74fceaed1c189e92fec339456a52f71bb418d06 

Diff: https://reviews.apache.org/r/46353/diff/


Testing
---

** 1. mvn clean install **

[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 47 licence.
[INFO]
[INFO] --- maven-jar-plugin:2.3.2:jar (default-jar) @ ambari-funtest ---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO] Building jar: 
/Users/nsomasundaram/ambari/ambari-funtest/target/ambari-funtest-2.0.0.0-SNAPSHOT.jar
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ 
ambari-funtest ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-assembly-plugin:2.2-beta-5:single (build-tarball) @ 
ambari-funtest ---
[INFO] Reading assembly descriptor: src/main/assemblies/empty.xml
[INFO]
[INFO] --- maven-failsafe-plugin:2.19.1:verify (run-verify) @ ambari-funtest ---
[INFO] Tests are skipped.
[INFO]
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
ambari-funtest ---
[INFO] Installing 
/Users/nsomasundaram/ambari/ambari-funtest/target/ambari-funtest-2.0.0.0-SNAPSHOT.jar
 to 
/Users/nsomasundaram/.m2/repository/org/apache/ambari/ambari-funtest/2.0.0.0-SNAPSHOT/ambari-funtest-2.0.0.0-SNAPSHOT.jar
[INFO] Installing /Users/nsomasundaram/ambari/ambari-funtest/pom.xml to 
/Users/nsomasundaram/.m2/repository/org/apache/ambari/ambari-funtest/2.0.0.0-SNAPSHOT/ambari-funtest-2.0.0.0-SNAPSHOT.pom
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 5.157s
[INFO] Finished at: Mon Apr 18 20:48:57 PDT 2016
[INFO] Final Memory: 38M/451M
[INFO] 

** 2. mvn verify **

---
 T E S T S
---
Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m -Djava.awt.headless=true

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 3.586s
[INFO] Finished at: Mon Apr 18 21:00:27 PDT 2016
[INFO] Final Memory: 22M/314M
[INFO] 


Thanks,

Nahappan Somasundaram

Re: Review Request 46172: Pass request object to delete API in resource providers

[Jayush Luniya]

> On April 15, 2016, 12:10 a.m., Jayush Luniya wrote:
> > Ship It!

@Ajit, can you close this review?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46172/#review129039
---


On April 14, 2016, 4:04 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46172/
> ---
> 
> (Updated April 14, 2016, 4:04 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15888
> https://issues.apache.org/jira/browse/AMBARI-15888
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently delete API on resource provider only takes predicate. Ideally it 
> should take request object as well which has additional metadata. It will be 
> required in scenarios like dry-run where it can look at request object to 
> figure out if current invocation is for dry run or not and behave accordingly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/persistence/PersistenceManagerImpl.java
>  3037446 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/gsinstaller/GSInstallerResourceProvider.java
>  d403114 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
>  0837a5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  faef86c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  10eecac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  bcf0205 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  dafd194 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
>  f52ee62 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
>  f19bea9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  3b749d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ArtifactResourceProvider.java
>  34952f2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  a4b2aaa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  3e4d7fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterControllerImpl.java
>  e776b5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  51c0db9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  a85f939 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  6236ac2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  2677ec7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
>  f9d12b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
>  8a3937a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
>  5087049 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  0d215ae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  39a09a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
>  322eab8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
>  b3f353c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/InstanceResourceProvider.java
>  49f968f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/JobResourceProvider.java
>  c732842 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/KerberosDescriptorResourceProvider.java
>  3cece5d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProvider.java
>  3d18a27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/MemberResourceProvider.java
>  307ed3f 
>   
> 

Re: Review Request 46169: Add dryrun method on request object

[Jayush Luniya]

> On April 15, 2016, 12:05 a.m., Jayush Luniya wrote:
> > Ship It!

@Ajit, can you close this review?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/#review129037
---


On April 14, 2016, 2:30 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46169/
> ---
> 
> (Updated April 14, 2016, 2:30 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15870
> https://issues.apache.org/jira/browse/AMBARI-15870
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> To implement dry-run version of an API, request needs to be parsed manually 
> to figure out if request has dry-run directive.
> It will be good to add a method on Request object method itself which 
> centralizes parsing and logic for figuring out dry-run directive
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
>  12b91e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
>  f27f621 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
>  f8f8290 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
>  50eed9a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
>  93fe36f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  ea4afde 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  633815e 
> 
> Diff: https://reviews.apache.org/r/46169/diff/
> 
> 
> Testing
> ---
> 
> Hadoop QA commented on AMBARI-15870:
> 
> 
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment
>   http://issues.apache.org/jira/secure/attachment/12798670/rb46169.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 3 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied patch does not increase the 
> total number of javac compiler warnings.
> 
> {color:green}+1 release audit{color}.  The applied patch does not 
> increase the total number of release audit warnings.
> 
> {color:green}+1 core tests{color}.  The patch passed unit tests in 
> ambari-server.
> 
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6435//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6435//console
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 46363: Kerberos wizard stuck trying to schedule service check operation

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46363/
---

(Updated April 18, 2016, 11:12 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, Sumit 
Mohanty, Srimanth Gunturi, and Sid Wagle.


Bugs: AMBARI-15961
https://issues.apache.org/jira/browse/AMBARI-15961


Repository: ambari


Description (updated)
---

Attached jstack after firing up the curl call.

```
curl -u admin:admin -H "X-Requested-By:ambari" -i -X POST 
-d'{"RequestInfo":{"context":"Kerberos Service 
Check","command":"KERBEROS_SERVICE_CHECK","operation_level":{"level":"CLUSTER","cluster_name":"c1"}},"Requests/resource_filters":[{"service_name":"KERBEROS"}]}'
 http://104.196.89.51:8080/api/v1/clusters/c1/requests
```

Behavior:
- Call timedout on the UI and wizard cannot proceed further.
- Exception in the server log after long wait:
```
12 Apr 2016 23:01:45,231  INFO [qtp-ambari-client-818] 
AmbariManagementControllerImpl:3376 - Received action execution request, 
clusterName=c1, request=isCommand :true, action :null, command 
:KERBEROS_SERVICE_CHECK, inputs :{}, resourceFilters: 
[RequestResourceFilter{serviceName='KERBEROS', componentName='null', 
hostNames=[]}], exclusive: false, clusterName :c1
12 Apr 2016 23:01:45,409  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: HIVE
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: AMBARI_METRICS
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: HDFS
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: MAPREDUCE2
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: OOZIE
12 Apr 2016 23:01:45,410  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: TEZ
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: HBASE
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: ZOOKEEPER
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: KERBEROS
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: YARN
12 Apr 2016 23:01:45,411  INFO [qtp-ambari-client-818] 
AmbariCustomCommandExecutionHelper:1135 - Iterating service type Instance in 
getCommandJson:: PIG
12 Apr 2016 23:03:49,984  WARN [qtp-ambari-client-818] 
MITKerberosOperationHandler:434 - Failed to execute kadmin:
Command: /usr/bin/kadmin -s perf-b-3.c.pramod-thangali.internal -p 
admin -w  -r EXAMPLE.COM -q "get_principal admin"
ExitCode: 1
STDOUT: Authenticating as principal admin with password.

STDERR: kadmin: Client not found in Kerberos database while 
initializing kadmin interface
```

# Solution
- Optimize preparation logic to create principal for Kerberos Service Check
- Optimize logic to create principals in MIT KDC to reduce the time in the 
Create Principal stage by about 30%


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 737b0aa 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
 a1e1544 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 55e046e 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
 93daae8 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosMissingAdminCredentialsException.java
 ddb2769 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
 e3d31de 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosPrincipalAlreadyExistsException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosPrincipalDoesNotExistException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
 90858fb 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
 34de6a8 
  

Re: Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46355/#review129475
---



Do you need to also set these new values on upgrade? I see that you put 
defaults in, but the thresholds will never show in existing configurations.

- Jonathan Hurley


On April 18, 2016, 8:26 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46355/
> ---
> 
> (Updated April 18, 2016, 8:26 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15953
> https://issues.apache.org/jira/browse/AMBARI-15953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The 'NameNode Last Checkpoint' alert description says "This service-level 
> alert will trigger if the last time that the NameNode performed a checkpoint 
> was too long ago. It will also trigger if the number of uncommitted 
> transactions is beyond a certain threshold."
> 
> But the default alert definition seems to miss the threshold parameters for 
> alerting the number of uncommitted transactions.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
> fc3e21f 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py
>  71e34e6 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_checkpoint_time.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46355/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 246 tests in 6.541s
> 
> OK
> --
> Total run:928
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 46355: NameNode Last Checkpoint script alert definition does not trigger based on uncommitted transactions

[Sid Wagle]

> On April 19, 2016, 3:13 a.m., Jonathan Hurley wrote:
> > Do you need to also set these new values on upgrade? I see that you put 
> > defaults in, but the thresholds will never show in existing configurations.

Ahh dank missed upgrade, thanks for the reminder, will post updates tomorrow.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46355/#review129475
---


On April 19, 2016, 12:26 a.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46355/
> ---
> 
> (Updated April 19, 2016, 12:26 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Jonathan Hurley, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15953
> https://issues.apache.org/jira/browse/AMBARI-15953
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The 'NameNode Last Checkpoint' alert description says "This service-level 
> alert will trigger if the last time that the NameNode performed a checkpoint 
> was too long ago. It will also trigger if the number of uncommitted 
> transactions is beyond a certain threshold."
> 
> But the default alert definition seems to miss the threshold parameters for 
> alerting the number of uncommitted transactions.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/alerts.json 
> fc3e21f 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_checkpoint_time.py
>  71e34e6 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_checkpoint_time.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46355/diff/
> 
> 
> Testing
> ---
> 
> --
> Ran 246 tests in 6.541s
> 
> OK
> --
> Total run:928
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 46359: HAWQ Immediate Stop cluster fails with key error

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46359/#review129485
---


Ship it!




Ship It!

- Alexander Denissov


On April 19, 2016, 1:20 a.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46359/
> ---
> 
> (Updated April 19, 2016, 1:20 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-15960
> https://issues.apache.org/jira/browse/AMBARI-15960
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Error log from running the wizard:
> 
> 
> stderr: 
> Traceback (most recent call last):
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 98, in 
> HawqMaster().execute()
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
>  line 219, in execute
> method(env)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/hawqmaster.py",
>  line 69, in immediate_stop_hawq_service
> common.stop_component(hawq_constants.CLUSTER, hawq_constants.IMMEDIATE)
>   File 
> "/var/lib/ambari-agent/cache/common-services/HAWQ/2.0.0/package/scripts/common.py",
>  line 309, in stop_component
> port_property_name = 
> hawq_constants.COMPONENT_ATTRIBUTES_MAP[component_name]['port_property']
> KeyError: 'cluster'
>  stdout:
> None
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawq_constants.py
>  4ce0c94 
> 
> Diff: https://reviews.apache.org/r/46359/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested. Unit Tests passed.
> 
> 
> Thanks,
> 
> Matt
> 
>

Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
---

(Updated April 18, 2016, 10:01 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert 
Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

- added router/maxShardsPerNode options
- fixed issues


Bugs: AMBARI-15865
https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
---

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to 
access zookeeper/solr and create their own collections in logsearch solr. (e.g. 
for ATLAS or RANGER)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java
 PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh 
PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java
 PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
---

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in 
org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129445
---


Ship it!




Ship It!

- Sid Wagle


On April 18, 2016, 10:24 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Jian He]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/
---

(Updated April 18, 2016, 10:24 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.


Repository: ambari


Description
---

BUG-55643 Add container metrics in AMS


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 28d3b9c 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 db8791f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 ab11333 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 e434d33 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 c0093a0 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
 2f08f3f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
 0efa68f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
 d2526a0 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 f61d619 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
 61d6e71 

Diff: https://reviews.apache.org/r/46342/diff/


Testing
---

Did end-to-end testing on cluster, NM can publish the container metrics, and 
AMS will store that in phoenix


Thanks,

Jian He

Re: Review Request 46351: Hive Server Interactive to also write configs to conf.server and specify folder to unpack LLAP Slider app

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46351/#review129447
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 (line 390)


Generalized this since canbe used by both Hive Server Batch and Interactive.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 204)


Unpack using a unique directory name.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 (line 312)


This allows generating the conf.server dir with the configs inside of it.



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
 (line 114)


Write server configs to correct folder.


- Alejandro Fernandez


On April 18, 2016, 11:24 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46351/
> ---
> 
> (Updated April 18, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15955
> https://issues.apache.org/jira/browse/AMBARI-15955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive Server Interactive should also create a conf.server folder (similar to 
> Hive Server Batch), in order to distinguish the configs used by the server 
> and client.
> 
> Further, when it starts the LLAP App on slider, it can specify which folder 
> to unpack it it,
> E.g., 
> ```
> /usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 
> -slider-am-container-mb {size} --loglevel INFO --output {directory}
> ```
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  a2ee491 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  9cfd41f 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py
>  8adff0a 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  9d011a0 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  33e8e47 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  92e67c7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  1205202 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/status_params.py
>  feca9f1 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> ac4f6fc 
> 
> Diff: https://reviews.apache.org/r/46351/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster by installing Hive Server Interactive with LLAP, and 
> then restarting HSI and LLAP.
> 
> Python unit tests passed.
> --
> Total run:966
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46352/#review129449
---


Ship it!




Ship It!

- Yusaku Sako


On April 18, 2016, 11:48 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46352/
> ---
> 
> (Updated April 18, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15956
> https://issues.apache.org/jira/browse/AMBARI-15956
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add quick links to the hs2 interactive UI on Ambari
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  ba46f00 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
> fcd05a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
>  PRE-CREATION 
>   ambari-web/app/models/quicklinks/quick_links_config.js d7d98e2 
>   ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 5c686a8 
>   ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 83d49b1 
>   ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs b6f1087 
>   
> ambari-web/app/templates/main/service/info/metrics/hive/hive_quick_links.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/main/service/item.hbs bc7f05f 
>   ambari-web/app/views/common/quick_view_link_view.js 3a99d7a 
>   ambari-web/test/views/common/quick_link_view_test.js 2b1c08f 
> 
> Diff: https://reviews.apache.org/r/46352/diff/
> 
> 
> Testing
> ---
> 
> #Manually tested the patch to work.
> 
> #verfied that all ambari-web unit tests passes:
> 
>   25675 tests complete (26 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 46342: BUG-55643 Add container metrics in AMS

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129444
---


Ship it!




Looks good to me.

- Aravindan Vijayan


On April 18, 2016, 10:24 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Review Request 46352: Add quick links to the hs2 interactive UI on Ambari

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46352/
---

Review request for Ambari, Srimanth Gunturi and Yusaku Sako.


Bugs: AMBARI-15956
https://issues.apache.org/jira/browse/AMBARI-15956


Repository: ambari


Description
---

Add quick links to the hs2 interactive UI on Ambari


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 ba46f00 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/metainfo.xml 
fcd05a4 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/quicklinks/quicklinks.json
 PRE-CREATION 
  ambari-web/app/models/quicklinks/quick_links_config.js d7d98e2 
  ambari-web/app/templates/main/dashboard/widgets/hbase_links.hbs 5c686a8 
  ambari-web/app/templates/main/dashboard/widgets/hdfs_links.hbs 83d49b1 
  ambari-web/app/templates/main/dashboard/widgets/yarn_links.hbs b6f1087 
  ambari-web/app/templates/main/service/info/metrics/hive/hive_quick_links.hbs 
PRE-CREATION 
  ambari-web/app/templates/main/service/item.hbs bc7f05f 
  ambari-web/app/views/common/quick_view_link_view.js 3a99d7a 
  ambari-web/test/views/common/quick_link_view_test.js 2b1c08f 

Diff: https://reviews.apache.org/r/46352/diff/


Testing
---

#Manually tested the patch to work.

#verfied that all ambari-web unit tests passes:

  25675 tests complete (26 seconds)
  154 tests pending


Thanks,

Jaimin Jetly

Re: Review Request 46342: AMBARI-15952 Add container metrics in AMS

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46342/#review129448
---


Ship it!




Ship It!

- Aravindan Vijayan


On April 18, 2016, 11:24 p.m., Jian He wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46342/
> ---
> 
> (Updated April 18, 2016, 11:24 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-15952
> https://issues.apache.org/jira/browse/AMBARI-15952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> BUG-55643 Add container metrics in AMS
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  28d3b9c 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/ContainerMetric.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  db8791f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  ab11333 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  e434d33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  c0093a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
>  2f08f3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
>  0efa68f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
>  d2526a0 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  f61d619 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java
>  61d6e71 
> 
> Diff: https://reviews.apache.org/r/46342/diff/
> 
> 
> Testing
> ---
> 
> Did end-to-end testing on cluster, NM can publish the container metrics, and 
> AMS will store that in phoenix
> 
> 
> Thanks,
> 
> Jian He
> 
>

Re: Review Request 46269: SQL constraints: Inline constraints and name them in CREATE table

[Balázs Bence Sári]

> On April 15, 2016, 1:52 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, lines 181-184
> > 
> >
> > Let's be consistent.  Either:
> > pk_sc_desired_state
> > fk_scds_...
> > unq_scdesired...
> > 
> > or
> > PK_sc_desired
> > FK_scds...
> > UNQ_scdesired...
> > 
> > I seem recall issues of case between the sql files and UpgradeCatalog* 
> > classes.  Jonathan?
> 
> Jonathan Hurley wrote:
> I'm all for consistency. You're right that we used to have problems with 
> the case of the contraints. For PK's, we added some utility methods which 
> don't require us to know the name anymore:
> 
> https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/orm/DBAccessor.java#L569-L581
> 
> We could do something similar for FKs as well.
> 
> Balázs Bence Sári wrote:
> I've got a couple of questions:
> - The method in DBAccessor only works with 3 databases. Can we rely on 
> that?
> - I just learned that the name of the constraints are important during 
> upgrade. So I guess I'd need to revert any constraint renamings I've done and 
> only name constraints that had been unnamed so far. (pls. confirm)
> - Existing constraints are mostly in PK_the_rest_is_lowecase format, but 
> some are in all lowercase format (also unique is sometimes noted as UQ and 
> sometimes UNQ). I always used the PK/FK/UQ_the_rest_is_lowercase format 
> because that seemed to be the most frequent. Are you ok to follow that 
> convenions? (Also, what should happen with existing all-lowercase 
> constraints? Would renaming them break upgrade scripts?)
> 
> Nate Cole wrote:
> I don't mind the PK/FK/UNQ_lower_name syntax myself, it's easy to 
> visually see "type" from "name" if you will.  These scripts are create-only, 
> so changing them shouldn't break existing deployments.  The concern is if 
> you've added new constraints, then yes, those need to be reflected in 
> UpgradeCatalog, but otherwise it seems safe.
> 
> Balázs Bence Sári wrote:
> I haven't introduced any new constraints, only renamed existing ones.
> I am still a bit worried about renaming existing constraints (even naming 
> unnamed ones). While these scripts are create only, there will still be 
> inconsistency between fresh 2.4 installs and old installs upgraded to 2.4. It 
> won't be an issue right away, but it can become one when we will upgrade to 
> the next version after 2.4, unless we are 100% sure that after 2.4 upgrade 
> catalogs will never drop any constraint by name (e.g. by using Jonathan's new 
> API extended to all kinds of constraints).

Discussed with Jonathan: this Jira will only address the issues in the headline 
(inline constraints and name PK's). All other issues will be addressed in 
separare Jira's.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46269/#review129114
---


On April 15, 2016, 1:41 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46269/
> ---
> 
> (Updated April 15, 2016, 1:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Robie, Nate Cole, and Nahappan 
> Somasundaram.
> 
> 
> Bugs: AMBARI-15915
> https://issues.apache.org/jira/browse/AMBARI-15915
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Inlined alter table statements (except one to overcome a circular FK 
> dependency)
> 2. Reorganized create table statemens to avoid forward references
> 3. Named all unnamed constraints, shortened names to fit Oracle's 30 
> character limit
> 4. Unified constraint names across database flavors
> 5. Wrote a JUnit test that checks DDL's for consistency (all constraints are 
> named, the same tables and constraints are defined for all database flavors)
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql f90ac96 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 2b214c4 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql fc93372 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 870a8e8 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 71d4813 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 6e600c7 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql a3ea10d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTestUtils.java 
> PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 
> PRE-CREATION 
> 
> Diff: 

Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45713/#review129352
---


Ship it!




Ship It!

- Sumit Mohanty


On April 11, 2016, 5:36 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45713/
> ---
> 
> (Updated April 11, 2016, 5:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-15700
> https://issues.apache.org/jira/browse/AMBARI-15700
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-15700: Stack advisor - Component layout recommendation needs support 
> for avoiding hosts in maintenance mode
> 
> ** Issue **
> Stack advisor script should ignore hosts in maintenance mode when 
> recommending or validating component layout
> 
> ** Fix **
> Modified the stack advisor scripts to handle the case when one or more hosts 
> are in maintenance state while recommending or validating component layout
> Added two test cases to validate the recommendation when one or more hosts 
> are in maintenance state.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 
> 53591cdcaed05713013be1ba7295b1c2b3ed64af 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> 0130483d3e1f08afe495fb30b6341f6f825f145d 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 
> b99c484b3e65de0c9186727064fc67a4bb1d8315 
>   ambari-server/src/main/resources/stacks/stack_advisor.py 
> 636de01ad6fc72d9dc397b754aa5e190d4d9c5ff 
>   ambari-server/src/test/python/TestStackAdvisor.py 
> 149ae1dc7ea2e596680321dd70030dcfe060f6cf 
> 
> Diff: https://reviews.apache.org/r/45713/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [8.744s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.041s]
> [INFO] Ambari Web  SUCCESS [25.392s]
> [INFO] Ambari Views .. SUCCESS [1.375s]
> [INFO] Ambari Admin View . SUCCESS [11.669s]
> [INFO] ambari-metrics  SUCCESS [0.375s]
> [INFO] Ambari Metrics Common . SUCCESS [0.524s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.450s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.662s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.685s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [2.209s]
> [INFO] Ambari Metrics Collector .. SUCCESS [7.115s]
> [INFO] Ambari Metrics Monitor  SUCCESS [2.137s]
> [INFO] Ambari Metrics Grafana  SUCCESS [0.980s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.948s]
> [INFO] Ambari Server . SUCCESS [2:56.964s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.720s]
> [INFO] Ambari Agent .. SUCCESS [24.955s]
> [INFO] Ambari Client . SUCCESS [0.045s]
> [INFO] Ambari Python Client .. SUCCESS [0.838s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.152s]
> [INFO] Ambari Shell .. SUCCESS [0.054s]
> [INFO] Ambari Python Shell ... SUCCESS [0.719s]
> [INFO] Ambari Groovy Shell ... SUCCESS [1.118s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 5:54.648s
> [INFO] Finished at: Thu Apr 07 16:59:26 PDT 2016
> [INFO] Final Memory: 261M/1301M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Ran 253 tests in 6.689s
> 
> OK
> --
> Total run:944
> Total errors:0
> Total failures:0
> OK
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 

Re: Review Request 46327: Blueprint based installations should automatically add dfs.internal.nameservices during cluster creation

[Robert Nettleton]

> On April 18, 2016, 1:39 p.m., Robert Nettleton wrote:
> > Could we get some more background context as to why this change is 
> > necessary?  I've checked the associated Apache JIRA, and there isn't much 
> > information there.
> > 
> > In particular, can the submitter please explain why this internal property 
> > needs to be added, especially considering that the HDFS documentation seems 
> > to indicate that the public and internal forms of this property should 
> > generally have the same value? 
> > 
> > Thanks.
> 
> Dmytro Sen wrote:
> HDFS-6376 allows distcp to copy data between HA clusters. Users can use a 
> new configuration property "dfs.internal.nameservices" to explicitly specify 
> the name services belonging to the local cluster, while continue using the 
> configuration property "dfs.nameservices" to specify all the name services in 
> the local and remote clusters.
> 
> All ambari users have single namesevice value in "dfs.nameservices" on 
> existing clusters, that's the name service belonging to the local cluster. 
> After upgrade to 2.4.0 or restoring ambari cluster from a blueprint created 
> from any older version, we add "dfs.internal.nameservices" pointing to the 
> local cluster and allow user to add to "dfs.nameservices" any external name 
> services.

Ok, thanks for the clarification.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46327/#review129331
---


On April 18, 2016, 1:39 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46327/
> ---
> 
> (Updated April 18, 2016, 1:39 p.m.)
> 
> 
> Review request for Ambari, John Speidel and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15791
> https://issues.apache.org/jira/browse/AMBARI-15791
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Blueprint config processing engine should automatically populate 
> dfs.internal.nameservices when it is deploying HA clusters. The work-around 
> till then is to explicitly add the property when submitting the blueprint.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1433a1b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  834953b 
> 
> Diff: https://reviews.apache.org/r/46327/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 46332: Upgrade Checks Fail After New Host Is Added To Cluster

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46332/#review129342
---


Ship it!




Ship It!

- Robert Levas


On April 18, 2016, 10:13 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46332/
> ---
> 
> (Updated April 18, 2016, 10:13 a.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-15942
> https://issues.apache.org/jira/browse/AMBARI-15942
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Caused by newly added hosts not having an ID and an internal map not being 
> updated correctly.
> 
> - Deploy 2.4.0.0 cluster with Ambari 222 (secure, non-HA cluster)
> - Add a new host to the cluster. The newly added host has following 
> components: DataNode, SmartSense HST Agent, Kerberos Client, Metrics Monitor
> - Register 2.4.2.0-221 version and install the bits
> - Start EU  or RU
> 
> ```
> 18 Apr 2016 05:21:37,172 ERROR [qtp-ambari-client-613] CheckHelper:120 - 
> Check SERVICES_UP failed
> org.apache.ambari.server.HostNotFoundException: Host not found, hostname=Host 
> Id = 51
>   at 
> org.apache.ambari.server.state.cluster.ClustersImpl.getHostById(ClustersImpl.java:404)
>   at 
> org.apache.ambari.server.checks.ServicesUpCheck.isConsideredDown(ServicesUpCheck.java:208)
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> 59dcaf8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  dcbf5a5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java 
> 186590e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersTest.java
>  b563268 
> 
> Diff: https://reviews.apache.org/r/46332/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 46196: Logsearch: reading config values from external property files

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46196/#review129297
---


Ship it!




Ship It!

- Jayush Luniya


On April 15, 2016, 4:03 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46196/
> ---
> 
> (Updated April 15, 2016, 4:03 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15842
> https://issues.apache.org/jira/browse/AMBARI-15842
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Reading config values (like xml files or *.sh scripts) from external property 
> files.
> 
> I did not added xml support for reading external property files. Reason is 
> because these xml files are jinja templates. So they can act as text files.
> 
> also added: Solr Instance renamed to LogSearch Solr Instance
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java
>  84842e2 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/XmlUtils.java 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
>  94ed27d 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
>  91fc0ce 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
>  4da16b1 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  ef6bebf 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
>  6741f41 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
>  60363c8 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
>  855f0e5 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
>  e99cb81 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
>  d31d0b3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 018398f 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/audit_logs-solrconfig.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-log4j.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-solr-env.sh.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/service_logs-solrconfig.xml.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr-log4j.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/solr.xml.j2
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46196/diff/
> 
> 
> Testing
> ---
> 
> Total run:959
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>