Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Daniel Gergely
> On jún. 9, 2016, 4:05 du, Daniel Gergely wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 343 > > > > > > Please consider cyclomati

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136973 --- Ship it! Ship It! - Dmytro Sen On Июнь 10, 2016, полночь, Ar

Review Request 48532: AMBARI-17157 Storm 1.0 log4j config update

2016-06-09 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48532/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Jungtaek Lim
> On 6 9, 2016, 5:42 오후, Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks > > Jungtaek Lim wrote: > Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen. > > Aravindan Vijayan wrote: > dsen I just found it. His name is registered as 'Dmytro Sen' so I

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
> On June 9, 2016, 5:42 p.m., Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks > > Jungtaek Lim wrote: > Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen. dsen - Aravindan --- This is an auto

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Jungtaek Lim
> On 6 9, 2016, 5:42 오후, Aravindan Vijayan wrote: > > Please add Dmitry Sen as well. Thanks Could you tell what's Dmitry's ID? Auto-complete can't find Dmitry Sen. - Jungtaek --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread enis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136941 --- Ship it! Ship It! - enis On June 10, 2016, midnight, Aravind

Re: Review Request 48526: AMBARI-17156: Ambari Agent: TestActionQueue and TestRecoveryManager python unit tests failures

2016-06-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48526/#review136939 --- Ship it! Ship It! - Sumit Mohanty On June 10, 2016, 12:13 a.

Review Request 48526: AMBARI-17156: Ambari Agent: TestActionQueue and TestRecoveryManager python unit tests failures

2016-06-09 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48526/ --- Review request for Ambari, Aravindan Vijayan and Sumit Mohanty. Bugs: AMBARI-17

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/ --- (Updated June 10, 2016, midnight) Review request for Ambari, Dmytro Sen and Sum

Review Request 48523: AMBARI-17145 Unformatted configs remain in zeppelin-env.sh

2016-06-09 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48523/ --- Review request for Ambari, Andrew Onischuk, Jayush Luniya, Pallav Kulshreshtha,

Re: Review Request 48413: Fix misnamed Zookeeper connect strings in Log Search

2016-06-09 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/ --- (Updated June 9, 2016, 11:04 p.m.) Review request for Ambari, Oliver Szabo, Rob

Re: Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

2016-06-09 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48516/ --- (Updated June 9, 2016, 11 p.m.) Review request for Ambari, Jonathan Hurley, Nat

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread enis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136919 --- ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apach

Re: Review Request 48517: AMBARI-17154 - Typo in SmartSense Warning Dialog

2016-06-09 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48517/#review136917 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 10:24 p.

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47673/#review136915 --- Pushed to trunk, commit 9b116fb28db774bb30a2d0c8e2f070e3b7c6d55d b

Review Request 48517: AMBARI-17154 - Typo in SmartSense Warning Dialog

2016-06-09 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48517/ --- Review request for Ambari and Zhe (Joe) Wang. Bugs: AMBARI-17154 https://is

Re: Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/#review136904 --- Ship it! Ship It! - Sumit Mohanty On June 9, 2016, 8:40 p.m.

Review Request 48516: SPNEGO keytab and principal configuration for HBase web UIs

2016-06-09 Thread Josh Elser
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48516/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas. Bugs:

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Juanjo Marron
> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote: > > Ship It! > > Juanjo Marron wrote: > I dont have privileges to commit. Could someone deliver it to trunk so I > can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as > complete, please? > Thanks > > Jayush

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48501/#review136899 --- Ship it! Ship It! - Andrew Onischuk On June 9, 2016, 6:56 p.

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Oliver Szabo
> On June 9, 2016, 9:06 p.m., Andrew Onischuk wrote: > > Doesn't this require changes we talked about. For logfeeder to read ambari > > logs? no its a different one. - Oliver --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48501/#review136892 --- Doesn't this require changes we talked about. For logfeeder to rea

Review Request 48508: AMBARI-17149 : HadoopTimelineMetricsSink from AMS prevents HBase RS process shutdown

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48508/ --- Review request for Ambari, Dmytro Sen and Sumit Mohanty. Bugs: AMBARI-17149

Re: Review Request 48506: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48506/#review136887 --- Ship it! Ship It! - Alejandro Fernandez On June 9, 2016, 8:0

Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark2

2016-06-09 Thread Weiqing Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/ --- (Updated June 9, 2016, 8:11 p.m.) Review request for Ambari, Zhe (Joe) Wang, Su

Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark

2016-06-09 Thread Weiqing Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/ --- (Updated June 9, 2016, 8:09 p.m.) Review request for Ambari, Zhe (Joe) Wang, Su

Review Request 48506: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as it w

2016-06-09 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48506/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-

Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark

2016-06-09 Thread Weiqing Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/ --- Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Srimanth Gunturi.

Re: Review Request 47673: Wrong memory conf in spark-env.xml

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47673/#review136884 --- Ship it! Ship It! - Alejandro Fernandez On June 3, 2016, 11:

Re: Review Request 48489: Atlas Integration : Required changes for atlas-application.properties

2016-06-09 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48489/ --- (Updated June 9, 2016, 7:30 p.m.) Review request for Ambari, John Speidel and R

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48501/#review136872 --- Ship it! Ship It! - Miklos Gergely On June 9, 2016, 6:56 p.m

Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48501/ --- Review request for Ambari, Andrew Onischuk, Miklos Gergely, Sumit Mohanty, and S

Re: Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48498/#review136870 --- Ship it! Ship It! - Jonathan Hurley On June 9, 2016, 12:49 p

Re: Review Request 48486: AMBARI-17136: If Solr is down or not ready, then LogFeeder to should retry

2016-06-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48486/#review136868 --- Ship it! Ship It! - Oliver Szabo On June 9, 2016, 10:47 a.m.

Re: Review Request 48485: AMBARI-17044 Optimize LogSearch Solr for cache setting and default values

2016-06-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48485/#review136866 --- ambari-logsearch/ambari-logsearch-portal/src/main/configsets/hado

Re: Review Request 48413: Fix misnamed Zookeeper connect strings

2016-06-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48413/#review136865 --- Ship it! Ship It! - Oliver Szabo On June 8, 2016, 2:14 p.m.,

Re: Review Request 48454: AMBARI-17103. Incorporating the inheritance logic for "tez_hive2/tez-site.xml" using tez/tez-site.xml. Also, removing 'hive.tez.java.opts' config from hive2/hive-site.xml as

2016-06-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48454/#review136860 --- Ship it! Ship It! - Alejandro Fernandez On June 9, 2016, 4:2

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review136855 --- Please add Dmitry Sen as well. Thanks - Aravindan Vijayan On Ju

Re: Review Request 48456: AMBARI-17134 - Add support flag for user type 'JWT'

2016-06-09 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48456/#review136850 --- Ship it! Ship It! - Zhe (Joe) Wang On June 9, 2016, 1:49 a.m

Re: Review Request 48065: AMBARI-16949 Metrics Collector API shows NPE if we use wildcard (%25 for '%') for metric name

2016-06-09 Thread Aravindan Vijayan
> On June 7, 2016, 3:07 p.m., Aravindan Vijayan wrote: > > Has this been checked in? If you need help doing that, I can do that for > > you. > > Jungtaek Lim wrote: > No it's not checked in yet. Please check this in. Thanks! Thank you Jungtaek. Patch has been committed. Please close the re

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Jayush Luniya
> On June 7, 2016, 6:45 p.m., Alejandro Fernandez wrote: > > Ship It! > > Juanjo Marron wrote: > I dont have privileges to commit. Could someone deliver it to trunk so I > can mark the JIRA https://issues.apache.org/jira/browse/AMBARI-16101 as > complete, please? > Thanks Will commit

Re: Review Request 48184: clean up import * for SPARK2 service scripts in common-services

2016-06-09 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48184/#review136845 --- Ship it! Ship It! - Jayush Luniya On June 7, 2016, 4:09 p.m.

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136841 --- This patch has been committed. Please close this review. - Aravin

Re: Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48498/#review136835 --- ambari-agent/src/main/python/ambari_agent/NetUtil.py (line 64)

Review Request 48498: Duplicate key in database exception during version registration

2016-06-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48498/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
> On Июнь 9, 2016, 4:26 п.п., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 343 > > > > > > Maybe we should think

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review136833 --- Please add Yusaku Sako and Prajwal Rao to the reviewers for the UI

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review136832 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
> On Июнь 9, 2016, 4:05 п.п., Daniel Gergely wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java, > > line 343 > > > > > > Please consider cycloma

Re: Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/#review136823 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin

2016-06-09 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48273/ --- (Updated June 9, 2016, 4:03 p.m.) Review request for Ambari, Alejandro Fernande

Review Request 48494: Implement config values trimming for deployment via blueprint

2016-06-09 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48494/ --- Review request for Ambari, Robert Nettleton, Sebastian Toader, and Vitalyi Brode

Re: Review Request 48489: Atlas Integration : Required changes for atlas-application.properties

2016-06-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48489/#review136812 --- Fix it, then Ship it! Ship It! ambari-server/src/main/resourc

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Sumit Mohanty
> On June 8, 2016, 7:21 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java, > > line 98 > > > > > > So I had thought that we decided to make these optional (

Re: Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48436/ --- (Updated June 9, 2016, 10:07 a.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48403/#review136808 --- Ship it! Ship It! - Nate Cole On June 9, 2016, 9:12 a.m., Dm

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/#review136799 --- ambari-server/src/main/java/org/apache/ambari/server/agent/Heartb

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48403/#review136805 --- Ship it! Ship It! - Andrew Onischuk On June 9, 2016, 1:12 p.

Re: Review Request 48440: Cluster operator and ServiceAdministrator able to enable/disable/edit alert definitions

2016-06-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48440/#review136804 --- Ship it! Ship It! - Robert Levas On June 8, 2016, 2:51 p.m.,

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48403/ --- (Updated June 9, 2016, 4:12 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 9, 2016, 12:54 du) Review request for Ambari, Laszlo Puskas, Oliv

Re: Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-09 Thread Jonathan Hurley
> On June 9, 2016, 8:47 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/StaleAlertRunnable.java, > > lines 76-81 > > > > > > Should this be a parameter of the alert definition?

Review Request 48490: Last button in the log search pagination panel does not take the user to the last page and few more fixes

2016-06-09 Thread Dharmesh Makwana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48490/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Don Bosco Durai

Re: Review Request 48436: Ambari Stale Alert Triggers For Server-Side Performance Alert

2016-06-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48436/#review136800 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 48460: Ambari Views logs should include information of view instance

2016-06-09 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48460/ --- (Updated June 9, 2016, 12:38 p.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Review Request 48489: Atlas Integration : Required changes for atlas-application.properties

2016-06-09 Thread Tom Beerbower
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48489/ --- Review request for Ambari, John Speidel and Robert Levas. Bugs: AMBARI-17144

Re: Review Request 48330: Hive View : Error in persisting JobImpl while submitting Hive Job

2016-06-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48330/#review136797 --- Ship it! Ship It! - Gaurav Nagar On June 7, 2016, 9:35 a.m.,

Re: Review Request 48319: Hive View : Upload Table : Support for Date and Timestamp type detection according to hive specs

2016-06-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48319/#review136796 --- Ship it! Ship It! - Gaurav Nagar On June 7, 2016, 7:26 a.m.,

Re: Review Request 48330: Hive View : Error in persisting JobImpl while submitting Hive Job

2016-06-09 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48330/#review136795 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 7, 2016, 9:35 a

Re: Review Request 48266: Add explicit ambari-server log line indicating cluster creation complete

2016-06-09 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48266/ --- (Updated jún. 9, 2016, 12:12 du) Review request for Ambari, Laszlo Puskas, Oliv

Re: Review Request 48319: Hive View : Upload Table : Support for Date and Timestamp type detection according to hive specs

2016-06-09 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48319/#review136794 --- Ship it! Ship It! - DIPAYAN BHOWMICK On June 7, 2016, 7:26 a

Re: Review Request 48460: Ambari Views logs should include information of view instance

2016-06-09 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48460/#review136793 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation

2016-06-09 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath S

Re: Review Request 48334: takeover_config_merge.py should provide XML, yaml, properties-diff capability

2016-06-09 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48334/#review136788 --- Ship it! Ship It! - Vitalyi Brodetskyi On Червень 9, 2016, 1

Review Request 48486: AMBARI-17136: If Solr is down or not ready, then LogFeeder to should retry

2016-06-09 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48486/ --- Review request for Ambari, Oliver Szabo and Sumit Mohanty. Bugs: AMBARI-17136

Re: Review Request 48480: View Config- views created for 2nd remote cluster points to 1st remote cluster

2016-06-09 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48480/#review136783 --- Ship it! Ship It! - Nitiraj Rathore On June 9, 2016, 8:43 a.

Review Request 48485: AMBARI-17044 Optimize LogSearch Solr for cache setting and default values

2016-06-09 Thread Don Bosco Durai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48485/ --- Review request for Ambari, Oliver Szabo and Sumit Mohanty. Bugs: AMBARI-17044

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > > > > > Why do we run logsearch components as ro

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > > > > > Why do we run logsearch components as ro

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > > > > > Why do we run logsearch components as ro

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > > > > > Why do we run logsearch components as ro

Review Request 48480: View Config- views created for 2nd remote cluster points to 1st remote cluster

2016-06-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48480/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshth

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > > > > > Why do we run logsearch components as ro

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48348/#review136775 --- ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Sriharsha Chintalapani
> On June 7, 2016, 6:07 a.m., Sid Wagle wrote: > > Changes look good, only thing to consider is the changes to the metric > > name. Cluster Aggregation will not occur at topology level since appId = > > topologyName for metrics with the same metric name. Is the metric name to > > fine grained?

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-06-09 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48030/#review136767 --- Ship it! Ship It! - Sriharsha Chintalapani On June 9, 2016,