Re: Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52500/#review151291
---


Ship it!




Ship It!

- Sumit Mohanty


On Oct. 4, 2016, 3:14 a.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52500/
> ---
> 
> (Updated Oct. 4, 2016, 3:14 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Robert Levas, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18520
> https://issues.apache.org/jira/browse/AMBARI-18520
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-18520: Ambari usernames should not be converted to lowercase before 
> storing in the DB.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f058d4270bedf8b10f68311232488d26a7ea 
> 
> Diff: https://reviews.apache.org/r/52500/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn test -DskipPythonTests 
> -Dtest=SecurityHelperImplTest,User*Test,UpgradeCatalog240Test **
> 
> Results :
> 
> Tests run: 95, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 58.913s
> [INFO] Finished at: Mon Oct 03 20:03:48 PDT 2016
> [INFO] Final Memory: 57M/866M
> [INFO] 
> 
> 
> ** 2. Manual tests **
> 
> Set up a one node cluster with the latest build from trunk and replaced 
> ambari-server JAR with the one from the local build.
> 1. Create a user ABCD. Was able to create the user successfully.
> 2. Create a user abcd. Unable to create the user.
> 3. curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
> http://localhost:8080/api/v1/users/abcd
> 
> {
>   "href" : "http://localhost:8080/api/v1/users/abcd;,
>   "Users" : {
> "active" : true,
> "admin" : false,
> "groups" : [ ],
> "ldap_user" : false,
> "user_name" : "abcd",
> "user_type" : "LOCAL"
>   },
>   "privileges" : [ ],
>   "widget_layouts" : [ ]
> }
> 
> curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
> http://localhost:8080/api/v1/users/ABCD
> 
> {
>   "href" : "http://localhost:8080/api/v1/users/ABCD;,
>   "Users" : {
> "active" : true,
> "admin" : false,
> "groups" : [ ],
> "ldap_user" : false,
> "user_name" : "abcd",
> "user_type" : "LOCAL"
>   },
>   "privileges" : [ ],
>   "widget_layouts" : [ ]
> }
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Re: Review Request 52455: Ambari UI changes to support PAM authentication

[Sangeeta Ravindran]

> On Oct. 3, 2016, 2:34 p.m., Alexandr Antonenko wrote:
> > ambari-admin/src/main/resources/ui/admin-web/app/index.html, line 162
> > 
> >
> > I don't see this newly created file in diff files list. You were able 
> > to build UI without this files ? UI should fail upon building because of 
> > declared file that does not exist

Hi Aleksandr,

I accidentally missed adding the file when I created the patch. I have now 
added it. New patch has been uplaoded.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/#review151170
---


On Oct. 3, 2016, 4:35 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52455/
> ---
> 
> (Updated Oct. 3, 2016, 4:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li.
> 
> 
> Bugs: AMBARI-18476
> https://issues.apache.org/jira/browse/AMBARI-18476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-12263 adds support for PAM as authentication mechanism for accessing 
> Ambari UI/REST. The changes in this review request cover the corresponding 
> changes in the amabri-admin code. 
> Since a new column groupt_type has been added for groups, the UI will display 
> labels for group type and enable/disable group delete/add member 
> functionality based on the group_type instead of the ldap_group flag.
> Patch includes similar changes for users. The user_type will be used to 
> determine if the user can be deleted or if the user's password can be changed.
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52455/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> Tests in ambari admin project ran clean.
> PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
> 
> 
> File Attachments
> 
> 
> New patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 52500: AMBARI-18520: Ambari usernames should not be converted to lowercase before storing in the DB.

[Nahappan Somasundaram]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52500/
---

Review request for Ambari, Mahadev Konar, Robert Levas, and Sumit Mohanty.


Bugs: AMBARI-18520
https://issues.apache.org/jira/browse/AMBARI-18520


Repository: ambari


Description
---

AMBARI-18520: Ambari usernames should not be converted to lowercase before 
storing in the DB.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 e547f058d4270bedf8b10f68311232488d26a7ea 

Diff: https://reviews.apache.org/r/52500/diff/


Testing
---

** 1. mvn test -DskipPythonTests 
-Dtest=SecurityHelperImplTest,User*Test,UpgradeCatalog240Test **

Results :

Tests run: 95, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 58.913s
[INFO] Finished at: Mon Oct 03 20:03:48 PDT 2016
[INFO] Final Memory: 57M/866M
[INFO] 

** 2. Manual tests **

Set up a one node cluster with the latest build from trunk and replaced 
ambari-server JAR with the one from the local build.
1. Create a user ABCD. Was able to create the user successfully.
2. Create a user abcd. Unable to create the user.
3. curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
http://localhost:8080/api/v1/users/abcd

{
  "href" : "http://localhost:8080/api/v1/users/abcd;,
  "Users" : {
"active" : true,
"admin" : false,
"groups" : [ ],
"ldap_user" : false,
"user_name" : "abcd",
"user_type" : "LOCAL"
  },
  "privileges" : [ ],
  "widget_layouts" : [ ]
}

curl -u admin:admin -H "X-Requested-By: ambari" -X GET 
http://localhost:8080/api/v1/users/ABCD

{
  "href" : "http://localhost:8080/api/v1/users/ABCD;,
  "Users" : {
"active" : true,
"admin" : false,
"groups" : [ ],
"ldap_user" : false,
"user_name" : "abcd",
"user_type" : "LOCAL"
  },
  "privileges" : [ ],
  "widget_layouts" : [ ]
}


Thanks,

Nahappan Somasundaram

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/
---

(Updated Oct. 3, 2016, 7:57 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.


Bugs: AMBARI-12263
https://issues.apache.org/jira/browse/AMBARI-12263


Repository: ambari


Description
---

Hello Robert,

How are you doing? 

We have been working on PAM support into Ambari and have something ready for 
review. Can you please take a look at the patch and documentation and provide 
your feedback.

Please let me know if you have any questions.

Note: I have added you as a reviewer as i see some authentication related 
commits under your name.

Thanks,
-Vishal


Diffs (updated)
-

  ambari-server/pom.xml d507b82 
  ambari-server/sbin/ambari-server 762ae19 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1fc9dbf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
 ef28f61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 e1aa5ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 bdd73a6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
e4ed9c6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 00e233e 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
 26d4da7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 b20df8d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aa9f3e0 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 e547f05 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 185bd58 
  ambari-server/src/main/python/ambari-server.py bb6bc0e 
  ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
  ambari-server/src/main/resources/properties.json eb27878 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 a80cd03 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 7b6c3ad 

Diff: https://reviews.apache.org/r/52369/diff/


Testing
---

No test cases added at this point.


File Attachments


AMBARI-12263_trunk.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch


Thanks,

Vishal Ghugare

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

On Oct. 3, 2016, 1:17 p.m., Vishal Ghugare wrote:
> > Missing unit test for `AmbariPamAuthenticationProvider`.

Can you please review AmbariPamAuthenticationProviderTest?


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151223
---


On Oct. 3, 2016, 11:43 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52495/
---

(Updated Oct. 4, 2016, 12:51 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18245
https://issues.apache.org/jira/browse/AMBARI-18245


Repository: ambari


Description
---

We are currently using 0.10, which is very old and going EOL 2016-10-01: 
https://github.com/nodejs/LTS
We should upgrade to Node 4.x:
Upgrade Node on Ambari Web
Upgrade Node on Ambari Admin
Upgrade Node on contrib/views/* modules


Diffs (updated)
-

  .gitignore d9f23de 
  ambari-admin/pom.xml e057178 
  ambari-web/app/styles/common.less bc11d4d 
  ambari-web/package.json 6702471 
  ambari-web/pom.xml 759b63e 
  contrib/views/capacity-scheduler/pom.xml cd97dcf 
  contrib/views/capacity-scheduler/src/main/resources/ui/package.json 2cdc672 
  contrib/views/files/pom.xml 383d90d 
  contrib/views/hawq/pom.xml 9a563f6 
  contrib/views/hive-next/pom.xml 921990a 
  contrib/views/hive-next/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hive/pom.xml 20b23f6 
  contrib/views/hive/src/main/resources/ui/hive-web/package.json 595b1f2 
  contrib/views/hueambarimigration/pom.xml 3b28276 
  contrib/views/jobs/pom.xml bd01753 
  contrib/views/pig/pom.xml 595537a 
  contrib/views/pig/src/main/resources/ui/pig-web/package.json 3221483 
  contrib/views/wfmanager/pom.xml 389dc6c 

Diff: https://reviews.apache.org/r/52495/diff/


Testing (updated)
---

Ran "mvn clean package", Ambari Server failed, which is irralevant to this 
patch.
Then run "mvn clean install" individually:

Ambari Web:
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 3:08.144s
[INFO] Finished at: Mon Oct 03 17:13:25 PDT 2016
[INFO] Final Memory: 16M/407M
[INFO] 

30366 tests complete (27 seconds)
151 tests pending

Ambari Admin:
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 14.924s
[INFO] Finished at: Mon Oct 03 17:47:01 PDT 2016
[INFO] Final Memory: 20M/284M
[INFO] 

PhantomJS 1.9.7 (Mac OS X): Executed 86 of 86 SUCCESS (0.267 secs / 0.475 secs)

contrib/views/ modules:
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Contrib Views .. SUCCESS [1:00.758s]
[INFO] Ambari View Utils . SUCCESS [4.714s]
[INFO] Ambari View Commons ... SUCCESS [0.286s]
[INFO] Files . SUCCESS [52.631s]
[INFO] Jobs .. SUCCESS [6.712s]
[INFO] Pig ... SUCCESS [1:07.799s]
[INFO] Slider  SUCCESS [36.043s]
[INFO] Capacity Scheduler  SUCCESS [53.446s]
[INFO] Tez ... SUCCESS [3.659s]
[INFO] HAWQ .. SUCCESS [2:24.060s]
[INFO] Storm_Monitoring .. SUCCESS [0.432s]
[INFO] Zeppelin .. SUCCESS [2.080s]
[INFO] hueambarimigration  SUCCESS [20.801s]
[INFO] Hive Jdbc . SUCCESS [1:00.664s]
[INFO] WF Manager View ... SUCCESS [32.911s]
[INFO] Hive .. SUCCESS [51.542s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 9:58.964s
[INFO] Finished at: Mon Oct 03 17:22:59 PDT 2016
[INFO] Final Memory: 90M/404M
[INFO] 


Thanks,

Zhe (Joe) Wang

Re: Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52497/#review151265
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 3, 2016, 11:13 p.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52497/
> ---
> 
> (Updated Oct. 3, 2016, 11:13 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Xi Wang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-18519
> https://issues.apache.org/jira/browse/AMBARI-18519
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enable Add/Remove JournalNode on NNHA Wizard Step 2
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js
>  b8d7978 
>   ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs 
> 27653d3 
> 
> Diff: https://reviews.apache.org/r/52497/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> 
>   30366 tests complete (30 seconds)
>   151 tests pending
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 52430: Include an option to download the saved query in hive view

[Anita Jebaraj]

> On Oct. 3, 2016, 7:41 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> >  line 86
> > 
> >
> > what's the point of passing the fileName only for the backend to add it 
> > to the header ? Can UI handle naming the file ?
> > 
> > HTTP URL is to identify a resource ({queryId}), HTTP request types are 
> > for basic action type ( read - GET, create - PUT, update - POST, and delete 
> > - DELETE). predicates are for detailing an action when the basic HTTP 
> > request types aren't enough.
> > 
> > so I am not clear on passing the file name here, as it's not really a 
> > resource (since that's identified by the queryId), and it's just so that 
> > web browser can name the file, right ? so I wonder if UI can do it without 
> > overheading it to the server backend.

Hi Di, yes its a valuable suggestion, I have updated the patch by removing the 
fileName from query param and handling it in the UI


> On Oct. 3, 2016, 7:41 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> >  line 87
> > 
> >
> > You may want to consider using operation=name format so that you don't 
> > need to add more query params each time you need to support a new 
> > operation. Think about download=true vs op=download, where op can be later 
> > extended to new operations, but download=true is set in stone and you will 
> > have no othe options but to introduce more URL query parameters for new 
> > operations.

Thank you for the suggestion, I have updated accordingly.


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151220
---


On Oct. 3, 2016, 11:25 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> ---
> 
> (Updated Oct. 3, 2016, 11:25 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18496
> https://issues.apache.org/jira/browse/AMBARI-18496
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> An option to download the saved query can be included.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
>  ccc4512 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
>  cbf6b42 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  f7f7706 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
>  9ea19c6 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
> cbf6b42 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> f7f7706 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
>  d55858f 
> 
> Diff: https://reviews.apache.org/r/52430/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 
> Added 1 new test case
> 
> 
> File Attachments
> 
> 
> screenshot2.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 52430: Include an option to download the saved query in hive view

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/
---

(Updated Oct. 3, 2016, 11:25 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-18496
https://issues.apache.org/jira/browse/AMBARI-18496


Repository: ambari


Description
---

An option to download the saved query can be included.


Diffs (updated)
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
 ccc4512 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
 cbf6b42 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
f7f7706 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
 9ea19c6 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
cbf6b42 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
f7f7706 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
 d55858f 

Diff: https://reviews.apache.org/r/52430/diff/


Testing
---

Ran mvn test

Added 1 new test case


File Attachments


screenshot2.jpg
  
https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
screenshot1.jpg
  
https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg


Thanks,

Anita Jebaraj

Review Request 52497: Enable Add/Remove JournalNode on NNHA Wizard Step 2

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52497/
---

Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Xi Wang, and Yusaku 
Sako.


Bugs: AMBARI-18519
https://issues.apache.org/jira/browse/AMBARI-18519


Repository: ambari


Description
---

Enable Add/Remove JournalNode on NNHA Wizard Step 2


Diffs
-

  
ambari-web/app/controllers/main/admin/highAvailability/nameNode/step2_controller.js
 b8d7978 
  ambari-web/app/templates/main/admin/highAvailability/nameNode/step3.hbs 
27653d3 

Diff: https://reviews.apache.org/r/52497/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.

  30366 tests complete (30 seconds)
  151 tests pending


Thanks,

Richard Zang

Re: Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52495/#review151248
---



When you say "local testing done", what did that entail?
Also, did you explicitly build all the contrib/views modules with the change?

- Yusaku Sako


On Oct. 3, 2016, 10:46 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52495/
> ---
> 
> (Updated Oct. 3, 2016, 10:46 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18245
> https://issues.apache.org/jira/browse/AMBARI-18245
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> We are currently using 0.10, which is very old and going EOL 2016-10-01: 
> https://github.com/nodejs/LTS
> We should upgrade to Node 4.x:
> Upgrade Node on Ambari Web
> Upgrade Node on Ambari Admin
> Upgrade Node on contrib/views/* modules
> 
> 
> Diffs
> -
> 
>   .gitignore d9f23de 
>   ambari-admin/pom.xml e057178 
>   ambari-web/app/styles/common.less bc11d4d 
>   ambari-web/package.json 6702471 
>   ambari-web/pom.xml 759b63e 
>   contrib/views/capacity-scheduler/pom.xml cd97dcf 
>   contrib/views/files/pom.xml 383d90d 
>   contrib/views/hawq/pom.xml 9a563f6 
>   contrib/views/hive-next/pom.xml 921990a 
>   contrib/views/hive/pom.xml 20b23f6 
>   contrib/views/hueambarimigration/pom.xml 3b28276 
>   contrib/views/jobs/pom.xml bd01753 
>   contrib/views/pig/pom.xml 595537a 
>   contrib/views/wfmanager/pom.xml 389dc6c 
> 
> Diff: https://reviews.apache.org/r/52495/diff/
> 
> 
> Testing
> ---
> 
> Local test passed.
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52496/
---

(Updated Oct. 3, 2016, 10:56 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18518
https://issues.apache.org/jira/browse/AMBARI-18518


Repository: ambari


Description
---

Currently, an exception is constantly being thrown in sink logs.

2016-10-03 21:01:06,537 WARN  availability.MetricCollectorHAHelper 
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(91)) - Unable to 
connect to zookeeper.
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException$ConnectionLossException:
 KeeperErrorCode = ConnectionLoss for /ambari-metrics-cluster
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:99)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:51)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1045)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1073)
at 
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:78)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:344)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:216)
at 
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:345)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at 
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)

After the change

2016-10-03 21:08:31,494 INFO  availability.MetricCollectorHAHelper 
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(80)) - 
/ambari-metrics-cluster znode does not exist. Skipping requesting live 
instances from zookeeper


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 ac1f52d 

Diff: https://reviews.apache.org/r/52496/diff/


Testing (updated)
---

Manually tested. 
Unit test added.


Thanks,

Aravindan Vijayan

Re: Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52496/
---

(Updated Oct. 3, 2016, 10:56 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18518
https://issues.apache.org/jira/browse/AMBARI-18518


Repository: ambari


Description
---

Currently, an exception is constantly being thrown in sink logs.

2016-10-03 21:01:06,537 WARN  availability.MetricCollectorHAHelper 
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(91)) - Unable to 
connect to zookeeper.
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException$ConnectionLossException:
 KeeperErrorCode = ConnectionLoss for /ambari-metrics-cluster
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:99)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:51)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1045)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1073)
at 
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:78)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:344)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:216)
at 
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:345)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at 
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)

After the change

2016-10-03 21:08:31,494 INFO  availability.MetricCollectorHAHelper 
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(80)) - 
/ambari-metrics-cluster znode does not exist. Skipping requesting live 
instances from zookeeper


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 ac1f52d 

Diff: https://reviews.apache.org/r/52496/diff/


Testing
---


Thanks,

Aravindan Vijayan

Review Request 52496: AMBARI-18518 : Sinks should not try to read collector hosts from Zk if AMS is in embedded mode.

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52496/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Repository: ambari


Description
---

Currently, an exception is constantly being thrown in sink logs.

2016-10-03 21:01:06,537 WARN  availability.MetricCollectorHAHelper 
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(91)) - Unable to 
connect to zookeeper.
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException$ConnectionLossException:
 KeeperErrorCode = ConnectionLoss for /ambari-metrics-cluster
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:99)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.KeeperException.create(KeeperException.java:51)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1045)
at 
org.apache.hadoop.metrics2.sink.relocated.zookeeper.ZooKeeper.exists(ZooKeeper.java:1073)
at 
org.apache.hadoop.metrics2.sink.timeline.availability.MetricCollectorHAHelper.findLiveCollectorHostsFromZNode(MetricCollectorHAHelper.java:78)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.findPreferredCollectHost(AbstractTimelineMetricsSink.java:344)
at 
org.apache.hadoop.metrics2.sink.timeline.AbstractTimelineMetricsSink.emitMetrics(AbstractTimelineMetricsSink.java:216)
at 
org.apache.hadoop.metrics2.sink.timeline.HadoopTimelineMetricsSink.putMetrics(HadoopTimelineMetricsSink.java:345)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:186)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.consume(MetricsSinkAdapter.java:43)
at 
org.apache.hadoop.metrics2.impl.SinkQueue.consumeAll(SinkQueue.java:87)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter.publishMetricsFromQueue(MetricsSinkAdapter.java:134)
at 
org.apache.hadoop.metrics2.impl.MetricsSinkAdapter$1.run(MetricsSinkAdapter.java:88)

After the change

2016-10-03 21:08:31,494 INFO  availability.MetricCollectorHAHelper 
(MetricCollectorHAHelper.java:findLiveCollectorHostsFromZNode(80)) - 
/ambari-metrics-cluster znode does not exist. Skipping requesting live 
instances from zookeeper


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 ac1f52d 

Diff: https://reviews.apache.org/r/52496/diff/


Testing
---


Thanks,

Aravindan Vijayan

Review Request 52495: AMBARI-18245 Upgrade node to version 4.x

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52495/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-18245
https://issues.apache.org/jira/browse/AMBARI-18245


Repository: ambari


Description
---

We are currently using 0.10, which is very old and going EOL 2016-10-01: 
https://github.com/nodejs/LTS
We should upgrade to Node 4.x:
Upgrade Node on Ambari Web
Upgrade Node on Ambari Admin
Upgrade Node on contrib/views/* modules


Diffs
-

  .gitignore d9f23de 
  ambari-admin/pom.xml e057178 
  ambari-web/app/styles/common.less bc11d4d 
  ambari-web/package.json 6702471 
  ambari-web/pom.xml 759b63e 
  contrib/views/capacity-scheduler/pom.xml cd97dcf 
  contrib/views/files/pom.xml 383d90d 
  contrib/views/hawq/pom.xml 9a563f6 
  contrib/views/hive-next/pom.xml 921990a 
  contrib/views/hive/pom.xml 20b23f6 
  contrib/views/hueambarimigration/pom.xml 3b28276 
  contrib/views/jobs/pom.xml bd01753 
  contrib/views/pig/pom.xml 595537a 
  contrib/views/wfmanager/pom.xml 389dc6c 

Diff: https://reviews.apache.org/r/52495/diff/


Testing
---

Local test passed.
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/python/ambari_server/setupSecurity.py, lines 838-843
> > 
> >
> > Roles will be configurable in the future, this will be problematic.

-is anyone already working on it? is there any JIRA to track this work?
-How is upgrade handled in this case (upgrade from version which has predefined 
roles to version which has configurable roles)?


> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java,
> >  lines 955-960
> > 
> >
> > roles may be set today, but in the future these may be customizabled by 
> > the user.

-is anyone already working on it? is there any JIRA to track this work? 
-How is upgrade handled in this case (upgrade from version which has predefined 
roles to version which has configurable roles)?


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151223
---


On Oct. 3, 2016, 11:43 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: 

Re: Review Request 52451: AMBARI-18508. Provide a configurable option for "LLAP's headroom space for YARN container".

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/#review151230
---


Ship it!




Ship It!

- Sumit Mohanty


On Oct. 3, 2016, 8:16 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52451/
> ---
> 
> (Updated Oct. 3, 2016, 8:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18508
> https://issues.apache.org/jira/browse/AMBARI-18508
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Issue:** LLAP daemons can be killed by the YARN Memory Monitor
> 
> The following messages in the AM log of LLAP YARN Application.
> {quote}
> is running beyond physical memory limits. Current usage:  of 
>  GB physical memory used.
> {quote}
> 
> **Fix:** Added a configurable option for 'headroom space' with default value 
> as 6G. This option gets used while calculating heap size.
> 
> - Screenshot attached.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  b14cc8c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 2a4728a 
> 
> Diff: https://reviews.apache.org/r/52451/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested on live cluster.
> - Ambari QA pending.
> 
> 
> File Attachments
> 
> 
> "llap headroom space" on UI.
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 296
> > 
> >
> > group_type does not need to be that large.

Thank you for reviewing the changes. I tried to keep the group_type size same 
as users.user_type.


> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 287
> > 
> >
> > group_type does not need to be that large.

Thank you for reviewing the changes. I tried to keep the group_type size same 
as users.user_type.


> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql, line 296
> > 
> >
> > group_type does not need to be that large.

Thank you for reviewing the changes. I tried to keep the group_type size same 
as users.user_type.


> On Oct. 3, 2016, 1:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql, line 300
> > 
> >
> > group_type does not need to be that large.

Thank you for reviewing the changes. I tried to keep the group_type size same 
as users.user_type.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151223
---


On Oct. 3, 2016, 11:43 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   

Re: Review Request 52451: AMBARI-18508. Provide a configurable option for "LLAP's headroom space for YARN container".

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/
---

(Updated Oct. 3, 2016, 8:16 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Summary (updated)
-

AMBARI-18508. Provide a configurable option for "LLAP's headroom space for YARN 
container".


Bugs: AMBARI-18508
https://issues.apache.org/jira/browse/AMBARI-18508


Repository: ambari


Description
---

**Issue:** LLAP daemons can be killed by the YARN Memory Monitor

The following messages in the AM log of LLAP YARN Application.
{quote}
is running beyond physical memory limits. Current usage:  of  
GB physical memory used.
{quote}

**Fix:** Added a configurable option for 'headroom space' with default value as 
6G. This option gets used while calculating heap size.

- Screenshot attached.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 b14cc8c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
2a4728a 

Diff: https://reviews.apache.org/r/52451/diff/


Testing
---

- Python UT passes.
- Tested on live cluster.
- Ambari QA pending.


File Attachments


"llap headroom space" on UI.
  
https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151223
---




ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 (lines 64 - 70)


Is both  `ldapGroup` and `groupType` necessary... wouldn't only `groupType` 
be needed?



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 (line 47)


Missing JavaDoc



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 (line 53)


Formatting?



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 (line 58)


This should be `private static`



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 (line 60)


This should be `private` or possibly `private final`.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 (line 28)


This seems unnecessary with `groupType`



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 (line 414)


Why not change `createGroup` to take a group type?



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 (line 503)


`grantAdminPrivilegeToGroup`, `grantClusterAdminPrivilegeToGroup`, 
`grantClusterOperatorPrivilegeToGroup`, `grantServiceAdminPrivilegeToGroup`, 
`grantServiceOperatorPrivilegeToGroup`, `grantClusterUserPrivilegeToGroup` 
should be consolidated to reuse code.  Also the different roles may be sort of 
hard coded today, but in the future the roles (and their names) will be managed 
by the user. For example Cluser Operator may be deleted and the use may create 
a new roles instead.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 (line 522)


`grantAdminPrivilegeToGroup`, `grantClusterAdminPrivilegeToGroup`, 
`grantClusterOperatorPrivilegeToGroup`, `grantServiceAdminPrivilegeToGroup`, 
`grantServiceOperatorPrivilegeToGroup`, `grantClusterUserPrivilegeToGroup` 
should be consolidated to reuse code.  Also the different roles may be sort of 
hard coded today, but in the future the roles (and their names) will be managed 
by the user. For example Cluser Operator may be deleted and the use may create 
a new roles instead.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 (line 545)


`grantAdminPrivilegeToGroup`, `grantClusterAdminPrivilegeToGroup`, 
`grantClusterOperatorPrivilegeToGroup`, `grantServiceAdminPrivilegeToGroup`, 
`grantServiceOperatorPrivilegeToGroup`, `grantClusterUserPrivilegeToGroup` 
should be consolidated to reuse code.  Also the different roles may be sort of 
hard coded today, but in the future the roles (and their names) will be managed 
by the user. For example Cluser Operator may be deleted and the use may create 
a new roles instead.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 (line 568)


`grantAdminPrivilegeToGroup`, `grantClusterAdminPrivilegeToGroup`, 
`grantClusterOperatorPrivilegeToGroup`, `grantServiceAdminPrivilegeToGroup`, 
`grantServiceOperatorPrivilegeToGroup`, `grantClusterUserPrivilegeToGroup` 
should be consolidated to reuse code.  Also the different roles may be sort of 
hard coded today, but in the future the roles (and their names) will be managed 
by the user. For example Cluser Operator may be deleted and the use may create 
a new roles instead.



ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 (line 592)


`grantAdminPrivilegeToGroup`, `grantClusterAdminPrivilegeToGroup`, 
`grantClusterOperatorPrivilegeToGroup`, `grantServiceAdminPrivilegeToGroup`, 
`grantServiceOperatorPrivilegeToGroup`, `grantClusterUserPrivilegeToGroup` 
should be consolidated to reuse code.  Also the different roles may be sort of 
hard coded today, but in the future the roles (and their names) will be managed 
by the user. For example Cluser Operator may be deleted and the use may create 
a new roles instead.

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/
---

(Updated Oct. 3, 2016, 8:16 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated Description.


Bugs: AMBARI-18508
https://issues.apache.org/jira/browse/AMBARI-18508


Repository: ambari


Description (updated)
---

**Issue:** LLAP daemons can be killed by the YARN Memory Monitor

The following messages in the AM log of LLAP YARN Application.
{quote}
is running beyond physical memory limits. Current usage:  of  
GB physical memory used.
{quote}

**Fix:** Added a configurable option for 'headroom space' with default value as 
6G. This option gets used while calculating heap size.

- Screenshot attached.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 b14cc8c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
2a4728a 

Diff: https://reviews.apache.org/r/52451/diff/


Testing
---

- Python UT passes.
- Tested on live cluster.
- Ambari QA pending.


File Attachments


"llap headroom space" on UI.
  
https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 52430: Include an option to download the saved query in hive view

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151220
---




contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
 (line 86)


what's the point of passing the fileName only for the backend to add it to 
the header ? Can UI handle naming the file ?

HTTP URL is to identify a resource ({queryId}), HTTP request types are for 
basic action type ( read - GET, create - PUT, update - POST, and delete - 
DELETE). predicates are for detailing an action when the basic HTTP request 
types aren't enough.

so I am not clear on passing the file name here, as it's not really a 
resource (since that's identified by the queryId), and it's just so that web 
browser can name the file, right ? so I wonder if UI can do it without 
overheading it to the server backend.



contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
 (line 87)


You may want to consider using operation=name format so that you don't need 
to add more query params each time you need to support a new operation. Think 
about download=true vs op=download, where op can be later extended to new 
operations, but download=true is set in stone and you will have no othe options 
but to introduce more URL query parameters for new operations.


- Di Li


On Oct. 3, 2016, 6:13 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> ---
> 
> (Updated Oct. 3, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18496
> https://issues.apache.org/jira/browse/AMBARI-18496
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> An option to download the saved query can be included.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
>  ccc4512 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
>  cbf6b42 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  f7f7706 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
>  9ea19c6 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
> cbf6b42 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> f7f7706 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
>  d55858f 
> 
> Diff: https://reviews.apache.org/r/52430/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 
> Added 1 new test case
> 
> 
> File Attachments
> 
> 
> screenshot2.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/#review151221
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 3, 2016, 7:32 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52451/
> ---
> 
> (Updated Oct. 3, 2016, 7:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18508
> https://issues.apache.org/jira/browse/AMBARI-18508
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Issue:** LLAP daemons can be killed by the YARN Memory Monitor
> 
> The following messages in the AM log of LLAP YARN Application.
> {quote}
> is running beyond physical memory limits. Current usage:  of 
>  GB physical memory used.
> {quote}
> 
> **Fix:** Added a configurable option for 'headroom space' with default value 
> as 6G.
> 
> - Screenshot attached.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  b14cc8c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 2a4728a 
> 
> Diff: https://reviews.apache.org/r/52451/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested on live cluster.
> - Ambari QA pending.
> 
> 
> File Attachments
> 
> 
> "llap headroom space" on UI.
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/
---

(Updated Oct. 3, 2016, 7:32 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Updated description.


Bugs: AMBARI-18508
https://issues.apache.org/jira/browse/AMBARI-18508


Repository: ambari


Description (updated)
---

**Issue:** LLAP daemons can be killed by the YARN Memory Monitor

The following messages in the AM log of LLAP YARN Application.
{quote}
is running beyond physical memory limits. Current usage:  of  
GB physical memory used.
{quote}

**Fix:** Added a configurable option for 'headroom space' with default value as 
6G.

- Screenshot attached.


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 b14cc8c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
2a4728a 

Diff: https://reviews.apache.org/r/52451/diff/


Testing
---

- Python UT passes.
- Tested on live cluster.
- Ambari QA pending.


File Attachments


"llap headroom space" on UI.
  
https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

[Swapan Shridhar]

> On Oct. 1, 2016, 3:21 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, 
> > line 956
> > 
> >
> > Should we instead introduce a variable in hive_interactive_env called - 
> > llap_headroom_space and use that?

Added 'llap headroom space' as configurable option in hive-interactive-env.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/#review151112
---


On Oct. 3, 2016, 7:30 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52451/
> ---
> 
> (Updated Oct. 3, 2016, 7:30 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18508
> https://issues.apache.org/jira/browse/AMBARI-18508
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Issue:** LLAP daemons can be killed by the YARN Memory Monitor
> 
> The following messages in the AM log of LLAP YARN Application.
> {quote}
> is running beyond physical memory limits. Current usage:  of 
>  GB physical memory used.
> {quote}
> 
> **Fix:** Increase the headroom space for heap from 1G (existing) to 6G.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  b14cc8c 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 2a4728a 
> 
> Diff: https://reviews.apache.org/r/52451/diff/
> 
> 
> Testing
> ---
> 
> - Python UT passes.
> - Tested on live cluster.
> - Ambari QA pending.
> 
> 
> File Attachments
> 
> 
> "llap headroom space" on UI.
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 52451: AMBARI-18508. Increasing headroom on heap size is from 1G to 6G for LLAP.

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52451/
---

(Updated Oct. 3, 2016, 7:30 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
---

Added 'llap headroom space' as configurable option in hive-interactive-env.


Bugs: AMBARI-18508
https://issues.apache.org/jira/browse/AMBARI-18508


Repository: ambari


Description
---

**Issue:** LLAP daemons can be killed by the YARN Memory Monitor

The following messages in the AM log of LLAP YARN Application.
{quote}
is running beyond physical memory limits. Current usage:  of  
GB physical memory used.
{quote}

**Fix:** Increase the headroom space for heap from 1G (existing) to 6G.


Diffs (updated)
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
 b14cc8c 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
2a4728a 

Diff: https://reviews.apache.org/r/52451/diff/


Testing
---

- Python UT passes.
- Tested on live cluster.
- Ambari QA pending.


File Attachments (updated)


"llap headroom space" on UI.
  
https://reviews.apache.org/media/uploaded/files/2016/10/03/08a70951-a3e9-4327-84a2-579bb40d5d2a__Screen_Shot_2016-10-03_at_12.29.31_PM.png


Thanks,

Swapan Shridhar

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Oct. 3, 2016, 12:04 p.m., Di Li wrote:
> > Ship It!

Thank you Di.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151215
---


On Oct. 3, 2016, 11:43 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151217
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

> On Oct. 3, 2016, 7:04 p.m., Alejandro Fernandez wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py,
> >  line 150
> > 
> >
> > Will hostname_hash ever be negative?

Ideally, no. In any case, we are guarded for it in 

Line 150 : *index = index if index >= 0 else index + size*


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151213
---


On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151213
---




ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
(line 149)


Will hostname_hash ever be negative?


- Alejandro Fernandez


On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151215
---


Ship it!




Ship It!

- Di Li


On Oct. 3, 2016, 6:43 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Oct. 3, 2016, 11:58 a.m., Alejandro Fernandez wrote:
> > Ship It!

Thank you for reviewing the patch. I would appreciate if you can commit the 
changes on my behalf (I am not a committer).


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151212
---


On Oct. 3, 2016, 11:43 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 11:43 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review151212
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 3, 2016, 6:43 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 3, 2016, 6:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263_trunk.patch
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/
---

(Updated Oct. 3, 2016, 6:52 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18487
https://issues.apache.org/jira/browse/AMBARI-18487


Repository: ambari


Description
---

1. Change metric monitor sharding strategy to hostname based.
2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
already FIXED*
3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 fa5b694 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 3982c4e 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 3ca3a31 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 

Diff: https://reviews.apache.org/r/52391/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/
---

(Updated Oct. 3, 2016, 11:43 a.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.


Bugs: AMBARI-12263
https://issues.apache.org/jira/browse/AMBARI-12263


Repository: ambari


Description
---

Hello Robert,

How are you doing? 

We have been working on PAM support into Ambari and have something ready for 
review. Can you please take a look at the patch and documentation and provide 
your feedback.

Please let me know if you have any questions.

Note: I have added you as a reviewer as i see some authentication related 
commits under your name.

Thanks,
-Vishal


Diffs (updated)
-

  ambari-server/pom.xml d507b82 
  ambari-server/sbin/ambari-server 762ae19 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1fc9dbf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
 ef28f61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 e1aa5ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 bdd73a6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
e4ed9c6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 00e233e 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
 26d4da7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 b20df8d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aa9f3e0 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 e547f05 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 185bd58 
  ambari-server/src/main/python/ambari-server.py bb6bc0e 
  ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
  ambari-server/src/main/resources/properties.json eb27878 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 7b6c3ad 

Diff: https://reviews.apache.org/r/52369/diff/


Testing
---

No test cases added at this point.


File Attachments


AMBARI-12263_trunk.patch
  
https://reviews.apache.org/media/uploaded/files/2016/09/30/80254a19-7d51-46f0-80f9-07e664b814ec__AMBARI-12263_trunk.patch


Thanks,

Vishal Ghugare

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151209
---


Fix it, then Ship it!




Please add unit tests maybe another Jira but this should be unit tested.


ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 352)


Please leave comments about why we need to track expirey vs first call.


- Sid Wagle


On Oct. 3, 2016, 6:22 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/
---

(Updated Oct. 3, 2016, 6:22 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18487
https://issues.apache.org/jira/browse/AMBARI-18487


Repository: ambari


Description (updated)
---

1. Change metric monitor sharding strategy to hostname based.
2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
already FIXED*
3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 fa5b694 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 3982c4e 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 3ca3a31 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 

Diff: https://reviews.apache.org/r/52391/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 52430: Include an option to download the saved query in hive view

[Anita Jebaraj]

> On Sept. 30, 2016, 7:48 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> >  line 117
> > 
> >
> > Does this store the entire query result in the memory ? can it be 
> > streamed for better performance ?

I have updated the latest patch based on your comments


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151070
---


On Oct. 3, 2016, 6:13 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> ---
> 
> (Updated Oct. 3, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18496
> https://issues.apache.org/jira/browse/AMBARI-18496
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> An option to download the saved query can be included.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
>  ccc4512 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
>  cbf6b42 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  f7f7706 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
>  9ea19c6 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
> cbf6b42 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> f7f7706 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
>  d55858f 
> 
> Diff: https://reviews.apache.org/r/52430/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 
> Added 1 new test case
> 
> 
> File Attachments
> 
> 
> screenshot2.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 52430: Include an option to download the saved query in hive view

[Anita Jebaraj]

> On Sept. 30, 2016, 7:45 p.m., Di Li wrote:
> > contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java,
> >  line 103
> > 
> >
> > REST API URLs mostly use nouns (names) instead of verbs (actions). your 
> > current URL design ends on an action.
> > 
> > I am also not sure I see the point of having a new @GET annotated 
> > method just for the download action (due to introducting the new URL, I 
> > guess?). 
> > 
> > Can this be handled in the original @GET method ? You can pass in 
> > pradicates like ?op=download.
> > 
> > If you look at the blueprint export rest api, it's still the @GET 
> > against /clusters, the only diff is the ?format=json parameter. so I also 
> > wonder - Can {queryId} support such parameter like if it's ?format=txt, 
> > then it means to download ?

I have added download as a query param in the existing @GET, so the download 
operation will happen when ?download=true, the fileName is also added as query 
param along with download


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/#review151067
---


On Oct. 3, 2016, 6:13 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52430/
> ---
> 
> (Updated Oct. 3, 2016, 6:13 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18496
> https://issues.apache.org/jira/browse/AMBARI-18496
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> An option to download the saved query can be included.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
>  ccc4512 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
>  cbf6b42 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js
>  f7f7706 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
>  9ea19c6 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
> cbf6b42 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
> f7f7706 
>   
> contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
>  d55858f 
> 
> Diff: https://reviews.apache.org/r/52430/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 
> Added 1 new test case
> 
> 
> File Attachments
> 
> 
> screenshot2.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
> screenshot1.jpg
>   
> https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 52430: Include an option to download the saved query in hive view

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52430/
---

(Updated Oct. 3, 2016, 6:13 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-18496
https://issues.apache.org/jira/browse/AMBARI-18496


Repository: ambari


Description
---

An option to download the saved query can be included.


Diffs (updated)
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/savedQueries/SavedQueryService.java
 ccc4512 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/queries.js
 cbf6b42 
  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/initializers/i18n.js 
f7f7706 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryService.java
 9ea19c6 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/queries.js 
cbf6b42 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
f7f7706 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/savedQueries/SavedQueryServiceTest.java
 d55858f 

Diff: https://reviews.apache.org/r/52430/diff/


Testing
---

Ran mvn test

Added 1 new test case


File Attachments


screenshot2.jpg
  
https://reviews.apache.org/media/uploaded/files/2016/09/30/26f21b91-2637-4127-9ff2-ee6c0d3ddcfd__screenshot2.jpg
screenshot1.jpg
  
https://reviews.apache.org/media/uploaded/files/2016/09/30/b494489d-90f6-42f1-847e-ac19ffcb817a__screenshot1.jpg


Thanks,

Anita Jebaraj

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/#review151191
---


Ship it!




Ship It!

- Di Li


On Sept. 30, 2016, 12:39 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51815/
> ---
> 
> (Updated Sept. 30, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
> Marron, Laszlo Puskas, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-18355
> https://issues.apache.org/jira/browse/AMBARI-18355
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently stack definitions do not list conditional dependencies, adding 
> those to the stack definitions would make it easy to validate errors in case 
> of blueprint deployment. Please refer to document attached to Jira
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java
>  e3db662 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
>  a5f33ff 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
> 65d166a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
>  b1de8ef 
> 
> Diff: https://reviews.apache.org/r/51815/diff/
> 
> 
> Testing
> ---
> 
> Written Junit test cases. Perfomred manual testing to check the Namenode HA 
> component dependency. Was able to proceed with the installation for valid 
> blueprint. and got validation error message while registering blueprint when 
> the Blueprint did not satisfy the conditional dependencies.
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52485/#review151188
---




ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
(line 71)


No XmlElement?


- Jayush Luniya


On Oct. 3, 2016, 3:20 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52485/
> ---
> 
> (Updated Oct. 3, 2016, 3:20 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18516
> https://issues.apache.org/jira/browse/AMBARI-18516
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a service is added to a stack, it should be identified as:
> default/regular - service is optional on the cluster, UI usually shows it as
> tech-preview - service may be deployed, UI will not auto-select these 
> services and mark them as TechPreview
> mandatory - service need to be deployed and all deployment should fail is the 
> service is not selected during deployment
> Lets create a proposal of what changes are needed in the services' 
> metainfo.xml? Note that a service can change its attribute between stack 
> versions - e.g. move from "tech-preview" to "mandatory".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  5865e20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  16713dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 34e65c3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> b0d81c3 
>   ambari-server/src/main/resources/properties.json eb27878 
> 
> Diff: https://reviews.apache.org/r/52485/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52485/#review151187
---



Add unit tests

- Jayush Luniya


On Oct. 3, 2016, 3:20 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52485/
> ---
> 
> (Updated Oct. 3, 2016, 3:20 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18516
> https://issues.apache.org/jira/browse/AMBARI-18516
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a service is added to a stack, it should be identified as:
> default/regular - service is optional on the cluster, UI usually shows it as
> tech-preview - service may be deployed, UI will not auto-select these 
> services and mark them as TechPreview
> mandatory - service need to be deployed and all deployment should fail is the 
> service is not selected during deployment
> Lets create a proposal of what changes are needed in the services' 
> metainfo.xml? Note that a service can change its attribute between stack 
> versions - e.g. move from "tech-preview" to "mandatory".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  5865e20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  16713dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 34e65c3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> b0d81c3 
>   ambari-server/src/main/resources/properties.json eb27878 
> 
> Diff: https://reviews.apache.org/r/52485/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52455: Ambari UI changes to support PAM authentication

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/
---

(Updated Oct. 3, 2016, 4:35 p.m.)


Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li.


Bugs: AMBARI-18476
https://issues.apache.org/jira/browse/AMBARI-18476


Repository: ambari


Description
---

AMBARI-12263 adds support for PAM as authentication mechanism for accessing 
Ambari UI/REST. The changes in this review request cover the corresponding 
changes in the amabri-admin code. 
Since a new column groupt_type has been added for groups, the UI will display 
labels for group type and enable/disable group delete/add member functionality 
based on the group_type instead of the ldap_group flag.
Patch includes similar changes for users. The user_type will be used to 
determine if the user can be deleted or if the user's password can be changed.


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/GroupConstants.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/52455/diff/


Testing
---

Manual testing. 
Tests in ambari admin project ran clean.
PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)


File Attachments (updated)


New patch
  
https://reviews.apache.org/media/uploaded/files/2016/10/03/460d7193-8d55-4ce3-96c6-ad3240502e7b__AMBARI-18476.patch


Thanks,

Sangeeta Ravindran

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

[Sangeeta Ravindran]

> On Sept. 29, 2016, 5:25 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Sangeeta Ravindran wrote:
> Thanks Alexandr. Can you please help push the fix?
> 
> Alexandr Antonenko wrote:
> done

Thank you. Closing the review request.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52397/#review150874
---


On Sept. 29, 2016, 4:48 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52397/
> ---
> 
> (Updated Sept. 29, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18488
> https://issues.apache.org/jira/browse/AMBARI-18488
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Delete Group button always has the tooltip "Cannot Delete Group" even when a 
> group is deleteable. Fix is to remove the tooltip in the case where group can 
> be deleted and Delete Group button is enabled.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 
> 8271432 
> 
> Diff: https://reviews.apache.org/r/52397/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> Tests in ambari admin project ran clean.
> PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52485/#review151178
---




ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
(line 1004)


How do we deprecate a component at a version yet still allow inheritence?

E.g., Ambari 2.4 supports Atlas on a fresh install only on HDP 2.5 but not 
2.4.


- Alejandro Fernandez


On Oct. 3, 2016, 3:20 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52485/
> ---
> 
> (Updated Oct. 3, 2016, 3:20 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18516
> https://issues.apache.org/jira/browse/AMBARI-18516
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When a service is added to a stack, it should be identified as:
> default/regular - service is optional on the cluster, UI usually shows it as
> tech-preview - service may be deployed, UI will not auto-select these 
> services and mark them as TechPreview
> mandatory - service need to be deployed and all deployment should fail is the 
> service is not selected during deployment
> Lets create a proposal of what changes are needed in the services' 
> metainfo.xml? Note that a service can change its attribute between stack 
> versions - e.g. move from "tech-preview" to "mandatory".
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
>  5865e20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
>  16713dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> 34e65c3 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> b0d81c3 
>   ambari-server/src/main/resources/properties.json eb27878 
> 
> Diff: https://reviews.apache.org/r/52485/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

[Alejandro Fernandez]

> On Oct. 3, 2016, 3:19 p.m., Robert Nettleton wrote:
> > pom.xml, line 679
> > 
> >
> > I think the overall scheme to categorize tests sounds like a good idea. 
> > 
> > However, I do have some concerns about categorizing tests as "fast" or 
> > "slow".  Do we have any specific guidelines for marking a test as either 
> > category?  
> > 
> > I believe there might be maven plugins to track the slowest tests in a 
> > given unit test run, so that might be a good place to start to determine 
> > which tests to mark as either category.
> > 
> > This could potentially become a slippery slope, though, in which 
> > developers only run the fast tests prior to checkin.  I would definitely be 
> > concerned about that.

The goal is two-fold.
1) Allow a developer to get faster results on problematic areas sooner. If I'm 
working on EU/RU, then I should be running that category. Once I've fixed that 
entire category, then I can run a full unit test.
2) Allow the parallelization of unit tests on multiple hosts (any QA Infra team 
can either run per category or look at historic results and run individual test 
cases).


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52457/#review151171
---


On Sept. 30, 2016, 11:10 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52457/
> ---
> 
> (Updated Sept. 30, 2016, 11:10 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Di Li, Dmitro 
> Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-14439
> https://issues.apache.org/jira/browse/AMBARI-14439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
> only the desired category in order to run the tests faster.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml 0445c39 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 87e3423 
>   ambari-metrics/pom.xml 6ab8c60 
>   ambari-server/pom.xml e37accd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
>  85dedba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java
>  3cc84c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
>  c534c4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  76aa2e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  7aef175 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  7964d14 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  fc4803b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  201d84e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  4f2a2f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  0070e6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
>  fca2f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  ef1c7bb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  79350eb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  635cc30 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  9896317 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  8be0eb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradePackTest.java
>  388a81f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  bf716b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java
>  9654dc3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  97e50c3 
>   pom.xml 7ca4ba4 
>   utility/pom.xml PRE-CREATION 
>   utility/src/main/java/category/AlertTest.java PRE-CREATION 
>   utility/src/main/java/category/AmbariUpgradeTest.java PRE-CREATION 
>   

Review Request 52485: Add ability to have services declare itself as tech-preview or mandatory

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52485/
---

Review request for Ambari, Jaimin Jetly, Jayush Luniya, and Yusaku Sako.


Bugs: AMBARI-18516
https://issues.apache.org/jira/browse/AMBARI-18516


Repository: ambari


Description
---

When a service is added to a stack, it should be identified as:
default/regular - service is optional on the cluster, UI usually shows it as
tech-preview - service may be deployed, UI will not auto-select these services 
and mark them as TechPreview
mandatory - service need to be deployed and all deployment should fail is the 
service is not selected during deployment
Lets create a proposal of what changes are needed in the services' 
metainfo.xml? Note that a service can change its attribute between stack 
versions - e.g. move from "tech-preview" to "mandatory".


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java
 5865e20 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java
 16713dd 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
34e65c3 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
b0d81c3 
  ambari-server/src/main/resources/properties.json eb27878 

Diff: https://reviews.apache.org/r/52485/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52457/#review151171
---


Ship it!




Overall, the patch looks fine to me, just a few comments below.

We should be careful to make sure that the categorization of unit tests, which 
is a useful feature for many reasons, does not encourage developers to only run 
certain subsuites prior to checkin.  

Thanks.


pom.xml (line 679)


I think the overall scheme to categorize tests sounds like a good idea. 

However, I do have some concerns about categorizing tests as "fast" or 
"slow".  Do we have any specific guidelines for marking a test as either 
category?  

I believe there might be maven plugins to track the slowest tests in a 
given unit test run, so that might be a good place to start to determine which 
tests to mark as either category.

This could potentially become a slippery slope, though, in which developers 
only run the fast tests prior to checkin.  I would definitely be concerned 
about that.



utility/src/main/java/category/AlertTest.java (line 1)


Having to create these empty interfaces to define new test categories seems 
problematic to me.  

That being said, based on how the Category annotation is defined, there 
might not be an option, so this might be the only way to use this annotation.


- Robert Nettleton


On Sept. 30, 2016, 11:10 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52457/
> ---
> 
> (Updated Sept. 30, 2016, 11:10 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Di Li, Dmitro 
> Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-14439
> https://issues.apache.org/jira/browse/AMBARI-14439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
> only the desired category in order to run the tests faster.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml 0445c39 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 87e3423 
>   ambari-metrics/pom.xml 6ab8c60 
>   ambari-server/pom.xml e37accd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
>  85dedba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java
>  3cc84c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
>  c534c4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  76aa2e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  7aef175 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  7964d14 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  fc4803b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  201d84e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  4f2a2f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  0070e6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
>  fca2f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  ef1c7bb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  79350eb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  635cc30 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  9896317 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  8be0eb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradePackTest.java
>  388a81f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  bf716b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java
>  9654dc3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  97e50c3 
>   pom.xml 7ca4ba4 
>   utility/pom.xml PRE-CREATION 
>   

Re: Review Request 52455: Ambari UI changes to support PAM authentication

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52455/#review151170
---




ambari-admin/src/main/resources/ui/admin-web/app/index.html (line 162)


I don't see this newly created file in diff files list. You were able to 
build UI without this files ? UI should fail upon building because of declared 
file that does not exist


- Alexandr Antonenko


On Sept. 30, 2016, 10:47 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52455/
> ---
> 
> (Updated Sept. 30, 2016, 10:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Alexandr Antonenko, and Di Li.
> 
> 
> Bugs: AMBARI-18476
> https://issues.apache.org/jira/browse/AMBARI-18476
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-12263 adds support for PAM as authentication mechanism for accessing 
> Ambari UI/REST. The changes in this review request cover the corresponding 
> changes in the amabri-admin code. 
> Since a new column groupt_type has been added for groups, the UI will display 
> labels for group type and enable/disable group delete/add member 
> functionality based on the group_type instead of the ldap_group flag.
> Patch includes similar changes for users. The user_type will be used to 
> determine if the user can be deleted or if the user's password can be changed.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html b3f1bd1 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
>  2e7830b 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsListCtrl.js
>  1f86393 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> af22d7f 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Group.js 
> 660306c 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/UserConstants.js
>  da63c6d 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 
> 8271432 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/list.html 
> b359ede 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/users/show.html 
> e576b28 
> 
> Diff: https://reviews.apache.org/r/52455/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> Tests in ambari admin project ran clean.
> PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52457/#review151169
---


Ship it!




Ship It!

- Di Li


On Sept. 30, 2016, 11:10 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52457/
> ---
> 
> (Updated Sept. 30, 2016, 11:10 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Di Li, Dmitro 
> Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-14439
> https://issues.apache.org/jira/browse/AMBARI-14439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
> only the desired category in order to run the tests faster.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml 0445c39 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 87e3423 
>   ambari-metrics/pom.xml 6ab8c60 
>   ambari-server/pom.xml e37accd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
>  85dedba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java
>  3cc84c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
>  c534c4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  76aa2e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  7aef175 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  7964d14 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  fc4803b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  201d84e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  4f2a2f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  0070e6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
>  fca2f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  ef1c7bb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  79350eb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  635cc30 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  9896317 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  8be0eb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradePackTest.java
>  388a81f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  bf716b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java
>  9654dc3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  97e50c3 
>   pom.xml 7ca4ba4 
>   utility/pom.xml PRE-CREATION 
>   utility/src/main/java/category/AlertTest.java PRE-CREATION 
>   utility/src/main/java/category/AmbariUpgradeTest.java PRE-CREATION 
>   utility/src/main/java/category/BlueprintTest.java PRE-CREATION 
>   utility/src/main/java/category/FastTest.java PRE-CREATION 
>   utility/src/main/java/category/KerberosTest.java PRE-CREATION 
>   utility/src/main/java/category/MetricsTest.java PRE-CREATION 
>   utility/src/main/java/category/SlowTest.java PRE-CREATION 
>   utility/src/main/java/category/StackUpgradeTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52457/diff/
> 
> 
> Testing
> ---
> 
> Verified,
> mvn clean test
> mvn clean test -P FastTests
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52456: Modify HTTP headers to follow best security practices

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52456/#review151168
---


Ship it!




Ship It!

- Di Li


On Sept. 30, 2016, 10:56 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52456/
> ---
> 
> (Updated Sept. 30, 2016, 10:56 p.m.)
> 
> 
> Review request for Ambari, Di Li, Robert Levas, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17311
> https://issues.apache.org/jira/browse/AMBARI-17311
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This patch adds the following HTTP headers to follow security best practices.
> 
> X-Content-Type-Options: nosniff
> Cache-control: no-store
> Pragma: no-cache
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/ambari.properties 4dcbe99 
>   ambari-server/conf/windows/ambari.properties 64cce3b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilter.java
>  05c9ecb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilter.java
>  b40953b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilter.java
>  5bff4e3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/AbstractSecurityHeaderFilterTest.java
>  7be70a3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariServerSecurityHeaderFilterTest.java
>  6537130 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/AmbariViewsSecurityHeaderFilterTest.java
>  c9d7974 
> 
> Diff: https://reviews.apache.org/r/52456/diff/
> 
> 
> Testing
> ---
> 
> Test cases have been updated to test with the new headers added.
> Also did manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 52467: Use logsearch truststore to look for credential in case of external authentication

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52467/#review151166
---


Ship it!




Ship It!

- Oliver Szabo


On Oct. 3, 2016, 1:08 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52467/
> ---
> 
> (Updated Oct. 3, 2016, 1:08 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18510
> https://issues.apache.org/jira/browse/AMBARI-18510
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logsearch looks for credentials also in it's own trust store, not only in 
> cacarts in case of external authentication
> 
> Other changes:
> - authentication cleanup
> - authentication unit tests added
> - trust store and key store handling moved to it's own class (SSLUtil)
> - docker test environment can be configured to use SSL for solr, and https 
> for logsearch portal
> - also removed non-existent LogProcessor.jar from the classpath of Log Search 
> and Log Feeder
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dfc7b7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  75d8be3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  c476b9d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  1844d8f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
>  eab33a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java
>  d37e545 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  7e146ac 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProvider.java
>  51b3547 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
>  400361b 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 4e8901d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/logsearch.properties
>  fa3efb8 
>   ambari-logsearch/docker/.gitignore 0d6af58 
>   ambari-logsearch/docker/Dockerfile a09f235 
>   ambari-logsearch/docker/bin/start.sh a09e4b2 
>   ambari-logsearch/docker/logsearch-docker.sh 022b1ba 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh e69b1db 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2ad7055 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh 92fa354 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
>  d1c1ef9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  501603a 
> 
> Diff: https://reviews.apache.org/r/52467/diff/
> 
> 
> Testing
> ---
> 
> Tested in docker envrionment.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 52481: Ambari-Server restart causes all host components to go in Heartbeat Lost state indefinitely.

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52481/#review151163
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 3, 2016, 11:44 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52481/
> ---
> 
> (Updated Жов. 3, 2016, 11:44 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18512
> https://issues.apache.org/jira/browse/AMBARI-18512
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps
> 
>   * Deploy cluster using Ambari trunk version.
>   * Restart Ambari Server.
>   * All host components show up as Heartbeat lost after that.
> 
> FYI, Agent restart fixes the issue.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  966efa2 
> 
> Diff: https://reviews.apache.org/r/52481/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 51197: Zeppelin logsearch configuration typo

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51197/
---

(Updated Oct. 3, 2016, 1:16 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

removed from 2.4


Bugs: AMBARI-18193
https://issues.apache.org/jira/browse/AMBARI-18193


Repository: ambari


Description
---

an s was missing


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 cb7b79f 

Diff: https://reviews.apache.org/r/51197/diff/


Testing
---


Thanks,

Miklos Gergely

Review Request 52483: Write unittests for configs.py

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52483/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18515
https://issues.apache.org/jira/browse/AMBARI-18515


Repository: ambari


Description
---

Write/update unittests for configs.py script.


Diffs
-

  ambari-server/src/main/resources/scripts/configs.py 3b5f693 
  ambari-server/src/test/python/TestConfigs.py 8dcc536 
  ambari-server/src/test/resources/TestConfigs-content.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/52483/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52467: Use logsearch truststore to look for credential in case of external authentication

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52467/
---

(Updated Oct. 3, 2016, 1:08 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

create config inside the container


Bugs: AMBARI-18510
https://issues.apache.org/jira/browse/AMBARI-18510


Repository: ambari


Description
---

Logsearch looks for credentials also in it's own trust store, not only in 
cacarts in case of external authentication

Other changes:
- authentication cleanup
- authentication unit tests added
- trust store and key store handling moved to it's own class (SSLUtil)
- docker test environment can be configured to use SSL for solr, and https for 
logsearch portal
- also removed non-existent LogProcessor.jar from the classpath of Log Search 
and Log Feeder


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dfc7b7b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
 75d8be3 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 c476b9d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
 1844d8f 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
 eab33a1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java
 d37e545 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
 7e146ac 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProvider.java
 51b3547 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
 400361b 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 4e8901d 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/test/resources/logsearch.properties
 fa3efb8 
  ambari-logsearch/docker/.gitignore 0d6af58 
  ambari-logsearch/docker/Dockerfile a09f235 
  ambari-logsearch/docker/bin/start.sh a09e4b2 
  ambari-logsearch/docker/logsearch-docker.sh 022b1ba 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh e69b1db 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2ad7055 
  ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env.sh 92fa354 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
 d1c1ef9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
 501603a 

Diff: https://reviews.apache.org/r/52467/diff/


Testing
---

Tested in docker envrionment.


Thanks,

Miklos Gergely

Re: Review Request 52397: Delete group button always shows tooltip "Cannot Delete Group"

[Alexandr Antonenko]

> On Sept. 29, 2016, 5:25 p.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Sangeeta Ravindran wrote:
> Thanks Alexandr. Can you please help push the fix?

done


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52397/#review150874
---


On Sept. 29, 2016, 4:48 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52397/
> ---
> 
> (Updated Sept. 29, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-18488
> https://issues.apache.org/jira/browse/AMBARI-18488
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Delete Group button always has the tooltip "Cannot Delete Group" even when a 
> group is deleteable. Fix is to remove the tooltip in the case where group can 
> be deleted and Delete Group button is enabled.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 
> 8271432 
> 
> Diff: https://reviews.apache.org/r/52397/diff/
> 
> 
> Testing
> ---
> 
> Manual testing. 
> Tests in ambari admin project ran clean.
> PhantomJS 1.9.7 (Linux): Executed 86 of 86 SUCCESS (0.771 secs / 0.75 secs)
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 52482: Analyze and Optimize Ambari Server Unit Tests - Group 7

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52482/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18513
https://issues.apache.org/jira/browse/AMBARI-18513


Repository: ambari


Description
---

Test Count Time (s)

org.apache.ambari.server.agent.TestHeartbeatHandler

24

63.327

org.apache.ambari.server.state.alerts.AlertReceivedListenerTest

17

48.005

org.apache.ambari.server.controller.internal.JMXHostProviderTest

10

35.514

org.apache.ambari.server.configuration.RecoveryConfigHelperTest

8

30.128

org.apache.ambari.server.state.cluster.ClustersDeadlockTest

3

68.167


Diffs
-

  
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClustersDeadlockTest.java
 a0a6444 

Diff: https://reviews.apache.org/r/52482/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 52481: Ambari-Server restart causes all host components to go in Heartbeat Lost state indefinitely.

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52481/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18512
https://issues.apache.org/jira/browse/AMBARI-18512


Repository: ambari


Description
---

Steps

  * Deploy cluster using Ambari trunk version.
  * Restart Ambari Server.
  * All host components show up as Heartbeat lost after that.

FYI, Agent restart fixes the issue.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 42ad96b 
  ambari-common/src/main/python/ambari_commons/inet_utils.py 987c761 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 966efa2 

Diff: https://reviews.apache.org/r/52481/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52457/#review151161
---


Ship it!




Ship It!

- Tim Thorpe


On Sept. 30, 2016, 11:10 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52457/
> ---
> 
> (Updated Sept. 30, 2016, 11:10 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Di Li, Dmitro 
> Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-14439
> https://issues.apache.org/jira/browse/AMBARI-14439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
> only the desired category in order to run the tests faster.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml 0445c39 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 87e3423 
>   ambari-metrics/pom.xml 6ab8c60 
>   ambari-server/pom.xml e37accd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
>  85dedba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java
>  3cc84c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
>  c534c4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  76aa2e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  7aef175 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  7964d14 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  fc4803b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  201d84e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  4f2a2f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  0070e6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
>  fca2f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  ef1c7bb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  79350eb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  635cc30 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  9896317 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  8be0eb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradePackTest.java
>  388a81f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  bf716b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java
>  9654dc3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  97e50c3 
>   pom.xml 7ca4ba4 
>   utility/pom.xml PRE-CREATION 
>   utility/src/main/java/category/AlertTest.java PRE-CREATION 
>   utility/src/main/java/category/AmbariUpgradeTest.java PRE-CREATION 
>   utility/src/main/java/category/BlueprintTest.java PRE-CREATION 
>   utility/src/main/java/category/FastTest.java PRE-CREATION 
>   utility/src/main/java/category/KerberosTest.java PRE-CREATION 
>   utility/src/main/java/category/MetricsTest.java PRE-CREATION 
>   utility/src/main/java/category/SlowTest.java PRE-CREATION 
>   utility/src/main/java/category/StackUpgradeTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52457/diff/
> 
> 
> Testing
> ---
> 
> Verified,
> mvn clean test
> mvn clean test -P FastTests
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52457: Categorize unit tests so can run mvn test -P $PROFILE

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52457/#review151160
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 1, 2016, 2:10 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52457/
> ---
> 
> (Updated Oct. 1, 2016, 2:10 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Grinenko, Di Li, Dmitro 
> Lisnichenko, Jonathan Hurley, Nate Cole, Sid Wagle, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-14439
> https://issues.apache.org/jira/browse/AMBARI-14439
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Categorize the unit tests so we that "mvn test -P $PROFILE" command can run 
> only the desired category in order to run the tests faster.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml 0445c39 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml 87e3423 
>   ambari-metrics/pom.xml 6ab8c60 
>   ambari-server/pom.xml e37accd 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AggregateAlertListenerTest.java
>  85dedba 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionEqualityTest.java
>  3cc84c0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java
>  c534c4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertEventPublisherTest.java
>  76aa2e4 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertReceivedListenerTest.java
>  7aef175 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertStateChangedEventTest.java
>  7964d14 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/alerts/InitialAlertEventTest.java
>  fc4803b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosComponentDescriptorTest.java
>  201d84e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosConfigurationDescriptorTest.java
>  4f2a2f5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
>  0070e6d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorUpdateHelperTest.java
>  fca2f1f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
>  ef1c7bb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosKeytabDescriptorTest.java
>  79350eb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosPrincipalDescriptorTest.java
>  635cc30 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosServiceDescriptorTest.java
>  9896317 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java
>  8be0eb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradePackTest.java
>  388a81f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/ConfigUpgradeValidityTest.java
>  bf716b7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/OSFamilyTest.java
>  9654dc3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  97e50c3 
>   pom.xml 7ca4ba4 
>   utility/pom.xml PRE-CREATION 
>   utility/src/main/java/category/AlertTest.java PRE-CREATION 
>   utility/src/main/java/category/AmbariUpgradeTest.java PRE-CREATION 
>   utility/src/main/java/category/BlueprintTest.java PRE-CREATION 
>   utility/src/main/java/category/FastTest.java PRE-CREATION 
>   utility/src/main/java/category/KerberosTest.java PRE-CREATION 
>   utility/src/main/java/category/MetricsTest.java PRE-CREATION 
>   utility/src/main/java/category/SlowTest.java PRE-CREATION 
>   utility/src/main/java/category/StackUpgradeTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52457/diff/
> 
> 
> Testing
> ---
> 
> Verified,
> mvn clean test
> mvn clean test -P FastTests
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/#review151158
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 3, 2016, 12:38 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52420/
> ---
> 
> (Updated Oct. 3, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18505
> https://issues.apache.org/jira/browse/AMBARI-18505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SmartSense status command does an http call without timeout in 1.2 version of
> SS.
> 
> Ambari agent queues STATUS commands until we end up with HB lost state with
> ton of commands queued up.
> 
> This should just never happen is commands are getting queued by by the agent
> every HB.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 
> 655b2fc 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 
> 
> Diff: https://reviews.apache.org/r/52420/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52340: Refactor solr layer in logsearch

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52340/
---

(Updated Oct. 3, 2016, 9:58 a.m.)


Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, and 
Sebastian Toader.


Changes
---

StringUtils fixes


Bugs: AMBARI-18310
https://issues.apache.org/jira/browse/AMBARI-18310


Repository: ambari


Description
---

- remove more unused endpoints + code
- introduce freemarker (using for download files)
- remove @Component and @Qualifier annotations
- remove Criteria (+ Criteria converter) layer
- convert request directly to solr queries
- get rid of QueryGeneration + QueryGenerationBase classes (keep GraphGenerator 
class , that is the response converter layer now)


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-portal/pom.xml a1d1bfc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
 9682a3d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
 d9d3b86 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogType.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageData.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
 786cf99 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/VResponse.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
 b279a83 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 7508fb1 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractAuditLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractDateRangeFacetQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractSearchRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractServiceLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditBarGraphRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditComponentsRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AuditServiceLoadRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/BaseServiceLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/FieldAuditLogRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogAnyGraphRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogComponentLevelRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogComponentRequestFacetQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogLevelCountRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogLevelDateRangeRequestQueryConverter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/ServiceLogTreeRequestFacetQueryConverter.java
 

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/#review151155
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 3, 2016, 9:38 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52420/
> ---
> 
> (Updated Жов. 3, 2016, 9:38 до полудня)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18505
> https://issues.apache.org/jira/browse/AMBARI-18505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SmartSense status command does an http call without timeout in 1.2 version of
> SS.
> 
> Ambari agent queues STATUS commands until we end up with HB lost state with
> ton of commands queued up.
> 
> This should just never happen is commands are getting queued by by the agent
> every HB.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 
> 655b2fc 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 
> 
> Diff: https://reviews.apache.org/r/52420/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/
---

(Updated Oct. 3, 2016, 9:38 a.m.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-18505
https://issues.apache.org/jira/browse/AMBARI-18505


Repository: ambari


Description
---

SmartSense status command does an http call without timeout in 1.2 version of
SS.

Ambari agent queues STATUS commands until we end up with HB lost state with
ton of commands queued up.

This should just never happen is commands are getting queued by by the agent
every HB.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 914e09a 
  ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
  ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 655b2fc 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 

Diff: https://reviews.apache.org/r/52420/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/#review151153
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 3, 2016, 9:21 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52420/
> ---
> 
> (Updated Жов. 3, 2016, 9:21 до полудня)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18505
> https://issues.apache.org/jira/browse/AMBARI-18505
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> SmartSense status command does an http call without timeout in 1.2 version of
> SS.
> 
> Ambari agent queues STATUS commands until we end up with HB lost state with
> ton of commands queued up.
> 
> This should just never happen is commands are getting queued by by the agent
> every HB.
> 
> 
> Diffs
> -
> 
>   ambari-agent/conf/unix/ambari-agent.ini 914e09a 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 
> 655b2fc 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 
> 
> Diff: https://reviews.apache.org/r/52420/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 52420: Ambari Status commands should enforce a timeout < heartbeat interval

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52420/
---

(Updated Oct. 3, 2016, 9:19 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18505
https://issues.apache.org/jira/browse/AMBARI-18505


Repository: ambari


Description
---

SmartSense status command does an http call without timeout in 1.2 version of
SS.

Ambari agent queues STATUS commands until we end up with HB lost state with
ton of commands queued up.

This should just never happen is commands are getting queued by by the agent
every HB.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 914e09a 
  ambari-agent/src/main/python/ambari_agent/ActionQueue.py f104939 
  ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 655b2fc 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 7d04d42 

Diff: https://reviews.apache.org/r/52420/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52340: Refactor solr layer in logsearch

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52340/#review151146
---


Fix it, then Ship it!




Fix it, then ship it


ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractAuditLogRequestQueryConverter.java
 (line 41)


Use StringUtils.isNotBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractDateRangeFacetQueryConverter.java
 (line 35)


Use StringUtils.defaultIfBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractOperationHolderConverter.java
 (line 95)


Use StringUtils.defaultIfEmpty



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/BaseServiceLogRequestQueryConverter.java
 (line 62)


Use StringUtils.isNotBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 (line 178)


Use StringUtils.isNotBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 (line 181)


Use StringUtils.isNotBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 (line 198)


Use StringUtils.isNotBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 (line 234)


Use StringUtils.isNotBlank



ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
 (line 283)


use StringUtils.isNotEmpty


- Miklos Gergely


On Sept. 30, 2016, 7:45 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52340/
> ---
> 
> (Updated Sept. 30, 2016, 7:45 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, Sumit Mohanty, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18310
> https://issues.apache.org/jira/browse/AMBARI-18310
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - remove more unused endpoints + code
> - introduce freemarker (using for download files)
> - remove @Component and @Qualifier annotations
> - remove Criteria (+ Criteria converter) layer
> - convert request directly to solr queries
> - get rid of QueryGeneration + QueryGenerationBase classes (keep 
> GraphGenerator class , that is the response converter layer now)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml a1d1bfc 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  9682a3d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  d9d3b86 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogType.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageData.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/MessageEnums.java
>  786cf99 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/VResponse.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java
>  b279a83 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
>  7508fb1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractAuditLogRequestQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractConverterAware.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractDateRangeFacetQueryConverter.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java
>  PRE-CREATION 
>   
>