Re: Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/#review159931 --- Ship it! Ship It! - Sid Wagle On Dec. 21, 2016, 11:05 a.m.,

Re: Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory

2016-12-21 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/#review159930 --- Ship it! Ship It! - Mahadev Konar On Dec. 21, 2016, 11:05

Re: Review Request 54958: Single API to download all client configs

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/#review159924 ---

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54609/#review159921 --- Ship it! Ship It! - Sid Wagle On Dec. 22, 2016, 1:53 a.m.,

Re: Review Request 54955: Add common log4j settings to advanced config - hbase, zookeeper, ams

2016-12-21 Thread Madhuvanthi Radhakrishnan
> On Dec. 22, 2016, 1:17 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py, > > line 228 > > > > > > These should be in > >

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-21 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54609/ --- (Updated Dec. 22, 2016, 1:53 a.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 54944: AMBARI-19273 : Refine AmbariServer Metrics service and enable JVM metrics source by default.

2016-12-21 Thread Aravindan Vijayan
> On Dec. 22, 2016, 12:14 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java, > > line 88 > > > > > > Why is this hardcoded ? > > Aravindan

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-21 Thread Aravindan Vijayan
> On Dec. 22, 2016, 12:12 a.m., Sid Wagle wrote: > > ambari-metrics/ambari-metrics-timelineservice/conf/windows/metrics_whitelist, > > line 1 > > > > > > No hive metrics? They are present in the whitelist. Examples

Re: Review Request 54944: AMBARI-19273 : Refine AmbariServer Metrics service and enable JVM metrics source by default.

2016-12-21 Thread Aravindan Vijayan
> On Dec. 22, 2016, 12:14 a.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java, > > line 88 > > > > > > Why is this hardcoded ? I thought that

Re: Review Request 54955: Add common log4j settings to advanced config - hbase, zookeeper, ams

2016-12-21 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54955/#review159901 ---

Review Request 54958: Single API to download all client configs

2016-12-21 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54958/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid

Re: Review Request 54944: AMBARI-19273 : Refine AmbariServer Metrics service and enable JVM metrics source by default.

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54944/#review159888 --- Fix it, then Ship it!

Re: Review Request 54609: AMBARI-19141 : Refinements for AMS whitelisting

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54609/#review159887 ---

Re: Review Request 54944: AMBARI-19273 : Refine AmbariServer Metrics service and enable JVM metrics source by default.

2016-12-21 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54944/ --- (Updated Dec. 21, 2016, 9:23 p.m.) Review request for Ambari, Dmytro Sen,

Re: Review Request 54903: BE changes needed for SNMP Ambari MIB support

2016-12-21 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54903/#review159853 --- Ship it! Ship It! - Jonathan Hurley On Dec. 20, 2016, 11:36

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/ --- (Updated Dec. 21, 2016, 7:31 p.m.) Review request for Ambari, Attila

Review Request 54944: AMBARI-19273 : Refine AmbariServer Metrics service and enable JVM metrics source by default.

2016-12-21 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54944/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs:

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/ --- (Updated Dec. 21, 2016, 7:12 p.m.) Review request for Ambari, Attila

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
> On Dec. 21, 2016, 6:41 p.m., Attila Doroszlai wrote: > > Why do we need default values in both `ambari-server.py` and > > `kerberos_setup.py`? It's indeed a duplication, however due to time constraints i didn't check how could this be changed. (the setup-ldap functionality is implemented

Re: Review Request 54891: Create quick links profile evaluator

2016-12-21 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/ --- (Updated Dec. 21, 2016, 7 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 54922: Improve and Fix "Dashboard page" after new guidelines

2016-12-21 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54922/#review159847 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Dec. 21,

Re: Review Request 54891: Create quick links profile evaluator

2016-12-21 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/ --- (Updated Dec. 21, 2016, 6:43 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/#review159842 --- Fix it, then Ship it! Why do we need default values in both

Re: Review Request 54942: AMBARI-19272. Ignored mount points logged for each mount

2016-12-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54942/#review159845 --- Ship it! Ship It! - Sebastian Toader On Dec. 21, 2016, 5:52

Re: Review Request 54817: AMBARI-19227 :: Provide support to show Ranger solr-configs in Ambari.

2016-12-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54817/#review159844 --- Ship it! Ship It! 1 note: is it okay to add to the

Re: Review Request 54822: AMBARI-19228 :: Knox doesn't redirect to Atlas after entering correct credentials.

2016-12-21 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54822/#review159843 --- Ship it! Ship It! - Oliver Szabo On Dec. 20, 2016, 2:21

Re: Review Request 54891: Create quick links profile evaluator

2016-12-21 Thread Balázs Bence Sári
> On Dec. 20, 2016, 2:49 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java, > > line 149 > > > > > >

Re: Review Request 54822: AMBARI-19228 :: Knox doesn't redirect to Atlas after entering correct credentials.

2016-12-21 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54822/#review159840 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 20, 2016,

Re: Review Request 54935: ulimit override missing from upgrade catalogs

2016-12-21 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54935/#review159837 --- Ship it!

Re: Review Request 54935: ulimit override missing from upgrade catalogs

2016-12-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54935/ --- (Updated Дек. 21, 2016, 4:55 п.п.) Review request for Ambari, Sumit Mohanty,

Review Request 54942: AMBARI-19272. Ignored mount points logged for each mount

2016-12-21 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54942/ --- Review request for Ambari, Balázs Bence Sári, Dmytro Grinenko, Laszlo Puskas,

Re: Review Request 54936: Zookeeper and RM connection is not secure

2016-12-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54936/#review159832 ---

Review Request 54936: Zookeeper and RM connection is not secure

2016-12-21 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54936/ --- Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene

Re: Review Request 54935: ulimit override missing from upgrade catalogs

2016-12-21 Thread Dmytro Sen
> On Дек. 21, 2016, 4:24 п.п., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 30 > > > > > > unused import The patch was initially

Re: Review Request 54939: AMBARI-19270. Log successful agent cache update at info level

2016-12-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54939/#review159827 --- Ship it! Ship It! - Sebastian Toader On Dec. 21, 2016, 4:42

Re: Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory

2016-12-21 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/#review159822 --- Ship it! Ship It! - Rohit Choudhary On Dec. 21, 2016, 11:05

Re: Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory

2016-12-21 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/#review159821 --- Ship it! Ship It! - Prabhjyot Singh On Dec. 21, 2016, 11:05

Re: Review Request 54939: AMBARI-19270. Log successful agent cache update at info level

2016-12-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54939/#review159818 --- ambari-agent/src/main/python/ambari_agent/FileCache.py (line

Review Request 54939: AMBARI-19270. Log successful agent cache update at info level

2016-12-21 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54939/ --- Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian

Re: Review Request 54938: Update Zeppelin version in service def to 0.6.2 instead of 0.7.0

2016-12-21 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54938/#review159817 --- Ship it! Ship It! - Rohit Choudhary On Dec. 21, 2016, 3:35

Re: Review Request 54938: Update Zeppelin version in service def to 0.6.2 instead of 0.7.0

2016-12-21 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54938/#review159815 --- Ship it! Ship It! - Prabhjyot Singh On Dec. 21, 2016, 3:35

Review Request 54938: Update Zeppelin version in service def to 0.6.2 instead of 0.7.0

2016-12-21 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54938/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Re: Review Request 54861: 'Cluster User' role issue after Ambari 2.4.2.0 upgrade

2016-12-21 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54861/#review159814 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 21, 2016,

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/#review159811 --- Ship it! Ship It! - Robert Levas On Dec. 21, 2016, 8:05

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/#review159809 --- Ship it! Ship It! - Sebastian Toader On Dec. 21, 2016, 2:05

Review Request 54935: ulimit override missing from upgrade catalogs

2016-12-21 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54935/ --- Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.

Re: Review Request 54934: NN HA Namespace input "jumps" when invalid value provided

2016-12-21 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54934/#review159808 --- Ship it! Ship It! - Aleksandr Kovalenko On Дек. 21, 2016,

Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

2016-12-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/#review159806 --- Ship it! Ship It! - Di Li On Dec. 20, 2016, 8:53 p.m.,

Review Request 54934: NN HA Namespace input "jumps" when invalid value provided

2016-12-21 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54934/ --- Review request for Ambari, Aleksandr Kovalenko, Alexandr Antonenko, and Andrii

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/ --- (Updated Dec. 21, 2016, 1:05 p.m.) Review request for Ambari, Attila

Re: Review Request 54861: 'Cluster User' role issue after Ambari 2.4.2.0 upgrade

2016-12-21 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54861/ --- (Updated Dec. 21, 2016, 1:02 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/ --- (Updated Dec. 21, 2016, 12:57 p.m.) Review request for Ambari, Robert Levas

Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54933/ --- Review request for Ambari, Robert Levas and Sebastian Toader. Bugs:

Review Request 54932: Zeppelin fails to install when hive-site.xml does not exist in spark conf directory

2016-12-21 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54932/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Re: Review Request 54895: AMBARI-19256:Asset support Rest API

2016-12-21 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54895/ --- (Updated Dec. 21, 2016, 8:57 a.m.) Review request for Ambari, Gaurav Nagar,

Re: Review Request 54857: Refactor Ambari service def configurations for Zeppelin

2016-12-21 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54857/#review159793 --- Ship it! Ship It! - Prabhjyot Singh On Dec. 19, 2016, 9:59

Re: Review Request 54930: Remove Spark dependency from Zeppelin service def

2016-12-21 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54930/#review159791 --- Ship it! Ship It! - Prabhjyot Singh On Dec. 21, 2016, 7:28