/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
Thanks
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/#review136089
---
On June 3, 2016, 4:54 p.m., T
(line 434)
<https://reviews.apache.org/r/48229/#comment201268>
This is really the advisor not the method.
- Tim Thorpe
On June 5, 2016, 10:18 p.m., Lav Jain wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48234/#review136238
---
Ship it!
Ship It!
- Tim Thorpe
On June 3, 2016, 10:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48229/#review136343
---
Ship it!
Ship It!
- Tim Thorpe
On June 6, 2016, 6:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48561/#review137066
---
Ship it!
Ship It!
- Tim Thorpe
On June 10, 2016, 6:13 p.m
/server/stack/StackManagerExtensionTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
/StackManagerExtensionTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
/StackManagerMiscTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/#review136105
-------
On June 14, 2016, 7:05 p.m., Tim Thorpe wrote:
>
> -
/StackManagerMiscTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
/server/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
-------
On May 20, 2016, 7:03 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47656/
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47858/#review135049
---
Ship it!
Ship It!
- Tim Thorpe
On May 26, 2016, 6:50 p.m
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47858/#review135294
---
Ship it!
Ship It!
- Tim Thorpe
On May 27, 2016, 7:11 p.m
/stack/StackManagerMiscTest.java
src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
src/test/java/org/apache/ambari/server/stack/ThemeModuleTest.java
Thanks,
Tim Thorpe
s
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47656/#review137828
---
On June 20, 2016, 4:18 p.m., Tim Tho
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48805/#review138056
---
Ship it!
Ship It!
- Tim Thorpe
On June 16, 2016, 5:47 p.m
.
> +1 on allowing add-on/custom service to extend stack upgrade packs
> instead of breaking down the entire upgrade pack to service level.
>
> Tim Thorpe wrote:
> We decided we wouldn't split the upgrade xml into pieces for all the
> stack services. Instead the goal will
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review121687
-------
On April 12, 2016, 5:33 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-
; Could this inheritate a brand new DefaultServiceAdvisor instead of the
> > stack advisor? service and stack are different hierarchy and I feel somehow
> > wrong if a service inheritate a stack.
>
> Tim Thorpe wrote:
> Point well taken. I'll look at refactoring it that way b
ervice advisors to be plugged in, there will be no dependence of BIGTOP to HDP.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review127148
--------
.0.0's metainfo.xml under HDP 2.3 stack, and say
> > that it extends from common-services, will this service_advisor be honored?
>
> Tim Thorpe wrote:
> I had some difficulty with HAWQ and PXF because they are not actually in
> the stack and can be added by installing
es from the default stack advisor
and live with the fact that a service is inheriting from the stack.
(See one of the comments above by Jun Aoki)
- Tim
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.
://reviews.apache.org/r/44210/diff/
Testing (updated)
---
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
; Could this inheritate a brand new DefaultServiceAdvisor instead of the
> > stack advisor? service and stack are different hierarchy and I feel somehow
> > wrong if a service inheritate a stack.
>
> Tim Thorpe wrote:
> Point well taken. I'll look at refactoring it that way b
_CHECK-SERVICE_CHECK", "YARN_SERVICE_CHECK-SERVICE_CHECK",
> "PXF_SERVICE_CHECK-SERVICE_CHECK"]
> }
> }
>
> Checked ambari-server.log, it does not show that this RCO is loaded but
> shows the others under /var/lib/ambari-server/resource
ted e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review124850
-------
On March 22, 2016, 6:18 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically
to the JIRA. Not
sure how to create a review board with a design doc instead of a patch file.
Thanks,
Tim Thorpe
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review125862
-----------
On March 22, 2016, 6:40 p.m., Tim Thorpe wrote:
>
> ---
> This is an aut
ply, visit:
https://reviews.apache.org/r/44210/#review130141
-----------
On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail
l we:
> - rely on stack inheritance ?
> - rely on SA inheritance within MYSERVICE ?
> - combination of these ?
>
> Tim Thorpe wrote:
> There will be no implicit inheritance. If you want to use inheritance
> you can but it will be left up to the service to h
eviews.apache.org/r/44210/#review130191
-------
On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To re
failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
t and create an instance.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130131
---
On April 22,
t:
https://reviews.apache.org/r/44210/#review130126
-------
On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e
we can make this work without adding new properties to
> > stack-service resource.
see my comment above.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#r
---
On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
> --
rated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130138
-------
On April 22, 2016, 4:39 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44210/
on as e:
traceback.print_exc()
print "Failed to load parent"
class
HDP23MAPREDUCE2ServiceAdvisor(service_advisor.HDP22MAPREDUCE2ServiceAdvisor):
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130141
ome additional logic for HAWQ mentioned in
> > recommendHDFSConfigurations:
> > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py#L368-#L370
> >
> >
> > I believe this would still work from the HDP 2.
s in the extra parameter(s), modify
the stacks/service_advisor.py to accept the extra parameter(s) and then modify
your service_advisor.py file(s) as well.
- Tim
---
This is an automatically generated e-mail. To
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131002
-----------
On April 28, 2016, 4:36 p.m., Tim Thorpe wrote:
>
> ---
> This is an aut
d e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review130191
-------
On April 22, 2016, 6:27 p.m., Tim Thorpe wrote:
>
> ---
> This is an a
views.apache.org/r/44210/diff/
Testing
---
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
to HDP2.3 stack, if any.
> >
> > This is the argument about inheritance between advisors of different
> > versions of service and stack.
>
> Tim Thorpe wrote:
> I debated about this but I don't see what you really gain by allowing the
> advisor n
java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
t; >
> > I am thinking this can work without adding these 2 properties to a
> > stack-service.
>
> Tim Thorpe wrote:
> The reason this works for the stack is because the stack_advisor.py in
> the scripts directory attempts to load all the stack_advisor.py
is mostly for the design doc which is attached to the JIRA. Not
sure how to create a review board with a design doc instead of a patch file.
Thanks,
Tim Thorpe
MY_MASTER_2
>
>
>
> Alterative
>
>
> CORE_MASTERS
>
> MY_MASTER_1
>
>
>
>
>
> CORE_MASTERS
>
> MY_SERVI
sting
> ---
>
> Manual testing so far. I have the code read the upgrade xml and all of its
> service specific xml files, built the upgrade pack and then write the full
> upgrade xml to disk and then compare the results to the original upgrade xml.
>
> This review is mostly for the design doc which is attached to the JIRA. Not
> sure how to create a review board with a design doc instead of a patch file.
>
>
> Thanks,
>
> Tim Thorpe
>
>
them, either the name or the title.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133587
-------
--------
On May 16, 2016, 6:50 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> -
.xml
is parsed. But I added the extra check just in case.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133587
-------
method from the Grouping class.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133533
-------
On May 16, 2016, 6:50 p.m., Tim Thorpe wrote:
>
> -
ault
behavior like what was happening before with mergeRegularGrouping.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133556
-------
the upgrade pack and then write the full
upgrade xml to disk and then compare the results to the original upgrade xml.
This review is mostly for the design doc which is attached to the JIRA. Not
sure how to create a review board with a design doc instead of a patch file.
Thanks,
Tim Thorpe
.
This review is mostly for the design doc which is attached to the JIRA. Not
sure how to create a review board with a design doc instead of a patch file.
Thanks,
Tim Thorpe
throw here or just log it and continue; ?
>
> Tim Thorpe wrote:
> When the StackManager encounters errors while reading the stack, it
> almost always ends up throwing an exception and ambari-server fails to start.
> I'm ok with just logging the issue for this and other erro
to the original upgrade xml.
This review is mostly for the design doc which is attached to the JIRA. Not
sure how to create a review board with a design doc instead of a patch file.
Thanks,
Tim Thorpe
://reviews.apache.org/r/44210/diff/
Testing
---
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote:
> > Do we have a branch cut with these changes in so that we can test HAWQ and
> > PXF with this new logic ? After testing the branch can be merged to trunk
> > and we will avoid any major surprises.
: https://reviews.apache.org/r/44210/diff/
Testing
---
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
---
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131747
---
On May 5, 2016, 2:50 p.m., Tim Thorpe wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47138/#review132419
---
Ship it!
Ship It!
- Tim Thorpe
On May 9, 2016, 11:43 p.m
dvisor,
self).getComponentLayoutValidations(services, hosts)
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131409
-----------
iff: https://reviews.apache.org/r/44210/diff/
Testing
---
Ran all the non java unit tests.
Total run:945
Total errors:0
Total failures:0
Manually configured HAWQ and PXF as part of the HDP 2.3 stack and made sure
their service advisors were called.
Thanks,
Tim Thorpe
00ServiceAdvisor is defined under commmon-services. I'd like to
> > override the method getComponentLayoutScheme with some new logic for HDP
> > 2.3 stack. Followed the documentation in
> > ambari-server/src/main/resources/stacks/service_advisor.py but it did not
> > w
flict
because all the files are called service_advisor.py.
- Tim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44210/#review131579
----------
onding method in
> > 2.0.6 stack advisor is overriding it.
>
> Tim Thorpe wrote:
> Hi Lav, I don't see the 2.0.6 stack advisor overriding this method (def
> validateComponentLayout). It does override the method
> getComponentLayoutValidations which gets called by valida
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50392/#review143377
---
Ship it!
Ship It!
- Tim Thorpe
On July 25, 2016, 12:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50350/#review143541
---
Ship it!
Ship It!
- Tim Thorpe
On July 26, 2016, 1:22 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50539/#review143873
---
Ship it!
Ship It!
- Tim Thorpe
On July 27, 2016, 11:06 p.m
/serveraction/upgrades/ConfigureAction.java
(line 243)
<https://reviews.apache.org/r/50539/#comment209827>
Spelling error "finnd"
- Tim Thorpe
On July 27, 2016, 11:06 p.m., Alejandro Fernandez wrote:
>
> ---
> This is a
be done in a separate script to allow it to be used when adding
extension-definitions or stack-addon-service-definitions management packs.
- Tim Thorpe
On July 18, 2016, 8:51 p.m., Lav Jain wrote:
>
> ---
> This is an automatically ge
://reviews.apache.org/r/50237/diff/
Testing
---
mvn clean test
mvnpackage
Thanks,
Tim Thorpe
/my-extension-1.0.0.0.tar.gz -v
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49521/#review140754
---
Ship it!
Ship It!
- Tim Thorpe
On July 4, 2016, 12:33 a.m
-mpack --mpack=/root/mpacks/myextension-1.0.0.0.tar.gz -v
Thanks,
Tim Thorpe
-DskipSurefireTests
No errors related to the mpack tests
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49861/#review141670
---
Ship it!
Ship It!
- Tim Thorpe
On July 9, 2016, 9:22 p.m
install-mpack
--mpack=/root/mpacks/myservice2-ambari-mpack-1.0.0.0.tar.gz -v
ambari-server install-mpack --mpack=/root/mpacks/myextension-1.0.0.0.tar.gz -v
Thanks,
Tim Thorpe
/myservice2-ambari-mpack-1.0.0.0.tar.gz -v
ambari-server install-mpack --mpack=/root/mpacks/myextension-1.0.0.0.tar.gz -v
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55848/#review163121
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 25, 2017, 9:36 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55960/#review163122
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 25, 2017, 9:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55774/#review162651
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 20, 2017, 4:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55848/#review162654
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 23, 2017, 4:51 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55847/#review162667
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 23, 2017, 6:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55584/#review161763
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 16, 2017, 6:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55720/#review162298
---
Ship it!
Ship It!
- Tim Thorpe
On Jan. 19, 2017, 3:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57146/#review167101
---
Ship it!
Ship It!
- Tim Thorpe
On Feb. 28, 2017, 1:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51604/#review147668
---
Ship it!
Ship It!
- Tim Thorpe
On Sept. 2, 2016, 3:26 p.m
/StackModule.java
(line 1129)
<https://reviews.apache.org/r/51238/#comment215353>
This won't include extension services. You would need to loop through all
the ServiceInfo objects and check to see if they have repos.
- Tim Thorpe
On Sept. 5, 2016, 1:26 p.m., Balázs Bence Sári
/RepoUtil.java (line
138)
<https://reviews.apache.org/r/51238/#comment214750>
The Optional class is only in JDK8. Currently Ambari is supposed to work
with both JDK7 and 8.
- Tim Thorpe
On Aug. 26, 2016, 9:25 a.m., Balázs Bence Sári
> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote:
> > I was under the impression that applying an m-pack would DIRECTLY update
> > repoinfo.xml on the filesystem. Has the design changed since then?
> >
> > What is the purpose of carrying service version around with the repo? When
> > updating
Total failures:0
Thanks,
Tim Thorpe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51747/#review148265
---
Ship it!
Ship It!
- Tim Thorpe
On Sept. 8, 2016, 9:11 p.m
/
Testing
---
None, this is a documentation defect.
Thanks,
Tim Thorpe
1 - 100 of 276 matches
Mail list logo
