/diff/
Testing
---
Added unit test. Local ambari-web test passed.
24557 tests complete (21 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
--------
On March 8, 2016, 6:33 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44413/
>
/diff/
Testing
---
Added unit test. Local ambari-web test passed.
24557 tests complete (21 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
. Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
test. Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/controllers/main/host_test.js 06a4813
Diff: https://reviews.apache.org/r/44487/diff/
Testing (updated)
---
Modified unit test. Local ambari-web test passed.
24557 tests complete (21 seconds)
146 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
ambari-web/app/views/main/host/combo_search_box.js 3ccacf2
Diff: https://reviews.apache.org/r/44598/diff/
Testing
---
Local ambari-web test passed.
24565 tests complete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
mplete (21 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
ontrollers/experimental.js 9fa6da5
ambari-web/app/messages.js dc9c264
ambari-web/app/templates/experimental.hbs 2873679
Diff: https://reviews.apache.org/r/44880/diff/
Testing
---
Local ambari-web test passed.
24578 tests complete (23 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
ponents in the list. But adding NFS_GATEWAY to this list may
cause problem.
- Zhe (Joe) Wang
On March 18, 2016, 9:46 p.m., Di Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
i-web test passed.
24578 tests complete (23 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
i-web test passed.
24578 tests complete (23 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45054/#review124333
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On March 18, 2016, 9:46
i-web test passed.
24578 tests complete (23 seconds)
145 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
passed.
10488 tests complete (10 seconds)
121 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/45187/diff/
Testing
---
Local ambari-web test passed.
10488 tests complete (10 seconds)
121 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
any add hosts/RM HA/others.
Diffs (updated)
-
ambari-web/app/messages.js b4ca9b0
Diff: https://reviews.apache.org/r/45187/diff/
Testing
---
Local ambari-web test passed.
10488 tests complete (10 seconds)
121 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
l testing done.
Thanks,
Zhe (Joe) Wang
passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
lerts/alert_definition.js a730572
ambari-web/app/templates/main/alerts/configs.hbs dff1b53
Diff: https://reviews.apache.org/r/45593/diff/
Testing
---
Local ambari-web test passed.
25602 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45609/#review126667
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 1, 2016, 10:40
alerts/alert_instance/status.hbs d82bc7b
ambari-web/app/templates/main/alerts/definition_details.hbs 14b749d
ambari-web/app/views/main/alerts/definition_details_view.js 2fc75c1
Diff: https://reviews.apache.org/r/45612/diff/
Testing
---
Local ambari-web test passed.
25602 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
roller.js
dc9f78c
ambari-web/app/messages.js 1b2a02f
ambari-web/app/styles/application.less a6b79ce
ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65
Diff: https://reviews.apache.org/r/45692/diff/
Testing
-------
Local ambari-web test passed.
25600 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
bari-web test passed.
25602 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
sit:
https://reviews.apache.org/r/45692/#review126935
---------------
On April 4, 2016, 5:58 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated
bari-web test passed.
25602 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/main/alerts/alert_definitions_actions_controller.js
dc9f78c
ambari-web/app/messages.js 1b2a02f
ambari-web/app/styles/application.less a6b79ce
ambari-web/app/templates/common/modal_popups/prompt_popup.hbs 078cc65
Diff: https://reviews.apache.org/r/45692/diff/
Testing
-------
Local ambari-web test passed.
25600 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45710/#review126958
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 4, 2016, 10:14
/definition_details_view.js 2fc75c1
ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b
Diff: https://reviews.apache.org/r/45462/diff/
Testing
---
Local ambari-web test passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/definition_details_view.js 656021c
ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b
Diff: https://reviews.apache.org/r/45462/diff/
Testing
---
Local ambari-web test passed.
25642 tests complete (22 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
://reviews.apache.org/r/45774/diff/
Testing
---
Local ambari-web test passed.
25609 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/ 0.299 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
org/r/45781/#review127321
---
On April 5, 2016, 10:50 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45791/#review127374
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 6, 2016, 1:20
tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
c209fcc
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js
4ba0fc1
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
39fabf6
Diff: https://reviews.apache.org/r/45903/diff/
Testing
---
ambari-admin:
Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
ackVersionsCreateCtrl.js
6feeeac
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
c209fcc
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js
4ba0fc1
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
39fabf6
Diff: https://reviews.apache.org/r/45903/diff/
Testing
---
ambari-admin:
Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
ackVersionsCreateCtrl.js
6feeeac
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
c209fcc
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js
4ba0fc1
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
39fabf6
Diff: https://reviews.apache.org/r/45903/diff/
Testing
---
ambari-admin:
Executed 64 of 64 SUCCESS (0.048 secs / 0.299 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
urces/alerts.json 3b6ebbb
Diff: https://reviews.apache.org/r/45974/diff/
Testing
---
Thanks,
Zhe (Joe) Wang
Diffs (updated)
-
ambari-server/src/main/resources/alerts.json 3b6ebbb
Diff: https://reviews.apache.org/r/45974/diff/
Testing
---
Thanks,
Zhe (Joe) Wang
Diffs
-
ambari-server/src/main/resources/alerts.json 3b6ebbb
Diff: https://reviews.apache.org/r/45974/diff/
Testing (updated)
---
All alert unit test passed.
mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
Thanks,
Zhe (Joe) Wang
tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45792/#review128528
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 8, 2016, 2:39
7b55545
Diff: https://reviews.apache.org/r/46128/diff/
Testing
---
Local ambari-web test passed.
25614 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/
Testing
---
Modified unit tests.
Local ambari-web test passed.
25683 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Diff: https://reviews.apache.org/r/46226/diff/
Testing
---
Modified unit tests.
Local ambari-web test passed.
25683 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
alert unit test passed.
mvn clean test -Dtest=Alert* -Drat.ignoreErrors -DfailIfNoTests=false
ambari-web:
All UT passed
Manual testing done.
Thanks,
Zhe (Joe) Wang
4259be8
ambari-web/app/templates/main/alerts/definition_details.hbs 15cf168
Diff: https://reviews.apache.org/r/46338/diff/
Testing
---
Local ambari-web test passed.
25681 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
odified unit test.
Local ambari-web test passed.
25680 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46408/#review129622
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 19, 2016, 9:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45792/#review129802
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 20, 2016, 8:30
sion.js e02999f
ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs
35677ab
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js
88bfec2
ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js
00d7ce8
Diff: https://reviews.apache.org/r/46460/diff/
Testing
---
Modified unit test.
Local ambari-web test passed.
25660 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46467/#review129920
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 21, 2016, 1:13
b/app/controllers/wizard.js 52fb241
ambari-web/app/mixins/wizard/assign_master_components.js e4c5295
Diff: https://reviews.apache.org/r/46405/diff/
Testing
---
Modified unit test.
Local ambari-web test passed.
25680 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
o reply, visit:
https://reviews.apache.org/r/46405/#review130109
-----------
On April 21, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automaticall
value.
- Zhe (Joe)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46405/#review130129
---
On April 21, 2016, 6:50 p.m.,
> On April 22, 2016, 5:30 p.m., Alexandr Antonenko wrote:
> > if we will ask BE and create task for them, this will mean move this out of
> > 2.4. As BE is pretty heavy loaded with tasks
>
> Zhe (Joe) Wang wrote:
> Agree. That's why I use FE to set the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46648/#review130475
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 25, 2016, 5:50
> On April 25, 2016, 5:51 p.m., Zhe (Joe) Wang wrote:
> > Ship It!
Works as FE expects.
- Zhe (Joe)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46648/#rev
g
ambari-admin:
Executed 64 of 64 SUCCESS (0.086 secs / 0.308 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46651/#review130499
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On April 25, 2016, 6:39
done.
Thanks,
Zhe (Joe) Wang
ambari-web/app/models/stack_version/repository_version.js e02999f
ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs
35677ab
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js
88bfec2
ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js
00d7ce8
Diff: https://reviews.apache.org/r/46460/diff/
Testing
---
Modified unit test.
Local ambari-web test passed.
25660 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
ri-web/app/templates/wizard/step1.hbs 0476580
ambari-web/app/utils/ajax/ajax.js 83914a7
ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js
168e8db
Diff: https://reviews.apache.org/r/46460/diff/
Testing
---
Modified unit test.
Local ambari-web test passed.
25660 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
. To reply, visit:
https://reviews.apache.org/r/46460/#review131215
---------------
On April 29, 2016, 11:12 p.m., Zhe (Joe) Wang wrote:
>
> ---
> This is an automatic
gt; > stack.use_redhat_satellite =
> > !item.operating_systems[0].OperatingSystems.ambari_managed_repositories;
> >
> > Logiclly it's the same but this way it's just more readable.
>
> Zhe (Joe) Wang wrote:
> The reason I wrote it that is:
> if item.op
223376b
ambari-web/app/mappers/component_config_mapper.js 8ff3416
Diff: https://reviews.apache.org/r/46861/diff/
Testing
---
Local ambari-web test passed.
27451 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
pending
ambari-admin:
Executed 64 of 64 SUCCESS (0.115 secs / 0.335 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46953/#review131597
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 4, 2016, 12:36
tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46987/#review131734
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 4, 2016, 5:52 p.m
only see
"jdbc:hive2://c6402".
- Zhe (Joe) Wang
On May 4, 2016, 5:52 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On May 4, 2016, 8:04 p.m., Zhe (Joe) Wang wrote:
> > The width of the field for this string seems be too small. I can only see
> > "jdbc:hive2://c6402".
>
> Jaimin Jetly wrote:
> Thats intentional as the string can be long depending upon zookeeper
/step1_controller.js dc95a45
ambari-web/app/routes/installer.js f280049
Diff: https://reviews.apache.org/r/46998/diff/
Testing
---
Local ambari-web test passed.
27529 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
/
Testing
---
Modified unit test.
Local ambari-web test passed.
27718 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47079/#review132112
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 6, 2016, 10:34
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47139/#review132348
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 9, 2016, 11:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47152/#review132364
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 10, 2016, 1:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47206/#review132589
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 11, 2016, 12:30
---
ambari-web:
27794 tests complete (24 seconds)
154 tests pending
ambari-admin:
Executed 64 of 64 SUCCESS (0.325 secs / 0.323 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47422/#review133434
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 16, 2016, 7:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47439/#review133575
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 17, 2016, 12:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47508/#review133698
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 18, 2016, 1:31
t; + vdf_version"
Diffs
-
ambari-web/app/controllers/installer.js 421f2dc
ambari-web/app/mappers/stack_mapper.js 473c466
Diff: https://reviews.apache.org/r/47513/diff/
Testing
---
Local ambari-web test passed.
27819 tests complete (23 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
(24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
test passed.
27819 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
Diffs
-
ambari-web/app/controllers/main/alerts/definition_configs_controller.js
617f7cc
Diff: https://reviews.apache.org/r/47523/diff/
Testing
---
Local ambari-web test passed.
27819 tests complete (24 seconds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
onds)
154 tests pending
Manual testing done.
Thanks,
Zhe (Joe) Wang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47751/#review134607
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 24, 2016, 2:18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47920/#review135128
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 26, 2016, 10:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47993/#review135348
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On May 27, 2016, 11:14
ces/ui/admin-web/app/scripts/services/AddVersionModal.js
0af7004
Diff: https://reviews.apache.org/r/48089/diff/
Testing
---
ambari-admin:
Executed 71 of 71 SUCCESS (0.13 secs / 0.35 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
,
Zhe (Joe) Wang
/assign_master_controller.js (line 161)
<https://reviews.apache.org/r/48156/#comment200891>
Typo?
- Zhe (Joe) Wang
On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
/assign_master_controller_test.js (line
152)
<https://reviews.apache.org/r/48156/#comment200892>
Typo?
- Zhe (Joe) Wang
On June 1, 2016, 9:36 p.m., Jaimin Jetly wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48156/#review135880
---
Ship it!
Ship It!
- Zhe (Joe) Wang
On June 1, 2016, 9:36
1 - 100 of 191 matches
Mail list logo