---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63282/#review189150
---
Ship it!
Ship It!
- Bill Farner
On Oct. 24, 2017, 5:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63236/#review189152
---
Ship it!
- Bill Farner
On Oct. 24, 2017, 12:10 a.m., Jordan
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62869/#review189062
---
On Oct. 18, 2017, 11:11 a.m., Bill Farner wrote:
>
> -
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote:
> > ```
> > /bin/sh: cmake: command not found
> > ```
> >
> > But now i need to install cmake, so i'm not sure this pays off.
>
> Bill Farner wrote:
> (this = the switch to cmake)
>
>
secondary benefit of simplifying testing with mocks by
removing the call to `listen()`.
- Bill Farner
On Oct. 25, 2017, 8:14 p.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63316/#review189482
---
Ship it!
Ship It!
- Bill Farner
On Oct. 27, 2017, 2:13 p.m
ns()`. The test now reads as "test that clearing
a cache clears the cache". I suggest removing the test case.
- Bill Farner
On Oct. 20, 2017, 10:53 p.m., Jordan Ly wrote:
>
> ---
> This is an a
n/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java
e93c4fa15a7cc1b025dcb0f29319bc774c62e2c9
src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java
51d0371007564bc0af32e256dbae8b57113536c2
Diff: https://reviews.apache.org/r/63383/diff/1/
Testing
---
Thanks,
Bill Farner
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63383/#review189497
-------
On Oct. 27, 2017, 4:46 p.m., Bill Farner wrote:
>
>
,
Bill Farner
/apache/aurora/scheduler/http/LeaderRedirectTest.java
a7cc046d97d7b817a5496a6a7190142375b7a8a1
Diff: https://reviews.apache.org/r/63418/diff/1/
Testing
---
Thanks,
Bill Farner
/LeaderRedirect.java
Line 88 (original), 88 (patched)
<https://reviews.apache.org/r/63418/#comment266778>
I've removed some superfluous field validation here (and an accompanying
test case). These checks are redundant to what is performed in
`Encoding#decode()`.
- Bill Farner
On Oct. 30, 201
ead and buried the field to effectively hard-code it.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63418/#review189621
------
> On Oct. 27, 2017, 3:03 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java
> > Lines 42-43 (patched)
> > <https://reviews.apache.org/r/63199/diff/4/?file=1865171#file1865171line42>
> >
> > How abo
`OfferSettings` as the finishing
touch. Nice patch!
- Bill Farner
On Oct. 30, 2017, 11:14 a.m., Jordan Ly wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
list item.
src/main/python/apache/aurora/executor/aurora_executor.py
Line 98 (original), 98 (patched)
<https://reviews.apache.org/r/63435/#comment266873>
Bonus points for an `Awaiting task health checks` message when applicable.
- Bill Farner
On Oct. 30, 2017, 4:43 p.m., Stephan Erb
ops/s
```
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63443/#review189866
---
Ship it!
Ship It!
- Bill Farner
On Oct. 31, 2017, 9:17 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63521/#review189940
---
Ship it!
Ship It!
- Bill Farner
On Nov. 2, 2017, 11:12 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63564/#review190110
---
Ship it!
Ship It!
- Bill Farner
On Nov. 5, 2017, 2:42 p.m
/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java
PRE-CREATION
src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java
PRE-CREATION
Diff: https://reviews.apache.org/r/63670/diff/1/
Testing
---
Thanks,
Bill Farner
nge to:
```
.put("/(?:index.html)?", "/assets/scheduler/index.html")
```
This should serve the scheduler UI when accessing `/` or `/index.html`.
- Bill Farner
On Nov. 8, 2017, 2:32 p.m., Stephan Erb wrote:
>
>
pdated Nov. 8, 2017, 4:48 p.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Bill
> Farner.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> This is my prototype code for adding partition-awareness to Aurora. T
rc0 has been cut, the
`CHANGELOG` needs an update in this patch. If we go to rc1, i think we should
pull this change in.
- Bill Farner
On Nov. 2, 2017, 5:03 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e
> On Sept. 26, 2017, 4:53 p.m., Bill Farner wrote:
> > ```
> > /bin/sh: cmake: command not found
> > ```
> >
> > But now i need to install cmake, so i'm not sure this pays off.
>
> Bill Farner wrote:
> (this = the switch to cmake)
>
>
ps://reviews.apache.org/r/63670/#review190462
-------
On Nov. 8, 2017, 8:13 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail.
bound the number of events
stored for a task.
src/main/java/org/apache/aurora/scheduler/state/StateModule.java
Lines 70 (patched)
<https://reviews.apache.org/r/63536/#comment268115>
PubsubEventModule.bindSubscriber(bind
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63705/#review190626
---
Ship it!
Ship It!
- Bill Farner
On Nov. 9, 2017, 10:42 a.m
> On Nov. 9, 2017, 9:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java
> > Lines 76 (patched)
> > <https://reviews.apache.org/r/63536/diff/2/?file=1885207#file1885207line76>
> >
> > Thinking
> On Nov. 9, 2017, 9:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/state/PartitionManager.java
> > Lines 76 (patched)
> > <https://reviews.apache.org/r/63536/diff/2/?file=1885207#file1885207line76>
> >
> > Thinking
/MemCronJobStoreTest.java
66b415cc395d09b15b977d0c54be94dd907a8485
src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java
9e75c98dfd5fcb949cd8a3ff2030892ac3b17180
Diff: https://reviews.apache.org/r/63743/diff/1/
Testing
---
Thanks,
Bill Farner
fixed.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63743/#review190776
---
On Nov. 10, 2017, 8:53 p.m., Bill Farner wrote:
>
> ---
1691477e8995756580162c460a82d20b82140c2d
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
4d62bba3eb64be4493dc80a1cee93159a4828c12
Diff: https://reviews.apache.org/r/63744/diff/1/
Testing
---
Thanks,
Bill Farner
---
On Sept. 26, 2017, 1:50 p.m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62590/
> ---
>
> (Updated Sept. 26, 2017, 1:50 p
re complex.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63743/#review190785
---
On Nov. 10, 2017, 8:53 p.m
-pycharm-virtualenv
0f422d6baed6ce0dd77ba3b148d6ae3887028f9d
src/test/python/apache/thermos/monitoring/test_disk.py
e57467c61d94d67e6cf6b766c062588235b4b235
Diff: https://reviews.apache.org/r/63746/diff/1/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63746/#review190798
---
@ReviewBot retry
- Bill Farner
On Nov. 12, 2017, 12:14 p.m
: Could not satisfy all requirements for mesos.executor==1.4.0:
mesos.executor==1.4.0
```
pants.ini
Lines 33-36 (original), 33-36 (patched)
<https://reviews.apache.org/r/63750/#comment268413>
You can now remove this workaround.
- Bill Farner
On Nov. 13, 2017, 4:29 a.m., se choi
`WebhookTest.testTaskChangedWithOldStateError`. I don't
reproduce this locally after a few tries, but it's beginning to look like a
flaky test.
- Bill Farner
On Nov. 12, 2017, 12:14 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generat
2906b08deba08f9f22bd78c8f83a78409114a913
Diff: https://reviews.apache.org/r/63760/diff/1/
Testing
---
Thanks,
Bill Farner
. Running again to hopefully
narrow in on flaky vs persistent failure.
- Bill Farner
On Nov. 13, 2017, 8:32 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/MesosCallbackHandlerTest.java
Line 335 (original), 337 (patched)
<https://reviews.apache.org/r/63763/#comment268440>
Can we get away with `MoreExecutors.directExecutor()` instead?
- Bill Farner
On Nov. 13, 2017, 11:32 a.m., Jordan Ly
, not sure why the bot tried to use it again.
- Bill Farner
On Nov. 11, 2017, 5:42 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On Nov. 13, 2017, 1:43 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java
> > Line 335 (original), 337 (patched)
> > <https://reviews.apache.org/r/63763/diff/1/?file=1890883#file1890883line339>
>
> On Nov. 13, 2017, 8:05 a.m., Bill Farner wrote:
> > Stephan - FYI, i reproduce the build error:
> > ```
> > Exception message: Could not satisfy all requirements for
> > mesos.executor==1.4.0:
> > mesos.executor==1.4.0
> > ```
>
> Stephan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63763/#review191024
---
Ship it!
Ship It!
- Bill Farner
On Nov. 13, 2017, 3:58 p.m
ra/scheduler/updater/JobUpdaterIT.java
661ce58a840e5a23ff5438517880877cd90d0537
Diff: https://reviews.apache.org/r/63884/diff/1/
Testing
-------
Thanks,
Bill Farner
llerImpl`.
src/test/java/org/apache/aurora/scheduler/storage/AbstractJobUpdateStoreTest.java
Lines 451 (patched)
<https://reviews.apache.org/r/63884/#comment268869>
Whoops, i need to finish this. Coming in an updated draft.
- Bill Farner
On Nov. 16, 2017, 10:20 a.m., Bill Farner wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63750/#review191018
-------
On Nov. 14, 2017, 3:51 p.m., se choi wrote:
>
> -
Please phrase this check as:
```java
assertEquals(
ImmutableList.of(PENDING, ASSIGNED, ...),
updatedTask.getTaskEvents().stream()
.map(e -> e.getStatus())
.collect(Collectors.toList()));
```
This will give greater confidenc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#review191580
---
Ping
- Bill Farner
On Nov. 16, 2017, 10:20 a.m., Bill Farner
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63973/
> ---
>
> (Updated Nov. 20, 2017, 7:40 p.m.)
>
>
> Review request
3973/#comment269498>
I suggest removing this customization. `OfferRanker` seems like a much
more reasonable level of abstraction.
- Bill Farner
On Nov. 20, 2017, 7:40 p.m., Jordan Ly wrote:
>
> ---
> This is an automatica
To reply, visit:
> https://reviews.apache.org/r/63536/
> ---
>
> (Updated Nov. 21, 2017, 10:42 a.m.)
>
>
> Review request for Aurora, Jordan Ly, Santhosh Kumar Shanmugham, and Bill
> Farner.
>
>
> Repository
------
On Nov. 16, 2017, 10:20 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63884/
> ---
tes of different jobs?
You're absolutey right, this was an egregious mistake. This code will be
removed in the next iteration of the patch, but thank you for catching the
mistake!
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63884/#revi
ySchedulerImplTest.java
39456cfe8b8c8e198a6f8c82e09769bd75db2adc
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
661ce58a840e5a23ff5438517880877cd90d0537
Diff: https://reviews.apache.org/r/63884/diff/3/
Changes: https://reviews.apache.org/r/63884/diff/2-3/
Testing
---
Thanks,
Bill Farner
> On Nov. 21, 2017, 1:27 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImpl.java
> > Lines 140 (patched)
> > <https://reviews.apache.org/r/63973/diff/1/?file=1898164#file1898164line140>
> >
> > Consid
(line 314)
<https://reviews.apache.org/r/35587/#comment140904>
What's being tested here? If i'm reading correctly, this test case would
pass before the patch.
- Bill Farner
On June 18, 2015, 1:02 a.m., M
> On June 18, 2015, 4:42 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java,
> > line 314
> > <https://reviews.apache.org/r/35587/diff/1/?file=986660#file986660line314>
> >
> > What's being
/UnsecureAuthModule.java (line 40)
<https://reviews.apache.org/r/35627/#comment140957>
Given how non-obvious this was, it deserves a comment to indicate why this
is necessary.
- Bill Farner
On June 18, 2015, 9:40 p.m., Kevin Sweeney
quot;: 10} 460502.356 ± 19182.511
{"instances": 100} 444265.855 ± 28006.036
{"instances": 1000} 419068.664 ± 49878.394
{"instances": 1} 404739.919 ± 13857.501
```
Seems like we're able to take pretty good advantage of caching in myBatis
and/or H2, at which point performance mostly varies with the response size.
Thanks,
Bill Farner
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/35630/#review88452
---
On June 18, 2015, 10:39 p.m., Bill Farner wrote:
>
> ---
> This is an aut
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35633/#review88456
---
Ship it!
Ship It!
- Bill Farner
On June 18, 2015, 11:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88460
---
Ship it!
LGTM once the bot is happy.
- Bill Farner
On June 18
NCT necessary given the Set result type?
>
> Bill Farner wrote:
> Functionally it's not necessary, but why not dedupe as low in the stack
> as we can? If the database is on a separate host, for example, we save on
> the network.
>
> Maxim Khutornenko wrote:
> The
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35639/#review88477
---
Ship it!
Ship It!
- Bill Farner
On June 19, 2015, 1:21 a.m
.
Thanks,
Bill Farner
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35672/#review88605
---
On June 19, 2015, 10:43 p.m., Bill Farner wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35587/#review88806
---
Ship it!
Ship It!
- Bill Farner
On June 19, 2015, 10:07 p.m
DbTaskStore on these benchmarks, i
believe these should be considered acceptable.
Thanks,
Bill Farner
ent141603>
while you're here, remove this newline
- Bill Farner
On June 23, 2015, 2:24 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
ent explaining the rationale behind the default.
- Bill Farner
On June 23, 2015, 2:29 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
hanks,
Bill Farner
ax, a network
disconnection, or the anticipated case of a consistency violation.
Thanks,
Bill Farner
doesn't
seem like we'd actually be able to alert on it.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89022
--
/MesosSchedulerImpl.java (line
233)
<https://reviews.apache.org/r/35761/#comment141643>
s/manager/handler/
- Bill Farner
On June 23, 2015, 6:35 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e
ttps://reviews.apache.org/r/35793/#review89047
---
On June 23, 2015, 6:28 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35839/#review89233
---
Ship it!
Ship It!
- Bill Farner
On June 24, 2015, 7:05 p.m
/StreamManagerImpl.java
(line 309)
<https://reviews.apache.org/r/35840/#comment141837>
This list has grown quite stale (there's another 6 values not mentioned),
so i'd actually be in favor of dropping these this group, and removing the
`LOG.warning` for the default case.
- Bill Far
er we should
continue this abstraction. Figured i'd drop a note here in case it changes the
shape of this patch.
- Bill Farner
On June 24, 2015, 10:13 p.m., Brian Wickman wrote:
>
> ---
> This is an automatically generat
> On June 24, 2015, 10:14 p.m., Bill Farner wrote:
> > FYI i've raised a mailing list discussion questioning whether we should
> > continue this abstraction. Figured i'd drop a note here in case it changes
> > the shape of this patch.
>
> Brian Wickm
case of a consistency violation.
Thanks,
Bill Farner
(-)
Nice! 2 requests:
- Can you confirm that end-to-end tests still pass?
- Can you add to this patch a note in NEWS under 0.9.0 that the GC executor has
been removed?
- Bill Farner
On June 24, 2015, 12:22 a.m., Maxim Khutornenko wrote
812/#comment141954>
```
The scheduler command line argument enable_legacy_constraints has been
removed, and the scheduler no longer automatically injects 'host' and 'rack'
constraints for production services.
```
- Bill Farner
On June 23, 2015, 11:5
le list rather than a single value:
```
assertEquals(
ImmutableList.of(...),
docker.getParametersList());
```
- Bill Farner
On June 20, 2015, 11:42 p.m., Mauricio Garavaglia wrote:
>
> ---
> This is an automatically
ically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35793/#review89393
-------
On June 24, 2015, 10:46 p.m., Bill Farner wrote:
>
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35842/#review89405
---
Ship it!
Ship It!
- Bill Farner
On June 25, 2015, 6:32 p.m
ll recommend having a run counter to help us monitor collector
> > availability/health.
>
> Bill Farner wrote:
> Does the comment above change your opinion? If not, perhaps a more
> cross-cutting approach is stats on the states of all Services?
>
> Maxim Khutornenko w
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35886/#review89413
---
Ship it!
Ship It!
- Bill Farner
On June 25, 2015, 6:50 p.m
hanks,
Bill Farner
1] https://issues.apache.org/jira/browse/AURORA-749
- Bill Farner
On June 26, 2015, 2:13 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mai
arbon copy of the
application code. Open to ideas, i couldn't quickly come up with anything
obviously better.
Thanks,
Bill Farner
98efeef460ecb
src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java
d6e855b879e7909e8ba66c03ed34c845bf978a8f
Diff: https://reviews.apache.org/r/35932/diff/
Testing
-------
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35840/#review89529
---
Ship it!
Ship It!
- Bill Farner
On June 26, 2015, 5:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36063/#review89963
---
Ship it!
Ship It!
- Bill Farner
On June 30, 2015, 8:10 p.m
/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java (line 156)
<https://reviews.apache.org/r/35954/#comment142868>
It would be nice if comparison logic resided in QuotaCheckResult alongside
the quota overage checks.
- Bill Farner
On June 30, 2015, 12:06 a.m., Zameer
d36b42a22ebf9bbe52e60fea9b8a2677c41bd598
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java
db508cace922b20a19081a1d918cc082b255cd02
Diff: https://reviews.apache.org/r/36096/diff/
Testing
---
Thanks,
Bill Farner
ra/scheduler/updater/OneWayJobUpdaterTest.java
d32b40a9b374eeed280a552508c98efeef460ecb
src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java
d6e855b879e7909e8ba66c03ed34c845bf978a8f
Diff: https://reviews.apache.org/r/35932/diff/
Testing
-------
Thanks,
Bill Farner
pache.org/r/35932/diff/1/?file=993356#file993356line77>
> >
> > same
Done.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35932/#review89742
---
On July 1, 201
101 - 200 of 1423 matches
Mail list logo
