/handlers/AssetHandler.java
(line 114)
<https://reviews.apache.org/r/37936/#comment152769>
foamtting nit: `try (`
- Bill Farner
On Aug. 30, 2015, 5:29 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37937/#review97057
---
Ship it!
Awesome!
- Bill Farner
On Aug. 30, 2015, 9:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37938/#review97058
---
Ship it!
Ship It!
- Bill Farner
On Aug. 30, 2015, 9:49 p.m
Description
---
Reset RPM changelog.
Diffs
-
specs/rpm/aurora.spec 0f3d0a735cc8c864f217b5e5de90243243738044
Diff: https://reviews.apache.org/r/37959/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37964/#review97169
---
Ship it!
Ship It!
- Bill Farner
On Aug. 31, 2015, 2:34 p.m
92>
We probably only want to create a job using revocable resources and watch
that it doesn't explode. The full extra round of test cases seems excessive.
- Bill Farner
On Aug. 31, 2015, 3:53 p.m., Maxim Khutornenko wrote:
>
> --
tps://reviews.apache.org/r/37818/#comment153053>
Can you expand this example to include the command executor? That's likely
to be the first non-default executor folks will want to try.
- Bill Farner
On Aug. 31, 2015, 5:37 p.m., Renan Del
n/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java
7f0cb5c7f30883982ea9388bf6a6195705dfdd75
Diff: https://reviews.apache.org/r/37987/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37988/#review97249
---
Ship it!
Ship It!
- Bill Farner
On Aug. 31, 2015, 8:33 p.m
/diff/
Testing
---
test suite
./gradlew run
end-to-end tests
Thanks,
Bill Farner
ava
<https://reviews.apache.org/r/38014/#comment153162>
This is now done in SchedulerMain.
- Bill Farner
On Sept. 1, 2015, 11:42 a.m., Bill Farner wrote:
>
> ---
> This is an automatically g
/preemptor/PreemptorModuleTest.java
3f045ff38d672266ce2e2bb26f729b0ca4657e81
Diff: https://reviews.apache.org/r/38014/diff/
Testing
---
test suite
./gradlew run
end-to-end tests
Thanks,
Bill Farner
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review97322
---
On Sept. 1, 2015, 11:59 a.m., Bill Farner wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38010/#review97384
---
Ship it!
Ship It!
- Bill Farner
On Sept. 1, 2015, 10:29 a.m
> On Aug. 31, 2015, 4:31 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/mesos-slave.conf, line 38
> > <https://reviews.apache.org/r/37926/diff/3/?file=1060746#file1060746line38>
> >
> > any reason for the verbosity? Why not just 'fixed_esti
/AbstractTaskStoreTest.java
2c03238d14a861401fbe88c25923122b60bcc6b5
src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java
947a50f6e298fa9cafd3eb2c68147796f54394ab
Diff: https://reviews.apache.org/r/38038/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38039/#review97392
---
Ship it!
Ship It!
- Bill Farner
On Sept. 1, 2015, 8:38 p.m
> On Aug. 31, 2015, 7:35 p.m., Bill Farner wrote:
> > examples/vagrant/executors-config.json, line 1
> > <https://reviews.apache.org/r/37818/diff/2/?file=1060851#file1060851line1>
> >
> > Can you expand this example to include the command executor? That&
with.
Maxim just did something very similar, which you can crib from:
https://github.com/apache/aurora/blob/89da936f3d28743e307c7c4fed0bff6fead7ceca/src/main/java/org/apache/aurora/scheduler/SchedulerModule.java#L132-L147
https://github.com/apache/aurora/blob/89da936f3d28743e307c7c4fed0bff6fead7ce
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37956/#review97479
---
Ship it!
Ship It!
- Bill Farner
On Sept. 1, 2015, 9:03 a.m
)
<https://reviews.apache.org/r/37926/#comment153373>
What's being tested here? Are you trying to determine whether the task
executed correctly? If so, maybe you should watch for it to enter RUNNING
instead?
- Bill Farner
On Sept. 2, 2015, 9:45 a.m., Maxim Khutor
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java,
> > line 87
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061926#file1061926line87>
> >
> > This code wi
> On Sept. 2, 2015, 9:53 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh, line 255
> > <https://reviews.apache.org/r/37926/diff/4-5/?file=1061209#file1061209line255>
> >
> > What's being tested here? Are yo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37926/#review97498
---
Ship it!
Ship It!
- Bill Farner
On Sept. 2, 2015, 9:45 a.m
/db/DbJobUpdateStoreTest.java
4c7133fa66bbe14002e2dc22cfaefa1585ab8a22
Diff: https://reviews.apache.org/r/38072/diff/
Testing
---
Thanks,
Bill Farner
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java,
> > line 87
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061926#file1061926line87>
> >
> > This code wi
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > examples/vagrant/executors-config.json, lines 4-7
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061919#file1061919line4>
> >
> > The code later converts this array into a single command string. I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38080/#review97573
---
Ship it!
Ship It!
- Bill Farner
On Sept. 2, 2015, 4:36 p.m
> On Sept. 2, 2015, 5:08 p.m., Bill Farner wrote:
> > Ship It!
>
> Kevin Sweeney wrote:
> procedural question - I see there's a long-running 0.9.x branch - should
> I merge this to master then merge this into that branch?
More or less, yes - i've been
tools/java/thrift_wrapper_codegen.py
b5f2bc9e54b525a6a782d8873c9112f6496cd3f2
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
295974a9f97e020dce11474d500a1bcd40d9f5d5
Diff: https://reviews.apache.org/r/38079/diff/
Testing
---
Thanks,
Bill Farner
l fix/update.
- Bill Farner
On Sept. 2, 2015, 6:08 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38084/#review97595
---
Ship it!
Thanks!!
- Bill Farner
On Sept. 2, 2015, 6:01 p.m
/Vagrantfile PRE-CREATION
test/rpm/centos-7/provision.sh PRE-CREATION
Diff: https://reviews.apache.org/r/38086/diff/
Testing
---
Thanks,
Bill Farner
,
Bill Farner
4d4e752088f7dca99675cc66782ae046bbd516d6
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
4685aa157be77502ad0e4e648ad333ee286f3de5
Diff: https://reviews.apache.org/r/38112/diff/
Testing
---
Thanks,
Bill Farner
run
end-to-end tests
Thanks,
Bill Farner
/ReadOnlySchedulerImplTest.java
4d4e752088f7dca99675cc66782ae046bbd516d6
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
4685aa157be77502ad0e4e648ad333ee286f3de5
Diff: https://reviews.apache.org/r/38112/diff/
Testing (updated)
---
End-to-end tests pass
Thanks,
Bill
Result, actualResult);
```
- Bill Farner
On Sept. 7, 2015, 4:51 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > examples/vagrant/executors-config.json, lines 4-7
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061919#file1061919line4>
> >
> > The code later converts this array into a single command string. I
081/#comment154263>
s/enforced for/consumed by/
- Bill Farner
On Sept. 8, 2015, 9:53 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/
Testing
---
test suite
./gradlew run
end-to-end tests
Thanks,
Bill Farner
--
On Sept. 3, 2015, 4:38 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38112/
> ---
che.org/r/38112/#comment154309>
Without the surrounding changes, this test would fail here. That's because
the second call to `saveTasks` would not recognize an `equals()` `ITaskConfig`,
and the third would identify a duplicate.
- Bill Farner
On Sept. 3, 2015, 4:38
.java
4685aa157be77502ad0e4e648ad333ee286f3de5
Diff: https://reviews.apache.org/r/38112/diff/
Testing
---
End-to-end tests pass
Thanks,
Bill Farner
ed e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98081
---
On Sept. 8, 2015, 2:49 p.m., Bill Farner wrote:
>
> ---
> This is an a
63716459a4e21aa035b683ad46ef0a31620cfd98
Diff: https://reviews.apache.org/r/38014/diff/
Testing
---
test suite
./gradlew run
end-to-end tests
Thanks,
Bill Farner
ache/aurora/scheduler/app/LifecycleModule.java (line 1)
<https://reviews.apache.org/r/38014/#comment154383>
The diff shows this as all new code, but it's a move that content tracking
doesn't want to follow.
- Bill Farner
On Sept. 8, 2015, 4
38112/diff/
Testing
---
End-to-end tests pass
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98118
---
@ReviewBot retry
- Bill Farner
On Sept. 8, 2015, 4:21 p.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38086/#review98135
---
Ping
- Bill Farner
On Sept. 2, 2015, 7:59 p.m., Bill Farner
s are addressed.
docs/deploying-aurora-scheduler.md (line 294)
<https://reviews.apache.org/r/38200/#comment154480>
remove one newline
- Bill Farner
On Sept. 9, 2015, 6:36 a.m., Jeffrey Schroeder wrote:
>
> ---
> This
a.m., Kevin Sweeney wrote:
> > test/rpm/centos-7/provision.sh, lines 3-5
> > <https://reviews.apache.org/r/38086/diff/2/?file=1062987#file1062987line3>
> >
> > yum should include these packages when we install the others, can this
> > lin
-trusty/provision.sh PRE-CREATION
test/rpm/centos-7/README.md PRE-CREATION
test/rpm/centos-7/Vagrantfile PRE-CREATION
test/rpm/centos-7/provision.sh PRE-CREATION
Diff: https://reviews.apache.org/r/38086/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38202/#review98286
---
Ship it!
Ship It!
- Bill Farner
On Sept. 8, 2015, 8:33 p.m
rated e-mail. To reply, visit:
https://reviews.apache.org/r/38014/#review98274
-------
On Sept. 8, 2015, 4:21 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/
63716459a4e21aa035b683ad46ef0a31620cfd98
Diff: https://reviews.apache.org/r/38014/diff/
Testing
---
test suite
./gradlew run
end-to-end tests
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98345
---
Maxim - ping.
- Bill Farner
On Sept. 8, 2015, 4:26 p.m., Bill
n shared object file: No such file or
directory
```
Thanks,
Bill Farner
e log has not been set up at this point IIUC.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38260/#review98411
---
On Sept. 10, 2
tps://reviews.apache.org/r/38260/#review98422
-------
On Sept. 10, 2015, 9:30 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail.
iverImpl
ImportError: libcurl-nss.so.4: cannot open shared object file: No such file or
directory
```
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38270/#review98504
---
Ship it!
Ship It!
- Bill Farner
On Sept. 10, 2015, 4:56 p.m
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38112/#review98503
-------
On Sept. 8, 2015, 4:26 p.m., Bill Farner wrote:
>
> ---
> This
tests pass
Thanks,
Bill Farner
sting
---
End-to-end tests pass
Thanks,
Bill Farner
org/r/38112/diff/
Testing
---
End-to-end tests pass
Thanks,
Bill Farner
/storage/db/DbJobUpdateStoreTest.java
4a09693774dee599c161b524ac9d0e388f027f82
Diff: https://reviews.apache.org/r/38288/diff/
Testing
---
Thanks,
Bill Farner
tices
Successfully ran end-to-end tests to validate other changes.
Thanks,
Bill Farner
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java,
> > line 87
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061926#file1061926line87>
> >
> > This code wi
---
Thanks,
Bill Farner
./gradlew run
end-to-end tests
Thanks,
Bill Farner
/scheduler/sla/SlaModuleTest.java
63716459a4e21aa035b683ad46ef0a31620cfd98
Diff: https://reviews.apache.org/r/38014/diff/
Testing
---
test suite
./gradlew run
end-to-end tests
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38309/#review98631
---
Ship it!
Thanks!
- Bill Farner
On Sept. 11, 2015, 10:31 a.m
-
On Sept. 11, 2015, 11:55 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38313/
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38313/#review98666
---
Ship it!
Ship It!
- Bill Farner
On Sept. 11, 2015, 11:55 a.m
/log/mesos/MesosLogStreamModule.java
e47dbaa8b0654a6f5b23ef794162012be3dc6c37
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java
7f141df03336504127b4ad7822efad3da0c8c9a7
Diff: https://reviews.apache.org/r/38315/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38316/#review98686
---
Ship it!
Ship It!
- Bill Farner
On Sept. 11, 2015, 1:42 p.m
-------
On Sept. 11, 2015, 1:34 p.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38315/
> --
---
Thanks,
Bill Farner
7f141df03336504127b4ad7822efad3da0c8c9a7
Diff: https://reviews.apache.org/r/38315/diff/
Testing
---
Thanks,
Bill Farner
? This seems
like something people might put in their bash profile.
- Bill Farner
On Sept. 11, 2015, 4:31 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote:
> > How would you feel about an env var instead of command line arg? This
> > seems like something people might put in their bash profile.
>
> Maxim Khutornenko wrote:
> I don't really like relying on env var
e are
terribly relevant, and could be considered sensitive.
commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java (lines 95 -
104)
<https://reviews.apache.org/r/38280/#comment155279>
If you like the previous comment, i believe this can disappear.
- Bill Farner
O
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote:
> > How would you feel about an env var instead of command line arg? This
> > seems like something people might put in their bash profile.
>
> Maxim Khutornenko wrote:
> I don't really like relying on env var
://reviews.apache.org/r/38331/diff/
Testing
---
unit tests
end-to-end tests
./gradlew run
Thanks,
Bill Farner
eviews.apache.org/r/38331/#comment155344>
This was all pulled in from AppLauncher, simplified slightly because it is
no longer generic.
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java (lines 279 -
282)
<https://reviews.apache.org/r/38331/#comment155345>
Thi
everything i could think of in ./gradlew run and in
vagrant
end-to-end tests
Thanks,
Bill Farner
6dd50264b7d119aa5b5f96ab153794e95c443822
Diff: https://reviews.apache.org/r/38336/diff/
Testing
---
Thanks,
Bill Farner
/TaskHistoryPrunerTest.java
0c7da074515e1fad534617f9b8f73d939caf948b
src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java
6dd50264b7d119aa5b5f96ab153794e95c443822
Diff: https://reviews.apache.org/r/38336/diff/
Testing
---
Thanks,
Bill Farner
Not strictly necessary in this patch, but i noticed this thread pool was
not cleaned up.
- Bill Farner
On Sept. 13, 2015, 10:05 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
;@ReviewBot retry"
> Test coverage missing for org/apache/aurora/scheduler/http/AbortCallback
Interesting. On master, this class only has coverage for static code. This
might be flaky, as i was able to get a green build and then repro locally.
Please feel free to review the patch, i&#x
/
Testing
---
manually clicked through everything i could think of in ./gradlew run and in
vagrant
end-to-end tests
Thanks,
Bill Farner
ize
diff churn.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38332/#review98781
---
On Sept. 13, 2015, 11:0
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java,
> > line 87
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061926#file1061926line87>
> >
> > This code wi
> On Sept. 2, 2015, 9:45 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/configuration/ExecutorSettingsLoader.java,
> > line 87
> > <https://reviews.apache.org/r/37818/diff/3/?file=1061926#file1061926line87>
> >
> > This code wi
avoid overloading the naming.
docs/deploying-aurora-scheduler.md (line 201)
<https://reviews.apache.org/r/38390/#comment155755>
Would it make sense to remove this flag, and instead enable revocable
resources when there's at least one configured tier that uses them?
- B
ens to fix things.
- Bill Farner
On Sept. 14, 2015, 5:41 p.m., Jake Farrell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
> On Sept. 11, 2015, 4:36 p.m., Bill Farner wrote:
> > How would you feel about an env var instead of command line arg? This
> > seems like something people might put in their bash profile.
>
> Maxim Khutornenko wrote:
> I don't really like relying on env var
/command_runner.py (line 93)
<https://reviews.apache.org/r/38326/#comment156012>
This patch uses mutable lists in several places, which i feel is a
divergence from general prefernce for immutability. I don't think it hinders
readability at all to assign these lists once and not mutate them.
-
ve it a fair look
as i head out of town. I'd like to tap out so you don't have to wait 3 weeks
to land it :-)
- Bill Farner
On Sept. 14, 2015, 11:46 a.m., Joe Smith wrote:
>
> ---
> This is an automatically generated
401 - 500 of 1423 matches
Mail list logo
