via:
`./build-support/python/make-pycharm-virtualenv`
Confirmed library source linking worked as did running unit tests
via the IDE.
Also grepped for pants commands in the repo, found `binary` and `setup-py`
and confirmed these worked.
Thanks,
John Sirois
Testing
---
Eyeballed:
`markdown_py CONTRIBUTING.md > CONTRIBUTING.html && open CONTRIBUTING.html`
Thanks,
John Sirois
/40197/diff/
Testing
---
Ran into this working https://issues.apache.org/jira/browse/AURORA-547.
After the fix, locally ran `./pants test src/test/python:: -- -v` green.
Previously this would lead to test failures and CPU starvation.
Thanks,
John Sirois
And no `dist/` created.
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40204/#review106171
---
Ship it!
Ship It!
- John Sirois
On Nov. 11, 2015, 4:39 p.m
fully locally which forces re-download of requirements
by pants:
```
$ ./pants clean-all test.pytest --no-fast src/test/python::
```
Thanks,
John Sirois
[complete]
FAILURE
```
Thanks,
John Sirois
-support && ./build-support/pex --version`
Thanks,
John Sirois
(1.1.0) and
proper use of the cached venv in the second run:
`git clean -fdx build-support && ./build-support/pex --version`
Thanks,
John Sirois
://reviews.apache.org/r/40220/diff/2#index_header
- John Sirois
On Nov. 12, 2015, 1:35 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
32
missing whitespace around operator
| context_aware_object_factories={'pants_requirement':
pants_requirement_factory}
FAILURE: Python Style issues found
00:48:50 00:01 [complete]
FAILURE
```
Thanks,
John Sirois
visit:
https://reviews.apache.org/r/40219/#review106301
---
On Nov. 12, 2015, 1:54 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To
e add a custom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as
e add a custom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as
e add a custom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as
e add a custom
> > plugin here we won't be able to upgrade pants in the future at all.
>
> John Sirois wrote:
> As you see fit. I will say that the APIs used here are minimal and
> historically stable. For example, Medium similarly enables checkstyle as
> well as
/test/python:: -- -v` green.
Previously this would lead to test failures and CPU starvation.
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40197/#review106424
-------
On Nov. 11, 2015, 1:30 p.m., John Sirois wrote:
>
> ---
it need only
contain the entry you added here.
- John Sirois
On Nov. 13, 2015, 9:34 a.m., Bill Farner wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106447
---
Ship it!
LGTM mod a pending comment
- John Sirois
On Nov. 13
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40299/#review106451
---
Ship it!
Ship It!
- John Sirois
On Nov. 13, 2015, 10:24 a.m
ache.org/r/40310/diff/
Testing
---
See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
40310/diff/
Testing
---
See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
://reviews.apache.org/r/40310/
- John Sirois
On Nov. 12, 2015, 1:54 a.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
w run `./build-support/jenkins/build.sh` green locally.
I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
://reviews.apache.org/r/40299/ with another approach and this is it.
This is a take-it or leave it. It certainly could be see as obscuring if folks
are used to looking in pants.ini for a custom repos setup.
- John Sirois
On Nov. 14, 2015, 5:18 p.m., John Sirois wrote
> On Nov. 13, 2015, 9:55 a.m., John Sirois wrote:
> > pants.ini, line 33
> > <https://reviews.apache.org/r/40299/diff/1/?file=1125123#file1125123line33>
> >
> > Seems worth a note this is only used by the vagrant provisioning ... or
> > add t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40320/#review106552
---
Ship it!
Ship It!
- John Sirois
On Nov. 14, 2015, 10 a.m
towards the
cleanups suggested by Kevin and style fixes failing the build currently? If so
- great. If not, I can brush this up and send out a new RB.
- John Sirois
On Oct. 9, 2015, 6:41 a.m., Brice Arnould wrote:
>
> ---
> T
refight leading
to this RB and one for Medium's mono repo as well as patching
of the fix in at Square. Now
`./build-support/jenkins/build.sh` runs green as well.
Thanks,
John Sirois
. Now
`./build-support/jenkins/build.sh` runs green as well.
Thanks,
John Sirois
ngages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
anticipation
of that fix landing Monday to prevent test errors.
- John Sirois
On Nov. 15, 2015, 4:34 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/40310/
Fixed diff coming...
- John Sirois
On Nov. 15, 2015, 4:32 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
hat triggered a bit of a pants release firefight leading
to this RB and one for Medium's mono repo as well as patching
of the fix in at Square. Now
`./build-support/jenkins/build.sh` runs green as well.
Thanks,
John Sirois
about that!
- John Sirois
On Nov. 15, 2015, 4:36 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
nt image and report back.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
---
On Nov. 14, 2015, 4:44 p.m., Jo
amp; \
> > make clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> >
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i
pport/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
x27;d appreciate it
if you could.
- John Sirois
On Nov. 15, 2015, 7:45 p.m., John Sirois wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
-
>
> build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7
> build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9
>
> Diff: https://reviews.apache.org/r/40323/diff/
>
>
> Testing
> ---
>
> I can now run `./build-support/jenkins/build.sh` green locally.
>
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
>
>
> Thanks,
>
> John Sirois
>
>
Testing
---
See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
make clean && make -j4 && \
> > make install
> > openssl:Error: 'sha256' is an invalid command.
> > ```
> >
> > Looks like the command syntax on OS X is `openssl dgst -sha256`, i
> > don't suppose t
org/r/40323/diff/
Testing
---
I can now run `./build-support/jenkins/build.sh` green locally.
I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
> >
> >
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
I'll wait until https://reviews.apache.org/r/40334/ is in to update this diff.
- John
--
5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
install-recursive] Error 1
> > make[1]: *** [install] Error 2
> > ```
> >
> > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P
Hrm - serves me right for installing OSX on case-sensitive HFS+.
Fixed; although the AuroraBot will continue to be red due to
h
gt; > File exists
> > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install:
> > Not a directory
> > make[5]: *** [install-libLIBRARIES] Error 1
> > make[4]: *** [install-am] Error 2
> > make[3]: *** [install] Error 2
> > make[2]: *** [inst
ld.sh` green locally.
I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
ply, visit:
https://reviews.apache.org/r/40324/#review106673
-------
On Nov. 14, 2015, 5:18 p.m., John Sirois wrote:
>
> ---
> This is an automatically ge
and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
elf._scheduler_proxy).restart(instances)
I couldn't follow the comment, but did change the style to the one you
demonstrated.
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
rded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
---
Successfully ran end-to-end with this change using a fresh vagrant
image and clean repo via:
```
vagrant destroy && \
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
with isort rules internally).
- John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review106710
---
On Nov. 16, 2015, 10:30 a.m., John Sirois wrote:
>
> ---
5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
rded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
-
See the discarded https://reviews.apache.org/r/40219/ for the
commit-hook check. This version of that RB engages the same code
and this RB commit was vetted by the same commit-hook.
Thanks,
John Sirois
ld.sh` green on it using this change.
Thanks,
John Sirois
cally:
```
$ rm -rf dist/ && \
./pants test.pytest --no-fast src/test/python/apache/aurora/executor:
```
And no `dist/` created.
Thanks,
John Sirois
-version`
Thanks,
John Sirois
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106749
-------
On Nov. 16, 2015, 1:11 p.m., John Sirois wrote:
>
> ---
> This is an automatically
gt; > productive to upgrade to 0.9.2+ before complicating our thrift build?
> >
> > Not a blocker to landing this but I think it would be nice if we didn't
> > have to download a patch for our vendored thrit.
>
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.
efile 51f37a959041536004f83a60d038f2116be8c8a9
Diff: https://reviews.apache.org/r/40323/diff/
Testing
---
I can now run `./build-support/jenkins/build.sh` green locally.
I also got a hold of an OSX 10.10.5 box and was able to run
`./build-support/jenkins/build.sh` green on it using this change.
Thanks,
John Sirois
gt; > productive to upgrade to 0.9.2+ before complicating our thrift build?
> >
> > Not a blocker to landing this but I think it would be nice if we didn't
> > have to download a patch for our vendored thrit.
>
> John Sirois wrote:
> Sadly 0.9.2 and 0.9.
/executor/ExecutorSettingsLoader.java
(line 79)
<https://reviews.apache.org/r/40391/#comment165689>
Isn't Schema.class enough? No type parameter to capture here.
- John Sirois
On Nov. 17, 2015, 9:28 a.m., Bill F
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40391/#review106895
---
Ship it!
Ship It!
- John Sirois
On Nov. 17, 2015, 10:51 a.m
:
http://aurora.local:8081/structdump
http://aurora.local:8081/slaves
http://aurora.local:8081/utilization
Thanks,
John Sirois
/http/utilization.st
4a8a07222d65681e77c90566be9dce9283c7be65
Diff: https://reviews.apache.org/r/40466/diff/
Testing
---
Manually tested the following endpoints:
http://aurora.local:8081/structdump
http://aurora.local:8081/slaves
http://aurora.local:8081/utilization
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37851/#review107127
---
@ReviewBot retry
- John Sirois
On Oct. 9, 2015, 10:38 a.m
up work on
https://issues.apache.org/jira/browse/AURORA-1376, is it safe to discard?
- John Sirois
On Aug. 18, 2015, 12:10 a.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
.
- John Sirois
On July 27, 2015, 9:01 p.m., Kevin Sweeney wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37851/#review107132
---
Ship it!
Ship It!
- John Sirois
On Oct. 9, 2015, 10:38 a.m
else discard?
@ReviewBot retry
- John Sirois
On March 20, 2015, 6:30 a.m., Brian Brazil wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40510/#review107357
---
Ship it!
Ship It!
- John Sirois
On Nov. 19, 2015, 5:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40201/#review107648
---
Friendly ping.
- John Sirois
On Nov. 18, 2015, 11:20 a.m., John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40310/#review107650
---
Friendly ping.
- John Sirois
On Nov. 16, 2015, 1:11 p.m., John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40466/#review107649
---
Friendly ping.
- John Sirois
On Nov. 18, 2015, 8:46 p.m., John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40629/#review107820
---
Ship it!
Ship It!
- John Sirois
On Nov. 23, 2015, 11:56 p.m
https://reviews.apache.org/r/40675/diff/
Testing
---
Locally green for `./build-support/thrift/thriftw 0.9.1 --version`
Bill confirmed the fix works for aurora-packaging CentOS 7.
Thanks,
John Sirois
aurora.tar.gz clusters.json thermos-observer.init.sh
thermos-observer.logrotate thermos-observer.service
thermos-observer.startup.sh thermos-observer.sysconfig
artifacts/aurora-centos-7/dist/rpmbuild/SRPMS:
aurora-scheduler-0.11.0snapshot.2015.11.24-1.el7.centos.aurora.src.rpm
```
Thanks,
John
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40689/#review107895
---
Ship it!
Ship It!
- John Sirois
On Nov. 24, 2015, 7 p.m
e the thrift issue though is side-stepped via:
`
http://people.apache.org/~jfarrell/thrift/0.9.1/contrib/deb/ubuntu/12.04/$THRIFT_DEB`
Thanks,
John Sirois
urora-tools_0.11.0snapshot.2015.11.24_amd64.deb
```
Looks like the thrift issue though is side-stepped via:
`
http://people.apache.org/~jfarrell/thrift/0.9.1/contrib/deb/ubuntu/12.04/$THRIFT_DEB`
Thanks,
John Sirois
hanks,
John Sirois
the README testing
instructions. This righted the thermos observer which was in a start/fail
cycle.
Thanks,
John Sirois
/r/40757/diff/
Testing
---
Performed the specs/debian/aurora-executor.thermos.upstart in the
test/deb/ubuntu-trusty/ Vagrant VM after following the README testing
instructions. This righted the thermos observer which was in a start/fail
cycle.
Thanks,
John Sirois
.getRoleSummary();
}
...
```
Thanks,
John Sirois
ThriftForwarder(AnnotatedAuroraAdmin annotatedAuroraAdmin) {
this.annotatedAuroraAdmin = Objects.requireNonNull(annotatedAuroraAdmin);
}
@Override
public Response getRoleSummary() throws TException {
return this.annotatedAuroraAdmin.getRoleSummary();
}
...
```
Thanks,
John Sirois
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40881/#review108715
---
Ship it!
Ship It!
- John Sirois
On Dec. 2, 2015, 1:18 p.m
ThriftForwarder(AnnotatedAuroraAdmin annotatedAuroraAdmin) {
this.annotatedAuroraAdmin = Objects.requireNonNull(annotatedAuroraAdmin);
}
@Override
public Response getRoleSummary() throws TException {
return this.annotatedAuroraAdmin.getRoleSummary();
}
...
```
Thanks,
John Sirois
enerated e-mail. To reply, visit:
https://reviews.apache.org/r/40786/#review109183
---
On Dec. 7, 2015, 2:55 p.m., John Sirois wrote:
>
> ---
> This is an automatically ge
---
Green: `./gradlew -Pq build`
Also confirmd `./gradlew idea` produced a project I could build from
within IDEA and debug tests with.
Thanks,
John Sirois
/
Testing
---
The project generated by `./gradlew idea` now compiles inside
IDEA, tests can be run and debugged in the IDE, jmh benchmarks
can likewise be run, and all generated code is mapped and
explorable.
Thanks,
John Sirois
/jenkins/build.sh`
Thanks,
John Sirois
201 - 300 of 771 matches
Mail list logo
