Re: Review Request 28398: Adding cron check into aurora beta-update start.

2014-11-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28398/ --- (Updated Nov. 25, 2014, 6 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 28398: Adding cron check into aurora beta-update start.

2014-11-25 Thread Maxim Khutornenko
On Nov. 24, 2014, 7:48 p.m., David McLaughlin wrote: src/main/python/apache/aurora/client/cli/cron.py, line 79 https://reviews.apache.org/r/28398/diff/1/?file=774538#file774538line79 s/existing // Done. - Maxim --- This is

Re: Review Request 28409: Bump the min coverage values.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28409/#review63012 --- Ship it! Ship It! - Bill Farner On Nov. 24, 2014, 9:11 p.m.,

Re: Review Request 28409: Bump the min coverage values.

2014-11-25 Thread Bill Farner
On Nov. 25, 2014, 6:33 p.m., Bill Farner wrote: Ship It! This is now on master: ``` $ git log -1 origin/master --abbrev-commit commit 22dd641 Author: Zameer Manji zma...@twopensource.com Date: Tue Nov 25 10:33:21 2014 -0800 Bump the min coverage values. Reviewed at

Review Request 28445: Improving messages in CronJobManager.

2014-11-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28445/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-924

Re: Review Request 28445: Improving messages in CronJobManager.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28445/#review63021 --- Ship it! Master (22dd641) is green with this patch.

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
On Nov. 21, 2014, 9:12 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 30 https://reviews.apache.org/r/28198/diff/2/?file=770028#file770028line30 We should expose the mesos-master (5050), mesos-slave (5051), and thermos-observer (1338) UIs too. And possibly ZooKeeper

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:37 p.m.) Review request for Aurora, Benjamin

Re: Review Request 28361: Extract thrift into an API subproject.

2014-11-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/#review63025 --- Ship it! Ship It! - Joshua Cohen On Nov. 25, 2014, 6:37 a.m.,

Re: Review Request 28361: Extract thrift into an API subproject.

2014-11-25 Thread Kevin Sweeney
On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote: build-support/thrift/thriftw, line 1 https://reviews.apache.org/r/28361/diff/1/?file=772952#file772952line1 License header? Fixed. On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote: build-support/thrift/thriftw, line 2

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63027 --- examples/docker/Dockerfile

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
On Nov. 25, 2014, 7:43 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, line 35 https://reviews.apache.org/r/28198/diff/3/?file=775982#file775982line35 Presumably we're not all going to use your zookeeper ensemble? oh oops... sorry I had it in my local version and forgot to

Re: Review Request 28361: Extract thrift into an API subproject.

2014-11-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/#review63029 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 25, 2014, 7:39

Re: Review Request 28361: Extract thrift into an API subproject.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/#review63030 --- Ship it! Ship It! - Bill Farner On Nov. 25, 2014, 7:39 p.m.,

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated Nov. 25, 2014, 7:47 p.m.) Review request for Aurora, Benjamin

Re: Review Request 28361: Extract thrift into an API subproject.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/ --- (Updated Nov. 25, 2014, 12:22 p.m.) Review request for Aurora, Joshua Cohen,

Review Request 28447: Disambiguate tag push from branch push in release script.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28447/ --- Review request for Aurora and Jake Farrell. Repository: aurora Description

Re: Review Request 28447: Disambiguate tag push from branch push in release script.

2014-11-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28447/#review63037 --- Ship it! Ship It! - Jake Farrell On Nov. 25, 2014, 8:36 p.m.,

Re: Review Request 28447: Disambiguate tag push from branch push in release script.

2014-11-25 Thread Bill Farner
On Nov. 25, 2014, 8:38 p.m., Kevin Sweeney wrote: build-support/release/release, line 138 https://reviews.apache.org/r/28447/diff/1/?file=776081#file776081line138 Should we not be pushing this branch? Bill Farner wrote: I'll let you and Jake hash that out. I'm indifferent.

Re: Review Request 28447: Disambiguate tag push from branch push in release script.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28447/#review63041 --- Ship it! Ship It! - Kevin Sweeney On Nov. 25, 2014, 12:36 p.m.,

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63040 --- examples/docker/Dockerfile

Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28449/ --- Review request for Aurora. Repository: aurora Description --- When

Re: Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28449/ --- (Updated Nov. 25, 2014, 9 p.m.) Review request for Aurora and Jake Farrell.

Review Request 28450: Fixing admin query command

2014-11-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28450/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-936

Re: Review Request 28450: Fixing admin query command

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28450/#review63043 --- Ship it! Ship It! - Bill Farner On Nov. 25, 2014, 9:16 p.m.,

Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/ --- Review request for Aurora. Bugs: AURORA-949

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/ --- (Updated Nov. 25, 2014, 1:22 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Tony Dong
On Nov. 25, 2014, 8:49 p.m., Kevin Sweeney wrote: examples/docker/Dockerfile, lines 14-16 https://reviews.apache.org/r/28198/diff/4/?file=776032#file776032line14 Can we avoid the extra clone here and build from the currently checked out repo? That way this script is likely to

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63044 --- src/test/python/apache/aurora/common/test_transport.py

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63045 --- Ship it! - Bill Farner On Nov. 25, 2014, 9:22 p.m., Zameer Manji

Review Request 28452: In review bot, tee test output rather than piping to a file.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28452/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63046 --- Ship it! Master (e95aa8e) is green with this patch.

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/#review63047 --- Ship it! Master (e95aa8e) is green with this patch.

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63048 --- Ship it! Master (e95aa8e) is green with this patch.

Re: Review Request 28452: In review bot, tee test output rather than piping to a file.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28452/#review63049 --- Ship it! Ship It! - Kevin Sweeney On Nov. 25, 2014, 1:34 p.m.,

Re: Review Request 28450: Fixing admin query command

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28450/#review63050 --- Master (e95aa8e) is red with this patch.

Re: Review Request 28450: Fixing admin query command

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28450/#review63051 --- Ship it! Master (e95aa8e) is green with this patch.

Re: Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28449/#review63055 --- Ship it! Master (e95aa8e) is green with this patch.

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63056 --- src/test/python/apache/aurora/common/test_transport.py

Re: Review Request 28361: Extract thrift into an API subproject.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28361/#review63058 --- Master (5e80581) is green with this patch.

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Zameer Manji
On Nov. 25, 2014, 1:27 p.m., Kevin Sweeney wrote: src/test/python/apache/aurora/common/test_transport.py, line 89 https://reviews.apache.org/r/28451/diff/1/?file=776097#file776097line89 You can remove the lambda here if you unset instance=True on session. The underlying code will

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Zameer Manji
On Nov. 25, 2014, 2:04 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/common/test_transport.py, line 81 https://reviews.apache.org/r/28451/diff/1/?file=776097#file776097line81 This test doesn't really do what it says. It's just testing that we call raise_for_status, but

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/ --- (Updated Nov. 25, 2014, 2:35 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63061 --- Ship it! Master (91b8d19) is green with this patch.

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/ --- (Updated Nov. 25, 2014, 2:51 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63064 --- Ship it! Ship It! - Kevin Sweeney On Nov. 25, 2014, 2:51 p.m.,

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63065 --- Ship it! Master (91b8d19) is green with this patch.

Re: Review Request 28451: Modify TRequestsTransport to raise an exception 4xx or 5xx responses.

2014-11-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28451/#review63071 --- Ship it! Ship It! - Joshua Cohen On Nov. 25, 2014, 10:51 p.m.,

Review Request 28460: Fix resolutionStrategy to be global.

2014-11-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28460/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora

Re: Review Request 28460: Fix resolutionStrategy to be global.

2014-11-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28460/#review63087 --- Ship it! Master (91b8d19) is green with this patch.

Re: Review Request 28460: Fix resolutionStrategy to be global.

2014-11-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28460/#review63088 --- Ship it! Ship It! - Bill Farner On Nov. 26, 2014, 1:28 a.m.,