Review Request 28692: Simplify logging in the Aurora client.

:: Thanks, Zameer Manji

Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a Diff: https://reviews.apache.org/r/28693/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

/apache/aurora/client:: Thanks, Zameer Manji

Re: Review Request 28674: Remove Response.messageDEPRECATED field.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28674/#review63737 --- Ship it! Ship It! - Zameer Manji On Dec. 3, 2014, 12:34 p.m

Re: Review Request 28682: Drop custom thrift doc generator in favor of the one included in thrift.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28682/#review63793 --- Ship it! Ship It! - Zameer Manji On Dec. 3, 2014, 4:36 p.m

Re: Review Request 28693: Make abstract method annotations on ConfigurationPlugin effective.

/apache/aurora/client:: Thanks, Zameer Manji

Re: Review Request 28692: Simplify logging in the Aurora client.

? Good catch. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/#review63869 --- On Dec. 3, 2014, 10:27 p.m., Zameer Manji

Re: Review Request 28692: Simplify logging in the Aurora client.

--- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji

Review Request 28728: Collect HTTP stats on every request.

Description --- Collect HTTP stats on every request. Diffs - src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 83ba0e49436034c8b6f9f736c60a726686096362 Diff: https://reviews.apache.org/r/28728/diff/ Testing --- ./gradlew build Thanks, Zameer Manji

Review Request 28742: Simplify logging in the client.

tasks for job: devcluster/www-data/prod/hello INFO:root:Instances to be killed: [0] Successfully killed shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

/hello INFO:root:Checking status of devcluster/www-data/prod/hello INFO:root:Killing tasks for job: devcluster/www-data/prod/hello INFO:root:Instances to be killed: [0] Successfully killed shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

/#review64075 --- On Dec. 4, 2014, 11:43 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742

Re: Review Request 28771: Don't fall back to old command syntax in the new client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64086 --- Ship it! Ship It! - Zameer Manji On Dec. 5, 2014, 1:12 p.m

Re: Review Request 28742: Simplify logging in the client.

/prod/hello INFO] Killing tasks for job: devcluster/www-data/prod/hello INFO] Instances to be killed: [0] Successfully killed shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

of devcluster/www-data/prod/hello INFO] Killing tasks for job: devcluster/www-data/prod/hello INFO] Instances to be killed: [0] Successfully killed shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

. 8, 2014, 11:58 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/ --- (Updated Dec. 8, 2014, 11:58 a.m

Re: Review Request 28742: Simplify logging in the client.

tasks for job: devcluster/www-data/prod/hello INFO] Instances to be killed: [0] Successfully killed shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28742: Simplify logging in the client.

On Dec. 8, 2014, 12:33 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/client.py, lines 52-54 https://reviews.apache.org/r/28742/diff/4/?file=785651#file785651line52 Is there a test for this? Zameer Manji wrote: There isn't a test. Adding a unit test

Re: Review Request 28742: Simplify logging in the client.

/prod/hello INFO] Checking status of devcluster/www-data/prod/hello INFO] Killing tasks for job: devcluster/www-data/prod/hello INFO] Instances to be killed: [0] Successfully killed shards [0] job killall succeeded Thanks, Zameer Manji

Re: Review Request 28876: Suppressing redundant client command error messaging.

://reviews.apache.org/r/28876/#comment107179 Is it at all possible to avoid the use of raw Mock objects? - Zameer Manji On Dec. 9, 2014, 2:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 28872: Improving quota check message in the client.

://reviews.apache.org/r/28872/#comment107183 Can you set all the calls to print quota? - Zameer Manji On Dec. 9, 2014, 1:30 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28876: Suppressing redundant client command error messaging.

On Dec. 9, 2014, 3:29 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 384 https://reviews.apache.org/r/28876/diff/1/?file=787343#file787343line384 This solution seems to be papering over the problem we have with output in the client

Re: Review Request 28872: Improving quota check message in the client.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28872/#review64676 --- Ship it! Ship It! - Zameer Manji On Dec. 10, 2014, 6:55 p.m

Re: Review Request 28876: Suppressing redundant client command error messaging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28876/#review64677 --- Ship it! Ship It! - Zameer Manji On Dec. 9, 2014, 2:32 p.m

Re: Review Request 28876: Suppressing redundant client command error messaging.

On Dec. 9, 2014, 3:29 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_update.py, line 69 https://reviews.apache.org/r/28876/diff/1/?file=787345#file787345line69 Is it at all possible to avoid the use of raw Mock objects? Maxim Khutornenko wrote

Re: Review Request 28971: Begin dismantling client v1.

://reviews.apache.org/r/28971/#comment107578 Are we going to keep the artifact name like this? - Zameer Manji On Dec. 11, 2014, 2:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 28879: Make abstract decorators effective in CommandHook class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28879/#review64815 --- Ping. - Zameer Manji On Dec. 9, 2014, 3:36 p.m., Zameer Manji

Re: Review Request 29058: Extract mechanism for determining pex version so it can be used for cases other than client version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29058/#review65119 --- Ship it! Ship It! - Zameer Manji On Dec. 15, 2014, 12:54 p.m

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

://reviews.apache.org/r/29137/#comment108458 Why do we need a deep copy here? - Zameer Manji On Dec. 17, 2014, 10:24 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

On Dec. 17, 2014, 10:57 a.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 174 https://reviews.apache.org/r/29137/diff/2/?file=794247#file794247line174 Why do we need a deep copy here? Maxim Khutornenko wrote: The [task] * config.instances

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65353 --- Ship it! Ship It! - Zameer Manji On Dec. 17, 2014, 11:26 a.m

Re: Review Request 30224: Stream backups directly to file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/#review69444 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2015, 11:19 a.m

Re: Review Request 30224: Stream backups directly to file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30224/#review69445 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2015, 11:25 a.m

Re: Review Request 30207: Simplify AuroraCommandContext

On Jan. 23, 2015, 12:47 p.m., Maxim Khutornenko wrote: I am not convinced there is enough value in this diff to risk possible regression. Besides, the majority of what this diff touches will die out along with the client updater. Zameer Manji wrote: Is there an ETA

Re: Review Request 30204: Upgrade to rbt=0.7.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30204/#review69473 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2015, 6:11 p.m

Re: Review Request 30207: Simplify AuroraCommandContext

updater? - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30207/#review69458 --- On Jan. 22, 2015, 7:32 p.m., Zameer Manji wrote

Re: Review Request 30203: Fix impedance mismatch between offer matching and task launching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30203/#review69487 --- Ship it! Ship It! - Zameer Manji On Jan. 23, 2015, 1:48 p.m

Re: Review Request 30586: Fix exception when opening cron urls.

3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 30586: Fix exception when opening cron urls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30586/#review70900 --- @ReviewBot retry - Zameer Manji On Feb. 3, 2015, 5:14 p.m

Re: Review Request 30585: Adding command hook for beta-update start.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/#review71014 --- Ship it! Ship It! - Zameer Manji On Feb. 3, 2015, 4:24 p.m

Re: Review Request 30649: Upgrade pants to 0.0.28

sort of summary that explains what is new. - Zameer Manji On Feb. 4, 2015, 6:46 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649

Re: Review Request 30586: Fix exception when opening cron urls.

3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 30586: Fix exception when opening cron urls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30586/#review71128 --- Maxim, can you review the changes to the tests? - Zameer Manji

Re: Review Request 30535: Remove shard uniqueness check from scheduler recovery phase.

/ Testing --- Thanks, Bill Farner -- Zameer Manji

Re: Review Request 30741: Add an interface and implementations of PathDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30741/#review71487 --- Ship it! Ship It! - Zameer Manji On Feb. 6, 2015, 11:30 a.m

Review Request 30704: Remove default root in TaskPath.

://reviews.apache.org/r/30704/diff/ Testing --- ./pants test src/test/python/apache/thermos:: Thanks, Zameer Manji

Review Request 30768: Reject None values for TaskPath

/30768/diff/ Testing --- ./pants test src/test/python/apache/thermos:: ./pants test src/test/python/apache/aurora/executor:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 30749: Port GC executor to PathDetector interface

://reviews.apache.org/r/30749/#comment117329 Shouldn't this log messsage be inside the collector implementation? - Zameer Manji On Feb. 6, 2015, 6:27 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 30768: Reject None values for TaskPath

:: ./pants test src/test/python/apache/aurora/executor:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Review Request 30586: Fix exception when opening cron urls.

f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 30585: Adding command hook for beta-update start.

: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30585/ --- (Updated Feb. 3, 2015, 3:58 p.m.) Review request for Aurora and Zameer Manji. Repository: aurora

Re: Review Request 30586: Fix exception when opening cron urls.

3416c8e1932056725880f2007b60d77112759428 src/test/python/apache/aurora/client/cli/test_cron.py f488432cd68cc68fab8fce968e8605625ea3f56a Diff: https://reviews.apache.org/r/30586/diff/ Testing --- ./pants goal test src/test/python/apache/aurora/client/cli:cron Thanks, Zameer Manji

Re: Review Request 29940: Paginate when necessary in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29940/#review68299 --- Ship it! Ship It! - Zameer Manji On Jan. 15, 2015, 11:21 a.m

Re: Review Request 29915: Ensure TaskStateChange event emitted by StateManagerImpl has valid data.

build -Pq Thanks, Zameer Manji

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

is to add CLI flags so this legacy behaviour can be enabled. This way we don't break backwards compatability and users who rely on this behaviour don't get a nasty surprise when they update to the next release. - Zameer Manji On Jan. 20, 2015, 1:46 p.m., Florian Pfeiffer wrote

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

. src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java https://reviews.apache.org/r/30010/#comment113512 This test is not necessary either. We don't need to add tests to ensure we are not doing the old behaviour. - Zameer Manji On Jan. 20, 2015, 1:46 p.m

Re: Review Request 30102: Fix newbie ticket link in docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30102/#review68822 --- Ship it! Ship It! - Zameer Manji On Jan. 20, 2015, 4:31 p.m

Review Request 30000: Bump the minimum allocation for thermos to 256MB of RAM.

5bf283062c9d119ff91ed45da8b236e36d0fc9aa src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/3/diff/ Testing --- ./gradlew clean test Thanks, Zameer Manji

Re: Review Request 30000: Bump the minimum allocation for thermos to 256MB of RAM.

/browse/AURORA-1022 - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3/#review68524 --- On Jan. 16, 2015, 5:08 p.m., Zameer Manji

Re: Review Request 29915: Prevent NPE in Preemptor.

--- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 29915: Prevent NPE in Preemptor.

-CREATION Diff: https://reviews.apache.org/r/29915/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Review Request 29915: Prevent NPE in Preemptor.

/apache/aurora/scheduler/async/preemptor/CachedClusterState.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/async/preemptor/CachedClusterStateTest.java PRE-CREATION Diff: https://reviews.apache.org/r/29915/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review69268 --- Ship it! Ship It! - Zameer Manji On Jan. 22, 2015, 1:09 p.m

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

/ --- (Updated Jan. 22, 2015, 1:09 p.m.) Review request for Aurora, Brian Wickman and Zameer Manji. Bugs: AURORA-1029 https://issues.apache.org/jira/browse/AURORA-1029 Repository: aurora Description --- Remove support for cluster

Review Request 30207: Simplify AuroraCommandContext

/cli/test_supdate.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a248cfe0a96458fb70c Diff: https://reviews.apache.org/r/30207/diff/ Testing --- ./pants test.pytest --no-fast src/test/python/apache/aurora/client:: Thanks, Zameer Manji

Re: Review Request 31104: task-executor: TASK_RUNNING after first health check

in the UpdateConfig are timeouts until a task enters the RUNNING state? - Zameer Manji On Feb. 16, 2015, 10:22 p.m., Moses Nakamura wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31104

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

On Feb. 14, 2015, 11:39 a.m., Florian Pfeiffer wrote: docs/build-for-centos.md, line 40 https://reviews.apache.org/r/31042/diff/1/?file=864093#file864093line40 Installing gradle is probably not needed, since the gradle wrapper is included in the aurora project? Zameer Manji

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

) and Kevin Sweeny (kevints) to the People line of the review? - Zameer Manji On Feb. 16, 2015, 11:21 a.m., Craig Wickesser wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31042

Re: Review Request 30950: Add the option to make a non-hooked API.

://reviews.apache.org/r/30950/#comment118308 Why don't you just use the imported values instead of declaring them here again? - Zameer Manji On Feb. 12, 2015, 1:59 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail

Re: Review Request 30950: Add the option to make a non-hooked API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72251 --- Ship it! Ship It! - Zameer Manji On Feb. 12, 2015, 1:59 p.m

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72739 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10 a.m

Re: Review Request 31124: Fix build break - remove unused imports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31124/#review72740 --- Ship it! Ship It! - Zameer Manji On Feb. 17, 2015, 10:09 a.m

Review Request 31135: Pin protobuf dependency to 2.6.1

-py2.7.egg $ ./pants test.pytest --no-fast src/test/python:: Thanks, Zameer Manji

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

On Feb. 18, 2015, 5:17 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java, line 166 https://reviews.apache.org/r/31170/diff/1/?file=868472#file868472line166 Shouldn't PruneVictim have the IJobUpdateKey as the parameter? Bill

Re: Review Request 31170: Refactor existing write APIs for job updates to use IJobUpdateKey.

an IJobUpdateKey from PruneVictim. - Zameer Manji On Feb. 19, 2015, 12:30 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31170

Re: Review Request 30346: Only print when coverage is below the pass threshold.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30346/#review69931 --- Ship it! Ship It! - Zameer Manji On Jan. 27, 2015, 5:09 p.m

Re: Review Request 30383: Fix small typo in documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30383/#review70106 --- Ship it! Ship It! - Zameer Manji On Jan. 28, 2015, 3:20 p.m

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

should avoid it. Would you mind moving this test up to the TestJobUpdateCommand suite at the top of this file? This test could then be modified to have minimal patching. - Zameer Manji On Jan. 29, 2015, 9:13 a.m., Bill Farner wrote

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

into this pattern. - Zameer Manji On Jan. 29, 2015, 11:31 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30389

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70407 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2015, 11:18 a.m

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

/aurora/scheduler/base/CommandUtilTest.java 876e173ccbac04e4a06a245648c7c6af15eaaa92 src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/30471/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

/scheduler/configuration/ConfigurationManagerTest.java https://reviews.apache.org/r/30010/#comment114209 Can you actually add a test for the false case here? - Zameer Manji On Jan. 23, 2015, 1:20 a.m., Florian Pfeiffer wrote

Re: Review Request 30207: Simplify AuroraCommandContext

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30207/#review70043 --- Bill, can I get a ship it here? - Zameer Manji On Jan. 22, 2015

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

? - Zameer Manji On Jan. 26, 2015, 5:08 p.m., Florian Pfeiffer wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010

Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67711 --- @ReviewBot retry - Zameer Manji On Jan. 12, 2015, 11:53 a.m

Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67721 --- @ReviewBot retry - Zameer Manji On Jan. 12, 2015, 11:53 a.m

Re: Review Request 29015: Suppressing duplicate error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29015/#review66949 --- Ship it! Ship It! - Zameer Manji On Jan. 6, 2015, 3:49 p.m

Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67764 --- @ReviewBot retry - Zameer Manji On Jan. 12, 2015, 11:53 a.m

Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.

Thanks, Zameer Manji

Re: Review Request 30710: add mesos role feature

On Feb. 9, 2015, 4:56 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java, line 117 https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117 I don't think we can safely do this right now. I know

Re: Review Request 30749: Port GC executor to PathDetector interface

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71741 --- Ship it! Ship It! - Zameer Manji On Feb. 9, 2015, 3:16 p.m

Re: Review Request 30768: Reject None values for TaskPath

. To reply, visit: https://reviews.apache.org/r/30768/#review71589 --- On Feb. 9, 2015, 10:47 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 30749: Port GC executor to PathDetector interface

but this change LGTM. - Zameer Manji On Feb. 9, 2015, 10:56 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749

Re: Review Request 30768: Reject None values for TaskPath

/executor:: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji

Re: Review Request 30710: add mesos role feature

as changed when we start setting a previously unset field to a default value. See https://issues.apache.org/jira/browse/MESOS-2309 for details. Currently as this stands, I think this will cause existing Aurora instances to be rejected by the Master. - Zameer Manji On Feb. 9

Re: Review Request 30681: docs: Expand Getting Started document

/ --- (Updated Feb. 6, 2015, 9:07 a.m.) Review request for Aurora, Chris Aniszczyk, Dave Lester, Joshua Cohen, Marko Gargenta, and Zameer Manji. Repository: aurora Description --- docs: Expand Getting Started document Diffs - docs/vagrant.md

<    1   2   3   4   >