[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 13: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6444: CTAS STORED AS KUDU not supporting reordering of columns

2018-01-26 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9147 Change subject: IMPALA-6444: CTAS STORED AS KUDU not supporting reordering of columns .. IMPALA-6444: CTAS STORED AS KUDU not supporting

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#13). Change subject: IMPALA-6193: Track memory of incoming data streams

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 13: Build started:

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 13: Code-Review+2 (1 comment) Rebased the change,

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 11: (3 comments) Thanks for the review. I addressed the

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#12). Change subject: IMPALA-6193: Track memory of incoming data streams

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-26 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9146 ) Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

2018-01-26 Thread Michael Brown (Code Review)
Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9146 Change subject: IMPALA-6441 addendum: fix reading rows from HS2 via Impyla .. IMPALA-6441 addendum: fix reading rows from HS2 via Impyla

[native-toolchain-CR](cdh6.x) Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9145 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR](cdh6.x) Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9145 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Bump Kudu version to c6beta-impala-toolchain-tag1

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 1: (1 comment) The changes to the BE tests

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9058 ) Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled .. Patch Set 2: Code-Review+1 Carry +1 -- To view, visit

[Impala-ASF-CR] IMPALA-5528: Bump total thread cache size when KRPC is enabled

2018-01-26 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9058 to look at the new patch set (#2). Change subject: IMPALA-5528: Bump total thread cache size when KRPC is enabled

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 9: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. IMPALA-6356: Reduce amount of

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. IMPALA-6410: compare_branches: use looser

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2642: Fix a potential deadlock in statestore

2018-01-26 Thread Zoram Thanga (Code Review)
Hello Bharath Vissapragada, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9038 to look at the new patch set (#3). Change subject: IMPALA-2642: Fix a potential deadlock in statestore

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 9: Build started:

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8950 ) Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr .. Patch Set 9: Code-Review+2 Fixed clang tidy issue. Rebase,

[Impala-ASF-CR] IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

2018-01-26 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8950 to look at the new patch set (#9). Change subject: IMPALA-6346: Potential deadlock in KrpcDataStreamMgr

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8439 ) Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala .. Patch Set 6: Code-Review+2 (2 comments) Rebase. Carry +2.

[Impala-ASF-CR] IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala

2018-01-26 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8439 to look at the new patch set (#6). Change subject: IMPALA-5054: [SECURITY] Enable KRPC w/ TLS in Impala ..

[Impala-ASF-CR] IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace()

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9125 ) Change subject: IMPALA-6356: Reduce amount of logging from RpczStore::LogTrace() .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 11: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 3: Build started:

[native-toolchain-CR](cdh6.x) Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9145 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-26 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 8: I probably won't have a chance to look

[native-toolchain-CR] Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/9086 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Abandoned see https://gerrit.cloudera.org/#/c/9145/ -- To view,

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns .. Patch Set 3: (4 comments) Thanks for taking a look,

[Impala-ASF-CR] IMPALA-6113: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#3). Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns

[Impala-ASF-CR] IMPALA-5237: Support a quoted string in date/time format

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/8508 ) Change subject: IMPALA-5237: Support a quoted string in date/time format .. Patch Set 7: (5 comments) Thanks for getting back to this

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. Patch Set 2: (4 comments) LGTM, had minor

[Impala-ASF-CR] IMPALA-5717: Support for ORC data files

2018-01-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for ORC data files .. Patch Set 2: Here is a document about this patch:

[Impala-ASF-CR] IMPALA-5717: Support for ORC data files

2018-01-26 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9134 Change subject: IMPALA-5717: Support for ORC data files .. IMPALA-5717: Support for ORC data files This patch integrates the

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 ) Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6311: Skip row groups with predicates on NULL columns

2018-01-26 Thread Gabor Kaszab (Code Review)
Hello Lars Volker, Zoltan Borok-Nagy, anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9140 to look at the new patch set (#2). Change subject: IMPALA-6311: Skip row groups with predicates on NULL columns