[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 8: Verified+1 -- To view,

[Impala-ASF-CR] Use unqualified table refs in TPCH planner tests.

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9270 ) Change subject: Use unqualified table refs in TPCH planner tests. .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] Use unqualified table refs in TPCH planner tests.

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9270 ) Change subject: Use unqualified table refs in TPCH planner tests. .. Use unqualified table refs in TPCH planner tests.

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. IMPALA-6516: Log catalog update

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-13 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 17: Code-Review-1 Let me look into the failure. -- To

[Impala-ASF-CR] IMPALA-5752: Add support for DECIMAL on Kudu tables

2018-02-13 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9306 Change subject: IMPALA-5752: Add support for DECIMAL on Kudu tables .. IMPALA-5752: Add support for DECIMAL on Kudu tables Adds support

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line of query

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-13 Thread Vincent Tran (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9310 to look at the new patch set (#3). Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release output from RHEL OS

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-13 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/9310 ) Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release output from RHEL OS .. Patch Set 1: (1 comment)

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 7: Verified-1 Build

[Impala-ASF-CR] Use unqualified table refs in TPCH planner tests.

2018-02-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9270 ) Change subject: Use unqualified table refs in TPCH planner tests. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [docs] Removed the obsolete Llama options files

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9219 ) Change subject: [docs] Removed the obsolete Llama options files .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-13 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9271 to look at the new patch set (#7). Change subject: IMPALA-6497: add "Last row fetched" and AC events

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-13 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9250 to look at the new patch set (#4). Change subject: IMPALA-6519: API to allocate unreserved buffer ..

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-13 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9250 to look at the new patch set (#3). Change subject: IMPALA-6519: API to allocate unreserved buffer ..

[Impala-ASF-CR] IMPALA-6519: API to allocate unreserved buffer

2018-02-13 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9250 to look at the new patch set (#2). Change subject: IMPALA-6519: API to allocate unreserved buffer ..

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Code-Review+1 Thanks for fixing

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 8: Code-Review-1 part1+2 passed core tests.

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: Code-Review+2 (1 comment) Seems

[Impala-ASF-CR] IMPALA-6497: add "Last row fetched" and AC events

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 ) Change subject: IMPALA-6497: add "Last row fetched" and AC events .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9123 ) Change subject: IMPALA-4953,IMPALA-6437: separate AC/scheduler from catalog topic updates .. Patch Set 15: I was able to borrow a 140

[Impala-ASF-CR] IMPALA-6511: Fix state machine in FIS::UpdateState()

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9294 ) Change subject: IMPALA-6511: Fix state machine in FIS::UpdateState() .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6511: Fix state machine in FIS::UpdateState()

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9294 ) Change subject: IMPALA-6511: Fix state machine in FIS::UpdateState() .. IMPALA-6511: Fix state machine in

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 8: Code-Review+1 (2 comments) >

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 1: Code-Review+2 -- To view, visit

[native-toolchain-CR](cdh6.x) Quiet down file transfers, rename target platform variable

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9315 ) Change subject: Quiet down file transfers, rename target platform variable .. Quiet down file transfers, rename target

[native-toolchain-CR](cdh6.x) Quiet down file transfers, rename target platform variable

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9315 ) Change subject: Quiet down file transfers, rename target platform variable .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: (1 comment)

[native-toolchain-CR](cdh6.x) Quiet down file transfers, rename target platform variable

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9315 Change subject: Quiet down file transfers, rename target platform variable .. Quiet down file transfers, rename target platform

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9314 ) Change subject: Quiet down file transfers, rename target platform variable .. Quiet down file transfers, rename target

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9314 ) Change subject: Quiet down file transfers, rename target platform variable .. Patch Set 1: Code-Review+2 Clean cherry-pick

[native-toolchain-CR](cdh5.x) Quiet down file transfers, rename target platform variable

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9314 ) Change subject: Quiet down file transfers, rename target platform variable .. Patch Set 1: Verified+1 -- To view, visit

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Removed reviewer Kudu Jenkins. -- To view, visit

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Hello Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9313 to review the following change. Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB

[Impala-ASF-CR] KUDU-2296: Fix deserialization of messages larger than 64MB

2018-02-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9313 ) Change subject: KUDU-2296: Fix deserialization of messages larger than 64MB .. Patch Set 1: Clean cherry-pick -- To view, visit

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-13 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. IMPALA-5139: Update mvn-quiet.sh to

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: (1 comment)

[Impala-ASF-CR] Bump Kudu version to b315d0e

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/9217 ) Change subject: Bump Kudu version to b315d0e .. Abandoned Forgot about this, and we're going to bump the version again to pull in the

[Impala-ASF-CR] IMPALA-6516: Log catalog update only if the catalog version changes

2018-02-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9311 ) Change subject: IMPALA-6516: Log catalog update only if the catalog version changes .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 8: (1 comment) > Patch Set 8: > > (1

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 17: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: (1 comment)

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 8: (1 comment) > > Patch Set 5:

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-13 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9310 Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release output from RHEL OS .. IMPALA-6517:

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line of query

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-02-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: (1 comment) Quick clarification.

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-13 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has abandoned this change. ( http://gerrit.cloudera.org:8080/9308 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-13 Thread Alex Behm (Code Review)
Alex Behm has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. IMPALA-6392: Consistent explain format

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 13: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6392: Consistent explain format for parquet predicate statistics

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 ) Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics .. Patch Set 13: Verified+1 -- To

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-13 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9308 Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. IMPALA-5139: Update mvn-quiet.sh to

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-13 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9273 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. IMPALA-5139: Update mvn-quiet.sh to

[Impala-ASF-CR] IMPALA-6116: Bound memory usage of DataStreamSevice's service queue

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 ) Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue .. Patch Set 1: (6 comments) I went through the

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-13 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has abandoned this change. ( http://gerrit.cloudera.org:8080/9303 ) Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. Abandoned -- To view, visit

[Impala-ASF-CR] IMPALA-5139: Update mvn-quiet.sh to print execution content to log file

2018-02-13 Thread Nithya Janarthanan (Code Review)
Nithya Janarthanan has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9303 Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to log file .. IMPALA-5139: Update mvn-quiet.sh to

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. IMPALA-5269: Fix issue with final line of query

[Impala-ASF-CR] IMPALA-6511: Fix state machine in FIS::UpdateState()

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9294 ) Change subject: IMPALA-6511: Fix state machine in FIS::UpdateState() .. Patch Set 1: Thanks for the review! :) -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9302 ) Change subject: IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool .. Patch Set 1: Dan requested a combined version of the two

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: See https://gerrit.cloudera.org/#/c/9302/

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: (1 comment)

[Impala-ASF-CR] IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool

2018-02-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9302 Change subject: IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool .. IMPALA-4835: Part 2+3: switch I/O buffers to buffer pool

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: > Patch Set 7: > > David, it'd be great if you also had time for a look

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: David, it'd be great if you also had time for a look here. Thanks :)

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 Dependency changes: -

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. IMPALA-5690: Part 1: Rename ostream operators for thrift

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 7: > Patch Set 5: > > Since this is a very

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. Patch Set 7: Why is there "Merge Conflict" while the

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 Dependency changes: -

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. IMPALA-5690: Part 1: Rename ostream operators for thrift

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9300 Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 Dependency changes: -

[Impala-ASF-CR] IMPALA-5690: Part 1: Rename ostream operators for thrift types

2018-02-13 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Part 1: Rename ostream operators for thrift types .. IMPALA-5690: Part 1: Rename ostream operators for thrift

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 7: I ran private core and exhaustive tests and added skips for tests that

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#7). Change subject: IMPALA-6508: add KRPC test flag ..

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 17: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-02-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 16: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Hello Michael Ho, Michael Brown, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9291 to look at the new patch set (#6). Change subject: IMPALA-6508: add KRPC test flag ..

[Impala-ASF-CR] IMPALA-5269: Fix issue with final line of query followed by a comment

2018-02-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9191 ) Change subject: IMPALA-5269: Fix issue with final line of query followed by a comment .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-13 Thread Zoltan Borok-Nagy (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9239 to look at the new patch set (#4). Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-02-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 24: (1 comment)

[Impala-ASF-CR] IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows

2018-02-13 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9239 ) Change subject: IMPALA-6258: Uninitialized tuple pointers in row batch for empty rows .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-02-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: Original patch build:

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (2 comments) > This means we will have automated test runs with both

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (3 comments) > Patch Set 5: > > (3 comments) > > I was trying to think

[Impala-ASF-CR] IMPALA-6508: add KRPC test flag

2018-02-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 ) Change subject: IMPALA-6508: add KRPC test flag .. Patch Set 5: (3 comments) I was trying to think about how this could be done

[native-toolchain-CR] Quiet down file transfers, rename target platform variable

2018-02-13 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/9149 ) Change subject: Quiet down file transfers, rename target platform variable .. Patch Set 3: Verified+1 -- To view, visit

[native-toolchain-CR] Quiet down file transfers, rename target platform variable

2018-02-13 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9149 ) Change subject: Quiet down file transfers, rename target platform variable .. Quiet down file transfers, rename target platform

[native-toolchain-CR] Quiet down file transfers, rename target platform variable

2018-02-13 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/9149 ) Change subject: Quiet down file transfers, rename target platform variable .. Patch Set 3: Code-Review+2 Rebased, unchanged, carrying

  1   2   >