[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#12). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10760 to look at the new patch set (#13). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. IMPALA-7211: Fix the between predicate for

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7201. Support DDL with LocalCatalog enabled

2018-07-11 Thread Todd Lipcon (Code Review)
Hello Tianyi Wang, Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10806 to look at the new patch set (#4). Change subject: IMPALA-7201. Support DDL with LocalCatalog enabled

[Impala-ASF-CR] IMPALA-2422: Fix escaping in the LIKE clause

2018-07-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10910 ) Change subject: IMPALA-2422: Fix escaping in the LIKE clause .. IMPALA-2422: Fix escaping in the LIKE clause There are two stages

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. IMPALA-7279: Fix flakiness in

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10798 ) Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables .. Patch Set 4: Appears that some conflict

[Impala-ASF-CR] IMPALA-7140 (part 6): fetch column stats for LocalTable

2018-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10797 ) Change subject: IMPALA-7140 (part 6): fetch column stats for LocalTable .. IMPALA-7140 (part 6): fetch column stats for

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10757 to look at the new patch set (#8). Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. IMPALA-7006:

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#11). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-11 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10835 to look at the new patch set (#3). Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-7140 (part 8): support views in LocalCatalog

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10805 ) Change subject: IMPALA-7140 (part 8): support views in LocalCatalog .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 15: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-11 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 5: > Can you also add test

[Impala-ASF-CR] IMPALA-7129: Fixing path to UBSAN suppressions.

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10895 ) Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. .. IMPALA-7129: Fixing path to UBSAN suppressions.

[Impala-ASF-CR] IMPALA-7129: Fixing path to UBSAN suppressions.

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 ) Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Pranay Singh (Code Review)
Hello Lars Volker, Zoram Thanga, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10847 to look at the new patch set (#5). Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down

[Impala-ASF-CR] IMPALA-7211: Fix the between predicate for decimals

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10898 ) Change subject: IMPALA-7211: Fix the between predicate for decimals .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-7251: Fix QueryMaintenance calls in Aggregators

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10871 ) Change subject: IMPALA-7251: Fix QueryMaintenance calls in Aggregators .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6034: Add CPU and scanned bytes limits per query

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10415 ) Change subject: IMPALA-6034: Add CPU and scanned bytes limits per query .. Patch Set 9: Could you take another look, Bikram? -- To

[Impala-ASF-CR] IMPALA-1760: Implement shutdown command

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 ) Change subject: IMPALA-1760: Implement shutdown command .. Patch Set 11: (10 comments)

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. IMPALA-7095: clean up scan node profiles Add counters to

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 3: (5 comments) looks

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Bikramjeet Vig (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10922 to look at the new patch set (#3). Change subject: IMPALA-7279: Fix flakiness in test_rows_availability

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 4: Can you also add test case

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-11 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. IMPALA-7239: Disable smaps parsing by default

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10798 ) Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables .. Patch Set 4: Verified+1 -- To

[Impala-ASF-CR] IMPALA-7140 (part 8): support views in LocalCatalog

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10805 ) Change subject: IMPALA-7140 (part 8): support views in LocalCatalog .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-7140 (part 6): fetch column stats for LocalTable

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10797 ) Change subject: IMPALA-7140 (part 6): fetch column stats for LocalTable .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 15: Code-Review+2 Rebased and addressed the final

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: That carried +2 was from Sailesh,

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 10: Code-Review+2 Rebased and addressed the final

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's +2. --

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 10: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 7: Code-Review+2 Rebased, carrying Michael's +2. -- To

[Impala-ASF-CR] IMPALA-7212: Deprecate --use krpc flag and remove old DataStream services

2018-07-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10835 ) Change subject: IMPALA-7212: Deprecate --use_krpc flag and remove old DataStream services .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. Patch Set 5: Code-Review+2 Rebased, carrying Michael's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10769 to look at the new patch set (#15). Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#10). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build.

[Impala-ASF-CR] IMPALA-6086: Use of permanent function should require SELECT privilege on DB

2018-07-11 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 ) Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7129: Fixing path to UBSAN suppressions.

2018-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 ) Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7129: Fixing path to UBSAN suppressions.

2018-07-11 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 ) Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. .. Patch Set 6: The typo broke my testing. This time I tested it by

[Impala-ASF-CR] IMPALA-7129: Fixing path to UBSAN suppressions.

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10895 ) Change subject: IMPALA-7129: Fixing path to UBSAN suppressions. .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Pranay Singh (Code Review)
Hello Lars Volker, Zoram Thanga, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10847 to look at the new patch set (#4). Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down

[Impala-ASF-CR] IMPALA-7129: Fixing path to UBSAN suppressions.

2018-07-11 Thread Philip Zeyliger (Code Review)
Hello Fredy Wijaya, Jim Apple, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10895 to look at the new patch set (#6). Change subject: IMPALA-7129: Fixing path to UBSAN suppressions.

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Pranay Singh (Code Review)
Hello Lars Volker, Zoram Thanga, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10847 to look at the new patch set (#3). Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-11 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 3: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 14: (2 comments)

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. IMPALA-6881: COMPUTE STATS should require

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 1: (2 comments) Thanks David!

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Bikramjeet Vig (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10922 to look at the new patch set (#2). Change subject: IMPALA-7279: Fix flakiness in test_rows_availability

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. IMPALA-6881: COMPUTE STATS should require

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 ) Change subject: IMPALA-7163: Implement a state machine for the QueryState class .. Patch Set 6: (15 comments)

[Impala-ASF-CR] IMPALA-7163: Implement a state machine for the QueryState class

2018-07-11 Thread Sailesh Mukil (Code Review)
Hello Michael Ho, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10813 to look at the new patch set (#6). Change subject: IMPALA-7163: Implement a state machine for the QueryState class

[Impala-ASF-CR] IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10918 ) Change subject: IMPALA-6881: COMPUTE STATS should require SELECT privilege at analysis .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-7201. Support DDL with LocalCatalog enabled

2018-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10806 ) Change subject: IMPALA-7201. Support DDL with LocalCatalog enabled .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 10: Code-Review+2 Carry -- To view, visit

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 2: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7095: clean up scan node profiles

2018-07-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/10810 ) Change subject: IMPALA-7095: clean up scan node profiles .. Patch Set 8: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10923 ) Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/10922 ) Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-11 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. IMPALA-7209: Disallow self referencing in ALTER

[Impala-ASF-CR] IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables

2018-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10798 ) Change subject: IMPALA-7140 (part 7): small fixes to enable most queries on HDFS tables .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 ) Change subject: IMPALA-7239: Disable smaps parsing by default .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-7239: Disable smaps parsing by default

2018-07-11 Thread Tim Armstrong (Code Review)
Hello Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10884 to look at the new patch set (#3). Change subject: IMPALA-7239: Disable smaps parsing by default .. IMPALA-7239:

[Impala-ASF-CR] IMPALA-7209: Disallow self referencing in ALTER VIEW statements

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10908 ) Change subject: IMPALA-7209: Disallow self referencing in ALTER VIEW statements .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10923 Change subject: IMPALA-7059: Inconsistent privilege between DESCRIBE and DESCRIBE DATABASE .. IMPALA-7059: Inconsistent privilege

[Impala-ASF-CR] IMPALA-7279: Fix flakiness in test rows availability

2018-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10922 Change subject: IMPALA-7279: Fix flakiness in test_rows_availability .. IMPALA-7279: Fix flakiness in test_rows_availability This

[Impala-ASF-CR] IMPALA-7275: Create table authorization error should not show table name

2018-07-11 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10919 ) Change subject: IMPALA-7275: Create table authorization error should not show table name .. Patch Set 4: (1 comment)

  1   2   >