[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Michael Smith (Code Review)
Hello Daniel Becker, Yida Wu, Noemi Pap-Takacs, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20399 to look at the new patch set (#2). Change subject: IMPALA-5081: Add codegen_opt_level query option

[Impala-ASF-CR] IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline

2023-08-23 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20355 ) Change subject: IMPALA-12364: Display memory, disk and network metrics in webUI's query timeline .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-12395: Override scan cardinality for optimized count star

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20406 ) Change subject: IMPALA-12395: Override scan cardinality for optimized count star .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-08-23 Thread Kurt Deschler (Code Review)
Hello Riza Suminto, David Rorke, Surya Hebbar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20377 to look at the new patch set (#3). Change subject: IMPALA-12385: Enable Periodic metrics by default

[Impala-ASF-CR] IMPALA-12395: Override scan cardinality for optimized count star

2023-08-23 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20406 Change subject: IMPALA-12395: Override scan cardinality for optimized count star .. IMPALA-12395: Override scan cardinality for

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 5: > Patch Set 3: Code-Review+2 > > LGTM.

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-12253: Improve the integration of codegen cache and async codegen

2023-08-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20211 ) Change subject: IMPALA-12253: Improve the integration of codegen cache and async codegen .. Patch Set 2: I can't see that 'bool

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Noemi Pap-Takacs (Code Review)
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11957: Implement Regression functions: regr slope(), regr intercept() and regr r2()

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19569 ) Change subject: IMPALA-11957: Implement Regression functions: regr_slope(), regr_intercept() and regr_r2() .. Patch Set 20: > >

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-08-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 1: (2 comments)

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. [tools] Add Dev Container support for Impala

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has removed a vote on this change. Change subject: [tools] Add Dev Container support for Impala development. .. Removed Verified-1 by Impala Public Jenkins -- To view, visit http://gerrit.cloudera.org:8080/20380

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 4: Verified+1 > Patch Set 4: Verified-1 > >

[Impala-ASF-CR] IMPALA-12387: PartialUpdates is misleading for LOCAL filter

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20397 ) Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter .. Patch Set 1: Code-Review+1 (1 comment) LGTM

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-12393: Fix inconsistent hash for TimestampValue in DictEncoder

2023-08-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20396 ) Change subject: IMPALA-12393: Fix inconsistent hash for TimestampValue in DictEncoder .. Patch Set 2: Code-Review+1 LGTM -- To

[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. IMPALA-12274: Fix memory leak from

[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 8: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile even if the query failed in planning

2023-08-23 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 ) Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID .. Patch Set 12: (5

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread ttttttz (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20358 to look at the new patch set (#7). Change subject: IMPALA-10856: Show client hosts and connections in the web UI

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-08-23 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread ttttttz (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20358 to look at the new patch set (#6). Change subject: IMPALA-10856: Show client hosts and connections in the web UI

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread ttttttz (Code Review)
ttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 5: Yes, this ambiguity should be avoided. --

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread ttttttz (Code Review)
ttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 5: (1 comment) > Patch Set 4: Code-Review+1 > >

[Impala-ASF-CR] IMPALA-12089: Be able to skip pushing down a subset of the predicates

2023-08-23 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20133 ) Change subject: IMPALA-12089: Be able to skip pushing down a subset of the predicates .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12152: Add query option to wait for events sync up

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 ) Change subject: IMPALA-12152: Add query option to wait for events sync up .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 4: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread ttttttz (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20358 to look at the new patch set (#5). Change subject: IMPALA-10856: Show client hosts and connections in the web UI

[Impala-ASF-CR] IMPALA-12152: Add query option to wait for events sync up

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20131 ) Change subject: IMPALA-12152: Add query option to wait for events sync up .. Patch Set 12: (1 comment)

[Impala-ASF-CR] IMPALA-12024: Add catalog profile for createTable

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20368 ) Change subject: IMPALA-12024: Add catalog profile for createTable .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-12152: Add query option to wait for events sync up

2023-08-23 Thread Quanlong Huang (Code Review)
Hello Sai Hemanth Gantasala, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20131 to look at the new patch set (#12). Change subject: IMPALA-12152: Add query option to wait for events sync up

[Impala-ASF-CR] IMPALA-12024: Add catalog profile for createTable

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20368 ) Change subject: IMPALA-12024: Add catalog profile for createTable .. Patch Set 5: Added tests for creating kudu/iceberg tables --

[Impala-ASF-CR] IMPALA-12024: Add catalog profile for createTable

2023-08-23 Thread Quanlong Huang (Code Review)
Hello Riza Suminto, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20368 to look at the new patch set (#5). Change subject: IMPALA-12024: Add catalog profile for createTable

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile even if the query failed in planning

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning .. Patch Set 8: Code-Review+1

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 3: Code-Review+2 LGTM. Welcome back to the

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] [tools] Add Dev Container support for Impala development.

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 ) Change subject: [tools] Add Dev Container support for Impala development. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-11898: Add query options in the profile even if the query failed in planning

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19517 ) Change subject: IMPALA-11898: Add query options in the profile even if the query failed in planning .. Patch Set 8:

[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference

2023-08-23 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 7: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-12274: Fix memory leak from unreleased local reference

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20175 ) Change subject: IMPALA-12274: Fix memory leak from unreleased local reference .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10798: Initial support for reading JSON files

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19699 ) Change subject: IMPALA-10798: Initial support for reading JSON files .. Patch Set 27: Build Successful

[Impala-ASF-CR] IMPALA-10798: Initial support for reading JSON files

2023-08-23 Thread Zihao Ye (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19699 to look at the new patch set (#27). Change subject: IMPALA-10798: Initial support for reading JSON files

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20358 ) Change subject: IMPALA-10856: Show client hosts and connections in the web UI .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-10856: Show client hosts and connections in the web UI

2023-08-23 Thread ttttttz (Code Review)
Hello Quanlong Huang, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20358 to look at the new patch set (#4). Change subject: IMPALA-10856: Show client hosts and connections in the web UI