[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. Patch Set 4: Build Successful ht

[Impala-ASF-CR] IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles

2023-09-07 Thread ji chen (Code Review)
ji chen has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20439 ) Change subject: IMPALA-12397: NullPointerException in SHOW ROLES when there are no roles .. IMPALA-12397: NullPointerException in SHOW ROLES w

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20467 ) Change subject: IMPALA-12402: v1 change the term from consistency to concurrency and fix nits .. Patch Set 1: Build Successfu

[Impala-ASF-CR] IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20466 ) Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ .. Patch Set 1: Build Successful htt

[Impala-ASF-CR] IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache

2023-09-07 Thread Anonymous Coward (Code Review)
cclive1...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20466 Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ .. IMPALA-12402: Add some configurations

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-07 Thread Anonymous Coward (Code Review)
cclive1...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20467 Change subject: IMPALA-12402: v1 change the term from consistency to concurrency and fix nits .. IMPALA-12402: v1 change the ter

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Build Successful ht

[Impala-ASF-CR] IMPALA-12402: v1 change the term from consistency to concurrency and fix nits

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20467 ) Change subject: IMPALA-12402: v1 change the term from consistency to concurrency and fix nits .. Patch Set 1: (1 comment) ht

[Impala-ASF-CR] IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20466 ) Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ .. Patch Set 1: (1 comment) http://g

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 3: Build Successful https://jenkins.impal

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Code-Review+2 I think this is reasonable -- T

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20387 to look at the new patch set (#4). Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks ...

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 4: Build started: https

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Code-Review+1 So sorry, was looking at this loc

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#4) to the change originally created by Steve Carlin. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424:

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Fixed new clang-tidy perform

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#3) to the change originally created by Steve Carlin. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. IMPALA-12424:

[Impala-ASF-CR] IMPALA-12424: Allow third party JniFrontend interface.

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 ) Change subject: IMPALA-12424: Allow third party JniFrontend interface. .. Patch Set 4: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Build Failed https:

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 10: Code-Review+1 This looks good to me. +1'ing to

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 3: Build started: https

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20387 ) Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks .. Patch Set 2: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-12390 (part 1): Enable some clang-tidy performance related checks

2023-09-07 Thread Joe McDonnell (Code Review)
Hello Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20387 to look at the new patch set (#3). Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance related checks ...

[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20174 ) Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods

[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 ) Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods .. Patc

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 9: Build Successful https://jenkins.impala.

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-07 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-07 Thread Sai Hemanth Gantasala (Code Review)
Hello Quanlong Huang, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20420 to look at the new patch set (#9). Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes

[native-toolchain-CR] [tools] Install aws to Python 3 when available

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: [tools] Install aws to Python 3 when available .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20465/

[Impala-ASF-CR] IMPALA-12231: Bump GBN to get HMS thrift API changes

2023-09-07 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 ) Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c

[native-toolchain-CR] [tools] Install aws to Python 3 when available

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20465 ) Change subject: [tools] Install aws to Python 3 when available .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20465

[native-toolchain-CR] [tools] Install aws to Python 3 when available

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20465 Change subject: [tools] Install aws to Python 3 when available .. [tools] Install aws to Python 3 when available I encountered failures

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 7: (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-07 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 7: (1 comment) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 10: Verified+1 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 15: Build Successful https://jen

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 15: (4 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#15). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 14: Build Successful https://jen

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#14). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .

[Impala-ASF-CR] IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20443 ) Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ .. Patch Set 1: (2 comments) These changes s

[Impala-ASF-CR] IMPALA-11284: Do non-optional rewrites for || and Between predicate

2023-09-07 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18581 ) Change subject: IMPALA-11284: Do non-optional rewrites for || and Between predicate .. Patch Set 7: Code-Review+1 -- To view, visit ht

[Impala-ASF-CR] IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/20435 ) Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ .. Abandoned 20443 has a newer version. -- To view, vi

[Impala-ASF-CR] IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has abandoned this change. ( http://gerrit.cloudera.org:8080/20436 ) Change subject: IMPALA-12402: Add some configurations for CatalogdMetaProvider's cache_ .. Abandoned 20443 has a newer version. -- To view, vi

[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 ) Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods .. Patc

[Impala-ASF-CR] IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20174 ) Change subject: IMPALA-12273 Fix possible memory corruption of premature release of objects returned by native methods .. Patc

[Impala-ASF-CR] IMPALA-12385: Enable Periodic metrics by default

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 ) Change subject: IMPALA-12385: Enable Periodic metrics by default .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/203

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-07 Thread Kurt Deschler (Code Review)
Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 2: (3 comments) http://gerr

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 13: (4 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 10: Build started: https://jenkins.impala.

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20425 ) Change subject: IMPALA-10086: Implicit cast comparing char and varchar .. Patch Set 3: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-10086: Implicit cast comparing char and varchar

2023-09-07 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Daniel Becker, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20425 to look at the new patch set (#3). Change subject: IMPALA-10086: Implicit cast comparing char and varchar ..

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 13: Build Successful https://jen

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 12: Build Successful https://jen

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. Patch Set 2: Build Failed htt

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#13). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 12: (2 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20366 to look at the new patch set (#12). Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12430: Skip compression when sending row batches within same process

2023-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/20462 ) Change subject: IMPALA-12430: Skip compression when sending row batches within same process .. IMPALA-12430: Skip compression when sen

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Michael Smith (Code Review)
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20379 to look at the new patch set (#10). Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] [tools] Simplify local toolchain development

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 ) Change subject: [tools] Simplify local toolchain development .. Patch Set 5: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] [tools] Simplify local toolchain development

2023-09-07 Thread Michael Smith (Code Review)
Hello Laszlo Gaal, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20267 to look at the new patch set (#5). Change subject: [tools] Simplify local toolchain development ...

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-12357: Skip scheduling bloom filter from full-build scan

2023-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 ) Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan .. Patch Set 11: Code-Review+1 (2 comments) lgtm in

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. IMPALA-12413: Make Iceber

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. Patch Set 3: Verified+1 -- To v

[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Verified+1 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-12383: Fix SingleNodePlanner aggregation limits

2023-09-07 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/20379 ) Change subject: IMPALA-12383: Fix SingleNodePlanner aggregation limits .. Patch Set 9: Code-Review+1 (4 comments) Looks great. http://g

[Impala-ASF-CR] IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20108 ) Change subject: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. Patch Set 4: Build

[Impala-ASF-CR] IMPALA-5081: Add codegen opt level query option

2023-09-07 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 ) Change subject: IMPALA-5081: Add codegen_opt_level query option .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-09-07 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20108 ) Change subject: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. IMPALA-12159: Support ORDER BY

[Impala-ASF-CR] IMPALA-12159: Support ORDER BY for collections of variable length types in select list

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20108 ) Change subject: IMPALA-12159: Support ORDER BY for collections of variable length types in select list .. Patch Set 4: (1 com

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. Patch Set 3: Build started: http

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. Patch Set 3: Code-Review+2 -- T

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. Patch Set 2: Code-Review+2 -- To view, v

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. Patch Set 2: Build Successful h

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20453 ) Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala .. Patch Set 1: (3 comments) Thanks fo

[Impala-ASF-CR] IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala

2023-09-07 Thread Zoltan Borok-Nagy (Code Review)
Hello Tamas Mate, Gabor Kaszab, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/20453 to look at the new patch set (#2). Change subject: IMPALA-12413: Make Iceberg tables created by Trino compatible with Impala ...

[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-12399: Add filter to skip OPEN TXN events from HMS

2023-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20427 ) Change subject: IMPALA-12399: Add filter to skip OPEN_TXN events from HMS .. Patch Set 6: Build failed: https://jenkins.impala