[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 ) Change subject: IMPALA-9778: Refactor HdfsPartition to be immutable .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 3: Sorry for repeated comments, but one more

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-04-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 3: (1 comment)

[Impala-ASF-CR] WIP: Asynchronous code generation

2020-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15105 ) Change subject: WIP: Asynchronous code generation .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >d characters

2019-11-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14614 ) Change subject: IMPALA-9116: KUDU-2989. Work around SASL bug when FQDN is >=64 characters .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-7506: support global INVALIDATE METADATA in local catalog mode

2019-10-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14307 ) Change subject: IMPALA-7506: support global INVALIDATE METADATA in local catalog mode .. Patch Set 8: (3 comments) I generally like

[Impala-ASF-CR] IMPALA-9001: Fix SPNEGO for requests with no 'Authorization'

2019-10-04 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14352 ) Change subject: IMPALA-9001: Fix SPNEGO for requests with no 'Authorization' .. Patch Set 1: Code-Review+2 I suppose adding a test for

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 11: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-8228: Ownership support for Ranger authz

2019-09-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: IMPALA-8228: Ownership support for Ranger authz .. Patch Set 6: (4 comments)

[Impala-ASF-CR] [WIP] IMPALA-8228: Ownership support for Ranger authz

2019-08-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14106 ) Change subject: [WIP] IMPALA-8228: Ownership support for Ranger authz .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-8869: Fix handling of HTTP keep-alive when returning 401

2019-08-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/14076 ) Change subject: IMPALA-8869: Fix handling of HTTP keep-alive when returning 401 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8661 : Add randomized tests to stress MetastoreEventsProcessor

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13932 ) Change subject: IMPALA-8661 : Add randomized tests to stress MetastoreEventsProcessor .. Patch Set 2: I'm out the next two weeks on

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 7: Code-Review+2 k, seems like this is

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server

2019-07-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13918 ) Change subject: IMPALA-8783: Add Kerberos SPNEGO support to the http hs2 server .. Patch Set 1: (2 comments)

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-11 Thread Todd Lipcon (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13774 to look at the new patch set (#4). Change subject: Support SPNEGO for Impala webserver

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13774 ) Change subject: Support SPNEGO for Impala webserver .. Patch Set 1: (4 comments)

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-09 Thread Todd Lipcon (Code Review)
Hello Thomas Tauber-Marshall, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13774 to look at the new patch set (#2). Change subject: Support SPNEGO for Impala webserver

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 1: Code-Review+2 (1 comment) +2 pending one issue

[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories

2019-07-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 12: Code-Review+2 -- To view,

[Impala-ASF-CR] build: use thin static archives

2019-07-02 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13775 to look at the new patch set (#2). Change subject: build: use thin static archives

[Impala-ASF-CR] build: use thin static archives

2019-07-02 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13775 ) Change subject: build: use thin static archives .. Patch Set 1: > Patch Set 1: > > I tried this out and I couldn't tell a difference

[Impala-ASF-CR] Support SPNEGO for Impala webserver

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13774 Change subject: Support SPNEGO for Impala webserver .. Support SPNEGO for Impala webserver This ports over changes from kudu commit

[Impala-ASF-CR] build: use thin static archives

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13775 Change subject: build: use thin static archives .. build: use thin static archives This enables thin static archives for our internal

[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 11: (3 comments)

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-07-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13768 ) Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95 .. Patch Set 3: Code-Review+2 ps2 fixes the whitespace, ps3

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-07-01 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13768 to look at the new patch set (#2). Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala-ASF-CR] IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-28 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13764 ) Change subject: IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-06-28 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13768 to review the following change. Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

[Impala-ASF-CR] Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d

2019-06-28 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13767 to review the following change. Change subject: Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d

[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload

2019-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 ) Change subject: IMPALA-8585: Insert data into ACID table during dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories

2019-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13665 ) Change subject: IMPALA-8663 : FileMetadataLoader should skip hidden and tmp directories .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-8627: re-enable catalog v2 in containers

2019-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13708 ) Change subject: IMPALA-8627: re-enable catalog v2 in containers .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8682: Add authorized proxy user/group test coverage with Ranger

2019-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13679 ) Change subject: IMPALA-8682: Add authorized proxy user/group test coverage with Ranger .. Patch Set 5: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8682: Add authorized proxy user/group test coverage with Ranger

2019-06-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13679 ) Change subject: IMPALA-8682: Add authorized proxy user/group test coverage with Ranger .. Patch Set 4: (2 comments)

[Impala-ASF-CR] Backport KUDU-2871 (part 1): disable TLS 1.3.

2019-06-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13689 ) Change subject: Backport KUDU-2871 (part 1): disable TLS 1.3. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 5: (3 comments)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-19 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#5). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#4). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#3). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-8584: Add cookie support to the HTTP HS2 server

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13672 ) Change subject: IMPALA-8584: Add cookie support to the HTTP HS2 server .. Patch Set 2: (5 comments) didn't look in detail yet, a

[Impala-ASF-CR] IMPALA-8667. Remove --pull incremental stats flag

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13671 to review the following change. Change subject: IMPALA-8667. Remove --pull_incremental_stats flag ..

[Impala-ASF-CR] IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13664 to look at the new patch set (#2). Change subject: IMPALA-7534. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider .. Patch Set 1: > Patch Set 1: > > I'm trying to

[Impala-ASF-CR] IMPALA-8658: Populate missing Ranger audit fields

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13601 ) Change subject: IMPALA-8658: Populate missing Ranger audit fields .. Patch Set 8: > Patch Set 8: > > > Patch Set 7: Verified-1 > > > >

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-18 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. IMPALA-8542. Add an access trace for the data cache This

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. fe: improve logging for metadata loading This annotates various

[Impala-ASF-CR] WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13664 ) Change subject: WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider .. Patch Set 1: (2 comments)

[Impala-ASF-CR] WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider

2019-06-17 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13664 to review the following change. Change subject: WIP: IMPALA-7434. Handle invalidation races in CatalogdMetaProvider

[Impala-ASF-CR] IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13663 ) Change subject: IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update .. Patch Set 4: Code-Review+2 --

[Impala-ASF-CR] IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13663 ) Change subject: IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13663 ) Change subject: IMPALA-8671: Do not re-create RangerAuthorizationChecker instance on catalog update .. Patch Set 2: (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 3: Code-Review+1 --

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 7: Code-Review+2 looks good. Thanks! -- To view, visit

[Impala-ASF-CR] IMPALA-8658: Populate missing Ranger audit fields

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13601 ) Change subject: IMPALA-8658: Populate missing Ranger audit fields .. Patch Set 5: (4 comments)

[Impala-ASF-CR] IMPALA-8599: Create a Maven module for query event hook API

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13653 ) Change subject: IMPALA-8599: Create a Maven module for query event hook API .. Patch Set 2: Code-Review+2 (1 comment) Looks fine. We

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: (1 comment)

[Impala-ASF-CR] [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement

2019-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13545 ) Change subject: [WIP] IMPALA-8630: Hash the full path when calculating consistent remote placement .. Patch Set 2: (3 comments)

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13463 to look at the new patch set (#4). Change subject: fe: improve logging for metadata loading

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-14 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13425 to look at the new patch set (#7). Change subject: IMPALA-8542. Add an access trace for the data cache

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 3: Ran a build locally with

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-13 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13425 to look at the new patch set (#4). Change subject: IMPALA-8542. Add an access trace for the data cache

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 5: r4 fixes the comments, r5 is a rebase (had a

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-13 Thread Todd Lipcon (Code Review)
Hello Michael Ho, Lars Volker, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13425 to look at the new patch set (#5). Change subject: IMPALA-8542. Add an access trace for the data cache

[Impala-ASF-CR] IMPALA-8542. Add an access trace for the data cache

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13425 ) Change subject: IMPALA-8542. Add an access trace for the data cache .. Patch Set 3: (10 comments)

[Impala-ASF-CR] IMPALA-8583: Add metrics for Basic auth

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13640 ) Change subject: IMPALA-8583: Add metrics for Basic auth .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8658: Populate missing Ranger audit fields

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13601 ) Change subject: IMPALA-8658: Populate missing Ranger audit fields .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 1: (4 comments) r2 fixes the

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-13 Thread Todd Lipcon (Code Review)
Hello Bharath Vissapragada, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13557 to look at the new patch set (#2). Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 1: (7 comments) patch set r2 has fixes for the comments. r3 will

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-13 Thread Todd Lipcon (Code Review)
Hello Vihang Karajgaonkar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13463 to look at the new patch set (#2). Change subject: fe: improve logging for metadata loading

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-8658: Populate missing Ranger audit fields

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13601 ) Change subject: IMPALA-8658: Populate missing Ranger audit fields .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. Patch Set 6: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8585: Insert data into ACID table during dataload

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13633 ) Change subject: IMPALA-8585: Insert data into ACID table during dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8583: Add metrics for BASIC auth

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13640 ) Change subject: IMPALA-8583: Add metrics for BASIC auth .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-8658: Populate missing Ranger audit fields

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13601 ) Change subject: IMPALA-8658: Populate missing Ranger audit fields .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8654: Log the SQL statement in the Ranger audit log

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13590 ) Change subject: IMPALA-8654: Log the SQL statement in the Ranger audit log .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8649: Fix confusing SHOW GRANT error messages

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13587 ) Change subject: IMPALA-8649: Fix confusing SHOW GRANT error messages .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8617: Add support for lz4 in parquet

2019-06-11 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13582 ) Change subject: IMPALA-8617: Add support for lz4 in parquet .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-8551: Make the grant/revoke error messages to be more user friendly

2019-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 ) Change subject: IMPALA-8551: Make the grant/revoke error messages to be more user friendly .. Patch Set 7: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8633 : Insert event should not error when table does not exists

2019-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13548 ) Change subject: IMPALA-8633 : Insert event should not error when table does not exists .. Patch Set 4: (1 comment) Is there any e2e

[Impala-ASF-CR] fe: improve logging for metadata loading

2019-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13463 ) Change subject: fe: improve logging for metadata loading .. Patch Set 1: Vihang, any chance you can take a look at this? -- To view,

[Impala-ASF-CR] IMPALA-8551: Make the grant/revoke error messages to be more user friendly

2019-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 ) Change subject: IMPALA-8551: Make the grant/revoke error messages to be more user friendly .. Patch Set 5: (1 comment)

[Impala-ASF-CR] Bump CDP BUILD NUMBER to 1153860

2019-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13574 ) Change subject: Bump CDP_BUILD_NUMBER to 1153860 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13574

[Impala-ASF-CR] IMPALA-8551: Bump CDP BUILD NUMBER to 1153860

2019-06-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 ) Change subject: IMPALA-8551: Bump CDP_BUILD_NUMBER to 1153860 .. Patch Set 5: (2 comments) Looks pretty good modulo some nits. One

[Impala-ASF-CR] Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13563 Change subject: Update mustache to commit b290952d8eb93d085214d8c8c9eab8559df9f606 .. Update mustache to commit

[Impala-ASF-CR] IMPALA-8551: Bump CDP BUILD NUMBER to 1153860

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13525 ) Change subject: IMPALA-8551: Bump CDP_BUILD_NUMBER to 1153860 .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13557 ) Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

2019-06-07 Thread Todd Lipcon (Code Review)
Hello Tim Armstrong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13557 to review the following change. Change subject: IMPALA-8459. LocalCatalog: Allow dropping tables that fail to load

[Impala-ASF-CR] IMPALA-8635. Use local metastore URIs when checking for Kudu/HMS integration

2019-06-07 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13555 Change subject: IMPALA-8635. Use local metastore URIs when checking for Kudu/HMS integration .. IMPALA-8635. Use local metastore URIs

  1   2   3   4   5   6   7   8   9   10   >