[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-23 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#2). Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-5801: [draft] Clean up codegen GetType() interface

2018-01-23 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9063 to look at the new patch set (#3). Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: (2 comments) look good to me. But the interface for

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: (1 comment) I think the usage LibCacheEntry* interface

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: GVO failed with IMPALA-6399 -- To view,

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. IMPALA-6435: Disable codegen for CHAR literals.

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 6: Build failed:

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-23 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#14) to the change originally created by Zoltan Borok-Nagy. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. IMPALA-5191:

[Impala-ASF-CR] IMPALA-5440 Add planner tests with extreme statistics values

2018-01-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 ) Change subject: IMPALA-5440 Add planner tests with extreme statistics values .. Patch Set 3: (7 comments)

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 18: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5191: Standardize column alias behavior

2018-01-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8801 ) Change subject: IMPALA-5191: Standardize column alias behavior .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-01-23 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9114 Change subject: IMPALA-6429: Fix decimal division .. IMPALA-6429: Fix decimal division Before this patch, it was possible for an

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9089 ) Change subject: IMPALA-6215: Removes race when using LibCache. .. Patch Set 2: (2 comments) Absolutely agree that lib-cache api is

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Xianda Ke (Code Review)
Xianda Ke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 9: Thank Tim a lot for the review. @Sailesh, would you

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 7: (12 comments) Applied update.

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#8). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
Hello Philip Zeyliger, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9102 to look at the new patch set (#4). Change subject: IMPALA-6435: Disable codegen for CHAR literals.

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-23 Thread Bikramjeet Vig (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9098 to look at the new patch set (#2). Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-6215: Removes race when using LibCache.

2018-01-23 Thread Vuk Ercegovac (Code Review)
Hello Tim Armstrong, Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9089 to look at the new patch set (#3). Change subject: IMPALA-6215: Removes race when using LibCache.

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 ) Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. Patch Set 5: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9045 ) Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. IMPALA-6410: Tool to cherrypick changes

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-23 Thread Tim Armstrong (Code Review)
Hello Bikramjeet Vig, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8966 to look at the new patch set (#11). Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool ..

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: Anyone want to do a +2 review? -- To

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Hello Sailesh Mukil, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9079 to look at the new patch set (#9). Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 17: Build started:

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 17: Code-Review+2 Fixed a rogue DCHECK, ran

[Impala-ASF-CR] IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8966 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. Patch Set 11: Fixed the remaining core tests. -- To view,

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-01-23 Thread Zoltan Borok-Nagy (Code Review)
Hello Dimitris Tsirogiannis, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9090 to look at the new patch set (#2). Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9100 to review the following change. Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

[Impala-ASF-CR] IMPALA-6383: free memory after skipping parquet row groups

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9059 ) Change subject: IMPALA-6383: free memory after skipping parquet row groups .. Patch Set 4: I'm happy to +2 this one. Alex, do you have

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Verified+1 Code-Review+2

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. IMPALA-6399: Fix timeout logic in

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#15). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 1: (1 comment)

[Impala-ASF-CR](refs/meta/config) Modify access rules

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9104 Change subject: Modify access rules .. Modify access rules Change-Id: I0ad3cec33990043480decb3b1bb37893d5f64b6e --- M project.config

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9102 to look at the new patch set (#2). Change subject: IMPALA-6435: Disable codegen for CHAR literals. ..

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#8). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 12: Code-Review+2 -- To

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins.

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9101 Change subject: Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins. .. Expose refs/heads/2.x and

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9102 Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. IMPALA-6435: Disable codegen for CHAR literals. Currently we do not

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. IMPALA-3942: Fix wrongly escaped string

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9101 to look at the new patch set (#2). Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Expose

[Impala-ASF-CR](refs/meta/config) Modify access rules

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has abandoned this change. ( http://gerrit.cloudera.org:8080/9104 ) Change subject: Modify access rules .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9104 To unsubscribe, visit

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9101 to look at the new patch set (#3). Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Expose

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9102 to look at the new patch set (#3). Change subject: IMPALA-6435: Disable codegen for CHAR literals. ..

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#16). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins. .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 1: GVO failed, but we know this

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 7: (12 comments)

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 11: Thanks you all for the reviews! -- To

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9101 ) Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Expose refs/heads/2.x and refs/sandbox//*. refs/heads/2.x is

[Impala-ASF-CR](refs/meta/config) Fixing typo: removing "heads" from "refs/sandbox"

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9106 ) Change subject: Fixing typo: removing "heads" from "refs/sandbox" .. Fixing typo: removing "heads" from "refs/sandbox"

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Kim Jin Chul (Code Review)
Hello Thomas Tauber-Marshall, Gabor Kaszab, Jim Apple, Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8818 to look at the new patch set (#10). Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 10: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 1: Code-Review+2 I'm testing GVO

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5903: Inconsistent specification of result set and result set metadata

2018-01-23 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9090 ) Change subject: IMPALA-5903: Inconsistent specification of result set and result set metadata .. Patch Set 1: Thanks for looking

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: -Code-Review Sailesh, Zoram,

[Impala-ASF-CR] IMPALA-3942: Fix wrongly escaped string literal in front-end

2018-01-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/8818 ) Change subject: IMPALA-3942: Fix wrongly escaped string literal in front-end .. Patch Set 10: Code-Review+2 Thanks for your patience and

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 6: (22 comments) Applied the update.

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-23 Thread Kim Jin Chul (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8851 to look at the new patch set (#7). Change subject: IMPALA-3193: Show table's comment on show tables ..

[Impala-ASF-CR] IMPALA-6399: Fix timeout logic in test query profile thrift timestamps

2018-01-23 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9079 ) Change subject: IMPALA-6399: Fix timeout logic in test_query_profile_thrift_timestamps .. Patch Set 8: Code-Review+1 -- To view,

[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds

2018-01-23 Thread Alex Rodoni (Code Review)
Hello John Russell, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9084 to look at the new patch set (#2). Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds

[Impala-ASF-CR] IMPALA-6395: Add a flag for data stream sender's buffer size

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9026 ) Change subject: IMPALA-6395: Add a flag for data stream sender's buffer size .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2018-01-23 Thread Lars Volker (Code Review)
Hello Michael Ho, Joe McDonnell, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#18). Change subject: IMPALA-6190/6246: Add instances tab and event sequence

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 9: Code-Review+1 LGTM. Might be good if Sailesh had

[Impala-ASF-CR] IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

2018-01-23 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9113 Change subject: IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE .. IMPALA-6024: Min sample bytes for COMPUTE STATS TABLESAMPLE

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-23 Thread Xianda Ke (Code Review)
Hello Zoltan Borok-Nagy, Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9032 to look at the new patch set (#9). Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. IMPALA-4132: Use -fno-omit-frame-pointer Using

[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds

2018-01-23 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. Patch Set 1: (3 comments)

[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds

2018-01-23 Thread John Russell (Code Review)
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. Patch Set 2: Code-Review+1 LGTM. I'll let Tim give the

[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds

2018-01-23 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. Patch Set 1: (3 comments)

[native-toolchain-CR] Patch thrift-0.9.3 for python 2.6.

2018-01-23 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9109 Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch thrift-0.9.3 for python 2.6. Thrift 0.9.3 doesn't work with python 2.6. The

[Impala-ASF-CR] IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters.

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8349 ) Change subject: IMPALA-6059: Enhance ltrim()/rtrim() functions to trim any set of characters. .. Patch Set 12: Verified+1 --

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-01-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8997 ) Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-6338: Fix flaky test profile fragment instances

2018-01-23 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8997 to look at the new patch set (#3). Change subject: IMPALA-6338: Fix flaky test_profile_fragment_instances

[Impala-ASF-CR] [DOCS] IMPALA-6105 unix timestamp returns a number of seconds

2018-01-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9084 ) Change subject: [DOCS] IMPALA-6105 unix_timestamp returns a number of seconds .. [DOCS] IMPALA-6105 unix_timestamp

  1   2   >