[Impala-ASF-CR] IMPALA-10524: Changes to HdfsPartition for third party extensions.

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17092 ) Change subject: IMPALA-10524: Changes to HdfsPartition for third party extensions. .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-10520: Implement ds theta intersect() function

2021-02-22 Thread Fucun Chu (Code Review)
Fucun Chu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17088 Change subject: IMPALA-10520: Implement ds_theta_intersect() function .. IMPALA-10520: Implement ds_theta_intersect() function This

[Impala-ASF-CR] IMPALA-10524: Changes to HdfsPartition for third party extensions.

2021-02-22 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/17092 ) Change subject: IMPALA-10524: Changes to HdfsPartition for third party extensions. .. IMPALA-10524: Changes to HdfsPartition for third

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 ) Change subject: IMPALA-10504: Add tracing for remote block reads .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2:

[Impala-ASF-CR] IMPALA-10520: Implement ds theta intersect() function

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17088 ) Change subject: IMPALA-10520: Implement ds_theta_intersect() function .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. IMPALA-10525: Add param to BuiltinsDb to defer

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 3: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 ) Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing .. Patch Set 3: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-22 Thread Kurt Deschler (Code Review)
Hello Aman Sinha, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17062 to look at the new patch set (#6). Change subject: IMPALA-10504: Add tracing for remote block reads

[Impala-ASF-CR] IMPALA-10535: Add interface to ImpalaServer for execution of externally compiled statements

2021-02-22 Thread Kurt Deschler (Code Review)
Hello j...@cloudera.com, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17104 to look at the new patch set (#3). Change subject: IMPALA-10535: Add interface to ImpalaServer for execution of externally compiled statements

[Impala-ASF-CR] IMPALA-10535: Add interface to ImpalaServer for execution of externally compiled statements

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17104 ) Change subject: IMPALA-10535: Add interface to ImpalaServer for execution of externally compiled statements .. Patch Set 3:

[Impala-ASF-CR] IMPALA-10520: Implement ds theta intersect() function

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17088 ) Change subject: IMPALA-10520: Implement ds_theta_intersect() function .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. IMPALA-10510: Change code to help

[Impala-ASF-CR] IMPALA-10505: Avoid creating misleading audit logs

2021-02-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17078 ) Change subject: IMPALA-10505: Avoid creating misleading audit logs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ..

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Vihang Karajgaonkar, Gabor Kaszab, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17081 to look at the new patch set (#2). Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-10533: Fix TestScratchDir.test scratch dirs mix local and remote dir spill local only seems flaky

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17102 ) Change subject: IMPALA-10533: Fix TestScratchDir.test_scratch_dirs_mix_local_and_remote_dir_spill_local_only seems flaky ..

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#14). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: (5 comments) Thanks for your review, Tim!

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17071 to look at the new patch set (#3). Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <=

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ..

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ..

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: Build Successful

[Impala-ASF-CR] IMPALA-10505: Avoid creating misleading audit logs

2021-02-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17078 ) Change subject: IMPALA-10505: Avoid creating misleading audit logs .. Patch Set 2: (4 comments) The fix looks good to me. Just have

[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build

2021-02-22 Thread Yida Wu (Code Review)
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17101 Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build ..

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Yida Wu (Code Review)
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17100 Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix

[Impala-ASF-CR] IMPALA-10526: Fix BufferPoolTest.Multi8RandomSpillToRemoteMix failed in sanitizer builds

2021-02-22 Thread Yida Wu (Code Review)
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17096 Change subject: IMPALA-10526: Fix BufferPoolTest.Multi8RandomSpillToRemoteMix failed in sanitizer builds .. IMPALA-10526: Fix

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 1: Build

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10533: Fix TestScratchDir.test scratch dirs mix local and remote dir spill local only seems flaky

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17102 ) Change subject: IMPALA-10533: Fix TestScratchDir.test_scratch_dirs_mix_local_and_remote_dir_spill_local_only seems flaky ..

[Impala-ASF-CR] IMPALA-10533: Fix TestScratchDir.test scratch dirs mix local and remote dir spill local only seems flaky

2021-02-22 Thread Yida Wu (Code Review)
Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17102 Change subject: IMPALA-10533: Fix TestScratchDir.test_scratch_dirs_mix_local_and_remote_dir_spill_local_only seems flaky .. IMPALA-10533:

[Impala-ASF-CR] IMPALA-10526: Fix BufferPoolTest.Multi8RandomSpillToRemoteMix failed in sanitizer builds

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17096 ) Change subject: IMPALA-10526: Fix BufferPoolTest.Multi8RandomSpillToRemoteMix failed in sanitizer builds .. Patch Set 1:

[Impala-ASF-CR] IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17101 ) Change subject: IMPALA-10531: Fix TmpFileMgrTest.TestCompressBufferManagementEncryptedRemoteUpload failed in exhaustive release build

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 ) Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17095 to look at the new patch set (#3). Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ..

[Impala-ASF-CR] IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def levels .CacheRemaining() <= num buffered values

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17071 ) Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Steve Carlin (Code Review)
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 1: (3 comments) For the most part, the

[Impala-ASF-CR] IMPALA-10371: test java udfs crash impalad if result spooling is enabled

2021-02-22 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17106 Change subject: IMPALA-10371: test_java_udfs crash impalad if result spooling is enabled .. IMPALA-10371: test_java_udfs crash impalad

[Impala-ASF-CR] IMPALA-10371: test java udfs crash impalad if result spooling is enabled

2021-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17106 ) Change subject: IMPALA-10371: test_java_udfs crash impalad if result spooling is enabled .. Patch Set 2: Code-Review+1 Hi Daniel, The

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 1: (2

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-10371: test java udfs crash impalad if result spooling is enabled

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17106 ) Change subject: IMPALA-10371: test_java_udfs crash impalad if result spooling is enabled .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 ) Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing .. Patch Set 3: Code-Review+2 This looks good to

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 ) Change subject: IMPALA-10504: Add tracing for remote block reads .. Patch Set 5: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10504: Add tracing for remote block reads

2021-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 ) Change subject: IMPALA-10504: Add tracing for remote block reads .. Patch Set 5: This is looking good to me. Please wrap the long

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 2: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: (26 comments) Started the review maybe 1/3 way

[Impala-ASF-CR] IMPALA-10371: test java udfs crash impalad if result spooling is enabled

2021-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17106 ) Change subject: IMPALA-10371: test_java_udfs crash impalad if result spooling is enabled .. Patch Set 2: Code-Review+1 lgtm, will

[Impala-ASF-CR] IMPALA-10525: Add param to BuiltinsDb to defer initialization

2021-02-22 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17093 ) Change subject: IMPALA-10525: Add param to BuiltinsDb to defer initialization .. Patch Set 1: (1 comment) Sounds like a good idea to

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Yida Wu (Code Review)
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Yida Wu (Code Review)
Yida Wu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. IMPALA-10527: Fix

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2: Build

[Impala-ASF-CR] IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build

2021-02-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 ) Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build .. Patch Set 2:

[Impala-ASF-CR] IMPALA-9218: Add support for locally compiled Hive

2021-02-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 ) Change subject: IMPALA-9218: Add support for locally compiled Hive .. Patch Set 2: (3 comments) This makes sense to me. Can you add

[Impala-ASF-CR] IMPALA-10533: Fix TestScratchDir.test scratch dirs mix local and remote dir spill local only seems flaky

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17102 ) Change subject: IMPALA-10533: Fix TestScratchDir.test_scratch_dirs_mix_local_and_remote_dir_spill_local_only seems flaky ..

[Impala-ASF-CR] IMPALA-10533: Fix TestScratchDir.test scratch dirs mix local and remote dir spill local only seems flaky

2021-02-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17102 ) Change subject: IMPALA-10533: Fix TestScratchDir.test_scratch_dirs_mix_local_and_remote_dir_spill_local_only seems flaky ..

[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 4: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-10510: Change code to help with third party extensions

2021-02-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 ) Change subject: IMPALA-10510: Change code to help with third party extensions .. Patch Set 3: Code-Review+2 These changes look

[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description

2021-02-22 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17107 ) Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 ) Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables

2021-02-22 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17081 ) Change subject: IMPALA-10512: ALTER TABLE ADD PARTITION should bump the write id for ACID tables .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10536: Fix saml2 callback token ttl's description

2021-02-22 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17107 Change subject: IMPALA-10536: Fix saml2_callback_token_ttl's description .. IMPALA-10536: Fix saml2_callback_token_ttl's description