[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 9: Thank you all for the reviews. -- To view, visit htt

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 6: latest patch fixes a failure in gvo. would an

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 21: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 21: Code-Review+2 PS21 fixes a rebasing problem. Carrying

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#21). Change subject: IMPALA-6193: Track memory of incoming data streams ..

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. IMPALA-3282: Adds regexp_escape built-in function

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Vuk Ercegovac (Code Review)
Hello Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9133 to look at the new patch set (#6). Change subject: IMPALA-3562: support column restriction for compute stats

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 20: Verified-1 Build failed: https://jenkins.im

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 13: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 13: Code-Review+2 Hit unrelated flaky test -- To view,

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. IMPALA-6454

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 10: Verif

[Impala-ASF-CR] IMPALA-5931: Generates scan ranges in planner for s3/adls

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8523 ) Change subject: IMPALA-5931: Generates scan ranges in planner for s3/adls .. Patch Set 9: (14 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9096/7/fe/s

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016

[Impala-ASF-CR] IMPALA-6242: Change runtime-profile-test into using the same clock

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9171 ) Change subject: IMPALA-6242: Change runtime-profile-test into using the same clock .. Patch Set 1: Verified+1 -- To view, vis

[Impala-ASF-CR] IMPALA-6242: Change runtime-profile-test into using the same clock

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9171 ) Change subject: IMPALA-6242: Change runtime-profile-test into using the same clock .. IMPALA-6242: Change runtime-profi

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 1: > (5 comments) > > I'm not really qualified to review this chan

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. IMPALA-6430: Log relevant d

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 4: Verified+1 -- To vie

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8080/#/c/9096/9/fe/sr

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 12: Verified-1 Build failed: https://jenkins.imp

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016 r

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 5: Verified-1 Build failed: https://jenk

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 8: Verified-1 Build failed: https://jen

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. IMPALA-6450: fix EventSequence::Start() It looks like this n

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 20: (10 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9096/7/fe/src

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 7: (1 comment) > Patch Set 7: > > (1 comment) http://gerr

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 4: (1 comment) > Patch Set 3: Code-Review+2 > > Also not for this p

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 1: (5 comments) I'm not really qualified to review this change,

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-01-31 Thread Tim Armstrong (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9173 to look at the new patch set (#3). Change subject: IMPALA-3271: organise and warn on removed startup flags .. IMPALA-

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 7: Thanks for the review. I will rebase and re-run exhaust

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 20: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 20: Code-Review+2 Rebased, carrying Michael's +2. -- To

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#20). Change subject: IMPALA-6193: Track memory of incoming data streams ..

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 7: (1 comment) Please see PS7. http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9153 to look at the new patch set (#7). Change subject: IMPALA-5293: Turn insert clustering on by default ..

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 8: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9096/7/fe/src

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 10: Buil

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 10: Code-Review+2 -

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9153/5/t

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 19: (3 comments) PS19 addresses Michael's comments. Will

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Lars Volker (Code Review)
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8914 to look at the new patch set (#19). Change subject: IMPALA-6193: Track memory of incoming data streams ..

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 2: (2 comments) I convinced myself with the followi

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. IMPALA-3271: organise and warn on removed startup flags Gather

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9173 Change subject: IMPALA-3271: organise and warn on removed startup flags .. IMPALA-3271: organise and warn on removed startup flags Gathe

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9096/7/

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 5: (1 comment) I'm still seeing s

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Pranay Singh (Code Review)
Hello Lars Volker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9147 to look at the new patch set (#10). Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 9: (3 comments)

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 6: (4 comments) Thanks for the review, please see my inli

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9153 to look at the new patch set (#6). Change subject: IMPALA-5293: Turn insert clustering on by default ..

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. IMPALA-3916: Reserve SQL:2016 reserved words This patch reserves SQL:2016 r

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-6448: Re-enable kerberized testing with KRPC

2018-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 ) Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9164

[Impala-ASF-CR] IMPALA-6075: Add Impala daemon metric for catalog version.

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8949 ) Change subject: IMPALA-6075: Add Impala daemon metric for catalog version. .. Patch Set 8: Build started: https://jenkins.impal

[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 ) Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption .. Patch Set 12: Verified-1 Build failed: https://jenkins

[Impala-ASF-CR] IMPALA-5293: Turn insert clustering on by default

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9153 ) Change subject: IMPALA-5293: Turn insert clustering on by default .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/9153/5/

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. IMPALA-6429: Fix decimal division Before this patch, it was possible for an over

[Impala-ASF-CR] IMPALA-6429: Fix decimal division

2018-01-31 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9114 ) Change subject: IMPALA-6429: Fix decimal division .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/9114/3/be/src/e

[Impala-ASF-CR] IMPALA-6242: Change runtime-profile-test into using the same clock

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9171 ) Change subject: IMPALA-6242: Change runtime-profile-test into using the same clock .. Patch Set 1: Build started: https://jenk

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 12: Build started: https://jenkins.impala.io/job/

[Impala-ASF-CR] IMPALA-3193: Show table's comment on show tables

2018-01-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 ) Change subject: IMPALA-3193: Show table's comment on show tables .. Patch Set 12: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-6242: Change runtime-profile-test into using the same clock

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9171 ) Change subject: IMPALA-6242: Change runtime-profile-test into using the same clock .. Patch Set 1: Code-Review+2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-5990: End-to-end compression of metadata

2018-01-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8825 ) Change subject: IMPALA-5990: End-to-end compression of metadata .. Patch Set 9: (5 comments) Great job! http://gerrit.clouder

[Impala-ASF-CR] IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. Patch Set 20: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names.

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9147 ) Change subject: IMPALA-6454: CTAS into Kudu fails with mixed-case partition or primary key column names. .. Patch Set 9: (3 comments) htt

[Impala-ASF-CR] IMPALA-6242: Change runtime-profile-test into using the same clock

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9171 Change subject: IMPALA-6242: Change runtime-profile-test into using the same clock .. IMPALA-6242: Change runtime-profile-test into using

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 4: Build started: https:

[Impala-ASF-CR] IMPALA-6430: Log relevant debug pages if wait for metric value times out

2018-01-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9098 ) Change subject: IMPALA-6430: Log relevant debug pages if wait_for_metric_value times out .. Patch Set 4: Code-Review+2 rebase to incl

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 18: Code-Review+2 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6193: Track memory of incoming data streams

2018-01-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8914 ) Change subject: IMPALA-6193: Track memory of incoming data streams .. Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/8914

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 3: Code-Review+2 Will wait for http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 5: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-3562: support column restriction for compute stats

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9133 ) Change subject: IMPALA-3562: support column restriction for compute stats .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-4319: remove some deprecated query options

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 ) Change subject: IMPALA-4319: remove some deprecated query options .. Patch Set 12: Build started: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-ver

[Impala-ASF-CR] IMPALA-6450: fix EventSequence::Start()

2018-01-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9155 ) Change subject: IMPALA-6450: fix EventSequence::Start() .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. IMPALA-6455: unique tmpdirs fo

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. Patch Set 2: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Alex Behm (Code Review)
Hello Vuk Ercegovac, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9139 to look at the new patch set (#3). Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. IMPALA

[Impala-ASF-CR] IMPALA-6228: Control stats extrapolation via tbl prop.

2018-01-31 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9139 ) Change subject: IMPALA-6228: Control stats extrapolation via tbl prop. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/913

[native-toolchain-CR](cdh5.x) Patch thrift-0.9.3 for python 2.6.

2018-01-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9170 ) Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch Set 1: > > Uploaded patch set 1. > > Thanks. I forgot this nativ

[native-toolchain-CR](cdh5.x) Patch thrift-0.9.3 for python 2.6.

2018-01-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9170 ) Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch Set 1: > Uploaded patch set 1. Thanks. I forgot this native-toolchain branch

[native-toolchain-CR](cdh5.x) Patch thrift-0.9.3 for python 2.6.

2018-01-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9170 ) Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:80

[native-toolchain-CR](cdh5.x) Patch thrift-0.9.3 for python 2.6.

2018-01-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9170 ) Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch Set 1: Code-Review+2 clean cherry-pick -- To view, visit http://

[native-toolchain-CR](cdh5.x) Patch thrift-0.9.3 for python 2.6.

2018-01-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9170 ) Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch thrift-0.9.3 for python 2.6. Thrift 0.9.3 doesn't work wit

[native-toolchain-CR](cdh5.x) Build old versions of gperftools and thrift.

2018-01-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9169 ) Change subject: Build old versions of gperftools and thrift. .. Build old versions of gperftools and thrift. We recent

[native-toolchain-CR](cdh5.x) Build old versions of gperftools and thrift.

2018-01-31 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9169 Change subject: Build old versions of gperftools and thrift. .. Build old versions of gperftools and thrift. We recently bumped

  1   2   >