[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9637 ) Change subject: IMPALA-6655: Add owner information on database creation .. Patch Set 1: (2 comments) Looks good to me as well, will merge

[Impala-ASF-CR] IMPALA-6683: Fix infinite loop after restarting the catalog

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9684 ) Change subject: IMPALA-6683: Fix infinite loop after restarting the catalog .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6683: Fix infinite loop after restarting the catalog

2018-03-15 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/9684 ) Change subject: IMPALA-6683: Fix infinite loop after restarting the catalog .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. IMPALA-6682: Remove MD5 assumption from

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] [DOCS] Changed to --use local tz for unix timestamp conversions

2018-03-15 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9620 ) Change subject: [DOCS] Changed to --use_local_tz_for_unix_timestamp_conversions .. Patch Set 3: John and Tim, Could one of you give

Re: [Impala-ASF-CR] IMPALA-6683: Fix infinite loop after restarting the catalog

2018-03-15 Thread Dimitris Tsirogiannis
Thanks for fixing this. I’ll take a look in about an hour from now. Dimitris On Thu, Mar 15, 2018 at 6:49 PM Alex Behm (Code Review) wrote: > Alex Behm *posted comments* on this change. > > View Change > > Patch set 1:Code-Review +1

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9667 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Patch Set 1: Verified+1 -- To view,

[Impala-ASF-CR] IMPALA-6683: Fix infinite loop after restarting the catalog

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9684 ) Change subject: IMPALA-6683: Fix infinite loop after restarting the catalog .. Patch Set 1: Code-Review+1 Looks good to me. I think we

[Impala-ASF-CR] IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9618 ) Change subject: IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations .. IMPALA-6654: [DOCS] Updated the

[Impala-ASF-CR] IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9618 ) Change subject: IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6683: Fix infinite loop after restarting the catalog

2018-03-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9684 Change subject: IMPALA-6683: Fix infinite loop after restarting the catalog .. IMPALA-6683: Fix infinite loop after restarting the catalog

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-15 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6655: Add owner information on database creation

2018-03-15 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9637 ) Change subject: IMPALA-6655: Add owner information on database creation .. Patch Set 1: Code-Review+1 Don't see any issues, just make

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9667 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Revert "IMPALA-6479: Update

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. IMPALA-6682: Remove MD5 assumption from pypi download

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. IMPALA-6682: Remove MD5 assumption from pypi download

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9683 ) Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6682: Remove MD5 assumption from pypi download script

2018-03-15 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9683 Change subject: IMPALA-6682: Remove MD5 assumption from pypi download script .. IMPALA-6682: Remove MD5 assumption from pypi download

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 5: Code-Review+1 (2 comments) I

[Impala-ASF-CR](impala-4835) IMPALA-6560: fix regression test for IMPALA-2376

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9675 ) Change subject: IMPALA-6560: fix regression test for IMPALA-2376 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9675 To

[Impala-ASF-CR](impala-4835) IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. ( http://gerrit.cloudera.org:8080/9674 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9674

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: (1 comment)

[Impala-ASF-CR](impala-4835) IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9674 ) Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. Patch Set 1: (1 comment)

[Impala-ASF-CR](impala-4835) IMPALA-6587: free buffers before ScanRange::Cancel() returns

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9674 Change subject: IMPALA-6587: free buffers before ScanRange::Cancel() returns .. IMPALA-6587: free buffers before ScanRange::Cancel()

[Impala-ASF-CR](impala-4835) IMPALA-6560: fix regression test for IMPALA-2376

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9675 Change subject: IMPALA-6560: fix regression test for IMPALA-2376 .. IMPALA-6560: fix regression test for IMPALA-2376 The test is

[Impala-ASF-CR](impala-4835) IMPALA-4835: Part 3: switch I/O buffers to buffer pool

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9673 ) Change subject: IMPALA-4835: Part 3: switch I/O buffers to buffer pool .. IMPALA-4835: Part 3: switch I/O buffers to buffer

[Impala-ASF-CR](impala-4835) IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9671 ) Change subject: IMPALA-4835: Part 1: simplify I/O mgr mem mgmt and cancellation .. IMPALA-4835: Part 1: simplify I/O mgr mem

[Impala-ASF-CR](impala-4835) IMPALA-4835: Part 2: Allocate scan range buffers upfront

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9672 ) Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront .. IMPALA-4835: Part 2: Allocate scan range buffers

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Hello Lars Volker, Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#5). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: (6 comments) > Patch Set 4: >

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns

2018-03-15 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9346 ) Change subject: IMPALA-6230, IMPALA-6468: Fix the output type of round() and related fns .. IMPALA-6230, IMPALA-6468: Fix the output

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: (6 comments) I had a first look

[Impala-ASF-CR] IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9618 ) Change subject: IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations .. Patch Set 2: Build started:

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9667 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Patch Set 1: Code-Review+2 Ok, this one looks good.

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9667 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Patch Set 1: Build started:

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9667 Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Revert "IMPALA-6479: Update DESCRIBE to respect

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. ( http://gerrit.cloudera.org:8080/9662 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Abandoned Something went wrong here. Abandoning. -- To view,

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9661 ) Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9661 ) Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-15 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9661 to look at the new patch set (#2). Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. ..

[Impala-ASF-CR] IMPALA-6338: Ensure successfully completed queries have full profile

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9656 ) Change subject: IMPALA-6338: Ensure successfully completed queries have full profile .. Patch Set 1: > There are some

[Impala-ASF-CR] IMPALA-6338: Ensure successfully completed queries have full profile

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. ( http://gerrit.cloudera.org:8080/9656 ) Change subject: IMPALA-6338: Ensure successfully completed queries have full profile .. Abandoned -- To view, visit

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9662 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Patch Set 1: We're reverting this on 2.x because

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9662 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-6672: test recover partitions.py should not be skipped on local FS

2018-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has abandoned this change. ( http://gerrit.cloudera.org:8080/9646 ) Change subject: IMPALA-6672: test_recover_partitions.py should not be skipped on local FS .. Abandoned -- To view, visit

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9662 ) Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. IMPALA-6643: Add REFRESH METADATA fine-grained privilege

[Impala-ASF-CR](2.x) Revert "IMPALA-6479: Update DESCRIBE to respect column privileges"

2018-03-15 Thread Adam Holley (Code Review)
Adam Holley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9662 Change subject: Revert "IMPALA-6479: Update DESCRIBE to respect column privileges" .. Revert "IMPALA-6479: Update DESCRIBE to respect

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. IMPALA-6488: removes use-after-free bug in

[Impala-ASF-CR] IMPALA-6573: Create consistent response on column access failures

2018-03-15 Thread Adam Holley (Code Review)
Adam Holley has abandoned this change. ( http://gerrit.cloudera.org:8080/9509 ) Change subject: IMPALA-6573: Create consistent response on column access failures .. Abandoned Duplicate of 9514. -- To view, visit

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-15 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9661 ) Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. .. Patch Set 1: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-15 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-15 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 4: soft +1. I'd like to test it

[Impala-ASF-CR] IMPALA-6675: Default to --compact catalog topic=true.

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9661 Change subject: IMPALA-6675: Default to --compact_catalog_topic=true. .. IMPALA-6675: Default to --compact_catalog_topic=true. Testing: -

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#4). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 3: (1 comment)

[native-toolchain-CR](cdh6.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9660 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 1: Code-Review+2 Clean cherry-pick -- To

[native-toolchain-CR](cdh6.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9660 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. CDH-65655: use ssh instead of https for Kudu

[native-toolchain-CR](cdh6.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9659 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: Build ORC C++ lib in toolchain This adds

[native-toolchain-CR](cdh6.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9660 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR](cdh6.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9659 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR](cdh6.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9659 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 1: Code-Review+2 Clean cherry-pick -- To view,

[native-toolchain-CR](cdh6.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9660 Change subject: CDH-65655: use ssh instead of https for Kudu github .. CDH-65655: use ssh instead of https for Kudu github

[native-toolchain-CR](cdh6.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9659 Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: Build ORC C++ lib in toolchain This adds the C++

[native-toolchain-CR](cdh5.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9658 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR](cdh5.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9658 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. CDH-65655: use ssh instead of https for Kudu

[native-toolchain-CR](cdh5.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9658 ) Change subject: CDH-65655: use ssh instead of https for Kudu github .. Patch Set 1: Code-Review+2 Clean cherry-pick -- To

[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9657 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9657 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: Build ORC C++ lib in toolchain This adds

[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9657 ) Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. Patch Set 1: Code-Review+2 Clean cherry-pick -- To view,

[native-toolchain-CR](cdh5.x) CDH-65655: use ssh instead of https for Kudu github

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9658 Change subject: CDH-65655: use ssh instead of https for Kudu github .. CDH-65655: use ssh instead of https for Kudu github

[native-toolchain-CR](cdh5.x) IMPALA-5717: Build ORC C++ lib in toolchain

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9657 Change subject: IMPALA-5717: Build ORC C++ lib in toolchain .. IMPALA-5717: Build ORC C++ lib in toolchain This adds the C++

[Impala-ASF-CR] IMPALA-6338: Ensure successfully completed queries have full profile

2018-03-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9656 ) Change subject: IMPALA-6338: Ensure successfully completed queries have full profile .. Patch Set 1: There are some additional cases

[Impala-ASF-CR] IMPALA-6338: Ensure successfully completed queries have full profile

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9656 ) Change subject: IMPALA-6338: Ensure successfully completed queries have full profile .. Patch Set 1: Some context here -

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-6338: Ensure successfully completed queries have full profile

2018-03-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9656 Change subject: IMPALA-6338: Ensure successfully completed queries have full profile .. IMPALA-6338: Ensure successfully

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9635 ) Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes .. Patch Set 2: (14 comments) Thanks for the

[Impala-ASF-CR] IMPALA-6662: Make stress test resilient to hangs due to client crashes

2018-03-15 Thread Sailesh Mukil (Code Review)
Hello Michael Brown, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9635 to look at the new patch set (#3). Change subject: IMPALA-6662: Make stress test resilient to hangs due to client crashes

[Impala-ASF-CR] IMPALA-5717: Support for reading ORC data files

2018-03-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9134 ) Change subject: IMPALA-5717: Support for reading ORC data files .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-15 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 6: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 5: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 11: Before I forget, I was expecting to see

[Impala-ASF-CR] IMPALA-6488: removes use-after-free bug in lib cache

2018-03-15 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 ) Change subject: IMPALA-6488: removes use-after-free bug in lib_cache .. Patch Set 5: Code-Review+1 Test looks fine to me. Someone else

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-15 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 11: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 13: (5 comments)

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-15 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#13). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

  1   2   >