[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. IMPALA-9809:

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 5: Verified+1 -- To

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 7: Code-Review+1 (3 comments) This looks

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. IMPALA-9000: clean up misc TODO-MT comments Filed

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16020 ) Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. Patch Set 3: Code-Review+1 (3 comments) Had a few very

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-02 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16020 ) Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-02 Thread Vihang Karajgaonkar (Code Review)
Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. IMPALA-9791: Support validWriteIdList in

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 7: Build Successful

[Impala-ASF-CR] IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu

2020-06-02 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15683 ) Change subject: IMPALA-3741 [part 2]: Push runtime bloom filter to Kudu .. Patch Set 22: (23 comments) The patch is looking

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 ) Change subject: IMPALA-9778: Refactor HdfsPartition to be immutable .. Patch Set 10: Passed exhaustive test:

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. IMPALA-9673: Add external warehouse dir variable in E2E

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-9820: Pull Datasketches-5 HLL MurmurHash fix

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16026 ) Change subject: IMPALA-9820: Pull Datasketches-5 HLL MurmurHash fix .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 4: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 5: Code-Review+2 --

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-9820: Pull Datasketches-5 HLL MurmurHash fix

2020-06-02 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16026 Change subject: IMPALA-9820: Pull Datasketches-5 HLL MurmurHash fix .. IMPALA-9820: Pull Datasketches-5 HLL MurmurHash fix There is a

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Tim Armstrong (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16023 to look at the new patch set (#2). Change subject: IMPALA-9000: clean up misc TODO-MT comments

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 1: Code-Review+2 (2 comments) This makes sense to me. A

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 4: (3 comments) Patch 4

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Yongzhi Chen (Code Review)
Hello Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16019 to look at the new patch set (#4). Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16020 ) Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 6: Build Successful

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16024 Change subject: Add link to slack channel on community .. Add link to slack channel on community Change-Id:

[Impala-ASF-CR] IMPALA-9318: Add admission control setting to cap MT DOP

2020-06-02 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16020 Change subject: IMPALA-9318: Add admission control setting to cap MT_DOP .. IMPALA-9318: Add admission control setting to cap MT_DOP

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 3: (3 comments) Great! The

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. Patch Set 5: (3 comments) mostly nits; patch almost

[Impala-ASF-CR] IMPALA-9673: Add external warehouse dir variable in E2E test

2020-06-02 Thread Xiaomeng Zhang (Code Review)
Xiaomeng Zhang has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15990 ) Change subject: IMPALA-9673: Add external warehouse dir variable in E2E test .. IMPALA-9673: Add external warehouse dir variable in E2E

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 ) Change subject: IMPALA-9000: clean up misc TODO-MT comments .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9814: fix mt dop parallelism for analytic fns

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16022 ) Change subject: IMPALA-9814: fix mt_dop parallelism for analytic fns .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16023 Change subject: IMPALA-9000: clean up misc TODO-MT comments .. IMPALA-9000: clean up misc TODO-MT comments Filed IMPALA-9812,

[Impala-ASF-CR] IMPALA-9814: fix mt dop parallelism for analytic fns

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16022 ) Change subject: IMPALA-9814: fix mt_dop parallelism for analytic fns .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-9814: fix mt dop parallelism for analytic fns

2020-06-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16022 Change subject: IMPALA-9814: fix mt_dop parallelism for analytic fns .. IMPALA-9814: fix mt_dop parallelism for analytic fns This

[Impala-ASF-CR] IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API

2020-06-02 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16008 ) Change subject: IMPALA-9791: Support validWriteIdList in getPartialCatalogObject API .. Patch Set 2: (9 comments) Compactions

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16015 ) Change subject: IMPALA-9702: Cleanup unique_database directories .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16015 ) Change subject: IMPALA-9702: Cleanup unique_database directories .. IMPALA-9702: Cleanup unique_database directories

[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 ) Change subject: IMPALA-9778: Refactor HdfsPartition to be immutable .. Patch Set 10: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16000 ) Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate() .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-9632: Implement ds hll sketch() and ds hll estimate()

2020-06-02 Thread Gabor Kaszab (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16000 to look at the new patch set (#3). Change subject: IMPALA-9632: Implement ds_hll_sketch() and ds_hll_estimate()

[Impala-ASF-CR] IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad

2020-06-02 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16019 ) Change subject: IMPALA-9809: Multi-aggregation query on particular dataset crashes impalad .. Patch Set 3: The new patch(patch set 3)

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16003 ) Change subject: IMPALA-8755: Unlock Z-ordering by default .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-8755: Unlock Z-ordering by default

2020-06-02 Thread Norbert Luksa (Code Review)
Norbert Luksa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16003 Change subject: IMPALA-8755: Unlock Z-ordering by default .. IMPALA-8755: Unlock Z-ordering by default Z-ordering has been around for

[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 ) Change subject: IMPALA-9778: Refactor HdfsPartition to be immutable .. Patch Set 10: Build Successful

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16015 ) Change subject: IMPALA-9702: Cleanup unique_database directories .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16015 ) Change subject: IMPALA-9702: Cleanup unique_database directories .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9702: Cleanup unique database directories

2020-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16015 ) Change subject: IMPALA-9702: Cleanup unique_database directories .. Patch Set 2: Code-Review+2 Thanks for fixing this! -- To view,

[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 ) Change subject: IMPALA-9778: Refactor HdfsPartition to be immutable .. Patch Set 10: Build started:

[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-02 Thread Quanlong Huang (Code Review)
Hello Anurag Mantripragada, Vihang Karajgaonkar, Todd Lipcon, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15985 to look at the new patch set (#10). Change subject: IMPALA-9778: Refactor HdfsPartition to be

[Impala-ASF-CR] IMPALA-9778: Refactor HdfsPartition to be immutable

2020-06-02 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15985 ) Change subject: IMPALA-9778: Refactor HdfsPartition to be immutable .. Patch Set 9: (5 comments)