[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8750 Change subject: IMPALA-6232: Disable file handle cache by default .. IMPALA-6232: Disable file handle cache by default There are

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8750 to look at the new patch set (#2). Change subject: IMPALA-6232: Disable file handle cache by default

[Impala-ASF-CR] IMPALA-6068: Scale back fixing functional-types

2017-12-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8690 ) Change subject: IMPALA-6068: Scale back fixing functional-types .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8841 Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. IMPALA-5948: Change Kudu RPC port to 27000 The current default for

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-15 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8841 to look at the new patch set (#2). Change subject: IMPALA-5948: Change Kudu RPC port to 27000 ..

[Impala-ASF-CR] IMPALA-5948: Change Kudu RPC port to 27000

2017-12-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8841 ) Change subject: IMPALA-5948: Change Kudu RPC port to 27000 .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] PREVIEW: IMPALA-6052: Change HDFS layout for test tables

2017-12-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/8260 ) Change subject: PREVIEW: IMPALA-6052: Change HDFS layout for test tables .. PREVIEW: IMPALA-6052: Change HDFS layout for test tables

[Impala-ASF-CR] KUDU-2198. Allow disregarding system-wide auth-to-local mapping

2017-12-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8875 ) Change subject: KUDU-2198. Allow disregarding system-wide auth-to-local mapping .. Patch Set 1: Code-Review+2 This is a

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 2: Code-Review+2 This makes sense to me. -- To view,

[Impala-ASF-CR] Pin gen build version's git handling to typical git dir.

2017-11-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8500 ) Change subject: Pin gen_build_version's git handling to typical git dir. .. Patch Set 3: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4835 (prep only): create io subfolder and namespace

2017-11-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8424 ) Change subject: IMPALA-4835 (prep only): create io subfolder and namespace .. Patch Set 8: Code-Review+2 I've gone through this a few

[Impala-ASF-CR] IMPALA-1575: part 2: yield admission control resources

2017-11-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8581 ) Change subject: IMPALA-1575: part 2: yield admission control resources .. Patch Set 1: Code-Review+2 Walked through this and compared

[Impala-ASF-CR] IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder

2017-12-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8034 ) Change subject: IMPALA-5522:Use tracked memory for DictDecoder and DictEncoder .. Patch Set 17: Code-Review+1 This looks good to me.

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 ) Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-05 Thread Joe McDonnell (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8750 to look at the new patch set (#4). Change subject: IMPALA-6232: Disable file handle cache by default

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 4: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-6081: Fix test basic filters runtime profile failure

2017-12-05 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8754 ) Change subject: IMPALA-6081: Fix test_basic_filters runtime profile failure .. Patch Set 2: Code-Review+1 This change makes sense to

[Impala-ASF-CR] Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io.

2017-12-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8853 ) Change subject: Remove unused deps, centralize some pom versions, upgrade SLF4J and commons-io. .. Patch Set 4: Code-Review+2 Rebase,

[Impala-ASF-CR] IMPALA-6974: Use CMAKE POSITION INDEPENDENT CODE in backend

2018-05-04 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10267 to look at the new patch set (#5). Change subject: IMPALA-6974: Use CMAKE_POSITION_INDEPENDENT_CODE in backend

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 3: Code-Review+2 Updated commit message.

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Code-Review+2 Assuming that one change

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: Code-Review-2 -- To view, visit

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: This needs another upload before any

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on 2.x

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on 2.x .. IMPALA-6972: Disable parallel dataload on 2.x There is a Hive bug in

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed a vote on this change. Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Removed Code-Review-2 by Joe McDonnell -- To view, visit

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-08 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10306 to look at the new patch set (#3). Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2

[Impala-ASF-CR] IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY

2018-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10316 ) Change subject: IMPALA-4850: [DOCS] COMMENT should come after PARTITIONED BY .. Patch Set 1: (1 comment) Thanks for working on this.

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10318 ) Change subject: test-with-docker: exit properly on failures .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] Warn about Hadoop / Java version incompatibility

2018-04-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10222 ) Change subject: Warn about Hadoop / Java version incompatibility .. Patch Set 6: Code-Review+2 Thanks for making this change -- To

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10364 Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. IMPALA-6997: Avoid redundant dumping in

[Impala-ASF-CR](2.x) IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-10 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10367 to review the following change. Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-09 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10306 to look at the new patch set (#4). Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2

[Impala-ASF-CR] IMPALA-6972: Disable parallel dataload on MINICLUSTER PROFILE=2

2018-05-09 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10306 ) Change subject: IMPALA-6972: Disable parallel dataload on MINICLUSTER_PROFILE=2 .. Patch Set 4: Fixed variable initialization. Tested

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-10 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 1: (1 comment)

[Impala-ASF-CR] test-with-docker: exit properly on failures

2018-05-07 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10318 ) Change subject: test-with-docker: exit properly on failures .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7035: Configure jceks.key.serialFilter for KMS.

2018-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10418 ) Change subject: IMPALA-7035: Configure jceks.key.serialFilter for KMS. .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10319 ) Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. Patch Set 3: Code-Review+2 (1 comment) Looks good to me.

[Impala-ASF-CR] IMPALA-7035: Configure jceks.key.serialFilter for KMS.

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10418 ) Change subject: IMPALA-7035: Configure jceks.key.serialFilter for KMS. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7035: Configure jceks.key.serialFilter for KMS.

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10418 ) Change subject: IMPALA-7035: Configure jceks.key.serialFilter for KMS. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7023: Wait for fragments to finish for test insert.py

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10426 ) Change subject: IMPALA-7023: Wait for fragments to finish for test_insert.py .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7023: Wait for fragments to finish for test insert.py

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10426 Change subject: IMPALA-7023: Wait for fragments to finish for test_insert.py .. IMPALA-7023: Wait for fragments to finish for

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10364 ) Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded() .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

2018-05-15 Thread Joe McDonnell (Code Review)
Hello Zoram Thanga, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10364 to look at the new patch set (#2). Change subject: IMPALA-6997: Avoid redundant dumping in SetMemLimitExceeded()

[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10397 ) Change subject: IMPALA-7017: deflake/fix test_catalog_restart test .. Patch Set 1: Code-Review+2 This looks good to me. -- To view,

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10319 ) Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] Trimming build-all-flag-combinations and adding minicluster profile.

2018-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10489 ) Change subject: Trimming build-all-flag-combinations and adding minicluster profile. .. Patch Set 4: Code-Review+1 This makes sense

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10447 to look at the new patch set (#7). Change subject: IMPALA-7061: Rework HBase splitting and assignment

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 8: Code-Review+2 (1 comment) Looks good to me. The commit message could

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10516 Change subject: Ignore IMPALA-6131 which has already been picked .. Ignore IMPALA-6131 which has already been picked IMPALA-6131 was

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Patch Set 1: Verified+1 Ran "python -m json.tool

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has removed Thomas Marshall from this change. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Removed reviewer Thomas Marshall. -- To view, visit

[Impala-ASF-CR](2.x) Ignore IMPALA-6131 which has already been picked

2018-05-25 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10516 ) Change subject: Ignore IMPALA-6131 which has already been picked .. Ignore IMPALA-6131 which has already been picked

[Impala-ASF-CR](2.x) Ignore "IMPALA-7003: Deflake erasure coding data loading"

2018-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10445 ) Change subject: Ignore "IMPALA-7003: Deflake erasure coding data loading" .. Patch Set 1: Code-Review+2 Thanks. Run this to validate

[Impala-ASF-CR] IMPALA-6070: Adding ASAN, --tail to test-with-docker.

2018-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10319 ) Change subject: IMPALA-6070: Adding ASAN, --tail to test-with-docker. .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-7035: Configure jceks.key.serialFilter for KMS.

2018-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10446 ) Change subject: IMPALA-7035: Configure jceks.key.serialFilter for KMS. .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] test-with-docker: work with git worktree

2018-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 ) Change subject: test-with-docker: work with git worktree .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-7043: HBase split failure should not fail dataload

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10437 Change subject: IMPALA-7043: HBase split failure should not fail dataload .. IMPALA-7043: HBase split failure should not fail dataload

[Impala-ASF-CR] IMPALA-7043: HBase split failure should not fail dataload

2018-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10437 ) Change subject: IMPALA-7043: HBase split failure should not fail dataload .. Patch Set 1: > Could you link the JIRA between this one

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10447 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-7061: Rework HBase splitting and assignment

2018-05-23 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10447 to look at the new patch set (#5). Change subject: IMPALA-7061: Rework HBase splitting and assignment ..

[Impala-ASF-CR] IMPALA-6953: clean up DiskIoMgr

2018-05-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10245 ) Change subject: IMPALA-6953: clean up DiskIoMgr .. Patch Set 7: > (1 comment) > > Rebase. Do you have time to take a look Joe?

[Impala-ASF-CR] Optimize dependencies for Codegen

2018-06-11 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10688 Change subject: Optimize dependencies for Codegen .. Optimize dependencies for Codegen Pieces of the Codegen library

[Impala-ASF-CR] IMPALA-7119: Restart whole minicluster when HDFS replication stalls

2018-06-08 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10665 to look at the new patch set (#2). Change subject: IMPALA-7119: Restart whole minicluster when HDFS replication stalls

[Impala-ASF-CR](2.x) IMPALA-6394: Disable dfs.namenode.replication.considerLoad

2018-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10664 ) Change subject: IMPALA-6394: Disable dfs.namenode.replication.considerLoad .. Patch Set 1: Code-Review+2 Thanks for backporting this.

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. Patch Set 3: Looked through error on the GVO run, and it

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. IMPALA-7161: Fix impala-config.sh's handling of

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-15 Thread Joe McDonnell (Code Review)
Hello Tianyi Wang, Philip Zeyliger, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10702 to look at the new patch set (#3). Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 8: (2 comments) I'm basically ready to +2 this.

[Impala-ASF-CR] Optimize dependencies for Codegen

2018-06-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 ) Change subject: Optimize dependencies for Codegen .. Patch Set 1: > Looks like the current way was done as a result of IMPALA-1896.

[Impala-ASF-CR] Optimize dependencies for Codegen

2018-06-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/10688 ) Change subject: Optimize dependencies for Codegen .. Abandoned This has a flawed dependency graph. -- To view, visit

[Impala-ASF-CR] IMPALA-2746: part 1: enable LSAN for many backend tests

2018-06-15 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10668 ) Change subject: IMPALA-2746: part 1: enable LSAN for many backend tests .. Patch Set 9: Code-Review+2 (1 comment) This all looks

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-13 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10702 to look at the new patch set (#2). Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME

[Impala-ASF-CR] IMPALA-7161: Fix impala-config.sh's handling of JAVA HOME

2018-06-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new patch set (#1). ( http://gerrit.cloudera.org:8080/10702 ) Change subject: IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME .. IMPALA-7161: Fix impala-config.sh's handling of JAVA_HOME

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10526 to look at the new patch set (#2). Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 2: Code-Review+2 Carry +2 -- To view,

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10526 ) Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7089: xfail test kudu dml reporting

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10527 ) Change subject: IMPALA-7089: xfail test_kudu_dml_reporting .. Patch Set 1: Code-Review+2 Makes sense to XFAIL for now since this is

[Impala-ASF-CR] IMPALA-7088: Fix uninitialized variable in cluster dataload

2018-05-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10526 Change subject: IMPALA-7088: Fix uninitialized variable in cluster dataload .. IMPALA-7088: Fix uninitialized variable in cluster

[Impala-ASF-CR](2.x) IMPALA-7061: Rework HBase splitting and assignment

2018-05-30 Thread Joe McDonnell (Code Review)
Hello Philip Zeyliger, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10545 to review the following change. Change subject: IMPALA-7061: Rework HBase splitting and assignment

[Impala-ASF-CR](2.x) IMPALA-7061: Rework HBase splitting and assignment

2018-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10545 ) Change subject: IMPALA-7061: Rework HBase splitting and assignment .. Patch Set 1: 2.x cherrypick required moving some files around,

[Impala-ASF-CR] IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

2018-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10531 ) Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize(). .. Patch Set 1: (1 comment) I think

[Impala-ASF-CR] IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

2018-05-30 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10531 ) Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize(). .. Patch Set 1: Code-Review+2 Given that

[Impala-ASF-CR](2.x) IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

2018-05-31 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10556 ) Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize(). .. Patch Set 1: Since the 2.x backport for

[Impala-ASF-CR](2.x) IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

2018-05-31 Thread Joe McDonnell (Code Review)
Hello Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/10556 to review the following change. Change subject: IMPALA-7091: Address NullPointerException in HBaseTable.getRegionSize().

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10615 Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. IMPALA-7132: Filter out useless output from

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7132: Filter out useless output from run clang tidy.sh

2018-06-06 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10615 ) Change subject: IMPALA-7132: Filter out useless output from run_clang_tidy.sh .. Patch Set 1: Just realized that I had patched

[Impala-ASF-CR] IMPALA-7185: low statestore custom cluster interval

2018-06-29 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10845 ) Change subject: IMPALA-7185: low statestore custom cluster interval .. Patch Set 2: (1 comment) Thanks for putting this together.

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10788 ) Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch Set 4: (1 comment)

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-22 Thread Joe McDonnell (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10788 to look at the new patch set (#5). Change subject: Patch llvm to fix run-clang-tidy.py output ..

[native-toolchain-CR] Patch llvm to fix run-clang-tidy.py output

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10788 ) Change subject: Patch llvm to fix run-clang-tidy.py output .. Patch Set 5: Code-Review+2 Carry +2 -- To view, visit

[Impala-ASF-CR] Add scripts to create code coverage reports

2018-06-22 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 ) Change subject: Add scripts to create code coverage reports .. Patch Set 1: (3 comments) Made this into a JIRA IMPALA-7199. There is

  1   2   3   4   5   6   7   8   9   10   >