[Impala-ASF-CR] IMPALA-8512: Disable certain tests on Centos6

2019-05-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13271 ) Change subject: IMPALA-8512: Disable certain tests on Centos6 .. Patch Set 4: GVO failed due to IMPALA-8527 -- To view, visit

[Impala-ASF-CR] IMPALA-8341: [DOCS] Describe the setting for remote data caching

2019-06-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13724 ) Change subject: IMPALA-8341: [DOCS] Describe the setting for remote data caching .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8744: Fix test session expiration.py to work with Python 2.6

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13819 Change subject: IMPALA-8744: Fix test_session_expiration.py to work with Python 2.6 .. IMPALA-8744: Fix test_session_expiration.py to

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() This

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 2: Code-Review+2 Carry Todd's +2 -- To view,

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13818 ) Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Hello Thomas Tauber-Marshall, Todd Lipcon, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13818 to look at the new patch set (#4). Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

[Impala-ASF-CR] IMPALA-8748: Always pass hostname to RpcMgr::GetProxy()

2019-07-08 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13818 Change subject: IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() .. IMPALA-8748: Always pass hostname to RpcMgr::GetProxy() This

[Impala-ASF-CR] IMPALA-8543: More diagnostics for TAcceptQueueServer

2019-07-02 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13790 Change subject: IMPALA-8543: More diagnostics for TAcceptQueueServer .. IMPALA-8543: More diagnostics for TAcceptQueueServer This change

[Impala-ASF-CR] IMPALA-8732: Use a serialized descriptor table in TQueryCtx

2019-07-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13772 ) Change subject: IMPALA-8732: Use a serialized descriptor table in TQueryCtx .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8341: [DOCS] Added a note about the experiemental feature

2019-07-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13788 ) Change subject: IMPALA-8341: [DOCS] Added a note about the experiemental feature .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d

2019-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13767 ) Change subject: Update kudu/security from 9ebcb77aa911aae76c48e717af24e643cb81908d .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4356,IMPALA-7331: codegen all ScalarExprs

2019-04-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12797 ) Change subject: IMPALA-4356,IMPALA-7331: codegen all ScalarExprs .. Patch Set 10: (12 comments)

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 ) Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8295: Fix flakiness in TestAdmissionControllerStress

2019-04-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13103 ) Change subject: IMPALA-8295: Fix flakiness in TestAdmissionControllerStress .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7981: Add host disk statistics to profile

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12822 ) Change subject: IMPALA-7981: Add host disk statistics to profile .. Patch Set 6: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8341: Data cache for remote reads

2019-04-10 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12987 Change subject: IMPALA-8341: Data cache for remote reads .. IMPALA-8341: Data cache for remote reads This is a patch based on PhilZ's

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 9: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-2990: timeout unresponsive queries in coordinator

2019-04-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12299 ) Change subject: IMPALA-2990: timeout unresponsive queries in coordinator .. Patch Set 8: (8 comments)

[Impala-ASF-CR] Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95

2019-07-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13768 ) Change subject: Update squeasel to 7973705170f4744d1806e32695f7ea1e8308ee95 .. Patch Set 1: Code-Review+2 Didn't look too much into the

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

2019-07-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 ) Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced

2019-06-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13762 ) Change subject: IMPALA-8427: [DOCS] Document the new startup flag IMPALA-7800 introduced .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-28 Thread Michael Ho (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/13764 to review the following change. Change subject: IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

[Impala-ASF-CR] IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections

2019-06-28 Thread Michael Ho (Code Review)
Michael Ho has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13764 ) Change subject: IMPALA-6159 / KUDU-2192: Enable TCP keepalive for all outbound connections .. Removed reviewer Kudu Jenkins. --

[Impala-ASF-CR] IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters

2019-08-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14026 ) Change subject: IMPALA-8685,IMPALA-8677: Use consistent scheduling for small clusters .. Patch Set 5: Code-Review+1 (1 comment) I will

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 15: Code-Review+1 (2 comments)

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 ) Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 4: (10 comments) LGTM. Mostly minor

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. IMPALA-8845: Cancel receiver's streams on exchange node's

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14101 Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. IMPALA-8845: Cancel receiver's streams on exchange node's

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-8818: Replace deque with spillable queue in BufferedPRS

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14039 ) Change subject: IMPALA-8818: Replace deque with spillable queue in BufferedPRS .. Patch Set 8: Code-Review+1 (1 comment) Not super

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-20 Thread Michael Ho (Code Review)
Hello Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14101 to look at the new patch set (#3). Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. IMPALA-8845: Cancel receiver's streams on exchange node's

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 4: Code-Review+1 Carrying Sahil's +1 -- To

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 1: (7 comments)

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. IMPALA-8691: Query option to disable data cache This change adds a

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14101 ) Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS .. Patch Set 5: Code-Review+2 Carry Thomas' +2 -- To

[Impala-ASF-CR] IMPALA-8845: Cancel receiver's streams on exchange node's EOS

2019-08-26 Thread Michael Ho (Code Review)
Hello Thomas Tauber-Marshall, Lars Volker, Sahil Takiar, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14101 to look at the new patch set (#5). Change subject: IMPALA-8845: Cancel receiver's streams on exchange node's EOS

[Impala-ASF-CR] IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes

2019-08-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14129 ) Change subject: IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes .. Patch Set 3: Code-Review+1 (3 comments)

[Impala-ASF-CR] IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes

2019-08-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14129 ) Change subject: IMPALA-8819: BufferedPlanRootSink should handle non-default fetch sizes .. Patch Set 2: (7 comments)

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-08-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-23 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. IMPALA-8691: Query option to disable data cache This change

[Impala-ASF-CR] IMPALA-8907: TestResultSpooling.test slow query is flaky

2019-09-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14170 ) Change subject: IMPALA-8907: TestResultSpooling.test_slow_query is flaky .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-09-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 9: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5802: use mt scan node for all formats

2019-09-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14171 ) Change subject: IMPALA-5802: use mt scan node for all formats .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 1: May also want to rebase and address the TODO (i.e.

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-8634: Catalog client should retry RPCs

2019-09-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14246 ) Change subject: IMPALA-8634: Catalog client should retry RPCs .. Patch Set 4: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs

2019-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14214 ) Change subject: IMPALA-8924, IMPALA-8934: Result spooling failpoint tests, fix DCHECKs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8825: Add additional counters to PlanRootSink

2019-09-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14180 ) Change subject: IMPALA-8825: Add additional counters to PlanRootSink .. Patch Set 5: Code-Review+2 (3 comments)

[Impala-ASF-CR] IMPALA-8803: Coordinator should release admitted memory per-backend

2019-09-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14104 ) Change subject: IMPALA-8803: Coordinator should release admitted memory per-backend .. Patch Set 7: (15 comments)

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 17: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-08-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-07-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 ) Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation .. Patch Set 6: (8 comments)

[Impala-ASF-CR] IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC

2019-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC .. Patch Set 11: (6 comments)

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-08-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 12: (9 comments) We don't really enforce any

[Impala-ASF-CR] IMPALA-8781: Result spooling tests to cover edge cases and cancellation

2019-08-01 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13907 ) Change subject: IMPALA-8781: Result spooling tests to cover edge cases and cancellation .. Patch Set 8: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-8339: Add local executor blacklist to coordinators

2019-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: IMPALA-8339: Add local executor blacklist to coordinators .. Patch Set 6: Code-Review+1 (3 comments) Not sure if Lars

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-8534: data cache for dockerised tests

2019-07-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13934 ) Change subject: IMPALA-8534: data cache for dockerised tests .. Patch Set 6: Code-Review+2 Nice. -- To view, visit

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-29 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC

2019-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 ) Change subject: IMPALA-7984: Port UpdateFilter() and PublishFilter() to KRPC .. Patch Set 12: A quick high level reminder about using

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 13: (14 comments) LGTM. Some more minor nits. The patch

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-05 Thread Michael Ho (Code Review)
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14015 Change subject: IMPALA-8691: Query option to disable data cache .. IMPALA-8691: Query option to disable data cache This change adds a

[Impala-ASF-CR] IMPALA-8781: Fix TestResultSpooling::test multi batches

2019-08-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14022 ) Change subject: IMPALA-8781: Fix TestResultSpooling::test_multi_batches .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8691: Query option to disable data cache

2019-08-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14015 ) Change subject: IMPALA-8691: Query option to disable data cache .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-8701: [DOCS] Document --idle client poll time s flag

2019-07-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13896 ) Change subject: IMPALA-8701: [DOCS] Document --idle_client_poll_time_s flag .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl .. Patch Set 3: (25 comments) High level

[Impala-ASF-CR] IMPALA-8701: [DOCS] Document --idle client poll time s flag

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13896 ) Change subject: IMPALA-8701: [DOCS] Document --idle_client_poll_time_s flag .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8656: Add RowBatchQueue interface and BufferedPlanRootSink impl .. Patch Set 4: (3 comments)

[Impala-ASF-CR] IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations

2019-07-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13873 ) Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations .. Patch Set 6: Code-Review+2 (2

[Impala-ASF-CR] IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations

2019-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13873 ) Change subject: IMPALA-8656: Re-factor PlanRootSink into blocking and buffered implementations .. Patch Set 7: Code-Review+2 -- To

[Impala-ASF-CR] [WIP] IMPALA-8339: Add local node blacklist to coordinators

2019-07-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: [WIP] IMPALA-8339: Add local node blacklist to coordinators .. Patch Set 1: (16 comments) Some comments on the first

[Impala-ASF-CR] [DOCS] An upgrade consideratiobn for IMPALA-7800

2019-07-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13879 ) Change subject: [DOCS] An upgrade consideratiobn for IMPALA-7800 .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl

2019-07-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue interface and BufferedPRS impl .. Patch Set 4: (4 comments) Unifying the

[Impala-ASF-CR] IMPALA-8339: Add local executor blacklist to coordinators

2019-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: IMPALA-8339: Add local executor blacklist to coordinators .. Patch Set 3: (19 comments) Looking good.

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 9: (7 comments)

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 9: (23 comments)

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 11: (8 comments)

[Impala-ASF-CR] IMPALA-8339: Add local executor blacklist to coordinators

2019-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13868 ) Change subject: IMPALA-8339: Add local executor blacklist to coordinators .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl

2019-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13883 ) Change subject: IMPALA-8779, IMPALA-8780: RowBatchQueue re-factoring and BufferedPRS impl .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-8884: track storage read statistics per queue

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14242 ) Change subject: IMPALA-8884: track storage read statistics per queue .. Patch Set 1: Code-Review+1 (4 comments)

[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 ) Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 ) Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI .. Patch Set 1: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI

2019-09-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 ) Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI .. Patch Set 1: Please address the comment about thrift

<    5   6   7   8   9   10   11   >