[Impala-ASF-CR] IMPALA-6695: Fix PyPi regex, update setuptools version

2018-03-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9711 ) Change subject: IMPALA-6695: Fix PyPi regex, update setuptools version .. Patch Set 1: Code-Review+2 I think this is LGTM for now.

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2018-03-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/7241 ) Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. ..

[Impala-ASF-CR] IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos.

2018-03-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/7241 ) Change subject: IMPALA-2782: Allow impala-shell to connect directly to impalad when configured with load balancer and kerberos. ..

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 2: Pretty superficial inspection suggested this was stuck at the

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 2: Code-Review+2 Carry after fixing spelling nit in commit message.

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-14 Thread Philip Zeyliger (Code Review)
Hello Michael Brown, Alex Behm, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9600 to look at the new patch set (#2). Change subject: Consistently use Java 1.7 compiler.

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9588 ) Change subject: Removing (broken) retries from split-hbase.sh. .. Patch Set 2: Code-Review+2 Carry +2 after rebase. -- To view,

[Impala-ASF-CR] DRAFT IMPALA-5973: Provide query plan in JSON format.

2018-03-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9614 ) Change subject: DRAFT IMPALA-5973: Provide query plan in JSON format. .. Patch Set 1: > into JSON format, so it can be displayed in

[Impala-ASF-CR] DRAFT IMPALA-5973: Provide query plan in JSON format.

2018-03-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9614 ) Change subject: DRAFT IMPALA-5973: Provide query plan in JSON format. .. Patch Set 1: I’m excited to see this being worked on!

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 1: https://jenkins.impala.io/job/gerrit-verify-dryrun-external/93/

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9600 Change subject: Consistently use Java 1.7 compiler. .. Consistently use Java 1.7 compiler. We use Java 1.7 in fe/pom.xml, where most

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9588 ) Change subject: Removing (broken) retries from split-hbase.sh. .. Patch Set 1:

[Impala-ASF-CR] Removing (broken) retries from split-hbase.sh.

2018-03-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9588 Change subject: Removing (broken) retries from split-hbase.sh. .. Removing (broken) retries from split-hbase.sh. The retries in

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 2: Tim, Please take a look at

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-03-09 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9395 to look at the new patch set (#2). Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

[Impala-ASF-CR](2.x) IMPALA-6405: Ignore commit for automatic cherry picking

2018-03-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9531 ) Change subject: IMPALA-6405: Ignore commit for automatic cherry picking .. Patch Set 1: Verified+1 Code-Review+2 I'm +1'ing the

[Impala-ASF-CR] IMPALA-6606: date trunc() misinterprets MILLENNIUM/CENTURY precision

2018-03-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9508 ) Change subject: IMPALA-6606: date_trunc() misinterprets MILLENNIUM/CENTURY precision .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5564: Release lock during planning. (wip)

2018-02-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8434 ) Change subject: IMPALA-5564: Release lock during planning. (wip) .. Patch Set 1: Took me a long time to get back to this, but I'm

[Impala-ASF-CR] IMPALA-6570: Support KUDU on SLES12.

2018-02-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9431 ) Change subject: IMPALA-6570: Support KUDU on SLES12. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6570: Support KUDU on SLES12.

2018-02-23 Thread Philip Zeyliger (Code Review)
Hello Thomas Tauber-Marshall, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9431 to look at the new patch set (#3). Change subject: IMPALA-6570: Support KUDU on SLES12. ..

[Impala-ASF-CR] IMPALA-6570: Support KUDU on SLES12.

2018-02-23 Thread Philip Zeyliger (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9431 to look at the new patch set (#2). Change subject: IMPALA-6570: Support KUDU on SLES12. .. IMPALA-6570:

[Impala-ASF-CR] IMPALA-6570: Support KUDU on SLES12.

2018-02-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9431 Change subject: IMPALA-6570: Support KUDU on SLES12. .. IMPALA-6570: Support KUDU on SLES12. Different versions (service packs) of

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-02-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9395 ) Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. Patch Set 1: I see this happening in

[Impala-ASF-CR] IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster.

2018-02-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9395 Change subject: IMPALA-6341, IMPALA-5917: Reduce mem-limit for start-impala-cluster. .. IMPALA-6341, IMPALA-5917: Reduce mem-limit

[Impala-ASF-CR] IMPALA-6517: bootstrap toolchain.py fails to recognize lsb release output from RHEL OS

2018-02-21 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9310 ) Change subject: IMPALA-6517: bootstrap_toolchain.py fails to recognize lsb_release output from RHEL OS .. Patch Set 4: Code-Review+2

[Impala-ASF-CR] IMPALA-5152: Introduce metadata loading phase

2018-02-20 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8958 ) Change subject: IMPALA-5152: Introduce metadata loading phase .. Patch Set 5: Code-Review+1 Thanks for addressing my comments! --

[Impala-ASF-CR] IMPALA-6482: add QUERY TIME LIMIT S option

2018-02-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 ) Change subject: IMPALA-6482: add QUERY_TIME_LIMIT_S option .. Patch Set 5: (2 comments) I just looked at how these two were

[Impala-ASF-CR] Bump Kudu Java version to 1.7.0

2018-02-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9349 ) Change subject: Bump Kudu Java version to 1.7.0 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6509: [docs] Note for haproxy for Kerberized clusters

2018-02-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9286 ) Change subject: IMPALA-6509: [docs] Note for haproxy for Kerberized clusters .. Patch Set 5: > Uploaded patch set 5: Patch Set 4 was

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-12 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has abandoned this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Abandoned Per conversation on user@, folks are interested in keeping this around.

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: > Patch Set 1: > > > > Patch Set 1: > > > > > > Did you also test

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: > Patch Set 1: > > Did you also test data load and snapshot creation?

[Impala-ASF-CR] IMPALA-6495: fix targeted-perf for new column alias syntax

2018-02-09 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9268 ) Change subject: IMPALA-6495: fix targeted-perf for new column alias syntax .. Patch Set 1: Code-Review+2 Change looks fine. Should

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9085 ) Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. IMPALA-6070: Expose using Docker to run tests faster. Allows

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9264 ) Change subject: Remove Yarn from minicluster. .. Patch Set 1: https://jenkins.impala.io/job/gerrit-verify-dryrun-external/78/ is

[Impala-ASF-CR] Remove Yarn from minicluster.

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9264 Change subject: Remove Yarn from minicluster. .. Remove Yarn from minicluster. Removes vestiges of Yarn from the minicluster. Turns

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 7: I ran tests with this change and observed data loading go

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 4: Thomas: could you give this a review? Sailesh: please

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-02-08 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams

2018-02-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 ) Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams .. Patch Set 1: The hammer here is to compress all

[Impala-ASF-CR] IMPALA-3271: organise and warn on removed startup flags

2018-02-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9173 ) Change subject: IMPALA-3271: organise and warn on removed startup flags .. Patch Set 3: Code-Review+2 LGTM. -- To view, visit

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-07 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 7: Rebased. Running

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-07 Thread Philip Zeyliger (Code Review)
Hello Jim Apple, Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#7). Change subject: IMPALA-6204: Remove external DataSource

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 5: (2 comments) Addressed the comments. Removed the remaining

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-06 Thread Philip Zeyliger (Code Review)
Hello Jim Apple, Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#6). Change subject: IMPALA-6204: Remove external DataSource

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, Zach Amsden, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#5). Change subject: IMPALA-6204: Remove external DataSource

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4: (1 comment) I've been generally hesitant of removing

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 4:

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-05 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#4). Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204:

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 3: I think this is now reviewable. I ran core tests

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#3). Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204:

[Impala-ASF-CR](2.x) IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9198 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 1: Code-Review+2 The conflict was boring, yes? I'd prefer

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9192 ) Change subject: IMPALA-6204: Remove external DataSource .. Patch Set 2: Code-Review-1 Sorry, hold off on this please. I rebased and

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9192 to look at the new patch set (#2). Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204:

[Impala-ASF-CR] IMPALA-6204: Remove external DataSource

2018-02-02 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9192 Change subject: IMPALA-6204: Remove external DataSource .. IMPALA-6204: Remove external DataSource Removes DataSourceScanNode,

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: > Patch Set 10: > > > Patch Set 10: Code-Review+2 > >

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-02-01 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 7: (1 comment) > Patch Set 7: > > (1 comment)

[Impala-ASF-CR] IMPALA-5690: Upgrade thrift to 0.9.3-p3

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9168 ) Change subject: IMPALA-5690: Upgrade thrift to 0.9.3-p3 .. Patch Set 1: (5 comments) I'm not really qualified to review this

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. Patch Set 2: Code-Review+2 Looks good to

[Impala-ASF-CR] IMPALA-6455: unique tmpdirs for test partition metadata compatibility

2018-01-31 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 ) Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility .. Patch Set 1: (2 comments) Thanks; this

[native-toolchain-CR](cdh6.x) Bump Kudu version to c6beta-impala-toolchain-tag1

2018-01-26 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9145 ) Change subject: Bump Kudu version to c6beta-impala-toolchain-tag1 .. Patch Set 1: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9135 to look at the new patch set (#3). Change subject: IMPALA-6410: compare_branches: use looser expression

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 ) Change subject: IMPALA-6410: compare_branches: use looser expression .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Lars Volker, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9135 to look at the new patch set (#2). Change subject: IMPALA-6410: compare_branches: use looser expression

[Impala-ASF-CR] IMPALA-6410: compare branches: use looser expression

2018-01-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9135 Change subject: IMPALA-6410: compare_branches: use looser expression .. IMPALA-6410: compare_branches: use looser expression We've

[native-toolchain-CR] Patch thrift-0.9.3 for python 2.6.

2018-01-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9109 ) Change subject: Patch thrift-0.9.3 for python 2.6. .. Patch Set 1: Code-Review+2 Looks fine to me. -- To view, visit

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-6440: Backwards compatibility for HBase metadata

2018-01-24 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9124 ) Change subject: IMPALA-6440: Backwards compatibility for HBase metadata .. Patch Set 1: (4 comments) Minor feedback. (Code logic

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-24 Thread Philip Zeyliger (Code Review)
Hello Gabor Kaszab, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9100 to look at the new patch set (#2). Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 3: Code-Review+1 Looks better to me. Not an area of my

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9101 to look at the new patch set (#3). Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Expose

[Impala-ASF-CR](refs/meta/config) Modify access rules

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has abandoned this change. ( http://gerrit.cloudera.org:8080/9104 ) Change subject: Modify access rules .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9104 To unsubscribe, visit

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/sandbox//*.

2018-01-23 Thread Philip Zeyliger (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9101 to look at the new patch set (#2). Change subject: Expose refs/heads/2.x and refs/sandbox//*. .. Expose

[Impala-ASF-CR](refs/meta/config) Modify access rules

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9104 Change subject: Modify access rules .. Modify access rules Change-Id: I0ad3cec33990043480decb3b1bb37893d5f64b6e --- M project.config

[Impala-ASF-CR] IMPALA-6435: Disable codegen for CHAR literals.

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9102 ) Change subject: IMPALA-6435: Disable codegen for CHAR literals. .. Patch Set 1: (1 comment)

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 1: GVO failed, but we know this

[Impala-ASF-CR](refs/meta/config) Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins.

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9101 Change subject: Expose refs/heads/2.x and refs/scratch/2.x-staging to impala-public-jenkins. .. Expose refs/heads/2.x and

[Impala-ASF-CR] IMPALA-3916: Reserve SQL:2016 reserved words

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9096 ) Change subject: IMPALA-3916: Reserve SQL:2016 reserved words .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 7: Code-Review+1 -- To view, visit

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9100 ) Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test" .. Patch Set 1: Code-Review+2 I'm testing GVO

[Impala-ASF-CR](2.x) IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

2018-01-23 Thread Philip Zeyliger (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9100 to review the following change. Change subject: IMPALA-6318: Revert "Adjustment for hanging query cancellation test"

[Impala-ASF-CR] IMPALA-6394: Enable HDFS debug logging

2018-01-22 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9082 ) Change subject: IMPALA-6394: Enable HDFS debug logging .. Patch Set 1: I don't really have a sense of how frequent this is. I would

[Impala-ASF-CR] IMPALA-6070: Expose using Docker to run tests faster.

2018-01-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9085 Change subject: IMPALA-6070: Expose using Docker to run tests faster. .. IMPALA-6070: Expose using Docker to run tests faster. Allows

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9044 ) Change subject: Bumping version to 3.0. .. Patch Set 3: Are folks comfortable +2'ing this? Once this goes in, I'll start

[Impala-ASF-CR] IMPALA-6372: Go parallel for Hive dataload

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8894 ) Change subject: IMPALA-6372: Go parallel for Hive dataload .. Patch Set 7: (16 comments) I did one pass through. This looks like a

[Impala-ASF-CR] IMPALA-6420: Fix TestCharFormats for local filesystem tests

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9074 ) Change subject: IMPALA-6420: Fix TestCharFormats for local filesystem tests .. Patch Set 2: Do you think we have this elsewhere?

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: > ... returns an internal

[Impala-ASF-CR] IMPALA-4924: Enable Decimal V2 by default

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9062 ) Change subject: IMPALA-4924: Enable Decimal V2 by default .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-6418: Find a reliable way to detect supported TLS versions

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9060 ) Change subject: IMPALA-6418: Find a reliable way to detect supported TLS versions .. Patch Set 1: Is there a convenient place where

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9045 ) Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. Patch Set 2: (25 comments) Thanks for the detailed

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-18 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9044 to look at the new patch set (#3). Change subject: Bumping version to 3.0. .. Bumping version to 3.0. This

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-18 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9045 to look at the new patch set (#4). Change subject: IMPALA-6410: Tool to cherrypick changes across branches.

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-17 Thread Philip Zeyliger (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9045 to look at the new patch set (#3). Change subject: IMPALA-6410: Tool to cherrypick changes across branches. ..

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9044 ) Change subject: Bumping version to 3.0. .. Bumping version to 3.0. This changes the version that Impala presents as to 3.0. We are

[Impala-ASF-CR] Bumping version to 3.0.

2018-01-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9044 Change subject: Bumping version to 3.0. .. Bumping version to 3.0. This changes the version that Impala presents as to 3.0. We are

[Impala-ASF-CR] IMPALA-6410: Tool to cherrypick changes across branches.

2018-01-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9045 Change subject: IMPALA-6410: Tool to cherrypick changes across branches. .. IMPALA-6410: Tool to cherrypick changes across branches.

[Impala-ASF-CR] IMPALA-3282: Adds regexp escape built-in function

2018-01-17 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8900 ) Change subject: IMPALA-3282: Adds regexp_escape built-in function .. Patch Set 5: (2 comments) Thanks for the iteration!

[native-toolchain-CR] Bump thrift to 0.9.3-p2; Add bison 3.0.4

2018-01-16 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9035 ) Change subject: Bump thrift to 0.9.3-p2; Add bison 3.0.4 .. Patch Set 2: Code-Review+2 Looks fine to me. Thanks! -- To view, visit

<    3   4   5   6   7   8   9   >