[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-11-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16765 ) Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16821 ) Change subject: IMPALA-9865: part 1: basic profile log parser .. Patch Set 2: (2 comments) > Uploaded patch set 2. Hi Tim, Thanks

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-12-03 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16765 to look at the new patch set (#7). Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-12-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16765 ) Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation .. Patch Set 7: (3 comments) Thanks Bikram,

[Impala-ASF-CR] IMPALA-9865: part 1: basic profile log parser

2020-12-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16821 ) Change subject: IMPALA-9865: part 1: basic profile log parser .. Patch Set 4: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-11-23 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16765 ) Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-11-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16765 ) Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-11-30 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16765 to look at the new patch set (#6). Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-12-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16765 ) Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-10390: impala-profile-tool JSON output

2020-12-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16855 ) Change subject: IMPALA-10390: impala-profile-tool JSON output .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2020-12-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16755 ) Change subject: IMPALA-9856: Enable result spooling by default. .. Patch Set 3: (10 comments) Patch set 3 is a rebase after several

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2020-12-10 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16755 to look at the new patch set (#2). Change subject: IMPALA-9856: Enable result spooling by default.

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2020-12-10 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16755 to look at the new patch set (#3). Change subject: IMPALA-9856: Enable result spooling by default.

[Impala-ASF-CR] IMPALA-10390: impala-profile-tool JSON output

2020-12-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16855 ) Change subject: IMPALA-10390: impala-profile-tool JSON output .. Patch Set 3: Code-Review+1 (1 comment) Thank you, Tim. LGTM!

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-21 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16884 to look at the new patch set (#2). Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16884 ) Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16884 Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString .. IMPALA-10374: Limit iteration at

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-21 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16884 to look at the new patch set (#3). Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

[Impala-ASF-CR] IMPALA-9865: part 2/2: add verbosity to profile tool

2020-12-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16881 ) Change subject: IMPALA-9865: part 2/2: add verbosity to profile tool .. Patch Set 8: Code-Review+1 (2 comments) Thanks for the

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16884 ) Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9865: part 2/2: add verbosity to profile tool

2020-12-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16881 ) Change subject: IMPALA-9865: part 2/2: add verbosity to profile tool .. Patch Set 7: (6 comments) I have 1 follow up question and 1

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16884 ) Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString .. Patch Set 4: > Patch Set 4: Verified-1 > > Build

[Impala-ASF-CR] IMPALA-9550: Fix flakiness in TestResultSpoolingFetchSize.test fetch

2020-12-22 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16895 Change subject: IMPALA-9550: Fix flakiness in TestResultSpoolingFetchSize.test_fetch .. IMPALA-9550: Fix flakiness in

[Impala-ASF-CR] IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString

2020-12-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16884 ) Change subject: IMPALA-10374: Limit iteration at BufferedTupleStream::DebugString .. Patch Set 5: Patch set 5 is a rebase on top of

[Impala-ASF-CR] IMPALA-9865: part 2/2: add verbosity to profile tool

2020-12-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16881 ) Change subject: IMPALA-9865: part 2/2: add verbosity to profile tool .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2020-11-20 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16755 Change subject: IMPALA-9856: Enable result spooling by default. .. IMPALA-9856: Enable result spooling by default. Result spooling has

[Impala-ASF-CR] IMPALA-10337: Consider MAX ROW SIZE when computing max reservation

2020-11-21 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16765 Change subject: IMPALA-10337: Consider MAX_ROW_SIZE when computing max reservation .. IMPALA-10337: Consider MAX_ROW_SIZE when

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2020-11-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16755 ) Change subject: IMPALA-9856: Enable result spooling by default. .. Patch Set 1: I file IMPALA-10337 separately to solve the crash /

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16628 ) Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme. .. Patch Set 1: > Patch Set 1: > > It looks like

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16628 Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme. .. IMPALA-10266: Identify FileSystem type based on

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16628 to look at the new patch set (#4). Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme.

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16628 to look at the new patch set (#2). Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme.

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16628 to look at the new patch set (#3). Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme.

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16628 ) Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme. .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-10266: Identify FileSystem type based on the protocol scheme.

2020-10-22 Thread Riza Suminto (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16628 to look at the new patch set (#5). Change subject: IMPALA-10266: Identify FileSystem type based on the protocol scheme.

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16963 ) Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. Patch Set 2: (2 comments) Thank you for the review.

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-21 Thread Riza Suminto (Code Review)
Hello Zoltan Borok-Nagy, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16963 to look at the new patch set (#2). Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits

[Impala-ASF-CR] IMPALA-10147: Avoid getting a file handle for data cache hits

2021-01-19 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16963 Change subject: IMPALA-10147: Avoid getting a file handle for data cache hits .. IMPALA-10147: Avoid getting a file handle for data

[Impala-ASF-CR] IMPALA-9355: TestExchangeMemUsage.test exchange mem usage scaling doesn't hit the memory limit

2021-06-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17586 ) Change subject: IMPALA-9355: TestExchangeMemUsage.test_exchange_mem_usage_scaling doesn't hit the memory limit .. Patch Set 1:

[Impala-ASF-CR] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-05-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 28: (3 comments)

[Impala-ASF-CR] IMPALA-10650: Bailout min/max filters in hash join builder early

2021-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 ) Change subject: IMPALA-10650: Bailout min/max filters in hash join builder early .. Patch Set 27: (2 comments) Hi Qifan, I wonder if

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 7: > Patch Set 7: Verified-1 > >

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-09 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17054 Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data. .. IMPALA-10497: Fix flakiness in

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17054 ) Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data. .. Patch Set 1: (1 comment) Thanks Joe for the

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-10 Thread Riza Suminto (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17054 to look at the new patch set (#2). Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data.

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17054 ) Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data. .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#4). Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 4: (8 comments) My exhaustive test

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#3). Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 3: Following up on private

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#5). Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#6). Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 6: (2 comments)

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 6: > Yes, let's do that. I presume

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 6: > Patch Set 6: Verified-1 > >

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 6: > Patch Set 6: > > > Patch Set 6:

[Impala-ASF-CR] IMPALA-10565: Check max spilled result spooling mem vs scratch limit

2021-03-10 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#2). Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit

[Impala-ASF-CR] IMPALA-10565: Check max spilled result spooling mem vs scratch limit

2021-03-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-10565: Check max spilled result spooling mem vs scratch limit

2021-03-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit .. Patch Set 2: (2 comments) Patch set 2

[Impala-ASF-CR] IMPALA-10565: Check max spilled result spooling mem vs scratch limit

2021-03-09 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17166 Change subject: IMPALA-10565: Check max_spilled_result_spooling_mem vs scratch_limit .. IMPALA-10565: Check

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-03-15 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17187 Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. IMPALA-10583: Fix bug on unbounded result spooling

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-13 Thread Riza Suminto (Code Review)
Hello Aman Sinha, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17166 to look at the new patch set (#7). Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit

[Impala-ASF-CR] IMPALA-10559: Fix flakiness in TestScratchLimit.

2021-03-13 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17182 Change subject: IMPALA-10559: Fix flakiness in TestScratchLimit. .. IMPALA-10559: Fix flakiness in TestScratchLimit. TestScratchLimit

[Impala-ASF-CR] IMPALA-10565: Adjust result spooling memory based on scratch limit

2021-03-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17166 ) Change subject: IMPALA-10565: Adjust result spooling memory based on scratch_limit .. Patch Set 7: Patch set 7 is a rebase of patch

[Impala-ASF-CR] IMPALA-10584: Allow UnpinStream to fail if reservation is not enough

2021-03-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17195 Change subject: IMPALA-10584: Allow UnpinStream to fail if reservation is not enough .. IMPALA-10584: Allow UnpinStream to fail if

[Impala-ASF-CR] IMPALA-10492: Lower default MAX CNF EXPRS query option

2021-02-26 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17132 Change subject: IMPALA-10492: Lower default MAX_CNF_EXPRS query option .. IMPALA-10492: Lower default MAX_CNF_EXPRS query option

[Impala-ASF-CR] IMPALA-10492: Lower default MAX CNF EXPRS query option

2021-02-26 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17132 to look at the new patch set (#2). Change subject: IMPALA-10492: Lower default MAX_CNF_EXPRS query option

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2021-02-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/16755 ) Change subject: IMPALA-9856: Enable result spooling by default. .. Patch Set 4: (2 comments) Patch set 4 is a rebase after

[Impala-ASF-CR] IMPALA-9856: Enable result spooling by default.

2021-02-24 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16755 to look at the new patch set (#4). Change subject: IMPALA-9856: Enable result spooling by default.

[Impala-ASF-CR] IMPALA-10492: Lower default MAX CNF EXPRS query option

2021-02-27 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17132 to look at the new patch set (#3). Change subject: IMPALA-10492: Lower default MAX_CNF_EXPRS query option

[Impala-ASF-CR] IMPALA-10492: Lower default MAX CNF EXPRS query option

2021-02-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17132 ) Change subject: IMPALA-10492: Lower default MAX_CNF_EXPRS query option .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10532: TestOverlapMinMaxFilters.test overlap min max filters seems flaky

2021-04-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky .. Patch Set 10: (3 comments)

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 21: (1 comment)

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 15: (2 comments) Thanks Qifan

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-12 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17195 to look at the new patch set (#3). Change subject: IMPALA-10584: Defer advancing read page when reservation is tight.

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 17: (5 comments)

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 3: It looks like the solution of this

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 18: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-10611: Fix flakiness in test wide row

2021-04-19 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17324 Change subject: IMPALA-10611: Fix flakiness in test_wide_row .. IMPALA-10611: Fix flakiness in test_wide_row test_wide_row has been

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-19 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 22: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 21: > Patch Set 21: > > Build

[Impala-ASF-CR] IMPALA-10647 Improve always-true min/max filter handling in coordinator

2021-04-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17252 ) Change subject: IMPALA-10647 Improve always-true min/max filter handling in coordinator .. Patch Set 20: Code-Review+1 -- To view,

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-13 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17195 to look at the new patch set (#4). Change subject: IMPALA-10584: Defer advancing read page when reservation is tight.

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 4: (2 comments) Patch set 4

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-13 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17195 to look at the new patch set (#5). Change subject: IMPALA-10584: Defer advancing read page when reservation is

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: (1 comment) s

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page when reservation is tight.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page when reservation is tight. .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-10596: De-flake TestAdmissionControllerStress

2021-04-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17272 ) Change subject: IMPALA-10596: De-flake TestAdmissionControllerStress .. Patch Set 1: Code-Review+1 Looks good to me, thanks Bikram for

[Impala-ASF-CR] IMPALA-10583: Fix bug on unbounded result spooling memory config.

2021-04-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17187 ) Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: (8 comments) Patch set 5 change

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17195 to look at the new patch set (#6). Change subject: IMPALA-10584: Defer advancing read page if stream only has 2

[Impala-ASF-CR] IMPALA-10584: Defer advancing read page if stream only has 2 pages.

2021-04-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 ) Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. .. Patch Set 6: > Patch Set 6: > > (8 comments) >

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-16 Thread Riza Suminto (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17054 to look at the new patch set (#3). Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data.

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17054 ) Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17054 ) Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data. .. Patch Set 4: (1 comment)

<    1   2   3   4   5   6   7   8   9   10   >