[Impala-ASF-CR] IMPALA-10497: Fix flakiness in test no fd caching on cached data.

2021-02-16 Thread Riza Suminto (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17054 to look at the new patch set (#4). Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data.

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17077 to look at the new patch set (#2). Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 3: (13 comments) Thank you for the

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17077 ) Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17077 Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile .. IMPALA-10509: Add tool to visualize Impala query

[Impala-ASF-CR] IMPALA-10509: Add tool to visualize Impala query plan from profile

2021-02-17 Thread Riza Suminto (Code Review)
Hello Aman Sinha, David Rorke, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17077 to look at the new patch set (#3). Change subject: IMPALA-10509: Add tool to visualize Impala query plan from profile

[Impala-ASF-CR] IMPALA-9767: Do not cleanup filter while PublishFilter is ongoing

2021-02-20 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17095 Change subject: IMPALA-9767: Do not cleanup filter while PublishFilter is ongoing .. IMPALA-9767: Do not cleanup filter while

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-21 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17095 to look at the new patch set (#2). Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 ) Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing .. Patch Set 2: (10 comments) Thanks Fang-Yu. I'm

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17095 ) Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

2021-02-22 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17095 to look at the new patch set (#3). Change subject: IMPALA-9767: Do not clean up filter while PublishFilter is ongoing

[Impala-ASF-CR] IMPALA-10371: test java udfs crash impalad if result spooling is enabled

2021-02-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17106 ) Change subject: IMPALA-10371: test_java_udfs crash impalad if result spooling is enabled .. Patch Set 2: Code-Review+1 Hi Daniel, The

[Impala-ASF-CR] IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool

2021-08-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17809 Change subject: IMPALA-10880: Fix SummaryStatsCounter bug in impala-profile-tool .. IMPALA-10880: Fix SummaryStatsCounter bug in

[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name

2021-08-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17816 ) Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name .. Patch Set 3: > Patch Set 2: Code-Review+2 > > This

[Impala-ASF-CR] IMPALA-10883: Do not override existing counters with empty profile

2021-08-30 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17819 Change subject: IMPALA-10883: Do not override existing counters with empty profile .. IMPALA-10883: Do not override existing counters

[Impala-ASF-CR] IMPALA-10883: Do not override existing counters with empty profile

2021-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17819 ) Change subject: IMPALA-10883: Do not override existing counters with empty profile .. Patch Set 2: (2 comments) Thanks Quanlong! I

[Impala-ASF-CR] IMPALA-10900: Add Iceberg tests that write many files

2021-09-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17831 ) Change subject: IMPALA-10900: Add Iceberg tests that write many files .. Patch Set 1: Code-Review+1 Other than flake8 warning, the

[Impala-ASF-CR] IMPALA-10883: Do not override existing counters with empty profile

2021-09-07 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17819 to look at the new patch set (#2). Change subject: IMPALA-10883: Do not override existing counters with empty profile

[Impala-ASF-CR] IMPALA-10904: Add some perf tools to the repository

2021-09-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17834 ) Change subject: IMPALA-10904: Add some perf tools to the repository .. Patch Set 1: (1 comment) Hi Zoltan, thanks for adding this

[Impala-ASF-CR] IMPALA-10904: Add some perf tools to the repository

2021-09-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17834 ) Change subject: IMPALA-10904: Add some perf tools to the repository .. Patch Set 3: Code-Review+1 Looks good to me. Thanks Zoltan!

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17853 Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached .. IMPALA-10714: Defer advancing read page until

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-16 Thread Riza Suminto (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17853 to look at the new patch set (#2). Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached

[Impala-ASF-CR] IMPALA-10904: Add some perf tools to the repository

2021-09-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17834 ) Change subject: IMPALA-10904: Add some perf tools to the repository .. Patch Set 2: (1 comment) Thanks for adding the pid option,

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-09-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. Patch Set 1: (2 comments) Hi Amogh, Thanks for submitting the

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-10921 Add script to compare TPCDS runs.

2021-10-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17855 ) Change subject: IMPALA-10921 Add script to compare TPCDS runs. .. Patch Set 5: Code-Review+1 (4 comments) LGTM, please carry my +1.

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 5: (9 comments)

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 5: (5 comments)

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-06 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#5). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-07 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#6). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 6: (5 comments)

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17853 ) Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17853 ) Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached .. Patch Set 4: (11 comments)

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-22 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17853 to look at the new patch set (#4). Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#2). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10942: Fix memory leak in admission controller

2021-10-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17893 ) Change subject: IMPALA-10942: Fix memory leak in admission controller .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#3). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-01 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17894 Change subject: IMPALA-10950: Update expr-benchmark.cc .. IMPALA-10950: Update expr-benchmark.cc Query planner has move the scalar

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 3: (1 comment) Hi Bikram, thank you for your review.

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-05 Thread Riza Suminto (Code Review)
Hello Gabor Kaszab, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17894 to look at the new patch set (#4). Change subject: IMPALA-10950: Update expr-benchmark.cc

[Impala-ASF-CR] IMPALA-10950: Update expr-benchmark.cc

2021-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17894 ) Change subject: IMPALA-10950: Update expr-benchmark.cc .. Patch Set 4: (8 comments)

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-21 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Qifan Chen, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17853 to look at the new patch set (#3). Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached

[Impala-ASF-CR] IMPALA-10714: Defer advancing read page until the buffer is attached

2021-09-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17853 ) Change subject: IMPALA-10714: Defer advancing read page until the buffer is attached .. Patch Set 3: (3 comments) Thank you for the

[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name

2021-08-30 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17816 Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name .. IMPALA-10884: Improve pretty-printing of fragment

[Impala-ASF-CR] IMPALA-10884: Improve pretty-printing of fragment instance name

2021-08-30 Thread Riza Suminto (Code Review)
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17816 to look at the new patch set (#2). Change subject: IMPALA-10884: Improve pretty-printing of fragment instance name

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#15) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-03 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 15: (2 comments)

[Impala-ASF-CR] IMPALA-11047 Preconditions.checkNotNull(statsTuple ) fail in HdfsScanNode.java if PARQUET READ STATISTICS=0

2021-12-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18071 ) Change subject: IMPALA-11047 Preconditions.checkNotNull(statsTuple_) fail in HdfsScanNode.java if PARQUET_READ_STATISTICS=0 .. Patch

[Impala-ASF-CR] IMPALA-11047: Disable overlap predicate if not reading statistic.

2021-12-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18069 Change subject: IMPALA-11047: Disable overlap predicate if not reading statistic. .. IMPALA-11047: Disable overlap predicate if not

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#16) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-11057: Speed up hex int function

2021-12-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 ) Change subject: IMPALA-11057: Speed up hex_int function .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-11057: Speed up hex int function

2021-12-22 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 ) Change subject: IMPALA-11057: Speed up hex_int function .. Patch Set 8: Code-Review+1 Code looks good to me. Thank you again! -- To

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-18 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#13) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. WIP IMPALA-6636: Use

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#10) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. WIP IMPALA-6636: Use

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#11) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. WIP IMPALA-6636: Use

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. Patch Set 11: Patch set 11 fix stream positioning bug and resolve some

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. Patch Set 10: Patch set 10 is a rebase of patch set 9 over recent

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. Patch Set 12: Patch set 12 has the following changes: 1. Remove

[Impala-ASF-CR] WIP IMPALA-6636: Use async IO in ORC scanner

2021-11-17 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#12) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: WIP IMPALA-6636: Use async IO in ORC scanner .. WIP IMPALA-6636: Use

[Impala-ASF-CR] IMPALA-5256: Force log rotation when max log size exceeded

2021-11-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17997 ) Change subject: IMPALA-5256: Force log rotation when max_log_size exceeded .. Patch Set 3: > Patch Set 3: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-5256: Force log rotation when max log size exceeded

2021-11-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17997 ) Change subject: IMPALA-5256: Force log rotation when max_log_size exceeded .. Patch Set 4: > Patch Set 4: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-11020: Reattach STDOUT/STDERR independently.

2021-11-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18031 Change subject: IMPALA-11020: Reattach STDOUT/STDERR independently. .. IMPALA-11020: Reattach STDOUT/STDERR independently. IMPALA-5256

[Impala-ASF-CR] IMPALA-11020: Reattach STDOUT/STDERR independently.

2021-11-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18031 ) Change subject: IMPALA-11020: Reattach STDOUT/STDERR independently. .. Patch Set 1: Hello Andrew & Joe, This is the patch needed to

[Impala-ASF-CR] IMPALA-11020: Reattach STDOUT/STDERR independently.

2021-11-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18031 ) Change subject: IMPALA-11020: Reattach STDOUT/STDERR independently. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#5). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#4). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 5: (16 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-02 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#6). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve performance of TimestampValue::ToString

2021-10-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve performance of TimestampValue::ToString .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-10984: Improve performance of TimestampValue::ToString

2021-10-27 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#2). Change subject: IMPALA-10984: Improve performance of TimestampValue::ToString

[Impala-ASF-CR] IMPALA-10984: Improve performance of TimestampValue::ToString

2021-10-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve performance of TimestampValue::ToString .. Patch Set 2: (4 comments) Thank you, Csaba, for the

[Impala-ASF-CR] IMPALA-10984: Improve performance of TimestampValue::ToString

2021-10-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve performance of TimestampValue::ToString .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-29 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (4 comments) Thank you everyone for the

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-28 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 3: (8 comments)

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-10-28 Thread Riza Suminto (Code Review)
Hello Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#3). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve performance of TimestampValue::ToString

2021-10-26 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17980 Change subject: IMPALA-10984: Improve performance of TimestampValue::ToString .. IMPALA-10984: Improve performance of

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: GVO over patch set 9 hit flaky test previously

[Impala-ASF-CR] IMPALA-5256: Force log rotation when max log size exceeded

2021-11-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17997 ) Change subject: IMPALA-5256: Force log rotation when max_log_size exceeded .. Patch Set 2: (9 comments)

[Impala-ASF-CR] IMPALA-5256: Force log rotation when max log size exceeded

2021-11-08 Thread Riza Suminto (Code Review)
Hello Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17997 to look at the new patch set (#2). Change subject: IMPALA-5256: Force log rotation when max_log_size exceeded

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 9: > Patch Set 9: > > Build failed:

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Riza Suminto (Code Review)
Hello Qifan Chen, Kurt Deschler, Csaba Ringhofer, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17980 to look at the new patch set (#8). Change subject: IMPALA-10984: Improve TimestampValue to String casting

[Impala-ASF-CR] IMPALA-10984: Improve TimestampValue to String casting

2021-11-04 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/17980 ) Change subject: IMPALA-10984: Improve TimestampValue to String casting .. Patch Set 8: The GVO failed because I forgot handling for

[Impala-ASF-CR] IMPALA-5256: Force log rolling when max log size exceeded

2021-11-03 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17997 Change subject: IMPALA-5256: Force log rolling when max_log_size exceeded .. IMPALA-5256: Force log rolling when max_log_size exceeded

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-02 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#14) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 14: (6 comments)

[Impala-ASF-CR] IMPALA-11055: Remove "exit" from HBase data loading script.

2021-12-09 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18079 Change subject: IMPALA-11055: Remove "exit" from HBase data loading script. .. IMPALA-11055: Remove "exit" from HBase data loading

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-09 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#18) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 18: Patch set 18 clarifies comment in HdfsScanNode.java -- To

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-08 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#17) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 17: (1 comment) Patch set 17 remove the reservation increment

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 16: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-10 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#19) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 19: (1 comment) Patch set 19 add typedef ColumnRangeLengths.

[Impala-ASF-CR] IMPALA-11057: Speed to hex int function

2021-12-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 ) Change subject: IMPALA-11057: Speed to hex_int function .. Patch Set 5: (1 comment) Hello! Thank you for your interest in improving

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-11057: Speed up hex int function

2021-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 ) Change subject: IMPALA-11057: Speed up hex_int function .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#20) to the change originally created by Csaba Ringhofer. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. IMPALA-6636: Use async

[Impala-ASF-CR] IMPALA-6636: Use async IO in ORC scanner

2021-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/15370 ) Change subject: IMPALA-6636: Use async IO in ORC scanner .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-11057: Speed up hex int function

2021-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18091 ) Change subject: IMPALA-11057: Speed up hex_int function .. Patch Set 7: (1 comment)

<    1   2   3   4   5   6   7   8   9   10   >