[Impala-ASF-CR] IMPALA-11674: Fix timeout detection for TSSLSocket

2022-10-20 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19157 ) Change subject: IMPALA-11674: Fix timeout detection for TSSLSocket .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-11418: A statement that returns at most one row need not to spool results

2022-09-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 ) Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results .. Patch Set 9: Code-Review+1 Looks

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

2022-09-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19040 Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml .. IMPALA-11611: Replace THRIFT_HOME with

[Impala-ASF-CR] IMPALA-11611: Replace THRIFT HOME with THIFT JAVA HOME in fe/pom.xml

2022-09-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19040 ) Change subject: IMPALA-11611: Replace THRIFT_HOME with THIFT_JAVA_HOME in fe/pom.xml .. Patch Set 1: Hit by IMPALA-11572 -- To

[Impala-ASF-CR] IMPALA-11418: A statement that returns at most one row need not to spool results

2022-09-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 ) Change subject: IMPALA-11418: A statement that returns at most one row need not to spool results .. Patch Set 8: (1 comment)

[Impala-ASF-CR] IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric

2022-10-05 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19095 Change subject: IMPALA-11637: Add DCHECK in AdmissionController::UpdateExecGroupMetric .. IMPALA-11637: Add DCHECK in

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-12 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#18) to the change originally created by Omid Shahidi. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. IMPALA-6684: Fix untracked

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 18: (3 comments) Since we removed TRowBatch-based

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 18: > Patch Set 18: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-11655: Impala should set write mode "merge-on-read" by default

2022-10-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19138 ) Change subject: IMPALA-11655: Impala should set write mode "merge-on-read" by default .. Patch Set 1: (3 comments) Hi Zoltan, the

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 15: (5 comments) Agree that we should clean up Thrift RPC

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: Code-Review+2 Looks good. Thank you for taking care of

[Impala-ASF-CR] IMPALA-11628: Switch to reload4j, update slf4j

2022-10-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19102 ) Change subject: IMPALA-11628: Switch to reload4j, update slf4j .. Patch Set 1: -Code-Review Removing my vote following Joe's comment.

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-11 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#16) to the change originally created by Omid Shahidi. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. IMPALA-6684: Fix untracked

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 16: (19 comments) Patch set 16 switch the tracking

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-11 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#17) to the change originally created by Omid Shahidi. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. IMPALA-6684: Fix untracked

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-14 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 19: > Patch Set 19: Verified-1 > > Build failed:

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-13 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#19) to the change originally created by Omid Shahidi. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. IMPALA-6684: Fix untracked

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-10-13 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 19: Can't figure out what the bug is. So I revert back to

[Impala-ASF-CR] IMPALA-6684: Fix untracked memory in KRPC

2022-09-05 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18798 ) Change subject: IMPALA-6684: Fix untracked memory in KRPC .. Patch Set 13: We can probably follow memory estimate computation from

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

2022-08-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 ) Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0 .. Patch Set 2: Code-Review+2 Rebase and carry +2 due to

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. Patch Set 2: Code-Review+2 Rebase and carry +2. --

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

2022-08-07 Thread Riza Suminto (Code Review)
Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/18804 to look at the new patch set (#2). Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

2022-08-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 ) Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0 .. Patch Set 2: > Patch Set 2: Verified-1 > > Build

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-07 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. Patch Set 1: Verified+1 Carry Verified vote from

[Impala-ASF-CR] IMPALA-11489: Fix int overflow in >2GB ORC files

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18827 ) Change subject: IMPALA-11489: Fix int overflow in >2GB ORC files .. Patch Set 1: Code-Review+2 Thank you for catching this, Csaba!

[Impala-ASF-CR] IMPALA-10453: Support file pruning via runtime filters on Iceberg

2022-08-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18531 ) Change subject: IMPALA-10453: Support file pruning via runtime filters on Iceberg .. Patch Set 11: (1 comment)

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

2022-08-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18804 ) Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0 .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. Patch Set 3: Verified+1 Carry chain head's vote. --

[Impala-ASF-CR] IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18804 ) Change subject: IMPALA-11385: Upgrade JAVA thrift components to thrift-0.16.0 .. IMPALA-11385: Upgrade JAVA thrift components

[Impala-ASF-CR] IMPALA-11465, IMPALA-11466: Bump CDP BUILD NUMBER to 30010248

2022-08-09 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18803 ) Change subject: IMPALA-11465, IMPALA-11466: Bump CDP_BUILD_NUMBER to 30010248 .. IMPALA-11465, IMPALA-11466: Bump

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 12: Since we're concern about DCHECK removal

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#12). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 12: > Patch Set 12: > > I wonder if somehow

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 11: Manually retested PS11 with test

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 12: > Patch Set 12: > > inconsistency found

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#7). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#4). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 4: (5 comments) Thank you for catching

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#5). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#8). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#13). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 12: > Patch Set 12: > > > Patch Set 12: > >

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 13: PS13 lower thrift_rpc_max_message_size

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-02 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. IMPALA-11669: (addendum) Set TConfiguration in

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 14: Thank you everyone for your review! I

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 30: ps30 is a rebase of ps29. -- To view, visit

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-10 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#30) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-12 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#32) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 31: ps31 picks up the design from ps29, but decouple

[Impala-ASF-CR] IMPALA-11833: Fixed manifest length in snapshot files

2023-01-12 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19409 ) Change subject: IMPALA-11833: Fixed manifest_length in snapshot files .. Patch Set 5: Code-Review+1 I picked up ps5 and test it by

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-12 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#31) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 1: (1 comment) Thanks Yida! Just have

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-11 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] [tools] Add inline pom.py script for development

2022-12-02 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19314 ) Change subject: [tools] Add inline_pom.py script for development .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2022-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 1: Code-Review+1 (1 comment) Looks

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2022-12-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-11584: Enable minicluster tests for Ozone

2022-11-21 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19250 ) Change subject: IMPALA-11584: Enable minicluster tests for Ozone .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19423 Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala .. IMPALA-11658: Implement Iceberg manifest caching

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#33) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-24 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 33: Summary for changes in ps33: - Restore import order -

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-24 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#34) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-25 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#35) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 35: (1 comment)

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-25 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 4: Code-Review+1 This looks good to

[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.48

2023-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.48 .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#37) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 37: ps37 is a rebase of ps36 -- To view, visit

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 37: (3 comments)

[Impala-ASF-CR] IMPALA-11855: Upgrade jetty to 9.4.50

2023-01-30 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19436 ) Change subject: IMPALA-11855: Upgrade jetty to 9.4.50 .. Patch Set 4: Code-Review+2 Looks good to me, thank you! -- To view, visit

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-27 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#36) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 36: ps36 adds the following: - CheckEffectiveInstanceCount in

[Impala-ASF-CR] IMPALA-11617: Pool service should be made aware of cpu core limit

2023-01-27 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19366 ) Change subject: IMPALA-11617: Pool service should be made aware of cpu core limit .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-18 Thread Riza Suminto (Code Review)
Hello Yida Wu, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19423 to look at the new patch set (#2). Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala

[Impala-ASF-CR] IMPALA-11658: Implement Iceberg manifest caching config for Impala

2023-01-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19423 ) Change subject: IMPALA-11658: Implement Iceberg manifest caching config for Impala .. Patch Set 2: (4 comments)

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-01-18 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 32: (2 comments)

[Impala-ASF-CR] IMPALA-11836: Remove duplicated information in codegen cache logs

2023-01-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19415 ) Change subject: IMPALA-11836: Remove duplicated information in codegen cache logs .. Patch Set 2: Code-Review+2 Thanks Yida! Carrying

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 10: Code-Review+2 (1 comment) Thank you

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#9). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#10). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 10: SslTest.TLSVersionControl fail with the

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-11-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 11: > Patch Set 11: > > Don't understand how

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#11). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19179 ) Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer .. Patch Set 11: I assumed PS10 failure is due to

[Impala-ASF-CR] IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

2022-10-31 Thread Riza Suminto (Code Review)
Hello Quanlong Huang, Csaba Ringhofer, Wenzhe Zhou, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/19179 to look at the new patch set (#6). Change subject: IMPALA-11669: (addendum) Set TConfiguration in TMemoryBuffer

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 39: (1 comment) ps39 add PlannerTest#testProcessingCost and

[Impala-ASF-CR] IMPALA-11809: Support non unique primary key for Kudu

2023-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19383 ) Change subject: IMPALA-11809: Support non unique primary key for Kudu .. Patch Set 13: (5 comments) I need to do another pass. In the

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-02-01 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#39) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 58: Code-Review+2 (1 comment) Thank you Qifan and Wenzhe! I

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#58) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. IMPALA-11604 Planner

[Impala-ASF-CR] IMPALA-11604 Planner changes for CPU usage

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 Planner changes for CPU usage .. Patch Set 58: -Code-Review Temporarily removing the +2 votes. I'll test

[Impala-ASF-CR] IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink

2023-03-08 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink .. IMPALA-11604 (part 1): Model

[Impala-ASF-CR] IMPALA-11604 (part 2): Compute Effective Parallelism of Query

2023-03-08 Thread Riza Suminto (Code Review)
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19593 ) Change subject: IMPALA-11604 (part 2): Compute Effective Parallelism of Query .. IMPALA-11604 (part 2): Compute Effective

[Impala-ASF-CR] IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink

2023-03-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink .. Patch Set 59: Verified+1 Code-Review+2 Carry

[Impala-ASF-CR] IMPALA-11604 (part 2): Compute Effective Parallelism of Query

2023-03-08 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/19593 ) Change subject: IMPALA-11604 (part 2): Compute Effective Parallelism of Query .. Patch Set 1: Code-Review+2 Thanks everyone! Carry two

[Impala-ASF-CR] IMPALA-11604 (part 2): Compute Effective Parallelism of Query

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19593 Change subject: IMPALA-11604 (part 2): Compute Effective Parallelism of Query .. IMPALA-11604 (part 2): Compute Effective Parallelism of

[Impala-ASF-CR] IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink

2023-03-06 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded a new patch set (#59) to the change originally created by Qifan Chen. ( http://gerrit.cloudera.org:8080/19033 ) Change subject: IMPALA-11604 (part 1): Model ProcessingCost for PlanNodes & DataSink ..

<    3   4   5   6   7   8   9   10   11   12   >