[Impala-ASF-CR] IMPALA-12705: Add /catalog-ha-info page on Starstore to show catalog HA information

2024-05-19 Thread Impala Public Jenkins (Code Review)
Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16187/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF

[Impala-ASF-CR] IMPALA-12705: Add /catalog-ha-info page on Starstore to show catalog HA information

2024-05-19 Thread ttttttz (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21418 to look at the new patch set (#6). Change subject: IMPALA-12705: Add /catalog-ha-info page on Starstore to show catalog HA information

[Impala-ASF-CR](branch-3.4.2) IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files.

2024-05-18 Thread Xiang Yang (Code Review)
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21410 ) Change subject: IMPALA-12362: (part-4/4) Refactor linux packaging related cmake files. .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-18 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: (3 comments) Looks great!

[Impala-ASF-CR] IMPALA-13093: Fix failure in inserting into OBS tables

2024-05-17 Thread Xiang Yang (Code Review)
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21438 ) Change subject: IMPALA-13093: Fix failure in inserting into OBS tables .. Patch Set 1: Code-Review+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16186/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 2: (1 comment) > Patch Set 1: C

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Hello Daniel Becker, Gabor Kaszab, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21441 to look at the new patch set (#2). Change subject: IMPALA-12562: Cast double and float to string with exact

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21436 ) Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. Patch Set 1: (15 comments) I like this change a

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. IMPALA-12886: Bump GoogleTest version to 1.14.0 This is to

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. Patch Set 4: Code-Review+2 Carry +2 from Joe -- To view, visit

[native-toolchain-CR] IMPALA-12886: Bump GoogleTest version to 1.14.0

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21133 ) Change subject: IMPALA-12886: Bump GoogleTest version to 1.14.0 .. Patch Set 4: Verified+1 Built successfully on private infrastructure

[Impala-ASF-CR] xxxx HA

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21418 ) Change subject: HA .. Patch Set 5: Build Failed https://jenkins.impala.io/job/gerrit-code-review-checks/16185

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-17 Thread Impala Public Jenkins (Code Review)
Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16184/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Impala Public Jenkins (Code Review)
Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16182/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21412 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-13093: Fix failure in inserting into OBS tables

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16183/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21438 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16181/ : Initial code review checks failed. See linked job for details on the failure. -- To view, visit http://gerrit.cloudera.org:8080/21441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16180/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21357 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 ) Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. IMPALA-13020 (part 2): Split

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. IMPALA-13020 (part 1): Change

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Verified+1 Code-Review+2 I'm

[Impala-ASF-CR] IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21442 To unsubscribe, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Impala Public Jenkins (Code Review)
.. Patch Set 1: Build Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16177/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21440 To unsubscribe

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16178/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21439 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Impala Public Jenkins (Code Review)
Successful https://jenkins.impala.io/job/gerrit-code-review-checks/16176/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21420 To unsubscribe, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Impala Public Jenkins (Code Review)
://jenkins.impala.io/job/gerrit-code-review-checks/16175/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/21367 To unsubscribe, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster

2024-05-17 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21442 Change subject: IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster .. IMPALA-13017: Add S3 bucket endpoint parameters

[Impala-ASF-CR] IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21442 ) Change subject: IMPALA-13017: Add S3 bucket endpoint parameters for the minicluster .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-17 Thread Steve Carlin (Code Review)
Hello Aman Sinha, Joe McDonnell, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21357 to look at the new patch set (#11). Change subject: IMPALA-12935: First pass on Calcite planner functions

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-17 Thread Steve Carlin (Code Review)
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 10: (2 comments)

[Impala-ASF-CR] IMPALA-13020 (part 1): Change thrift rpc max message size to int64 t

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21367 ) Change subject: IMPALA-13020 (part 1): Change thrift_rpc_max_message_size to int64_t .. Patch Set 5: Code-Review+1 (1 comment) http

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Code-Review+2 (1

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21441 ) Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. Patch Set 1: Code-Review+1 (1 comment) Thanks

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 ) Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches .. Patch Set 3: Code-Review+1

[Impala-ASF-CR] IMPALA-12562: Cast double and float to string with exact presicion

2024-05-17 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21441 Change subject: IMPALA-12562: Cast double and float to string with exact presicion .. IMPALA-12562: Cast double and float to string with

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21440 ) Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant .. Patch

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21439 ) Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. Patch Set 2: Code-Review+2 Thanks Csaba! Carry +2

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Riza Suminto (Code Review)
Hello Laszlo Gaal, Csaba Ringhofer, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21439 to look at the new patch set (#2). Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Code-Review+1 > Pa

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. IMPALA-13055: Some Iceberg metadata

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-13091: query test.test iceberg.TestIcebergV2Table.test metadata tables fails on an expected constant

2024-05-17 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21440 Change subject: IMPALA-13091: query_test.test_iceberg.TestIcebergV2Table.test_metadata_tables fails on an expected constant ..

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Verified+1 --

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-17 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21439 ) Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. Patch Set 1: Code-Review+2 (1 comment) http

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21412 ) Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-13034: Add logs and counters for HTTP profile requests blocking client fetches

2024-05-17 Thread Quanlong Huang (Code Review)
Hello Kurt Deschler, Csaba Ringhofer, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21412 to look at the new patch set (#3). Change subject: IMPALA-13034: Add logs and counters for HTTP profile requests blocking

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-13055: Some Iceberg metadata table tests don't assert

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21394 ) Change subject: IMPALA-13055: Some Iceberg metadata table tests don't assert .. Patch Set 3: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 5: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-13029: Tests for multi format equality deletes

2024-05-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21348 ) Change subject: IMPALA-13029: Tests for multi format equality deletes .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 3: Build started:

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Joe McDonnell (Code Review)
Hello Quanlong Huang, Riza Suminto, Michael Smith, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21420 to look at the new patch set (#3). Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

[Impala-ASF-CR] IMPALA-13040: (addendum) Inject larger delay for sanitized build

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21439 Change subject: IMPALA-13040: (addendum) Inject larger delay for sanitized build .. IMPALA-13040: (addendum) Inject larger delay for

[Impala-ASF-CR] IMPALA-13093: Fix failure in inserting into OBS tables

2024-05-16 Thread Quanlong Huang (Code Review)
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21438 Change subject: IMPALA-13093: Fix failure in inserting into OBS tables .. IMPALA-13093: Fix failure in inserting into OBS tables On

[Impala-ASF-CR] IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off

2024-05-16 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21437 Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when EP is turned off .. IMPALA-12277: Fix

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 5:

[Impala-ASF-CR] IMPALA-13083: Clarify REASON MEM LIMIT TOO LOW FOR RESERVATION

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21436 Change subject: IMPALA-13083: Clarify REASON_MEM_LIMIT_TOO_LOW_FOR_RESERVATION .. IMPALA-13083: Clarify

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 1: Verified-1

[Impala-ASF-CR] IMPALA-12935: First pass on Calcite planner functions

2024-05-16 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21357 ) Change subject: IMPALA-12935: First pass on Calcite planner functions .. Patch Set 10: (3 comments)

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. Patch Set 1: Verified+1 -- To view, visit

[native-toolchain-CR] IMPALA-13072: Add retries for s3 uploads to combat flakiness

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21421 ) Change subject: IMPALA-13072: Add retries for s3 uploads to combat flakiness .. IMPALA-13072: Add retries for s3 uploads to

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 5:

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Impala Public Jenkins (Code Review)
: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90275bb8c065fc5af61186901ac7e9839a68c43b Gerrit-Change-Number: 21188

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: Code-Review+1

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (1 comment) > Also,

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 ) Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-16 Thread Michael Smith (Code Review)
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder

2024-05-16 Thread Zoltan Borok-Nagy (Code Review)
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21435 Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder .. IMPALA-13088: (part 1) Improve

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 4:

[Impala-ASF-CR] IMPALA-13809: Revert "IMPALA-12559: Support x5c Parameter for RSA JSON"

2024-05-16 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has abandoned this change. ( http://gerrit.cloudera.org:8080/21434 ) Change subject: IMPALA-13809: Revert "IMPALA-12559: Support x5c Parameter for RSA JSON" .. Abandoned Superceded by a real fix in

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-16 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21429 ) Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. Patch Set 3: Code-Review+1 Thank

[Impala-ASF-CR] IMPALA-13809: Revert "IMPALA-12559: Support x5c Parameter for RSA JSON"

2024-05-16 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21434 ) Change subject: IMPALA-13809: Revert "IMPALA-12559: Support x5c Parameter for RSA JSON" .. Patch Set 1: Patch

[Impala-ASF-CR] IMPALA-12559 (part 2): Fix build issue for different versions of openssl

2024-05-16 Thread Wenzhe Zhou (Code Review)
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21432 ) Change subject: IMPALA-12559 (part 2): Fix build issue for different versions of openssl .. IMPALA-12559 (part 2): Fix build

[Impala-ASF-CR] IMPALA-12559 (part 2): Fix build issue for different versions of openssl

2024-05-16 Thread Abhishek Rawat (Code Review)
Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21432 ) Change subject: IMPALA-12559 (part 2): Fix build issue for different versions of openssl .. Patch Set 1: Code-Review+2 -- To view

[Impala-ASF-CR] IMPALA-13809: Revert "IMPALA-12559: Support x5c Parameter for RSA JSON"

2024-05-16 Thread Laszlo Gaal (Code Review)
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21434 Change subject: IMPALA-13809: Revert "IMPALA-12559: Support x5c Parameter for RSA JSON" .. IMPALA-13809: Revert "IMPALA-12559: Support

[Impala-ASF-CR] IMPALA-13001: Support graceful and force shutdown for impala.sh.

2024-05-16 Thread Xiang Yang (Code Review)
Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21297 ) Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh. .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-12559 (part 2): Fix build issue for different versions of openssl

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21432 ) Change subject: IMPALA-12559 (part 2): Fix build issue for different versions of openssl .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-16 Thread Daniel Becker (Code Review)
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21429 ) Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. IMPALA-13085: Add warning and NULL

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-16 Thread Daniel Becker (Code Review)
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21429 ) Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. Patch Set 3: (3 comments)

[Impala-ASF-CR] IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables

2024-05-16 Thread Peter Rozsa (Code Review)
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21429 ) Change subject: IMPALA-13085: Add warning and NULL out DECIMAL values in Iceberg metadata tables .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 3: Code

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 4:

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Impala Public Jenkins (Code Review)
: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90275bb8c065fc5af61186901ac7e9839a68c43b Gerrit-Change-Number: 21188

[Impala-ASF-CR] IMPALA-13001: Support graceful and force shutdown for impala.sh.

2024-05-16 Thread Xiang Yang (Code Review)
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21297 to look at the new patch set (#3). Change subject: IMPALA-13001: Support graceful and force shutdown for impala.sh.

[Impala-ASF-CR] IMPALA-12921, IMPALA-12985: Support locally built Ranger

2024-05-16 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21160 ) Change subject: IMPALA-12921, IMPALA-12985: Support locally built Ranger .. Patch Set 15: (1 comment) In patch set 15, I have

[Impala-ASF-CR] IMPALA-12559 (part 2): Fix build issue for different versions of openssl

2024-05-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21432 ) Change subject: IMPALA-12559 (part 2): Fix build issue for different versions of openssl .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 3:

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-16 Thread Sai Hemanth Gantasala (Code Review)
Hello Csaba Ringhofer, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21188 to look at the new patch set (#3). Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user

[Impala-ASF-CR] IMPALA-12559 (part 2): Fix build issue for different versions of openssl

2024-05-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21432 ) Change subject: IMPALA-12559 (part 2): Fix build issue for different versions of openssl .. Patch Set 1: Verified-1 Build

[Impala-ASF-CR] IMPALA-12709: Add support for hierarchical metastore event processing

2024-05-15 Thread Sai Hemanth Gantasala (Code Review)
Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 ) Change subject: IMPALA-12709: Add support for hierarchical metastore event processing .. Patch Set 19: (12 comments)

[Impala-ASF-CR] IMPALA-12921, IMPALA-12985: Support locally built Ranger

2024-05-15 Thread Fang-Yu Rao (Code Review)
Hello Quanlong Huang, Aman Sinha, Joe McDonnell, Impala Public Jenkins, John Sherman, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/21160 to look at the new patch set (#15). Change subject: IMPALA-12921, IMPALA-12985: Support locally built Ranger

[Impala-ASF-CR] IMPALA-11735: Handle CREATE TABLE event when the db is invisible to the impala server user

2024-05-15 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21188 ) Change subject: IMPALA-11735: Handle CREATE_TABLE event when the db is invisible to the impala server user .. Patch Set 2: Code

[Impala-ASF-CR] IMPALA-12921, IMPALA-12985: Support locally built Ranger

2024-05-15 Thread Fang-Yu Rao (Code Review)
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21160 ) Change subject: IMPALA-12921, IMPALA-12985: Support locally built Ranger .. Patch Set 14: (1 comment) I found a typo in

[Impala-ASF-CR] IMPALA-13020 (part 2): Split out external vs internal Thrift max message size

2024-05-15 Thread Riza Suminto (Code Review)
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21420 ) Change subject: IMPALA-13020 (part 2): Split out external vs internal Thrift max message size .. Patch Set 2: Also, please update

  1   2   3   4   5   6   7   8   9   10   >