[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 6: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 6: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 6: Code-Review+2 Carrying +2 -- To view, visit

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 6: (4 comments) Rebase and fix the tests.

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#6). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 5: Code-Review+2 Oh and looks like this needs to be

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments) LGTM pending the test updates / doc

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 5: (1 comment) > Patch Set 3: > > (2 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-24 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-23 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 5: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-23 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 5: (2 comments) patch 5 fixed style issues.

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-23 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#5). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 4: Code-Review+1 (2 comments) Couple of nits, but i'm

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 4: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-20 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (6 comments) Patch 4 addresses review issues.

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-20 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#4). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-19 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: > Patch Set 3: > > (2 comments) Give you an example

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-19 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (5 comments) > Patch Set 3: > > (2 comments) . I

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-19 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-19 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments) Answer some questions while I fix the

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: (9 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 3: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 2: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#3). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 2: (3 comments) New patch refactoring code to address

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 2: (6 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-18 Thread Yongzhi Chen (Code Review)
Hello Bharath Vissapragada, Sahil Takiar, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14234 to look at the new patch set (#2). Change subject: IMPALA-7637: Add more hash table stats to profile

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: (2 comments) Looks good, I had a couple of

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14234 ) Change subject: IMPALA-7637: Add more hash table stats to profile .. Patch Set 1: Build Successful

[Impala-ASF-CR] IMPALA-7637: Add more hash table stats to profile

2019-09-16 Thread Yongzhi Chen (Code Review)
Yongzhi Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14234 Change subject: IMPALA-7637: Add more hash table stats to profile .. IMPALA-7637: Add more hash table stats to profile Add hash table