Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 4: Code-Review+2
Carrying +2. Holding off GVO till other priority
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6651
to look at the new patch set (#4).
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 3:
(4 comments)
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 3: Code-Review+2
(4 comments)
Alex Behm has posted comments on this change.
Change subject: IMPALA-5145 : Do not constant fold null in CastExprs
..
Patch Set 1:
(1 comment)
Bharath Vissapragada has uploaded a new patch set (#3).
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
IMPALA-4943: Speed up block md loading for add/recover partition calls.
This
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
(2 comments)
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5145 : Do not constant fold null in CastExprs
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6663/1//COMMIT_MSG
Commit
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
(2 comments)
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6664
Change subject: IMPALA-4548: BlockingJoinNode should wait for async build thread
..
IMPALA-4548: BlockingJoinNode should wait for async
Alex Behm has posted comments on this change.
Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to
Thrift
..
Patch Set 1:
(1 comment)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Patch Set 3:
(17 comments)
first look
Alex Behm has posted comments on this change.
Change subject: IMPALA-5145 : Do not constant fold null in CastExprs
..
Patch Set 1:
(6 comments)
Minor comments, changes look good.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5124: add tests for scratch read errors
..
Patch Set 5: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/6562
To unsubscribe,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5124: add tests for scratch read errors
..
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/462/
--
To view,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool
..
Patch Set 9:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/461/
--
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool
..
Patch Set 9: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/6498
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5124: add tests for scratch read errors
..
Patch Set 4: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/459/
--
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool
..
Patch Set 8: Verified-1
Build failed:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool
..
Patch Set 23: Code-Review+2
Fix clang-tidy nit
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool
..
Patch Set 22: Verified-1
Build failed:
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6414
to look at the new patch set (#23).
Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool
..
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to
Thrift
..
Patch Set 1:
(1 comment)
anujphadke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6663
Change subject: IMPALA-5145 : Do not constant fold null in CastExprs
..
IMPALA-5145 : Do not constant fold null in CastExprs
Constant
Taras Bobrovytsky has uploaded a new patch set (#3).
Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to
Thrift
..
IMPALA-5188: Sort the slots in a tuple before serializing to Thrift
The slot
Taras Bobrovytsky has uploaded a new patch set (#2).
Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to
Thrift
..
IMPALA-5188: Sort the slots in a tuple before serializing to Thrift
The slot
Michael Ho has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/runtime/coordinator-backend-state.h
File
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 6:
(25 comments)
http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/common/status.h
File
Alex Behm has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6651/2//COMMIT_MSG
Commit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 4:
(5 comments)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 4:
(3 comments)
Just some minor comments.
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
(1 comment)
Alex Behm has posted comments on this change.
Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
..
Patch Set 10: Code-Review+2
(2 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5124: add tests for scratch read errors
..
Patch Set 4: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/6562
To unsubscribe,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool
..
Patch Set 8: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/6498
To
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5124: add tests for scratch read errors
..
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/459/
--
To view,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool
..
Patch Set 8:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/458/
--
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool
..
Patch Set 22:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/457/
--
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
..
Patch Set 10: Code-Review+1
carry +1
--
To view, visit http://gerrit.cloudera.org:8080/5538
To
Oops, ignore the outdated PS2 comments. The PS6 ones are current though!
On 17 April 2017 at 16:41, Henry Robinson (Code Review) wrote:
> Henry Robinson has posted comments on this change.
>
> Change subject: IMPALA-2550: Switch to per-query exec rpc
>
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
..
Patch Set 9:
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
..
Patch Set 9:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/5538/9/common/thrift/CMakeLists.txt
File
Hello Bharath Vissapragada,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5538
to look at the new patch set (#10).
Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
..
Henry Robinson has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 6:
(14 comments)
I quickly looked at some familiar files.
Hello Matthew Jacobs,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6626
to look at the new patch set (#5).
Change subject: IMPALA-5220: memory maintenance cleanup
..
IMPALA-5220:
Dimitris Tsirogiannis has uploaded a new patch set (#4).
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
IMPALA-5147: Add the ability to exclude hosts from query execution
This commit
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 1:
(1 comment)
Michael Ho has posted comments on this change.
Change subject: IMPALA-5192: Don't bake MemPool* into IR
..
Patch Set 3: Code-Review+1
Carry Tim's and Tara's +1 forward.
--
To view, visit http://gerrit.cloudera.org:8080/6657
Michael Ho has posted comments on this change.
Change subject: IMPALA-5192: Don't bake MemPool* into IR
..
Patch Set 2:
(4 comments)
Thanks for the review.
Hello Taras Bobrovytsky, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6657
to look at the new patch set (#3).
Change subject: IMPALA-5192: Don't bake MemPool* into IR
..
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6442/3/be/src/util/blocking-queue.h
Dan Hecht has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 3: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-2800: make memory maintenance less aggressive
..
Patch Set 4:
As we talked about in person, it'd be good to figure out whether the
GcTcmalloc() is coming
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5720
to look at the new patch set (#10).
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
Henry Robinson has uploaded a new patch set (#6).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
IMPALA-4669: [KRPC] Add kudu_rpc library to build
Import FindKRPC.cmake from Apache Kudu.
One minor linking
Henry Robinson has posted comments on this change.
Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore
services to KRPC
..
Patch Set 10:
Rebase, plus a couple of bug fixes.
--
To view, visit
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6473
to look at the new patch set (#4).
Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs
..
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
IMPALA-4856: Port ImpalaInternalService to KRPC
This patch ports the ImpalaInternalService to KRPC.
*
Taras Bobrovytsky has posted comments on this change.
Change subject: IMPALA-5192: Don't bake MemPool* into IR
..
Patch Set 2: Code-Review+1
Looks good to me too. Agree with Tim that comments need to be updated.
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool
..
Patch Set 8:
Updated with an algorithmic improvement to PAGG IMPALA-2708 and a related test.
--
Tim Armstrong has uploaded a new patch set (#8).
Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool
..
PREVIEW: IMPALA-4678: port backend exec to use buffer pool
Always create global BufferPool at
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5073: Part 1: add option to use mmap() for buffer pool
..
Patch Set 11: Code-Review+2
Rebase
--
To view, visit http://gerrit.cloudera.org:8080/6474
To
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4166: Add SORT BY sql clause
..
Patch Set 15:
(19 comments)
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables
..
Patch Set 4:
> > > > Perf results from running on the 10 node cluster:
> > > >
> > > > For
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 6:
(4 comments)
Looked through some of the files I'm more familiar with - had a few minor
comments.
Henry Robinson has posted comments on this change.
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6442/2/be/src/util/blocking-queue.h
Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6442
to look at the new patch set (#3).
Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args
..
Allow
Zach Amsden has uploaded a new patch set (#2).
Change subject: IMPALA-5159: Optimze predicates [DRAFT]
..
IMPALA-5159: Optimze predicates [DRAFT]
In addition to propagating constants, we can infer bounds on slotRefs
which are
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5198: Error messages are sometimes dropped before
reaching client
..
Patch Set 4:
> > > > (1 comment)
> >
> > > We have an error_log, which is different
Alex Behm has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6651/2//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5192: Don't bake MemPool* into IR
..
Patch Set 2: Code-Review+1
(4 comments)
This looks good to me aside from some comments that need updating.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4029: Reduce memory requirements for storing file
metadata
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6406
To
Alex Behm has posted comments on this change.
Change subject: IMPALA-5125: SimplifyConditionalsRule incorrectly handles
aggregates
..
Patch Set 1:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/6653/1//COMMIT_MSG
Commit
Michael Ho has uploaded a new patch set (#2).
Change subject: IMPALA-5192: Don't bake MemPool* into IR
..
IMPALA-5192: Don't bake MemPool* into IR
Tuple::CodegenMaterializeExprs() currently bakes the MemPool*
provided by its
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables
..
Patch Set 4:
> > > Perf results from running on the 10 node cluster:
> > >
> > > For smaller
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
Our metadata benchmark doesn't have "refresh partition" calls
Alex Behm has posted comments on this change.
Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs
..
Patch Set 9:
(8 comments)
Unfortunate that we have to do this, but I can't think of a better way.
Michael Ho has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/runtime/query-state.cc
File
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
Patch Set 2:
(1 comment)
Bharath Vissapragada has uploaded a new patch set (#2).
Change subject: IMPALA-4943: Speed up block md loading for add/recover
partition calls.
..
IMPALA-4943: Speed up block md loading for add/recover partition calls.
This
Michael Ho has posted comments on this change.
Change subject: IMPALA-2550: Switch to per-query exec rpc
..
Patch Set 6:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/exec/data-sink.cc
File
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5198: Error messages are sometimes dropped before
reaching client
..
Patch Set 4:
> > > (1 comment)
>
> > We have an error_log, which is different
Michael Ho has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6657
Change subject: IMPALA-5129: Don't bake MemPool* into IR
..
IMPALA-5129: Don't bake MemPool* into IR
Tuple::CodegenMaterializeExprs()
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 1:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5198: Error messages are sometimes dropped before
reaching client
..
Patch Set 4:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 1:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
Patch Set 1:
(1 comment)
Dimitris Tsirogiannis has uploaded a new patch set (#3).
Change subject: IMPALA-5147: Add the ability to exclude hosts from query
execution
..
IMPALA-5147: Add the ability to exclude hosts from query execution
This commit
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5159: Optimze predicates
..
Patch Set 1:
So I don't think our JVM implementation likes calling .add and .remove on the
same ListIterator, despite that
Thomas Tauber-Marshall has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6653
Change subject: IMPALA-5125: SimplifyConditionalsRule incorrectly handles
aggregates
..
IMPALA-5125: SimplifyConditionalsRule
Jakub Kukul has posted comments on this change.
Change subject: IMPALA-1726: Treat parquet ENUMs as STRINGs when creating
tables.
..
Patch Set 1:
> Hey Jakub. Have you had time to think about how we could test this?
> Let me
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5080: OutOfMemory PermGen space
..
Patch Set 3: Code-Review+2
Carrying forward Alex's +2
--
To view, visit
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5080: OutOfMemory PermGen space
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6642/2/bin/impala-config.sh
File
Hello Matthew Jacobs, Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6642
to look at the new patch set (#3).
Change subject: IMPALA-5080: OutOfMemory PermGen space
..
94 matches
Mail list logo