[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 4: Code-Review+2 Carrying +2. Holding off GVO till other priority

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6651 to look at the new patch set (#4). Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls.

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 3: Code-Review+2 (4 comments)

[Impala-ASF-CR] IMPALA-5145 : Do not constant fold null in CastExprs

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5145 : Do not constant fold null in CastExprs .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#3). Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. IMPALA-4943: Speed up block md loading for add/recover partition calls. This

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5145 : Do not constant fold null in CastExprs

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5145 : Do not constant fold null in CastExprs .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6663/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4548: BlockingJoinNode should wait for async build thread

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6664 Change subject: IMPALA-4548: BlockingJoinNode should wait for async build thread .. IMPALA-4548: BlockingJoinNode should wait for async

[Impala-ASF-CR] IMPALA-5188: Sort the slots in a tuple before serializing to Thrift

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to Thrift .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4856: Port ImpalaInternalService to KRPC

2017-04-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC .. Patch Set 3: (17 comments) first look

[Impala-ASF-CR] IMPALA-5145 : Do not constant fold null in CastExprs

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5145 : Do not constant fold null in CastExprs .. Patch Set 1: (6 comments) Minor comments, changes look good.

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5124: add tests for scratch read errors .. Patch Set 5: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6562 To unsubscribe,

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5124: add tests for scratch read errors .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/462/ -- To view,

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/461/ --

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 9: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/6498 To

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5124: add tests for scratch read errors .. Patch Set 4: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/459/ --

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 8: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 23: Code-Review+2 Fix clang-tidy nit -- To view, visit

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 22: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6414 to look at the new patch set (#23). Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool ..

[Impala-ASF-CR] IMPALA-5188: Sort the slots in a tuple before serializing to Thrift

2017-04-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to Thrift .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5145 : Do not constant fold null in CastExprs

2017-04-17 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6663 Change subject: IMPALA-5145 : Do not constant fold null in CastExprs .. IMPALA-5145 : Do not constant fold null in CastExprs Constant

[Impala-ASF-CR] IMPALA-5188: Sort the slots in a tuple before serializing to Thrift

2017-04-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#3). Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to Thrift .. IMPALA-5188: Sort the slots in a tuple before serializing to Thrift The slot

[Impala-ASF-CR] IMPALA-5188: Sort the slots in a tuple before serializing to Thrift

2017-04-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5188: Sort the slots in a tuple before serializing to Thrift .. IMPALA-5188: Sort the slots in a tuple before serializing to Thrift The slot

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/runtime/coordinator-backend-state.h File

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 6: (25 comments) http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/common/status.h File

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6651/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 4: (3 comments) Just some minor comments.

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 10: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5124: add tests for scratch read errors .. Patch Set 4: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/6562 To unsubscribe,

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 8: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/6498 To

[Impala-ASF-CR] IMPALA-5124: add tests for scratch read errors

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5124: add tests for scratch read errors .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/459/ -- To view,

[Impala-ASF-CR] IMPALA-4114: Port BufferedBlockMgr tests to buffer pool

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4114: Port BufferedBlockMgr tests to buffer pool .. Patch Set 8: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/458/ --

[Impala-ASF-CR] IMPALA-3203: Part 2: per-core free lists in buffer pool

2017-04-17 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3203: Part 2: per-core free lists in buffer pool .. Patch Set 22: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/457/ --

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 10: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/5538 To

Re: [Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Henry Robinson
Oops, ignore the outdated PS2 comments. The PS6 ones are current though! On 17 April 2017 at 16:41, Henry Robinson (Code Review) wrote: > Henry Robinson has posted comments on this change. > > Change subject: IMPALA-2550: Switch to per-query exec rpc >

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 9: (8 comments) http://gerrit.cloudera.org:8080/#/c/5538/9/common/thrift/CMakeLists.txt File

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-17 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5538 to look at the new patch set (#10). Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs ..

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 6: (14 comments) I quickly looked at some familiar files.

[Impala-ASF-CR] IMPALA-5220: memory maintenance cleanup

2017-04-17 Thread Tim Armstrong (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6626 to look at the new patch set (#5). Change subject: IMPALA-5220: memory maintenance cleanup .. IMPALA-5220:

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 3: Code-Review+1 Carry Tim's and Tara's +1 forward. -- To view, visit http://gerrit.cloudera.org:8080/6657

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 2: (4 comments) Thanks for the review.

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-17 Thread Michael Ho (Code Review)
Hello Taras Bobrovytsky, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6657 to look at the new patch set (#3). Change subject: IMPALA-5192: Don't bake MemPool* into IR ..

[Impala-ASF-CR] Allow BlockingQueue and ThreadPool to accept rvalue args

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6442/3/be/src/util/blocking-queue.h

[Impala-ASF-CR] Allow BlockingQueue and ThreadPool to accept rvalue args

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-2800: make memory maintenance less aggressive

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2800: make memory maintenance less aggressive .. Patch Set 4: As we talked about in person, it'd be good to figure out whether the GcTcmalloc() is coming

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-04-17 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5720 to look at the new patch set (#10). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#6). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build Import FindKRPC.cmake from Apache Kudu. One minor linking

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 10: Rebase, plus a couple of bug fixes. -- To view, visit

[Impala-ASF-CR] IMPALA-4889: Use client sidecars for Thrift RPCs

2017-04-17 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6473 to look at the new patch set (#4). Change subject: IMPALA-4889: Use client sidecars for Thrift RPCs ..

[Impala-ASF-CR] IMPALA-4856: Port ImpalaInternalService to KRPC

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC .. IMPALA-4856: Port ImpalaInternalService to KRPC This patch ports the ImpalaInternalService to KRPC. *

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-17 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 2: Code-Review+1 Looks good to me too. Agree with Tim that comments need to be updated. -- To view,

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. Patch Set 8: Updated with an algorithmic improvement to PAGG IMPALA-2708 and a related test. --

[Impala-ASF-CR] PREVIEW: IMPALA-4678: port backend exec to use buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: PREVIEW: IMPALA-4678: port backend exec to use buffer pool .. PREVIEW: IMPALA-4678: port backend exec to use buffer pool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-5073: Part 1: add option to use mmap() for buffer pool

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5073: Part 1: add option to use mmap() for buffer pool .. Patch Set 11: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/6474 To

[Impala-ASF-CR] IMPALA-4166: Add SORT BY sql clause

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4166: Add SORT BY sql clause .. Patch Set 15: (19 comments)

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-17 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 4: > > > > Perf results from running on the 10 node cluster: > > > > > > > > For

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 6: (4 comments) Looked through some of the files I'm more familiar with - had a few minor comments.

[Impala-ASF-CR] Allow BlockingQueue and ThreadPool to accept rvalue args

2017-04-17 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6442/2/be/src/util/blocking-queue.h

[Impala-ASF-CR] Allow BlockingQueue and ThreadPool to accept rvalue args

2017-04-17 Thread Henry Robinson (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6442 to look at the new patch set (#3). Change subject: Allow BlockingQueue and ThreadPool to accept rvalue args .. Allow

[Impala-ASF-CR] IMPALA-5159: Optimze predicates [DRAFT]

2017-04-17 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-5159: Optimze predicates [DRAFT] .. IMPALA-5159: Optimze predicates [DRAFT] In addition to propagating constants, we can infer bounds on slotRefs which are

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 4: > > > > (1 comment) > > > > > We have an error_log, which is different

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6651/2//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-17 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 2: Code-Review+1 (4 comments) This looks good to me aside from some comments that need updating.

[Impala-ASF-CR] IMPALA-4029: Reduce memory requirements for storing file metadata

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4029: Reduce memory requirements for storing file metadata .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6406 To

[Impala-ASF-CR] IMPALA-5125: SimplifyConditionalsRule incorrectly handles aggregates

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5125: SimplifyConditionalsRule incorrectly handles aggregates .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/6653/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-5192: Don't bake MemPool* into IR .. IMPALA-5192: Don't bake MemPool* into IR Tuple::CodegenMaterializeExprs() currently bakes the MemPool* provided by its

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-17 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 4: > > > Perf results from running on the 10 node cluster: > > > > > > For smaller

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: Our metadata benchmark doesn't have "refresh partition" calls

[Impala-ASF-CR] IMPALA-5184: build fe against both Hive 1 & 2 APIs

2017-04-17 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5184: build fe against both Hive 1 & 2 APIs .. Patch Set 9: (8 comments) Unfortunate that we have to do this, but I can't think of a better way.

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/runtime/query-state.cc File

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4943: Speed up block md loading for add/recover partition calls.

2017-04-17 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#2). Change subject: IMPALA-4943: Speed up block md loading for add/recover partition calls. .. IMPALA-4943: Speed up block md loading for add/recover partition calls. This

[Impala-ASF-CR] IMPALA-2550: Switch to per-query exec rpc

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2550: Switch to per-query exec rpc .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/6535/4/be/src/exec/data-sink.cc File

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-17 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 4: > > > (1 comment) > > > We have an error_log, which is different

[Impala-ASF-CR] IMPALA-5129: Don't bake MemPool* into IR

2017-04-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6657 Change subject: IMPALA-5129: Don't bake MemPool* into IR .. IMPALA-5129: Don't bake MemPool* into IR Tuple::CodegenMaterializeExprs()

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5198: Error messages are sometimes dropped before reaching client

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5198: Error messages are sometimes dropped before reaching client .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This commit

[Impala-ASF-CR] IMPALA-5159: Optimze predicates

2017-04-17 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5159: Optimze predicates .. Patch Set 1: So I don't think our JVM implementation likes calling .add and .remove on the same ListIterator, despite that

[Impala-ASF-CR] IMPALA-5125: SimplifyConditionalsRule incorrectly handles aggregates

2017-04-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6653 Change subject: IMPALA-5125: SimplifyConditionalsRule incorrectly handles aggregates .. IMPALA-5125: SimplifyConditionalsRule

[Impala-ASF-CR] IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables.

2017-04-17 Thread Jakub Kukul (Code Review)
Jakub Kukul has posted comments on this change. Change subject: IMPALA-1726: Treat parquet ENUMs as STRINGs when creating tables. .. Patch Set 1: > Hey Jakub. Have you had time to think about how we could test this? > Let me

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 3: Code-Review+2 Carrying forward Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-17 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5080: OutOfMemory PermGen space .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6642/2/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-5080: OutOfMemory PermGen space

2017-04-17 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6642 to look at the new patch set (#3). Change subject: IMPALA-5080: OutOfMemory PermGen space ..