Lars Volker has submitted this change and it was merged.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
..
IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Occasionally we'd
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7167
Change subject: IMPALA-5495: Improve error message if no impalad role configured
..
IMPALA-5495: Improve error message if no impalad
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5446: dropped Sorter::Reset() status
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7134
To unsubscribe, visit
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5446: dropped Sorter::Reset() status
..
IMPALA-5446: dropped Sorter::Reset() status
This patch aligns the sorter's methods closer with
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 5: Verified-1
Patchset 5 takes about an hour or so to repro the error - it
Henry Robinson has posted comments on this change.
Change subject: Support gcc 6.3.0 and 7.1.0
..
Patch Set 2: Code-Review+2
That Thrift bug was some ugly code :/
--
To view, visit http://gerrit.cloudera.org:8080/7156
To
sakinape...@cloudera.com has posted comments on this change.
Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate
..
Patch Set 3:
(17 comments)
additional tests and changes to normalize binary
sakinape...@cloudera.com has uploaded a new patch set (#3).
Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate
..
IMPALA-5280: Coalesce chains of OR conditions to an IN predicate
This change
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5492:There is an error in impala-shell introduction when
using LDAP
..
Patch Set 2:
(3 comments)
Thanks for submitting the patch. Mind fix a
Donghui Xu has uploaded a new patch set (#2).
Change subject: IMPALA-5492:There is an error in impala-shell introduction when
using LDAP
..
IMPALA-5492:There is an error in impala-shell introduction when using LDAP
The
Donghui Xu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7166
Change subject: IMPALA-5492:There is an error in impala-shell introduction when
using LDAP
..
IMPALA-5492:There is an error in
David Knupp has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7159
To
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 4:
(2 comments)
Thanks for the comments. Please see PS5.
Lars Volker has uploaded a new patch set (#5).
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs
There was a race
Lars Volker has uploaded a new patch set (#4).
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs
There was a race
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5085: large rows in BufferedTupleStreamV2
..
Patch Set 10:
(23 comments)
Michael Ho has posted comments on this change.
Change subject: IMPALA-4669: [SECURITY] Add security library to build
..
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5717/7/CMakeLists.txt
File CMakeLists.txt:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5446: dropped Sorter::Reset() status
..
Patch Set 2: Code-Review+2
rebase
--
To view, visit http://gerrit.cloudera.org:8080/7134
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5446: dropped Sorter::Reset() status
..
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/724/
--
To view,
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7154
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
IMPALA-5487: Fix race in RuntimeProfile::toThrift()
node.num_children got initialized
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5446: dropped Sorter::Reset() status
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7134
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 3:
(2 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7148
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
IMPALA-5031: Don't dereference uninitialized memory as a bool.
Every bool
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 1:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/7103/1/be/src/runtime/data-stream-mgr.cc
File
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4856: Port data stream service to KRPC
..
IMPALA-4856: Port data stream service to KRPC
This patch ports the data-flow parts of ImpalaInternalService to
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3905: HdfsScanner::GetNext() for Avro, RC, and Seq scans.
..
Patch Set 4:
(6 comments)
Did the tests pass?
I did another pass over the code, just had
anujphadke has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7159
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7159
To
Michael Brown has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
..
Patch Set 1:
(1 comment)
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
..
IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Occasionally we'd see HBase
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 3:
(2 comments)
Apologies Sailesh for the messed up PS #2. In general I try
Lars Volker has posted comments on this change.
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
Patch Set 3:
Thank you for your comments. I changed the code and the commit message
Lars Volker has uploaded a new patch set (#3).
Change subject: IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and
beeswax RPCs
..
IMPALA-5427: Fix race between CRS::UpdateQueryStatus() and beeswax RPCs
There was a race
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 2:
(2 comments)
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
IMPALA-5427: Fix order of status handling in ClientRequestState
There was a race in
Tim Armstrong has uploaded a new patch set (#2).
Change subject: Support gcc 6.3.0 and 7.1.0
..
Support gcc 6.3.0 and 7.1.0
The default still remains gcc 4.9.2 but this lets us play around
with different GCC versions. The
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7156
Change subject: Support gcc 6.3.0 and 7.1.0
..
Support gcc 6.3.0 and 7.1.0
The default still remains gcc 4.9.2 but this lets us play
Henry Robinson has abandoned this change.
Change subject: IMPALA-4856: Port ImpalaInternalService to KRPC
..
Abandoned
Superseded by https://gerrit.cloudera.org/#/c/7103/
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 1:
> > (1 comment)
> >
> > This is really subtle. In order to be correct, you'd need
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 1: -Code-Review
> (1 comment)
>
> This is really subtle. In order to be correct,
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2: -Code-Review
> Is the the -kerb option deprecated in the buildall.sh script? If
>
Michael Brown has posted comments on this change.
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
Patch Set 2:
(1 comment)
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
Is the the -kerb option deprecated in the buildall.sh script? If not is there a
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4856: Port data stream service to KRPC
..
Patch Set 1:
(12 comments)
> This patch passes core, exhaustive and ASAN tests. It can execute
> 32
David Knupp has posted comments on this change.
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
Patch Set 2: Code-Review+2
(1 comment)
Michael Brown has posted comments on this change.
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
Patch Set 2:
> Do you have a Jenkins run that uses this code?
There is currently nothing
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 1:
(1 comment)
This is really subtle. In order to be correct, you'd need at least a
Matthew Mulder has posted comments on this change.
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
Patch Set 2:
The code looks good to me. Do you have a Jenkins run that uses this code?
--
Congratulations on your first commit, Yu! Thanks for your contribution.
Great work on getting this through design and code review!
On Mon, Jun 12, 2017 at 1:31 PM, Impala Public Jenkins (Code Review) <
ger...@cloudera.org> wrote:
> Impala Public Jenkins has submitted this change and it was
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
..
IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
Simplify
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7015
To
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7155
To
Alex Behm has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 3:
(26 comments)
http://gerrit.cloudera.org:8080/#/c/6812/3/be/src/exec/hdfs-parquet-scanner.cc
File
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7155
Change subject: IMPALA-5427: Fix order of status handling in ClientRequestState
..
IMPALA-5427: Fix order of status handling in
Thomas Tauber-Marshall has uploaded a new patch set (#4).
Change subject: IMPALA-4622: Add ALTER COLUMN statement.
..
IMPALA-4622: Add ALTER COLUMN statement.
Kudu recently added the ability to alter a column's default value
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-4622: Add ALTER COLUMN statement.
..
Patch Set 4:
(2 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 2:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/723/
--
To
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 2: Code-Review+1
LGTM, thanks.
--
To view, visit http://gerrit.cloudera.org:8080/7154
To
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7154
To unsubscribe, visit
Lars Volker has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 1:
(1 comment)
Thank you for the comments. I uploaded PS2, where I removed the .reserve().
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 2: Code-Review+2
Please have Tim and Sailesh also finish their reviews.
--
To view, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5031: Remove undefined behavior "reference binding to
null"
..
Patch Set 6:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
Patch Set 3:
Build started:
Jim Apple has posted comments on this change.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
Patch Set 3:
> Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/720/
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
Patch Set 3: Verified-1
Build failed:
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 1:
> (1 comment)
Let's remove it
--
To view, visit http://gerrit.cloudera.org:8080/7154
To
Lars Volker has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7154/1/be/src/util/runtime-profile.cc
File
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow
builds
..
Patch Set 2: Code-Review+1
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7154/1/be/src/util/runtime-profile.cc
File
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7154/1/be/src/util/runtime-profile.cc
File
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7154
Change subject: IMPALA-5487: Fix race in RuntimeProfile::toThrift()
..
IMPALA-5487: Fix race in RuntimeProfile::toThrift()
Michael Brown has posted comments on this change.
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
Patch Set 2:
(1 comment)
Alex Behm has posted comments on this change.
Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate
..
Patch Set 2:
(17 comments)
Michael Brown has uploaded a new patch set (#2).
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
IMPALA-5263: test infra: support CA bundles with secure clusters
This patch adds the command
Michael Brown has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7152
Change subject: IMPALA-5263: test infra: support CA bundles with secure clusters
..
IMPALA-5263: test infra: support CA bundles with
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
..
Patch Set 6:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/721/
Alex Behm has posted comments on this change.
Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7015
To unsubscribe,
Alex Behm has uploaded a new patch set (#6).
Change subject: IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
..
IMPALA-5016: Simplify COALESCE() in SimplifyConditionalsRule.
Simplify COALESCE by skipping leading
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
Patch Set 3:
Build started:
Jim Apple has posted comments on this change.
Change subject: IMPALA-5031: Don't dereference uninitialized memory as a bool.
..
Patch Set 3: Code-Review+2
rebase carry
--
To view, visit http://gerrit.cloudera.org:8080/7148
82 matches
Mail list logo
