[Impala-ASF-CR] [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations

2017-11-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8545 Change subject: [PREVIEW] IMPALA-5058: Improve concurrency of DDL/DML operations .. [PREVIEW] IMPALA-5058: Improve concurrency

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-11-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8529 ) Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. Patch Set 1: Screenshots of the catalog

[Impala-ASF-CR] [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI.

2017-11-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8529 Change subject: [PREVIEW] IMPALA-4886: Expose table metrics in the catalog web UI. .. [PREVIEW] IMPALA-4886: Expose table

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-11-09 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 22: Code-Review+2 (7

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-3613: Avoid topic updates to unregistered subscriber instances

2017-11-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8449 ) Change subject: IMPALA-3613: Avoid topic updates to unregistered subscriber instances .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 10: Code-Review+2 Nice work! -- To view,

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 9: (16 comments)

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-10-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 5: (8 comments) Did you add any planner

[Impala-ASF-CR] IMPALA-1422: support a constant on LHS of IN predicates.

2017-10-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8322 ) Change subject: IMPALA-1422: support a constant on LHS of IN predicates. .. Patch Set 4: (20 comments) First pass. I think

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 11: Code-Review+1 (4

[Impala-ASF-CR] IMPALA-4704: Turns on client connections when local catalog initialized.

2017-10-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Turns on client connections when local catalog initialized. .. Patch Set 9: (6 comments)

[Impala-ASF-CR] IMPALA-5058: Improve concurrency of DDL/DML during catalog updates

2017-10-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has abandoned this change. ( http://gerrit.cloudera.org:8080/8266 ) Change subject: IMPALA-5058: Improve concurrency of DDL/DML during catalog updates .. Abandoned There are a number of serious issues

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-16 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. .. Patch Set 4: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-4704: Disallow client connections to imapalad until catalog is received.

2017-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8202 ) Change subject: IMPALA-4704: Disallow client connections to imapalad until catalog is received. .. Patch Set 7: (15 comments)

[Impala-ASF-CR] IMPALA-5058: Improve concurrency of DDL/DML during catalog updates

2017-10-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8266 Change subject: IMPALA-5058: Improve concurrency of DDL/DML during catalog updates .. IMPALA-5058: Improve concurrency of

[Impala-ASF-CR] IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION.

2017-10-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8238 ) Change subject: IMPALA-4524: Batch calls to ALTER TABLE...ADD PARTITION. .. Patch Set 3: (2 comments) Re testing, a simple

[Impala-ASF-CR] IMPALA-5429: Multi threaded block metadata loading

2017-10-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8235 ) Change subject: IMPALA-5429: Multi threaded block metadata loading .. Patch Set 5: (22 comments)

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 9: Code-Review+1 (5

[Impala-ASF-CR] IMPALA-4682 Fix IllegalStateException issue

2017-10-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8143 ) Change subject: IMPALA-4682 Fix IllegalStateException issue .. Patch Set 1: Zoram, let's try to move this forward. We don't

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-10-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 8: (3 comments) Thanks!

[Impala-ASF-CR] IMPALA-6009: Upgrade Guava to 14.0.1

2017-10-03 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8198 ) Change subject: IMPALA-6009: Upgrade Guava to 14.0.1 .. Patch Set 4: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4951: Fix database visibility for user with only column privilege

2017-09-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8168 ) Change subject: IMPALA-4951: Fix database visibility for user with only column privilege .. Patch Set 3: Code-Review+2 -- To

[Impala-ASF-CR] IMPALA-5951: Remove flaky test catalogd timeout

2017-09-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8154 ) Change subject: IMPALA-5951: Remove flaky test_catalogd_timeout .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4951: Fix database visibility for user with only column privilege

2017-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8168 ) Change subject: IMPALA-4951: Fix database visibility for user with only column privilege .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-4951: Fix database visibility for user with only column privilege

2017-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8168 ) Change subject: IMPALA-4951: Fix database visibility for user with only column privilege .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.

2017-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8136 ) Change subject: IMPALA-5310: Add COMPUTE STATS TABLESAMPLE. .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5951: test catalogd timeout fails to cause expected exception

2017-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8154 ) Change subject: IMPALA-5951: test_catalogd_timeout fails to cause expected exception .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4951: Fix database visibility for user with only column privilege

2017-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8168 ) Change subject: IMPALA-4951: Fix database visibility for user with only column privilege .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7564 ) Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 6: Thanks for adding the

[Impala-ASF-CR] IMPALA-5310: Add COMPUTE STATS TABLESAMPLE.

2017-09-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8136 ) Change subject: IMPALA-5310: Add COMPUTE STATS TABLESAMPLE. .. Patch Set 1: (26 comments) First pass. High level approach

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-26 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 ) Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 8: Code-Review+2 Rebase and keep

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-25 Thread Dimitris Tsirogiannis (Code Review)
Hello Bharath Vissapragada, Alex Behm, Vuk Ercegovac, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7731 to look at the new patch set (#7). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/7731 ) Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 5: (7 comments)

[Impala-ASF-CR] IMPALA-5955: Use totalSize tblproperty instead of rawDataSize.

2017-09-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8110 ) Change subject: IMPALA-5955: Use totalSize tblproperty instead of rawDataSize. .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-5954: Set DO NOT UPDATE STATS in alterTable() RPCs to HMS.

2017-09-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. ( http://gerrit.cloudera.org:8080/8112 ) Change subject: IMPALA-5954: Set DO_NOT_UPDATE_STATS in alterTable() RPCs to HMS. .. Patch Set 2: Code-Review+2 -- To view,

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-19 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7731 to look at the new patch set (#6). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ..

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-19 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 5: (27 comments)

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 5: (2 comments) Addressing some questions by Dan.

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7731 to look at the new patch set (#5). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ..

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7731 to look at the new patch set (#4). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects ..

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 3: (4 comments)

[Impala-ASF-CR] IMPALA-5856: Fix outer join predicate assignment.

2017-09-14 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5856: Fix outer join predicate assignment. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8039 To unsubscribe,

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-5856: Fix outer join predicate assignment.

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5856: Fix outer join predicate assignment. .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. IMPALA-5538: Use explicit catalog versions for deleted objects This commit changes the

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 2: (16 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 18: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-12 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 18: Taking a look now. -- To view, visit

[Impala-ASF-CR] IMPALA-1767 Adds predicate to test boolean values true, false, unknown.

2017-09-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1767 Adds predicate to test boolean values true, false, unknown. .. Patch Set 6: (22 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. IMPALA-5538: Use explicit catalog versions for deleted objects This commit changes the

[Impala-ASF-CR] [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 1: (28 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (9 comments)

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (2 comments) Flushing minor comments from patch #8 and switching to

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > For this options serialization question, we have a C++ >

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-06 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > > > > (1 comment) > > > > > > The tests in this change use only

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/7955/3//COMMIT_MSG

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-09-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 4: > > (1 comment) > > The tests in this change use only 3 query

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-05 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: (17 comments)

[Impala-ASF-CR] [PREVIEW] Use native allocation while building catalog updates

2017-09-04 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] Use native allocation while building catalog updates .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-31 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5850: Cast sender partition exprs under unions.

2017-08-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5850: Cast sender partition exprs under unions. .. Patch Set 1: Code-Review+2 (2 comments)

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-08-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Patch Set 2: (4 comments) Just some answers on the comments. Haven't looked at

[Impala-ASF-CR] IMPALA-5836: Improvements to Eclipse frontend configuration.

2017-08-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5836: Improvements to Eclipse frontend configuration. .. Patch Set 1: Code-Review+2 Thank you! -- To view, visit

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-24 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 5: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#4). Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. IMPALA-5531: Fix correctness issue in correlated aggregate subqueries This

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 3: (5 comments)

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#3). Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. IMPALA-5531: Fix correctness issue in correlated aggregate subqueries This

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-22 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-21 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. IMPALA-5531: Fix correctness issue in correlated aggregate subqueries This

[Impala-ASF-CR] [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-08-18 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7731 Change subject: [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects .. [PREVIEW] IMPALA-5538: Use explicit

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-17 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/7706 Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. IMPALA-5531: Fix correctness issue in

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7652 To

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-11 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 2: (3 comments) Yay, more lined deleted :)

[Impala-ASF-CR] IMPALA-4847: Simplify HdfsTable block metadata loading code

2017-08-10 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4847: Simplify HdfsTable block metadata loading code .. Patch Set 1: (5 comments)

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7257 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-30 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 2: (2 comments) Just minor responses; thanks for the clarifications. I'll take a look at the

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-29 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 2: (8 comments)

[Impala-ASF-CR] IMPALA-5489: Improve Sentry authorization for Kudu tables

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5489: Improve Sentry authorization for Kudu tables .. Patch Set 1: (4 comments)

[Impala-ASF-CR] IMPALA-5547: Rework FK/PK join detection.

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5547: Rework FK/PK join detection. .. Patch Set 1: (17 comments) I have one comment about testing. We have lots of test changes but it's not

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 10: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7268 To unsubscribe,

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7268 to look at the new patch set (#9). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500:

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7268 to look at the new patch set (#8). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500:

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/7268/7/be/src/catalog/catalog-server.cc

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 7: > The code changes look good. We don't seem to have any test coverage > for this flag

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#7). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/5/be/src/catalog/catalog-server.cc

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#5). Change subject: IMPALA-5500: Reduce catalog update topic size .. IMPALA-5500: Reduce catalog update topic size Problem: IMPALA-4029 introduced the use of the flatbuffers

[Impala-ASF-CR] IMPALA-5500: Reduce catalog update topic size

2017-06-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5500: Reduce catalog update topic size .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7268/4/be/src/catalog/catalog-server.cc

  1   2   3   4   5   >