[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 15: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. IMPALA-5908: Allow SET to unset modified

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 15: Build started:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 15: Code-Review+2 Let me retry -- To view,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: The build error seems to be: > 19:44:25 ]

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 14: Build started:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-10-03 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 13: Phil, please rebase this one now that the other

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 12: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 12: Build started:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-29 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 12: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-29 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#11). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 7: (7 comments)

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 10: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 10: Code-Review+1 (1 comment) Tim, since you were a

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-25 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 10: (8 comments) I filed

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-25 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, Tim Armstrong, Dan Hecht, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#10). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-21 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8070 ) Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message: PS9,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: (9 comments) If you haven't already, please file a doc jira to update the docs based on

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 9: This passes tests, so is ready to be reviewed. -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#9). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 8: I'm still re-running tests. The Overlay function wasn't setting __is_set when it

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#8). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-19 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 7: I'm still fighting through some test failures in this latest iteration. -- To view,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 7: (2 comments)

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#7). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-18 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 5: Following through on the layering (process options, pool defaults, session options,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 6: Code-Review-1 Dan pointed out an important point that unsetting might mean that we

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#6). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Hello Impala Public Jenkins, Bharath Vissapragada, Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#5). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 5: How embarrassing! New patch uploaded. The relevant test passes now. -- To view,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 4: That last error looks like an infra issue but it does looks like there was a test

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 4: I'm not an expert at reading these yet, but I think it's complaining about the

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1224/ -- To

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-15 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8070 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 3: Code-Review+1 Carry'ing Tim's +1. -- To view, visit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8070 to look at the new patch set (#3). Change subject: IMPALA-5908: Allow SET to unset modified query options.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 2: Code-Review+1 (3 comments) Wrote these up earlier but didn't push them out.

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new patch set (#2). Change subject: IMPALA-5908: Allow SET to unset modified query options. .. IMPALA-5908: Allow SET to unset modified query options. The query 'SET =""' will now unset option,

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/1/be/src/service/query-options.cc File

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8070/1/be/src/service/query-options.cc

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5908: Allow SET to unset modified query options. .. Patch Set 1: (4 comments) Makes sense to me. Had some minor comments but I'd also like someone else

[Impala-ASF-CR] IMPALA-5908: Allow SET to unset modified query options.

2017-09-14 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded a new change for review. http://gerrit.cloudera.org:8080/8070 Change subject: IMPALA-5908: Allow SET to unset modified query options. .. IMPALA-5908: Allow SET to unset modified query options.