[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/187/ --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. Patch Set 7: (15 comments)

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#8). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4752: make ObjectPool more efficient .. IMPALA-4752: make ObjectPool more efficient Previously it was implemented as a vector of

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5666 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4757: addendum: avoid double underscore in name .. IMPALA-4757: addendum: avoid double underscore in name Names containing double

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore in name .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5702 To

[Impala-ASF-CR] Clean up tags for 2 query options

2017-01-12 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: Clean up tags for 2 query options .. Patch Set 1: Code-Review+1 pulled and built the changes in a new branch--no merge conflicts. HTML nav titles look good. --

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. IMPALA-4549: consistently treat as upper bound for timestamp year Previously

[Impala-ASF-CR] IMPALA-4549: consistently treat 9999 as upper bound for timestamp year

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4549: consistently treat as upper bound for timestamp year .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. IMPALA-4748: crash in TmpFileMgr when hitting process mem limit The bug is that FileGroup

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 3: Code-Review+2 Verified+1 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5660 To unsubscribe,

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5631 To unsubscribe,

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4757: addendum: avoid double underscore in name .. IMPALA-4757: addendum: avoid double underscore in name Names containing double underscore are

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore in name .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5702/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4757: addendum: avoid double underscore prefix .. IMPALA-4757: addendum: avoid double underscore prefix Names starting with double underscore are

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore in name .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5702 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2615: warn if Status is ignored .. IMPALA-2615: warn if Status is ignored This introduces a WARN_UNUSED_RESULT macro. It can be used at

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5631 To

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 2: (1 comment) Hopefully that is a little clearer.

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-12 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. Patch Set 2: you do have a merge conflict that must be resolved. -- To view, visit

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore prefix .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5702/1//COMMIT_MSG Commit Message: PS1, Line

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore in name

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4757: addendum: avoid double underscore in name .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/188/ --

[Impala-ASF-CR] IMPALA-3202: implement spill-to-disk in new buffer pool

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool .. IMPALA-3202: implement spill-to-disk in new buffer pool See https://goo.gl/0zuy97 for a high-level

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements -

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5486

[Impala-ASF-CR] IMPALA-4739: ExprRewriter fails on HAVING clauses

2017-01-12 Thread Anonymous Coward (Code Review)
zams...@cloudera.com has posted comments on this change. Change subject: IMPALA-4739: ExprRewriter fails on HAVING clauses .. Patch Set 6: (2 comments) I realize this is already merged - simply learning how to use gerrit and

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState .. Patch Set 4: (18 comments) http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/coordinator.cc File

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5631 to look at the new patch set (#4). Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException ..

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5659 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: > Turns out there's a gcc bug that prevents this from working > sometimes (including for DiskIoMgr::Init()).

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4757: addendum: avoid double underscore prefix

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5702 Change subject: IMPALA-4757: addendum: avoid double underscore prefix .. IMPALA-4757: addendum: avoid double underscore prefix Names

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5666 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. Patch Set 7: Code-Review+2 carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5486

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/185/ -- To view, visit

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment .. IMPALA-4036: invalid SQL generated for partitioned table with comment For a

[Impala-ASF-CR] IMPALA-4036: invalid SQL generated for partitioned table with comment

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4036: invalid SQL generated for partitioned table with comment .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5648 To

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5631 to look at the new patch set (#5). Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException ..

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Tim Armstrong (Code Review)
Hello Lars Volker, Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5666 to look at the new patch set (#4). Change subject: IMPALA-4752: make ObjectPool more efficient

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5666/3/be/src/common/object-pool.h File

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 4: Code-Review+2 Carry +2 -- To view, visit http://gerrit.cloudera.org:8080/5666 To unsubscribe,

[Impala-ASF-CR] IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-4643: Centralize tags in separate .ditamap

2017-01-12 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4643: Centralize tags in separate .ditamap .. Patch Set 2: Code-Review+1 I pulled the files into my own branch and built them with the dita ot 2.3.3 into

[Impala-ASF-CR] IMPALA-4678: move query MemTracker into QueryState

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4678: move query MemTracker into QueryState .. IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/186/ -- To view,

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4651: Add LibEv to build .. IMPALA-4651: Add LibEv to build Add libev 4.20 to the Impala build. This is a dependency of KRPC. FindLibEv.cmake

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5659 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 2: Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/178/ -- To view, visit

[Impala-ASF-CR] IMPALA-4652: Add crcutil to build

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4652: Add crcutil to build .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5660 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/179/ -- To

[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints

2017-01-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2522: Add doc for sortby() and clustered hints .. Patch Set 4: (10 comments) Thanks for the change. I added comments inline.

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 3: (2 comments)

[Impala-ASF-CR] IMPALA-4716: Expr rewrite causes IllegalStateException

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4716: Expr rewrite causes IllegalStateException .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-4747: macros should only evaluate their arguments once

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5686/2/be/src/testutil/gtest-util.h

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2017-01-12 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 6: Code-Review+2 carry taras's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-4355: random query generator: modify statement execution flow to support DML

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4355: random query generator: modify statement execution flow to support DML .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/6/be/src/runtime/disk-io-mgr-test.cc File

[Impala-ASF-CR] IMPALA-4752: make ObjectPool more efficient

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4752: make ObjectPool more efficient .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 3: Is this a duplicate of https://gerrit.cloudera.org/#/c/5668/? -- To view, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#6). Change subject: IMPALA-2615: warn if Status is ignored

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: Code-Review+2 Missed one clang-tidy warning. Really need to figure out how to run it locally. -- To

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 6: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/180/ -- To view, visit

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored .. Patch Set 7: Turns out there's a gcc bug that prevents this from working sometimes (including for DiskIoMgr::Init()).

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-2615: warn if Status is ignored

2017-01-12 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4878 to look at the new patch set (#7). Change subject: IMPALA-2615: warn if Status is ignored

[Impala-ASF-CR] IMPALA-4651: Add LibEv to build

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4651: Add LibEv to build .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/182/ -- To view, visit

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. IMPALA-4722: Disable log caching in test_scratch_disk test_scratch_disk fails

[Impala-ASF-CR] IMPALA-4722: Disable log caching in test scratch disk

2017-01-12 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4722: Disable log caching in test_scratch_disk .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5669 To unsubscribe,

[Impala-ASF-CR] IMPALA-4216: Test became flaky: TestTpchMemLimitError.test low mem limit q20

2017-01-12 Thread Attila Jeges (Code Review)
Attila Jeges has abandoned this change. Change subject: IMPALA-4216: Test became flaky: TestTpchMemLimitError.test_low_mem_limit_q20 .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4572 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#8). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-12 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 8: (4 comments)