[Impala-ASF-CR] IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-20 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 10: (11 comments) Flushing some comments. Will focus on testing next

[Impala-ASF-CR] IMPALA-4101: qgen: Hive join predicates should only contains equality functions

2016-09-20 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has uploaded a new patch set (#3). Change subject: IMPALA-4101: qgen: Hive join predicates should only contains equality functions .. IMPALA-4101: qgen: Hive join predicates should only contains equality fun

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (14 comments) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push-pull-s

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-20 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 1: > As I mentioned in your previous review and/or the JIRA, this needs > t

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4428 To unsubsc

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity .. IMPALA-4138: Fix AcquireState() for batches that change capacity If MarkAtCapacit

[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files

2016-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4117: Factor simple scheduler test code into own files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4486/1/be/src/scheduling/simple-s

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. Patch Set 1: Hi Youwei, As I mentioned in your previous review and/or the JIRA, thi

[Impala-ASF-CR] IMPALA-3504: function for current timestamp in UTC, i.e. utc timestamp()

2016-09-20 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/4490 Change subject: IMPALA-3504: function for current timestamp in UTC, i.e. utc_timestamp() .. IMPALA-3504: function for current timestamp in

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 16: (9 comments) http://gerrit.cloudera.org:8080/#/c/3942/16/fe/src/main/java/com/cloudera/impa

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#17). Change subject: IMPALA-1654: General partition exprs in DDL operations. .. IMPALA-

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. The SQL state

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4479 To unsub

[Impala-ASF-CR] IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend

2016-09-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3902: Scheduler improvements for running multiple fragment instances on a single backend .. Patch Set 9: (22 comments) Focused mostly where I left off

[Impala-ASF-CR] IMPALA-4117: Factor simple scheduler test code into own files

2016-09-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4486 Change subject: IMPALA-4117: Factor simple scheduler test code into own files .. IMPALA-4117: Factor simple scheduler test code into own fi

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible. .. Patch Set 7: Verified-1 Build failed: http://sandbox.jenkins.cloude

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 5: Code-Review+2 Carry +2. -- To view, visit http://gerrit.cloudera.org:8080/4445 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4160: Remove Llama support. .. IMPALA-4160: Remove Llama support. Alas, poor Llama! I knew him, Impala: a system of infinite jest, of most excel

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 16: (9 comments) Great work. I just have a bunch of nits and some clarifications. Th

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/4390/4/be/src/exec/aggregation-node.cc Fi

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4318 To unsubscribe, vi

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. While I'm in here, remove

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4318 To unsubsc

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/4/impala-docs.html File impala-

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Jim Apple (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4318 to look at the new patch set (#5). Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. ...

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4318/4/impala-docs.html File im

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 16: Code-Review+1 (2 comments) Thanks, Amos! Minor comments left. I'll also let Henry and Marce

[Impala-ASF-CR] IMPALA-4138: Fix AcquireState() for batches that change capacity

2016-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4138: Fix AcquireState() for batches that change capacity .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4428 To unsubscribe

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 5: Rebased, passed tests: http://sandbox.jenkins.cloudera.com/job/impala-umbrella-b

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-20 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3937 to look at the new patch set (#5). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. IMPALA-37

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-20 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3936 to look at the new patch set (#4). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) ..

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-09-20 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 6: (24 comments) http://gerrit.cloudera.org:8080/#/c/4402/6/be/src/exec/push

[Impala-ASF-CR] IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has abandoned this change. Change subject: IMPALA-4014: PARALLEL HEADERS ONLY: Introduce query-wide execution state. .. Abandoned Review is continued in https://gerrit.cloudera.org/#/c/4418/ -- To view, visit

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4479 To unsu

[Impala-ASF-CR] IMPALA-4008: Don't bake ExprContext pointers into IR code

2016-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: Don't bake ExprContext pointers into IR code .. Patch Set 4: Code-Review+1 We definitely need to fix this agg codegen stuff just for general sanity,

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 5: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/4350/5/be/src/util/bloc

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4479/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible. .. Patch Set 7: Code-Review+2 Rebased, will start merge -- To view, visi

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-20 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 3: Code-Review+1 If Thomas is confident that the job failure was unrelated to this change and we

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: Yes, I've successfully run the packaging build now (the comment on the other rev

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 4: > Currently, the on demand packaging build won't run because there > are no sles64 nodes onli

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 3: > I have finally gotten the BVTs to successfully run. > > Packaging run: > http://golden.j

[Impala-ASF-CR] IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4047: DO NOT SUBMIT Highlight all occurrences of CDH/cdh .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4187/3/testdata/cluster/.gitignore

[Impala-ASF-CR](asf-site) IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala.

2016-09-20 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4068: Focus pages on Apache Impala, not Cloudera Impala. .. Patch Set 4: Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/4318 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4479/1//COMMIT_MSG Commit Me

[Impala-ASF-CR] IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS.

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4479 Change subject: IMPALA-4170: Fix identifier quoting in COMPUTE INCREMENTAL STATS. .. IMPALA-4170: Fix identifier quoting in COMPUTE INCREMEN

[Impala-ASF-CR] IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times

2016-09-20 Thread anujphadke (Code Review)
anujphadke has abandoned this change. Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times .. Abandoned This change is not needed. Discussed this with dan and tim last week. -- To view, visit

[Impala-ASF-CR] IMPALA-3980: qgen: re-enable Hive as a target database

2016-09-20 Thread Anonymous Coward (Code Review)
stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: qgen: re-enable Hive as a target database .. Patch Set 7: > This needs a committer's look. @Michael, do we know of a committer that has time

[Impala-ASF-CR] IMPALA-4075: Fix import kudu module exception on conftest.py

2016-09-20 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4075: Fix import kudu module exception on conftest.py .. Patch Set 1: Hello hewenting, any updates? Regarding this comment of mine: > Fix underlying cau

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h Fil

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 14: (1 comment) Sorry I got quite busy recently. I still have no luck running local tests. Hope

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#16). Change subject: IMPALA-1654: General partition exprs in DDL operations. .. IMPALA-

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible. .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

2016-09-20 Thread Alex Behm (Code Review)
Hello Lars Volker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4309 to look at the new patch set (#6). Change subject: IMPALA-4028: Improve message for improper Sentry config to make extra spaces visible.

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 15: Amos, I got all core tests to pass. I'm now running the exhaustive test suite, but I don't

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#15). Change subject: IMPALA-1654: General partition exprs in DDL operations. .. IMPALA-1654: General partition exprs in DDL operations. This commit handles partition related DDL in a more

[Impala-ASF-CR] IMPALA-889: Add support for ISO-SQL trim()

2016-09-20 Thread Youwei Wang (Code Review)
Youwei Wang has posted comments on this change. Change subject: IMPALA-889: Add support for ISO-SQL trim() .. Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/4474/1//COMMIT_MSG Commit Message: Line 10: Form #1:

[Impala-ASF-CR] IMPALA-889: Add support for ISO-SQL trim()

2016-09-20 Thread Youwei Wang (Code Review)
Youwei Wang has uploaded a new patch set (#2). Change subject: IMPALA-889: Add support for ISO-SQL trim() .. IMPALA-889: Add support for ISO-SQL trim() Add support for an ISO-SQL compliant trim() function. Form 1: Impala UDF cal

[Impala-ASF-CR] IMPALA-4160: Remove Llama support.

2016-09-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4160: Remove Llama support. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4445 To unsubscribe, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-20 Thread segelyang (Code Review)
segelyang has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 4: Thanks for your comments. I have re-uploaded the patch. -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-20 Thread segelyang (Code Review)
segelyang has uploaded a new patch set (#4). Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. IMPALA-3308: Get expr-test passing on PPC64LE When using gcc 5+ (which introduced a new library ABI that includes new