[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/946/ -- To view, vis

[Impala-ASF-CR] IMPALA-5714: Add OpenSSL to bootstrap toolchain.py

2017-07-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7532 Change subject: IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py .. IMPALA-5714: Add OpenSSL to bootstrap_toolchain.py To support KRPC on

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7527/1/b

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: (8 comments) Looks pretty good. No major concerns, we just need some tests and a b

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: Thanks, yeah I overthought it. I'll run this through run-all-tests and post the patch. > My instinc

[Impala-ASF-CR] IMPALA-5417: make I/O buffer queue fixed-size

2017-07-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5417: make I/O buffer queue fixed-size .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7408/4/be/src/runtime/disk-io-mgr-test.

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Greg Rahn (Code Review)
Greg Rahn has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: IIRC that's the calculation SimpleDateFormat uses for two digit years and likely where

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. Patch Set 4: Greg, you've got a lot of experience looking at date/time functions. What do you t

[Impala-ASF-CR] IMPALA-3894: Changed the behavior parsing 2-digit year values

2017-07-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7530 Change subject: IMPALA-3894: Changed the behavior parsing 2-digit year values .. IMPALA-3894: Changed the behavior parsing 2-digit year val

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/943/ -- To

[Impala-ASF-CR](asf-site) Fix incorrect email address identified by Nathanael Smith

2017-07-27 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Fix incorrect email address identified by Nathanael Smith .. Fix incorrect email address identified by Nathanael Smith While I'm here, change @impala.incuba

[Impala-ASF-CR](asf-site) Fix incorrect email address identified by Nathanael Smith

2017-07-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Fix incorrect email address identified by Nathanael Smith .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7529 To unsubscribe, visit ht

[Impala-ASF-CR](asf-site) Fix incorrect email address identified by Nathanael Smith

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Fix incorrect email address identified by Nathanael Smith .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7529 To unsubscribe, v

[Impala-ASF-CR](asf-site) Fix incorrect email address identified by Nathanael Smith

2017-07-27 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/7529 Change subject: Fix incorrect email address identified by Nathanael Smith .. Fix incorrect email address identified by Nathanael Smith While

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7527 Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. IMPALA-1891: Statestore won't send deletions

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: My instinct would be just to use the size of tasks_ to control the coordination. In SetupConnection

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 10: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/7022 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-27 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#38). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 38: Code-Review+2 Rebase -- To view, visit http://gerrit.cloudera.org:8080/5801 To unsubscrib

[Impala-ASF-CR] IMPALA-5630: Add Kudu client version as a common metric

2017-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7525 Change subject: IMPALA-5630: Add Kudu client version as a common metric .. IMPALA-5630: Add Kudu client version as a common metric Chan

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-07-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7524 Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level .. Patch Set 3: Code-Review+2 Looks good to me. We're having some issues with the stability of the p

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/942/ -- To view, visit

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/decimal-util.h File be/src/util/deci

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has posted comments on this change. Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/7513/1//COMMIT_MSG Commit Me

[Impala-ASF-CR] Build a ConcatenatedStreams wrapper for ScannerContext::Stream

2017-07-27 Thread Pooja Nilangekar (Code Review)
Pooja Nilangekar has uploaded a new patch set (#2). Change subject: Build a ConcatenatedStreams wrapper for ScannerContext::Stream .. Build a ConcatenatedStreams wrapper for ScannerContext::Stream The ConcatenatedStreams class k

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7479/1/fe/src/main/java

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. IMPALA-4795: Allow fetching function obj from catalog using signature Fixed a bug where

[Impala-ASF-CR] IMPALA-1882: Remove ORDER BY restriction from first value()/last value()

2017-07-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value() .. Patch Set 3: Code-Review+2 Will hold off on submitting gvo until the job looks bett

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/941/ -- To

[Impala-ASF-CR] IMPALA-1882: Remove ORDER BY restriction from first value()/last value()

2017-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#3). Change subject: IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value() .. IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value() In order to

[Impala-ASF-CR] IMPALA-1882: Remove ORDER BY restriction from first value()/last value()

2017-07-27 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-1882: Remove ORDER BY restriction from first_value()/last_value() .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7502/2/fe/src/main/j

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/943/ -- To view, vis

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. Patch Set 4: Code-Review+2 Rebased and forwarding the +2 -- To view, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-5689: Avoid inverting non-equi left joins .. IMPALA-5689: Avoid inverting non-equi left joins When checking if a join can be inverted, we forgot to also

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi left joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7476 to look at the new patch set (#4). Change subject: IMPALA-5689: Avoid inverting non-equi left joins .

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi right joins

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi right joins .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7476/3//COMMIT_MSG Commit Message: PS3,

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/2/tests/query_test/test_insert_parquet.py File t

[Impala-ASF-CR] IMPALA-5689: Avoid inverting non-equi right joins

2017-07-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5689: Avoid inverting non-equi right joins .. Patch Set 3: Code-Review+2 (1 comment) Looks like its good to get this in quickly. +2'ing since the

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7518 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File be/src/util/

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. IMPALA-5009: Clean up test_insert_parquet.py Replace make_tmp_dir with py.test's own tmpdir Change-Id: Ia84c78d7ff74

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 1: (2 comments) Thank you for the reviews. http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/942/ -- To view, visi

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 7: Restarting GVO, previous one seems to have hit IMPALA-5733. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level

2017-07-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-5636: changed the format metadata of repetition level .. IMPALA-5636: changed the format metadata of repetition level Testing: This change is only manually te

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level from bit packing to RLE

2017-07-27 Thread Tianyi Wang (Code Review)
Tianyi Wang has restored this change. Change subject: IMPALA-5636: changed the format metadata of repetition level from bit_packing to RLE .. Restored reopen to do some modifications -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/string-parser.h File be/src/util/string-

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/util/decimal-util.h File be/src/util/decimal-u

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-27 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7521/1/fe/src/main/java/org/apache/impala/

[Impala-ASF-CR] IMPALA-5722: Fix string to decimal cast

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5722: Fix string to decimal cast .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7517/1/be/src/runtime/decimal-test.cc File be/src/runti

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/941/ -- T

[Impala-ASF-CR] IMPALA-5394: Handle blocked HS2 connections

2017-07-27 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Handle blocked HS2 connections .. Patch Set 3: I'd like some advice/feedback on the approach for enforcing fe_service_threads. In my local diff, I'v

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7521 Change subject: IMPALA-5336: Fix partition pruning when column is cast .. IMPALA-5336: Fix partition pruning when column is cast Partit

[Impala-ASF-CR] IMPALA-5636: changed the format metadata of repetition level from bit packing to RLE

2017-07-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5636: changed the format metadata of repetition level from bit_packing to RLE .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7514/2//C

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py File

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py File t

[native-toolchain-CR] IMPALA-5714: Add linker's version script for OpenSSL library

2017-07-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5714: Add linker's version script for OpenSSL library .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7484/6/source/openss

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7518/1/tests/query_test/test_insert_parquet.py File

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 26: hm, the failures in the last two runs look different from IMPALA-5729 -- To view, vi

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 26: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/940/ -- To v