[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-07-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/5717/12/CMakeLists.txt File CMakeLists.txt:

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4669: [SECURITY] Add security library to build .. Patch Set 12: This patch builds on RHEL5.5 and 6.0, debian 7 and 8, ubuntu 12.04 and 14.04, and

[Impala-ASF-CR] IMPALA-4669: [SECURITY] Add security library to build

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#12). Change subject: IMPALA-4669: [SECURITY] Add security library to build .. IMPALA-4669: [SECURITY] Add security library to build * Minor compilation fix * Set toolchain version

[Impala-ASF-CR] IMPALA-5745: Bump Breakpad version

2017-07-31 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7547 Change subject: IMPALA-5745: Bump Breakpad version .. IMPALA-5745: Bump Breakpad version This change bumps the breakpad version to pull

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 4: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. IMPALA-4795: Allow fetching function obj from catalog using signature

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/965/ --

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. Patch Set 2: Any takers for a review? This patch reduces the be-test end-to-end time from

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode Googletest supports sharded

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7518 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 3: Re-reading the commit message, the renaming seems inevitable with the

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 1: FWIW, I was actually expecting that the renaming would happen later. This

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. IMPALA-1891: Statestore won't send deletions in initial non-delta

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 3: > (1 comment) > > Quick question before I get stuck in - did you

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 1: (1 comment) Quick question before I get stuck in - did you evaluate

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#3). Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface This patch

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface This patch

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-07-31 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7542 Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add dummy 'use_krpc' flag and

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-07-31 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 4: (5 comments)

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/965/ -- To view,

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: Code-Review+2 (1 comment)

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-07-31 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#4). Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec If

[Impala-ASF-CR] IMPALA-5616: Add --enable minidumps startup flag

2017-07-31 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/7541 Change subject: IMPALA-5616: Add --enable_minidumps startup flag .. IMPALA-5616: Add --enable_minidumps startup flag Change-Id:

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7539/3/be/src/service/fe-support.cc File

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7539/3/be/src/service/fe-support.cc File

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7479 To

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 4: Build started:

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 2: (1 comment) Looks good to me, just one minor thing.

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. IMPALA-5336: Fix partition pruning when column is cast Partition pruning has two

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7521 To

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 3: It does seem to work with the field made required. -- To view, visit

[Impala-ASF-CR] IMPALA-3931: arbitrary fixed-size agg intermediate types

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-3931: arbitrary fixed-size agg intermediate types .. IMPALA-3931: arbitrary fixed-size agg intermediate types Make many builtin aggregate functions use

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#3). Change subject: IMPALA-1470: Fix error message with catalog down .. IMPALA-1470: Fix error message with catalog down When the catalog server cannot be reached, currently impala

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7539/2/be/src/service/fe-support.cc File

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1470: Fix error message with catalog down .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7539/2/be/src/service/fe-support.cc File

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7530 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 9: I asked MJ to double-check this since date/time stuff is so subtle. -- To view, visit

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 9: I'll do another pass tonight or tomorrow morning. -- To view, visit

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#3). Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. IMPALA-4795: Allow fetching function obj from catalog using signature Fixed a bug where

[Impala-ASF-CR] IMPALA-4795: Allow fetching function obj from catalog using signature

2017-07-31 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-4795: Allow fetching function obj from catalog using signature .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#2). Change subject: IMPALA-1470: Fix error message with catalog down .. IMPALA-1470: Fix error message with catalog down When the catalog server cannot be reached, currently impala

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#9). Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. IMPALA-3894: Change the behavior parsing date "YY" This patch change the behavor when running

[Impala-ASF-CR] IMPALA-1470: Fix error message with catalog down

2017-07-31 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new change for review. http://gerrit.cloudera.org:8080/7539 Change subject: IMPALA-1470: Fix error message with catalog down .. IMPALA-1470: Fix error message with catalog down When the catalog

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/963/ -- To view, visit

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 3: Thank you for the quick reviews! -- To view, visit http://gerrit.cloudera.org:8080/7518 To

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. Patch Set 2: Build started:

[Impala-ASF-CR] IMPALA-1891: Statestore won't send deletions in initial non-delta topic

2017-07-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1891: Statestore won't send deletions in initial non-delta topic .. Patch Set 2: Code-Review+2 carrying henry's +2 -- To view, visit

[Impala-ASF-CR] IMPALA-3894: Change the behavior parsing date "YY"

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3894: Change the behavior parsing date "YY" .. Patch Set 8: (2 comments) Just a couple of readability improvements but looks good to go otherwise.

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-31 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/961/ -- To

[Impala-ASF-CR] IMPALA-5336: Fix partition pruning when column is cast

2017-07-31 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5336: Fix partition pruning when column is cast .. Patch Set 3: Code-Review+2 needed to also update compute-table-stats.sh -- To view, visit

[Impala-ASF-CR] IMPALA-5009: Clean up test insert parquet.py

2017-07-31 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5009: Clean up test_insert_parquet.py .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7518 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5636: Change the metadata in parquet .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7514 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5636: Change the metadata in parquet

2017-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-5636: Change the metadata in parquet .. IMPALA-5636: Change the metadata in parquet When writing in parquet format, Impala does not use