[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-4895: Memory limit exceeded in test outer joins

2017-02-08 Thread Thomas Tauber-Marshall (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5941 to look at the new patch set (#2). Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins ..

[Impala-ASF-CR] IMPALA-4895: Memory limit exceeded in test outer joins

2017-02-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-4895: Memory limit exceeded in test outer joins

2017-02-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5941 Change subject: IMPALA-4895: Memory limit exceeded in test_outer_joins .. IMPALA-4895: Memory limit exceeded in

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Hello Dan Hecht, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5389 to look at the new patch set (#10). Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 10: (1 comment)

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5914 Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. IMPALA-4731: Crash when sorting on

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-06 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5917 Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. IMPALA-4849: IllegalStateException from

[Impala-ASF-CR] IMPALA-4849: IllegalStateException from rewritten CASE expr

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4849: IllegalStateException from rewritten CASE expr .. IMPALA-4849: IllegalStateException from rewritten CASE expr In SelectList.reset(), we call

[Impala-ASF-CR] IMPALA-4731: Crash when sorting on non-deterministic expr

2017-02-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4731: Crash when sorting on non-deterministic expr .. IMPALA-4731: Crash when sorting on non-deterministic expr When sorting on a

[Impala-ASF-CR] IMPALA-4801: fix heap use after free for MemTracker

2017-01-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4801: fix heap use after free for MemTracker .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5772 To

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-23 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 9: (1 comment) > I believe the current patchset still has the resource

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-23 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, Impala Public Jenkins, Bharath Vissapragada, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#12). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-23 Thread Thomas Tauber-Marshall (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5389 to look at the new patch set (#9). Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 9: (1 comment)

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 9: This passed a core ASAN run:

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 2: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4829: Change default Kudu read behavior for "RYW"

2017-01-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4829: Change default Kudu read behavior for "RYW" .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5802 To

[Impala-ASF-CR] IMPALA-4828: Alter Kudu schema outside Impala may crash on read

2017-02-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4828: Alter Kudu schema outside Impala may crash on read .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5840

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-02-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/6037 Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. PREVIEW: IMPALA-3742: partitions INSERTs into Kudu

[Impala-ASF-CR] IMPALA-4748: crash in TmpFileMgr when hitting process mem limit

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5683

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5585 to look at the new patch set (#11). Change subject: IMPALA-1861: Simplify conditionals with constant conditions

[Impala-ASF-CR] IMPALA-1861: Simplify conditionals with constant conditions

2017-01-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1861: Simplify conditionals with constant conditions .. Patch Set 11: (2 comments)

[Impala-ASF-CR] PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables

2017-02-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables .. PREVIEW: IMPALA-3742: partitions INSERTs into Kudu tables Bulk inserts into Kudu are

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-09-15 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 4: Jim - Just waiting on someone to +2 it. You had added Alex to the review last

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3936 to look at the new patch set (#5). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3937 to look at the new patch set (#6). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 5: Code-Review+1 Rebased, carrying forward +1s. -- To view, visit

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 6: Code-Review+1 Rebased, carrying forward +1s. -- To view, visit

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 2)

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 2) .. Patch Set 5: (2 comments)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 6: (3 comments)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-05 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1) .. Patch Set 3: I have finally gotten the BVTs to successfully run. Packaging run:

[Impala-ASF-CR] IMPALA-3786: Replace "cloudera" with "apache" (part 1)

2016-09-20 Thread Thomas Tauber-Marshall (Code Review)
Hello Jim Apple, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3936 to look at the new patch set (#4). Change subject: IMPALA-3786: Replace "cloudera" with "apache" (part 1)

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (12 comments) The main problem with subclassing

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 5: The patch passed an exhaustive run on Jenkins:

[Impala-ASF-CR] Revert org.apache.impala.hive.serde.ParquetOutputFormat

2016-10-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/4611 Change subject: Revert org.apache.impala.hive.serde.ParquetOutputFormat .. Revert

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-09-30 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 5: The latest version moves back to using a single class, InsertStmt, rather than having

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-29 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#15). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#16). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 15: (1 comment)

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/4861 Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. IMPALA-4372: 'Describe formatted' returns

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-25 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#13). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala ..

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#6). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage This patch adds a

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4845 to look at the new patch set (#2). Change subject: IMPALA-4260: Alter table add column drops all the column stats

[Impala-ASF-CR] IMPALA-4260: Alter table add column drops all the column stats

2016-10-26 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4260: Alter table add column drops all the column stats .. Patch Set 2: (1 comment) The 'describe formatted' issue is unrelated. I filed:

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-10-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. Patch Set 2: test_describe_formatted did not catch this bug because it was silently

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-10-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. IMPALA-4372: 'Describe formatted' returns types in upper case A recent change caused

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: Improve Kudu UPSERT test coverage .. Improve Kudu UPSERT test coverage In preparation for the public release of Kudu integration in 2.8, we need to make

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: Improve Kudu UPSERT test coverage .. Improve Kudu UPSERT test coverage In preparation for the public release of Kudu integration in 2.8, we need to make

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPDATE test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5036 Change subject: IMPALA-4466: Improve Kudu UPDATE test coverage .. IMPALA-4466: Improve Kudu UPDATE test coverage Change-Id:

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5040/1/tests/conftest.py File

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#7). Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ..

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#8). Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ..

[Impala-ASF-CR] IMPALA-4454: test kudu.TestShowCreateTable flaky

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5040 Change subject: IMPALA-4454: test_kudu.TestShowCreateTable flaky .. IMPALA-4454: test_kudu.TestShowCreateTable flaky The cause

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Improve Kudu UPSERT test coverage .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/4953/4//COMMIT_MSG Commit Message: PS4, Line 9:

[Impala-ASF-CR] Improve Kudu UPSERT test coverage

2016-11-10 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#5). Change subject: Improve Kudu UPSERT test coverage .. Improve Kudu UPSERT test

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#18). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725 Support Kudu UPSERT in Impala This patch introduces a new query statement, UPSERT, for Kudu

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 9: The reason the GVO failed was the change in this patch that always

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage Previously, the

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 8: (16 comments) http://gerrit.cloudera.org:8080/#/c/4047/7//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#8). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4756/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage This patch adds a

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#10). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. IMPALA-3725

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 10: (8 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage This patch adds a

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 3: (8 comments) As discussed, eliminated the separate list on the

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 12: Code-Review+1 (1 comment) Carrying forward Alex's +2

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 8: (6 comments)

[Impala-ASF-CR] IMPALA-4466: Improve Kudu INSERT coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-4466: Improve Kudu INSERT coverage .. Abandoned Consolidated into: https://gerrit.cloudera.org/#/c/4953/ -- To view, visit

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPDATE test coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-4466: Improve Kudu UPDATE test coverage .. Abandoned Consolidated into: https://gerrit.cloudera.org/#/c/4953/ -- To view, visit

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#11). Change subject: IMPALA-4466: Improve Kudu CRUD test coverage

[Impala-ASF-CR] IMPALA-4466: Improve Kudu DELETE test coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has abandoned this change. Change subject: IMPALA-4466: Improve Kudu DELETE test coverage .. Abandoned Consolidated into: https://gerrit.cloudera.org/#/c/4953/ -- To view, visit

[Impala-ASF-CR] IMPALA-4466: Improve Kudu DELETE test coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5069 Change subject: IMPALA-4466: Improve Kudu DELETE test coverage .. IMPALA-4466: Improve Kudu DELETE test coverage Test results

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPDATE test coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4466: Improve Kudu UPDATE test coverage .. IMPALA-4466: Improve Kudu UPDATE test coverage Test results in kudu_update.test were verified by hand.

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables

2016-11-22 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables .. Patch Set 1: It was pointed out by Alex that this is a more general problem than just

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#12). Change subject: IMPALA-4466: Improve Kudu CRUD test coverage

[Impala-ASF-CR] IMPALA-4466: Improve Kudu CRUD test coverage

2016-11-16 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu CRUD test coverage .. Patch Set 12: (1 comment) Yes, the only changes since the last time it was +2ed are the three new test

[Impala-ASF-CR] IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables

2016-11-18 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5144 Change subject: IMPALA-4357: Fix DROP TABLE for externally deleted Kudu tables .. IMPALA-4357: Fix DROP TABLE for externally

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-11 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4953 to look at the new patch set (#9). Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage ..

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPSERT test coverage

2016-11-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4466: Improve Kudu UPSERT test coverage .. Patch Set 9: GVO manually aborted - forget trunk is supposed to be locked. -- To view, visit

[Impala-ASF-CR] IMPALA-4372: 'Describe formatted' returns types in upper case

2016-11-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4372: 'Describe formatted' returns types in upper case .. IMPALA-4372: 'Describe formatted' returns types in upper case A recent change caused

[Impala-ASF-CR] IMPALA-4466: Improve Kudu INSERT coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new change for review. http://gerrit.cloudera.org:8080/5080 Change subject: IMPALA-4466: Improve Kudu INSERT coverage .. IMPALA-4466: Improve Kudu INSERT coverage Test results in

[Impala-ASF-CR] IMPALA-4466: Improve Kudu UPDATE test coverage

2016-11-14 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4466: Improve Kudu UPDATE test coverage .. IMPALA-4466: Improve Kudu UPDATE test coverage Test results in kudu_update.test were verified by hand.

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-03 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4047 to look at the new patch set (#17). Change subject: IMPALA-3725 Support Kudu UPSERT in Impala

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Hello Matthew Jacobs, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4756 to look at the new patch set (#8). Change subject: IMPALA-1169: Admission control info on the queries debug webpage

[Impala-ASF-CR] IMPALA-4048: Misc. improvements to /sessions

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4048: Misc. improvements to /sessions .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-11-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 17: The GVO failed due to some Jenkins issue. Looks like the machine ran out of disk space:

  1   2   3   4   5   6   >