Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8500 )
Change subject: Pin gen_build_version's git handling to typical git dir.
..
Patch Set 2: Code-Review+2
--
To view, visit
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8500 )
Change subject: Pin gen_build_version's git handling to typical git dir.
..
Patch Set 1:
Sorry, didn't realize this was the upstream
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8500 )
Change subject: Pin gen_build_version's git handling to typical git dir.
..
Patch Set 1:
Sounds like
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8456 )
Change subject: IMPALA-6148: Specifying thirdparty deps as URLs
..
Patch Set 2:
(1 comment)
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8311 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC
..
Patch Set 4:
(3 comments)
Let's figure out how to
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8311 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC
..
Patch Set 2:
Looks like we want NANOSECONDS after all,
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8311 )
Change subject: IMPALA-5607: Add additional units to EXTRACT, DATE_PART, TRUNC
..
Patch Set 2:
(6 comments)
Overall this looks good -
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8350 )
Change subject: IMPALA-6068: Fix dataload for complextypes_fileformat
..
Patch Set 5: Code-Review+2
--
To view, visit
Zach Amsden has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/8274 )
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
..
IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8274 )
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
..
Patch Set 4:
Looks like I finally got a good GVO on this.
Tim,
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8320 )
Change subject: IMPALA-6070: Parallel data load.
..
Patch Set 1:
(1 comment)
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8274 )
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
..
Patch Set 4:
Anyone know what's going on with this change not
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8274 )
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
..
Patch Set 2:
Looks like a transient failure, retrying
--
To
Hello Philip Zeyliger, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8274
to look at the new patch set (#2).
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8274 )
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
..
Patch Set 1:
(2 comments)
Zach Amsden has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8274
Change subject: IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
..
IMPALA-6055: Fix hdfs encryption test far Hadoop 2.8+
Hadoop
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/7438 )
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
..
Patch Set 6:
The algorithm mentioned here, on page 17 seems quite
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/7438 )
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
..
Patch Set 6:
I totally agree about doing anything fancy as a
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
..
Patch Set 1:
>From private build and test 6418,
14:21:05 Executing:
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
..
Patch Set 1:
I tested this with a local data load, but we need to
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8132 )
Change subject: IMPALA-5975: Work around broken beeline clients
..
Patch Set 1:
I will do that now.
--
To view, visit
Zach Amsden has uploaded this change for review. (
http://gerrit.cloudera.org:8080/8132
Change subject: IMPALA-5975: Work around broken beeline clients
..
IMPALA-5975: Work around broken beeline clients
To make statements
Zach Amsden has posted comments on this change. (
http://gerrit.cloudera.org:8080/8004 )
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 7:
Finally got back to this, looks like this was the only
Hello Lars Volker, Michael Brown, Tim Armstrong, Alex Behm, Dan Hecht, Impala
Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8004
to look at the new patch set (#6).
Change subject: IMPALA-4513: Promote integer types for ABS()
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4940: Decimal V2 multiplication
..
Patch Set 5:
Have we ever tried using SSE/AVX for multiplication? It should be possible to
avoid using
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 5: Code-Review+1
(1 comment)
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 4:
(8 comments)
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 4:
(17 comments)
Looks good but I have a few comments - there is a lot more that
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 5:
Sorry, been under C6 crunch. Will get back to this today.
--
To view, visit
Hello Lars Volker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8004
to look at the new patch set (#4).
Change subject: IMPALA-4513: Promote integer types for ABS()
..
IMPALA-4513:
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 3:
(2 comments)
Decimal is immune to this because the range is clamped. Float and double are
immune
Zach Amsden has uploaded a new patch set (#3).
Change subject: IMPALA-4513: Promote integer types for ABS()
..
IMPALA-4513: Promote integer types for ABS()
The internal representation of the most negative number
in two's
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8004/2/be/src/exprs/expr-test.cc
File
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 2:
As per Greg's request, add overflow check for BIGINT. All other types just get
promoted.
--
To
Zach Amsden has uploaded a new patch set (#2).
Change subject: IMPALA-4513: Promote integer types for ABS()
..
IMPALA-4513: Promote integer types for ABS()
The internal representation of the most negative number
in 2's
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4513: Promote integer types for ABS()
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8004/1/be/src/exprs/expr-test.cc
File
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8004
Change subject: IMPALA-4513: Promote integer types for ABS()
..
IMPALA-4513: Promote integer types for ABS()
The internal representation
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 2:
Need to get back to this now that I have smokes fixed. I imagine I'll want to
do things a
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5854: Update external hadoop versions
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh
File
Hello Michael Brown,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7892
to look at the new patch set (#2).
Change subject: IMPALA-5854: Update external hadoop versions
..
IMPALA-5854:
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5854: Update external hadoop versions
..
Patch Set 1:
Components are already built, S3 buckets updated, and I ran a private
exhaustive build & load job,
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7892
Change subject: IMPALA-5854: Update external hadoop versions
..
IMPALA-5854: Update external hadoop versions
These versions need to be
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7581/2/bin/impala-config.sh
File
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 2:
(4 comments)
A couple of minor nits. Also, let me make sure I didn't accidentally introduce
Zach Amsden has abandoned this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Abandoned
Gerrit created another change for some reason.
--
To view, visit http://gerrit.cloudera.org:8080/7648
To
Zach Amsden has uploaded a new patch set (#2).
Change subject: IMPALA-5764: Allow overriding packaged components
..
IMPALA-5764: Allow overriding packaged components
For allowing multiple different distributions to build
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7648
Change subject: IMPALA-5764: Allow overriding packaged components
..
IMPALA-5764: Allow overriding packaged components
For allowing
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 1:
needs rebase against merged changes, coming presently
--
To view, visit
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7350
to look at the new patch set (#5).
Change subject: IMPALA-5768: Better developer documentation
..
IMPALA-5768:
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5768: Better developer documentation
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7350/2/bin/impala-config.sh
File
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7350
to look at the new patch set (#4).
Change subject: IMPALA-5768: Better developer documentation
..
IMPALA-5768:
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7350
to look at the new patch set (#3).
Change subject: IMPALA-5768
..
IMPALA-5768
Guide to important environment
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5764: Allow overriding packaged components
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG
Commit Message:
Line 9:
Zach Amsden has posted comments on this change.
Change subject: Guide to important environment variables for build, test, and
mini-cluster operations.
..
Patch Set 2:
(5 comments)
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7581
Change subject: IMPALA-5764: Allow overriding packaged components
..
IMPALA-5764: Allow overriding packaged components
For allowing
Zach Amsden has posted comments on this change.
Change subject: Guide to important environment variables for build, test, and
mini-cluster operations.
..
Patch Set 2:
I cut this back in scope somewhat and made it use
Zach Amsden has uploaded a new patch set (#2).
Change subject: Guide to important environment variables for build, test, and
mini-cluster operations.
..
Guide to important environment variables for
build, test, and mini-cluster
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7438/1/be/src/exprs/expr-test.cc
File
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication
..
Patch Set 1:
(11 comments)
http://gerrit.cloudera.org:8080/#/c/7438/1/be/src/exprs/expr-test.cc
File
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5164: Better benchmark heuristic
..
Patch Set 1: -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/7389
To unsubscribe, visit
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7389
Change subject: IMPALA-5164: Better benchmark heuristic
..
IMPALA-5164: Better benchmark heuristic
If any benchmark took longer than 50ms
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5164: Better benchmark heuristic
..
Patch Set 1: Code-Review+1
Turns out this approach works even better and avoids any special changes to
benchmarks.
--
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5164: Bloom filter benchmark fails to complete
..
Patch Set 1:
@jbapple, let's go ahead with this diff and if there are more failures, I'll
attach more
Hello Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7381
to look at the new patch set (#2).
Change subject: IMPALA-5164: Bloom filter benchmark fails to complete
..
Zach Amsden has posted comments on this change.
Change subject: IMPALA-: Bloom filter benchmark fails to complete
..
Patch Set 1:
@jbapple, Is there a JIRA open for this already?
--
To view, visit
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5623: Fix lag() on STRING cols to release UDF mem
..
Patch Set 1: Code-Review+1
(1 comment)
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5498: Support for partial sorts
..
Patch Set 3:
(6 comments)
Looks promising!
http://gerrit.cloudera.org:8080/#/c/7267/3/be/src/exec/partial-sort-node.cc
Zach Amsden has posted comments on this change.
Change subject: Complete guide to important environment variables for build,
test, and mini-cluster operations.
..
Patch Set 1:
(2 comments)
> > I personally abhor Google docs
Zach Amsden has posted comments on this change.
Change subject: Complete guide to important environment variables for build,
test, and mini-cluster operations.
..
Patch Set 1:
I personally abhor Google docs as they just seem
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7350
Change subject: Complete guide to important environment variables for build,
test, and mini-cluster operations.
..
Complete guide to
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 1:
(1 comment)
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5128: BE Test Infrastructure
..
Patch Set 2: Code-Review-1
I think we have more important things to do and there are probably even more
egregious tests.
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5547: Rework FK/PK join detection.
..
Patch Set 1:
(3 comments)
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7240
to look at the new patch set (#3).
Change subject: IMPALA-5548 Fix some minor nits with HDFS parquet column readers
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7240
to look at the new patch set (#2).
Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column
readers
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column
readers
..
Patch Set 1:
(2 comments)
Zach Amsden has abandoned this change.
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
Abandoned
Not enough win for the complexity.
--
To view, visit http://gerrit.cloudera.org:8080/6726
To
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column
readers
..
Patch Set 1:
Some pretty simple fixes that came from work on IMPALA-4864. Running build
Zach Amsden has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7240
Change subject: IMPALA-5548 Fix some minor issues with HDFS / parquet column
readers
..
IMPALA-5548 Fix some minor issues with HDFS /
Zach Amsden has uploaded a new patch set (#19).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has uploaded a new patch set (#18).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5036: Parquet count star optimization
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6812/3/be/src/exec/hdfs-parquet-scanner.cc
File
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5467: disable flaky BenchmarkTest to unblock builds
..
Patch Set 1: Code-Review+1
Well since the fix, we know this isn't being caused by contention, any
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
Patch Set 16:
(1 comment)
Hello Impala Public Jenkins, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6935
to look at the new patch set (#8).
Change subject: IMPALA-5164: Fix flaky benchmarks
..
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
Patch Set 16:
(5 comments)
Zach Amsden has uploaded a new patch set (#16).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
Patch Set 14:
I'm getting kind of disheartened by this approach. The biggest obstacle is
that
Zach Amsden has uploaded a new patch set (#14).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4988: Add query option read_parquet_statistics
..
Patch Set 1:
(1 comment)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6935
to look at the new patch set (#6).
Change subject: IMPALA-5164: Fix flaky benchmarks
..
IMPALA-5164: Fix flaky
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5164: Fix flaky benchmarks
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6935/5/be/src/benchmarks/free-lists-benchmark.cc
File
Zach Amsden has uploaded a new patch set (#13).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has uploaded a new patch set (#12).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
Patch Set 9:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/6726/9/be/src/exec/exec-node.cc
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6935
to look at the new patch set (#5).
Change subject: IMPALA-5164: Fix flaky benchmarks
..
IMPALA-5164: Fix flaky
Zach Amsden has posted comments on this change.
Change subject: IMPALA-5164: Fix flaky benchmarks
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6935/4/be/src/util/benchmark.h
File be/src/util/benchmark.h:
Zach Amsden has uploaded a new patch set (#11).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
Zach Amsden has posted comments on this change.
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
Patch Set 10:
(3 comments)
Zach Amsden has uploaded a new patch set (#10).
Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries
..
IMPALA-4864 Speed up single slot predicates with dictionaries
When dictionaries are present we can
1 - 100 of 361 matches
Mail list logo
