[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4099/1//COMMIT_MSG Commit Message: Line 8:

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

2016-08-23 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Patch Set 3: Code-Review+1 -- To view, visit

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

2016-08-23 Thread Mladen Kovacevic (Code Review)
Mladen Kovacevic has posted comments on this change. Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Patch Set 3: > There's a bunch of similar git clone links that use

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3045/ -- To

[kudu-CR] KuduSession: do not advertise thread-safety

2016-08-23 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4105 to look at the new patch set (#2). Change subject: KuduSession: do not advertise thread-safety .. KuduSession: do

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1048 master should show versions of tservers, version summary .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3040/ -- To view, visit

[kudu-CR] tests: add --stress cpu threads argument

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tests: add --stress_cpu_threads argument .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3039/ -- To view, visit

[kudu-CR] tests: add --stress cpu threads argument

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4106 to review the following change. Change subject: tests: add --stress_cpu_threads argument .. tests: add

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1048 master should show versions of tservers, version summary .. Patch Set 1: (3 comments)

[kudu-CR] KUDU-1048 master should show versions of tservers, version summary

2016-08-23 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4104 Change subject: KUDU-1048 master should show versions of tservers, version summary .. KUDU-1048 master should show versions of

[kudu-CR] Create base class for MiniCluster and ExternalMiniCluster

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Create base class for MiniCluster and ExternalMiniCluster .. Patch Set 5: (4 comments)

[kudu-CR] Various comment / doc improvements

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Various comment / doc improvements .. Various comment / doc improvements * Update link to code review for supporting reinsert * Fix comment in

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4100 to look at the new patch set (#4). Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags

[kudu-CR] KUDU-1157. Don't use array reference equality for EMPTY ARRAY

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1157. Don't use array reference equality for EMPTY_ARRAY .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3034/ -- To view, visit

[kudu-CR] pbc tool: fix broken build

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: pbc tool: fix broken build .. pbc tool: fix broken build Some out-of-order patch submission caused a build breakage Change-Id:

[kudu-CR] pbc tool: fix broken build

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: pbc tool: fix broken build .. Patch Set 1: Code-Review+2 Verified+1 Locally verified this fixes the build error, will push to avoid build breakage -- To view,

[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Convert pbc-dump over to the new tool infrastructure .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4037 To unsubscribe, visit

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3031/ -- To view, visit

[kudu-CR] KUDU-1231. Add "unlock" flag for experimental and unsafe flags

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4100 to look at the new patch set (#2). Change subject: KUDU-1231. Add "unlock" flag for experimental and unsafe flags

[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Convert pbc-dump over to the new tool infrastructure .. Patch Set 2: > Please update install_kudu.sh (on the internal CDH/cdh-package.git:kudu repo > and branch)

[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Convert pbc-dump over to the new tool infrastructure .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3029/ -- To view, visit

[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4037 to look at the new patch set (#2). Change subject: Convert pbc-dump over to the new tool infrastructure .. Convert

[kudu-CR] tool: improve help output

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4038 to look at the new patch set (#2). Change subject: tool: improve help output .. tool:

[kudu-CR] tool: improve help output

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: improve help output .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4038/1//COMMIT_MSG Commit Message: Line 9: - adds blank line in

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3026/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf .. Patch Set 1:

[kudu-CR] Convert pbc-dump over to new tool infrastructure

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Convert pbc-dump over to new tool infrastructure .. Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/4037/1//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf .. Patch Set 1:

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf

2016-08-23 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4099 to review the following change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC Sample output is at:

[kudu-CR] subprocess: allow Call() to read both stdout and stderr

2016-08-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr .. Patch Set 1: Code-Review+1 Test passes on OS X -- To view, visit http://gerrit.cloudera.org:8080/4057

[kudu-CR] Remove CHECK that undos always exist

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove CHECK that undos always exist .. Patch Set 1: Also, have you tested that this actually allows for downgrade? ie there's no other code path which will now

[kudu-CR] Remove CHECK that undos always exist

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Remove CHECK that undos always exist .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4061/1/src/kudu/tablet/compaction.cc File

[kudu-CR] Forward compat for changing TSRegistrationPB

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Forward compat for changing TSRegistrationPB .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4062/3/src/kudu/master/ts_descriptor.cc File

[kudu-CR] tool: basic integration test

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: basic integration test .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4058/3/build-support/dist_test.py File build-support/dist_test.py:

[kudu-CR] Forward compat for changing TSRegistrationPB

2016-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Forward compat for changing TSRegistrationPB .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4062/3/src/kudu/master/ts_descriptor.cc File

[kudu-CR] subprocess: allow Call() to read both stdout and stderr

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4057/1/src/kudu/util/subprocess.cc File

[kudu-CR] subprocess: allow Call() to read both stdout and stderr

2016-08-23 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: subprocess: allow Call() to read both stdout and stderr .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4057/1/src/kudu/util/subprocess.cc File

[kudu-CR](branch-0.10.x) Update version to 0.10.1-SNAPSHOT on branch

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update version to 0.10.1-SNAPSHOT on branch .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3024/ -- To view, visit

[kudu-CR](branch-0.10.x) Update version to 0.10.1-SNAPSHOT on branch

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4097 to review the following change. Change subject: Update version to 0.10.1-SNAPSHOT on branch .. Update version to

[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x

2016-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Update docs from tip of branch-0.10.x .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4091/2/docs/release_notes.html File

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 21: Build Started http://104.196.14.100/job/kudu-gerrit/3023/ -- To view, visit

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-23 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#21). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode ..

[kudu-CR](gh-pages) Add release announcement blog for 0.10

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add release announcement blog for 0.10 .. Patch Set 1: Code-Review+2 Verified+1 Going to push this without review since I already sent the same text out on slack

[kudu-CR](gh-pages) Add release announcement blog for 0.10

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add release announcement blog for 0.10 .. Add release announcement blog for 0.10 Change-Id: I08e9aa3e43a57e27953b867d733b8162b25ff76f Reviewed-on:

[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Update docs from tip of branch-0.10.x .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4091 To unsubscribe, visit

[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Update docs from tip of branch-0.10.x .. Update docs from tip of branch-0.10.x Hash ffd8fa4758fd8598a8d06a79249a6ab57d72aa81 Change-Id:

[kudu-CR](gh-pages) Update docs from tip of branch-0.10.x

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4091 to review the following change. Change subject: Update docs from tip of branch-0.10.x .. Update docs from

[kudu-CR](branch-0.10.x) Fix release notes formatting for multi-paragraph list items

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4089 Change subject: Fix release notes formatting for multi-paragraph list items .. Fix release notes formatting for multi-paragraph list items

[kudu-CR](branch-0.10.x) Fix release notes formatting for multi-paragraph list items

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix release notes formatting for multi-paragraph list items .. Fix release notes formatting for multi-paragraph list items If a list item spans multiple