[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 4: > (1 comment) > > Looks good to me apart from the one leftover nit. Get a +2 from > Alexey

[kudu-CR] [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client

2016-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client .. [java] - Synchronize the removal of the TabletClient

[kudu-CR] [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client

2016-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

2016-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Allow multi-master AlterTable tests in TestKuduTable.java .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4406 To

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

2016-09-13 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4408 to look at the new patch set (#2). Change subject: KUDU-1611 - [python] Enable setting scanner selection policy ..

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4394 to look at the new patch set (#5). Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090:

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3417/ -- To view, visit

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Allow multi-master AlterTable tests in TestKuduTable.java .. Patch Set 3: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3416/ -- To view, visit

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#7). Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with images can be found here:

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [WIP] KUDU-861 Support changing default, storage attributes .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3415/ -- To view, visit

[kudu-CR] [WIP] KUDU-861 Support changing default, storage attributes

2016-09-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#5). Change subject: [WIP] KUDU-861 Support changing default, storage attributes ..

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3414/ -- To view, visit

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4394 to look at the new patch set (#4). Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090:

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 5: (1 comment) Looks good to me apart from the one leftover nit. Get a +2 from Alexey (he can give

[kudu-CR] consensus: properly truncate all state when aborting operations

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: consensus: properly truncate all state when aborting operations .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3413/ -- To view, visit

[kudu-CR] Set desiredBlockSize in pbToColumnSchema

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Set desiredBlockSize in pbToColumnSchema .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3412/ -- To view, visit

[kudu-CR] [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client

2016-09-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java] - Synchronize the removal of the TabletClient from client2tablets and ip2client .. Patch Set 2: This is happening more and more on jenkins. Could

[kudu-CR] WIP: fix consensus divergence issue

2016-09-13 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4409 to review the following change. Change subject: WIP: fix consensus divergence issue .. WIP: fix consensus

[kudu-CR] WIP: fix consensus divergence issue

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: fix consensus divergence issue .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3411/ -- To view, visit

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Allow multi-master AlterTable tests in TestKuduTable.java .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3410/ -- To view, visit

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3409/ -- To view, visit

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4394 to look at the new patch set (#3). Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. KUDU-1090:

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/4384/3/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4384/4/_posts/predicate-pushdown.md File

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

2016-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Allow multi-master AlterTable tests in TestKuduTable.java .. Patch Set 2: Code-Review+2 Assuming the test passes. -- To view, visit

[kudu-CR] Set desiredBlockSize in pbToColumnSchema

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Set desiredBlockSize in pbToColumnSchema .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3406/ -- To view, visit

[kudu-CR] Set desiredBlockSize in pbToColumnSchema

2016-09-13 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/4407 Change subject: Set desiredBlockSize in pbToColumnSchema .. Set desiredBlockSize in pbToColumnSchema pbToColumnSchema forgets to set

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

2016-09-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Allow multi-master AlterTable tests in TestKuduTable.java .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4406/1//COMMIT_MSG Commit

[kudu-CR] Allow multi-master AlterTable tests in TestKuduTable.java

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Allow multi-master AlterTable tests in TestKuduTable.java .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3405/ -- To view, visit

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 4: (14 comments) http://gerrit.cloudera.org:8080/#/c/4384/3/_posts/predicate-pushdown.md File

[kudu-CR] dist-test: allow collecting the tmp dir of failed tests

2016-09-13 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: dist-test: allow collecting the tmp dir of failed tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2336 To

[kudu-CR] build-and-test: only run cmake once

2016-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: build-and-test: only run cmake once .. build-and-test: only run cmake once Running it twice as we were before was confusing, and the way in which we'd

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/4384/3/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#4). Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with images can be found here:

[kudu-CR] [WIP] [No-Review] KUDU-861 Support changing default, storage attributes

2016-09-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4310 to look at the new patch set (#4). Change subject: [WIP] [No-Review] KUDU-861 Support changing default, storage attributes

[kudu-CR] [WIP] [No-Review] KUDU-861 Support changing default, storage attributes

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [WIP] [No-Review] KUDU-861 Support changing default, storage attributes .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3404/ -- To view,

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4384/2/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: Blogpost describing predicate evaluation pushdown .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4384/2/_posts/predicate-pushdown.md File

[kudu-CR](gh-pages) Blogpost describing predicate evaluation pushdown

2016-09-13 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded a new patch set (#3). Change subject: Blogpost describing predicate evaluation pushdown .. Blogpost describing predicate evaluation pushdown Version with images can be found here:

[kudu-CR] [python] Implement Scan Token API

2016-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [python] Implement Scan Token API .. [python] Implement Scan Token API First attempt at implementing the [Scan Token

[kudu-CR] [python] Implement Scan Token API

2016-09-13 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [python] Implement Scan Token API .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4367 To unsubscribe, visit

[kudu-CR](branch-1.0.x) [client] avoid circular deps in time-based flusher

2016-09-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4403 To unsubscribe, visit

[kudu-CR](branch-1.0.x) [client] avoid circular deps in time-based flusher

2016-09-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [client] avoid circular deps in time-based flusher .. [client] avoid circular deps in time-based flusher The boost::bind() makes cast of parameters

[kudu-CR](branch-1.0.x) [client] avoid circular deps in time-based flusher

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3403/ -- To view, visit

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [client] avoid circular deps in time-based flusher .. [client] avoid circular deps in time-based flusher The boost::bind() makes cast of parameters

[kudu-CR] [client] avoid circular deps in time-based flusher

2016-09-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] avoid circular deps in time-based flusher .. Patch Set 3: Verified+1 I managed to write a test which reliably leaks without this patch:

[kudu-CR] build-and-test: only run cmake once

2016-09-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: build-and-test: only run cmake once .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4401 To unsubscribe, visit

[kudu-CR] KUDU-1090: relax MemTracker uniqueness constraint

2016-09-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1090: relax MemTracker uniqueness constraint .. Patch Set 2: (5 comments)