[kudu-CR] Fix LTO support

2017-02-26 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6162 to review the following change. Change subject: Fix LTO support .. Fix LTO support This fixes

[kudu-CR] KUDU-1899. Fix support for empty string keys

2017-02-26 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6163 to review the following change. Change subject: KUDU-1899. Fix support for empty string keys ..

[kudu-CR] cmake: don't incorporate filenames in regexp patterns

2017-02-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cmake: don't incorporate filenames in regexp patterns .. Patch Set 1: Verified+1 Unrelated failure in master-stress-test. -- To view, visit

[kudu-CR] cmake: don't incorporate filenames in regexp patterns

2017-02-26 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6161 to review the following change. Change subject: cmake: don't incorporate filenames in regexp patterns .. cmake: don't

[kudu-CR] [catalog manager] fixed deadlock on catalog shutdown

2017-02-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [catalog manager] fixed deadlock on catalog shutdown .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6134/4/src/kudu/master/catalog_manager.cc

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-26 Thread Ram Mettu (Code Review)
Ram Mettu has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 4: (4 comments) Added test cases from alter_table-test.cc and alter_table-randomized-test.cc as

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-02-26 Thread Ram Mettu (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6078 to look at the new patch set (#4). Change subject: KUDU-1890 Allow renaming of primary key column .. KUDU-1890

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

2017-02-26 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6159 to look at the new patch set (#2). Change subject: Misc optimizations to BinaryPlainBlockDecoder

[kudu-CR] Micro-optimizations to try to inline DeltaKey::DecodeFrom

2017-02-26 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6160 to review the following change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom

[kudu-CR] Misc optimizations to BinaryPlainBlockDecoder

2017-02-26 Thread Todd Lipcon (Code Review)
Hello David Ribeiro Alves, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6159 to review the following change. Change subject: Misc optimizations to BinaryPlainBlockDecoder ..

[kudu-CR] KUDU-1896 (part 1). Add redaction to JSON protobuf output

2017-02-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6158/1/src/kudu/util/logging.h File

[kudu-CR] [linked list test] use timeout for WaitAndVerify in all modes

2017-02-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [linked list test] use timeout for WaitAndVerify in all modes .. Patch Set 1: Code-Review+2 I find that retry/loop a little hairy, so it might be best to get

[kudu-CR] KUDU-1896 (part 1). Add redaction to JSON protobuf output

2017-02-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 8: (6 comments)

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: Combine redaction flag for log and flags into one. .. Patch Set 8: (11 comments) http://gerrit.cloudera.org:8080/#/c/6112/7/src/kudu/util/flags.cc File

[kudu-CR] Combine redaction flag for log and flags into one.

2017-02-26 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6112 to look at the new patch set (#8). Change subject: Combine redaction flag for log and flags into one. .. Combine

[kudu-CR] KUDU-1896 (part 1). Add redaction to JSON protobuf output

2017-02-26 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Hao Hao, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6158 to review the following change. Change subject: KUDU-1896 (part 1). Add redaction to JSON protobuf output

[kudu-CR] spark: send authentication credentials to tasks

2017-02-26 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6081 to look at the new patch set (#3). Change subject: spark: send authentication credentials to tasks ..

[kudu-CR] security-itest: fix assertion for el6

2017-02-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: security-itest: fix assertion for el6 .. security-itest: fix assertion for el6 On el6, the error message when no Kerberos credentials are available is a

[kudu-CR] security-itest: fix assertion for el6

2017-02-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security-itest: fix assertion for el6 .. Patch Set 2: Verified+1 Flaky test that Alexey's fixing -- To view, visit http://gerrit.cloudera.org:8080/6157 To

[kudu-CR] security-itest: fix assertion for el6

2017-02-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: security-itest: fix assertion for el6 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6157 To unsubscribe, visit

[kudu-CR] security-itest: fix assertion for el6

2017-02-26 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6157 to look at the new patch set (#2). Change subject: security-itest: fix assertion for el6 .. security-itest: fix

[kudu-CR] [security] added info on non-renewable authn tokens

2017-02-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] added info on non-renewable authn tokens .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6122 To unsubscribe, visit

[kudu-CR] security-itest: fix assertion for el6

2017-02-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: security-itest: fix assertion for el6 .. Patch Set 1: Code-Review+2 LGTM, but the line's too long. Feel free to carry over with that fix. -- To view, visit

[kudu-CR] [security] Add per-connection nonce for Kerberos replay resistance

2017-02-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] Add per-connection nonce for Kerberos replay resistance .. Patch Set 5: (2 comments)

[kudu-CR](gh-pages) Update old download links to Apache Archive

2017-02-26 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update old download links to Apache Archive .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6156 To unsubscribe, visit

[kudu-CR](gh-pages) Update old download links to Apache Archive

2017-02-26 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update old download links to Apache Archive .. Update old download links to Apache Archive We're supposed to stop using