[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6734/2/src/kudu/security/ca/cert_management-t

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-04-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6734 to look at the new patch set (#3). Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. KUDU-1981 K

[kudu-CR] [fs] fix build on OS X

2017-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [fs] fix build on OS X .. Patch Set 1: Verified+1 Unrelated failure in RELEASE configuration: 22:37:01 > git fetch --tags --progress http://gerrit.cloudera.org

[kudu-CR] [fs] fix build on OS X

2017-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [fs] fix build on OS X .. [fs] fix build on OS X Added kudu_fs dependency for kudu_fs_test_util library. Prior to this patch, the following error was r

[kudu-CR] [fs] fix build on OS X

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [fs] fix build on OS X .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6756 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] [fs] fix build on OS X

2017-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6756 Change subject: [fs] fix build on OS X .. [fs] fix build on OS X Added kudu_fs dependency for kudu_fs_test_util library. Prior to this

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#12). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add

[kudu-CR] external mini cluster: spawn perf record for each daemon during Start()

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: external mini cluster: spawn perf record for each daemon during Start() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6742/1/src/kudu/integrati

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6755/2/src/kudu/util/flags.cc File src/ku

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-04-27 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6755 to look at the new patch set (#3). Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. KUD

[kudu-CR] log block manager: more container accounting

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: more container accounting .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6716/3/src/kudu/fs/log_block_manager.cc File src/kudu/

[kudu-CR] KUDU-1957: Clarify web UI redaction in --redact flag help

2017-04-27 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new patch set (#2). Change subject: KUDU-1957: Clarify web UI redaction in --redact flag help .. KUDU-1957: Clarify web UI redaction in --redact flag help Currently,row data in web UI will be redacted if -

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6715/3/src/kudu/fs/log_block_manager-t

[kudu-CR] KUDU-1957 Clarify web UI redaction in --redact flag help

2017-04-27 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6755 Change subject: KUDU-1957 Clarify web UI redaction in --redact flag help .. KUDU-1957 Clarify web UI redaction in --redact flag help Currently

[kudu-CR] thirdparty: fix typo in SPARSEHASH PATCHLEVEL

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: fix typo in SPARSEHASH_PATCHLEVEL .. Patch Set 1: Verified+1 Failures were totally unrelated. -- To view, visit http://gerrit.cloudera.org:8080/6754 T

[kudu-CR] thirdparty: fix typo in SPARSEHASH PATCHLEVEL

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: fix typo in SPARSEHASH_PATCHLEVEL .. thirdparty: fix typo in SPARSEHASH_PATCHLEVEL I briefly experimented with using "set -o nounset" to preven

[kudu-CR] subprocess: remove progname argument

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: subprocess: remove progname argument .. subprocess: remove progname argument When constructing a subprocess, 'argv[0]' always duplicates 'program', and is

[kudu-CR] log block manager: corruptor test utility

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: log block manager: corruptor test utility .. log block manager: corruptor test utility This patch introduces the LBMCorruptor, a test-only class for adding

[kudu-CR] fs: generate report during Open

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: fs: generate report during Open .. fs: generate report during Open This patch modifies the FsManager and block managers to produce a filesystem report when

[kudu-CR] subprocess: add ScopedSubprocess

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: subprocess: add ScopedSubprocess .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6741/1/src/kudu/util/subprocess.h File src/kudu/util/subprocess.h

[kudu-CR] thirdparty: fix typo in SPARSEHASH PATCHLEVEL

2017-04-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: fix typo in SPARSEHASH_PATCHLEVEL .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6754 To unsubscribe, visit http://ge

[kudu-CR] thirdparty: fix typo in SPARSEHASH PATCHLEVEL

2017-04-27 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6754 to review the following change. Change subject: thirdparty: fix typo in SPARSEHASH_PATCHLEVEL .. thirdpar

[kudu-CR] Persistent cache support for NVM

2017-04-27 Thread Sarah Jelinek (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2593 to look at the new patch set (#25). Change subject: Persistent cache support for NVM .. Persistent cache support fo

[kudu-CR] external mini cluster: spawn perf record for each daemon during Start()

2017-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: external mini cluster: spawn perf record for each daemon during Start() .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6742/1/src/kudu/

[kudu-CR](gh-pages) FAQ refresh

2017-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: FAQ refresh .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6697 To unsubscribe, visit http://gerrit.cloudera.org:8080/set

[kudu-CR] [KUDU-754] add an environment variable for kudu client debugging to stderr

2017-04-27 Thread William Li (Code Review)
William Li has posted comments on this change. Change subject: [KUDU-754] add an environment variable for kudu client debugging to stderr .. Patch Set 2: (12 comments) new patch has been submitted. http://gerrit.cloudera.org

[kudu-CR] subprocess: add ScopedSubprocess

2017-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: subprocess: add ScopedSubprocess .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6741/1/src/kudu/util/subprocess.h File src/kudu/util/subp

[kudu-CR] log block manager: corruptor test utility

2017-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: log block manager: corruptor test utility .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6582 To unsubscribe, visit http

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

2017-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6715/3/src/kudu/fs/log_block_

[kudu-CR] log block manager: more container accounting

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: more container accounting .. Patch Set 3: Code-Review+2 (1 comment) one comment on some pre-existing code, but doesn't need to block this patch

[kudu-CR] [KUDU-754] add an environment variable for kudu client debugging to stderr

2017-04-27 Thread William Li (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6736 to look at the new patch set (#2). Change subject: [KUDU-754] add an environment variable for kudu client debugging to stderr .

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6715/3/src/kudu/fs/log_block_manager-

[kudu-CR] log block manager: corruptor test utility

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log block manager: corruptor test utility .. Patch Set 11: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6582 To unsubscribe, visit http://gerri

[kudu-CR] fs: generate report during Open

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6581 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] fs: generate report during Open

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: generate report during Open .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6581 To unsubscribe, visit http://gerrit.cloudera

[kudu-CR] WIP: Add tool to detect pending config changes

2017-04-27 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6752 Change subject: WIP: Add tool to detect pending config changes .. WIP: Add tool to detect pending config changes This is a first pass at a

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/6630/11/src/kudu/util/env.h File src/kudu/util/env.h: Li

[kudu-CR] subprocess: remove progname argument

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: subprocess: remove progname argument .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6740 To unsubscribe, visit http://gerrit.clou

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil.isLocalAddress) is very slow on Windows, so cache added.

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil.isLocalAddress) is very slow on Windows, so cache added. ..

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil.isLocalAddress) is very slow on Windows, so cache added.

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil.isLocalAddress) is very slow on Windows, so cache added. ...

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#11). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/util/env_posix.cc File src/kudu/util/env

[kudu-CR] subprocess: add ScopedSubprocess

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: subprocess: add ScopedSubprocess .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6741/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 9: The failure test passed on my local dev environment. And it seems not related to the change? -- To vi

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/util/env_posix.cc File src/kudu/util/en

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/fs/block_manager-test.cc File src/kudu/

[kudu-CR] [docs] Add troubleshooting for KuduStorageHandler

2017-04-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [docs] Add troubleshooting for KuduStorageHandler .. [docs] Add troubleshooting for KuduStorageHandler Change-Id: I80e028a6f827269d97f26ec7a2cf4b8c

[kudu-CR] [docs] Add troubleshooting for KuduStorageHandler

2017-04-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [docs] Add troubleshooting for KuduStorageHandler .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6738 To unsubscribe, visit http:

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 10: (23 comments) http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/cfile/cfile_reader.cc File src/kudu/c

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Allow to pad UNIXTIME_MICROS slots in scan results This changes the wire protocol to, upon r

[kudu-CR] subprocess: add ScopedSubprocess

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: subprocess: add ScopedSubprocess .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/6741/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Remove forgotten debug code.

2017-04-27 Thread Pavel Martynov (Code Review)
Pavel Martynov has abandoned this change. Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Remove forgotten debug code. .. Abandoned squashed -- To view, visit http://gerrit.cloudera.o

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Code refactored after first review.

2017-04-27 Thread Pavel Martynov (Code Review)
Pavel Martynov has abandoned this change. Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Code refactored after first review. .. Abandoned squashed -- To view, visit http://gerrit.clo

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil.isLocalAddress) is very slow on Windows, so cache added.

2017-04-27 Thread Pavel Martynov (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6735 to look at the new patch set (#3). Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often NetworkInterface.getByInetAddress (which is used by NetUtil

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6734/2/src/kudu/security/ca/cert_management-tes

[kudu-CR] [c++-client] clear non-covered entries from meta cache on table open

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [c++-client] clear non-covered entries from meta cache on table open .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6713 To unsu

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Remove forgotten debug code.

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Remove forgotten debug code. .. Patch Set 1: Hi Pavel. it looks like you've ended up with

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: WIP: KUDU-463. Add checksumming to cfile .. Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/6630/10/src/kudu/cfile/cfile_reader.cc File src/kudu/cfi

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to pad UNIXTIME_MICROS slots in scan results .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6623 To unsubscribe, visit htt

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

2017-04-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/6640/10/src/kudu/integration-tests/security-unknown

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

2017-04-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6640 to look at the new patch set (#11). Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. [rpc] handling ER

[kudu-CR] mapreduce: add support for fault tolerant scanner

2017-04-27 Thread Hao Hao (Code Review)
Hao Hao has uploaded a new change for review. http://gerrit.cloudera.org:8080/6745 Change subject: mapreduce: add support for fault tolerant scanner .. mapreduce: add support for fault tolerant scanner This adds support to us

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-27 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/6566/8/java/kudu-client/src/main/java/org/apache/kudu/

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-27 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#9). Change subject: KUDU-579 [java_client] Scanner fault tolerance .. KUDU-579 [java

[kudu-CR] KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Remove forgotten debug code.

2017-04-27 Thread Pavel Martynov (Code Review)
Pavel Martynov has uploaded a new change for review. http://gerrit.cloudera.org:8080/6744 Change subject: KUDU-1982 Java client calls NetworkInterface.getByInetAddress too often. Remove forgotten debug code. .. KUDU-1982 Java